[gwt-contrib] Re: Pretty massive refactoring of FieldManager and HtmlTemplates to make (issue1522803)

2011-08-18 Thread hermes
On 2011/08/18 00:21:22, rjrjr wrote: LGTM http://gwt-code-reviews.appspot.com/1522803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Provides an integration test for IsRenderable (issue1527804)

2011-08-17 Thread Hermes Freitas
WidgetInterpreter and WidgetPlaceholderInterpreter shouldn't output LazyDomElement. Rafa, do you remember why? I don't think this aggregates any performance gain for us, am I missing something? And I vote for #1 On Tue, Aug 16, 2011 at 10:10 PM, Rafael Castro wrote: > +hermes &

[gwt-contrib] Re: Pretty massive refactoring of FieldManager and HtmlTemplates to make (issue1522803)

2011-08-16 Thread hermes
Overall looks pretty good. Still trying to digest this first round. I'll take another pass tomorrow. For now, just silly style suggestions. http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java File user/src/com/googl

[gwt-contrib] Re: Adding a missing addAndReplaceElement(IsWidget, Element) to HTMLPanel. (issue1514805)

2011-08-09 Thread hermes
http://gwt-code-reviews.appspot.com/1514805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adding a missing addAndReplaceElement(IsWidget, Element) to HTMLPanel. (issue1514805)

2011-08-09 Thread hermes
Reviewers: rjrjr, Description: Adding a missing addAndReplaceElement(IsWidget, Element) to HTMLPanel. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/1514805/ Affected files: M user/src/com/google/gwt/user/client/ui/HTMLPanel.java Index: user/src/com/g

[gwt-contrib] Making lazy widgets generation the default option. (issue1499809)

2011-08-02 Thread hermes
Reviewers: rjrjr, Description: Making lazy widgets generation the default option. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/1499809/ Affected files: M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml M user/src/com/google/gwt/uibinder/rebind/UiB

[gwt-contrib] Re: Reduce the visiblity of a UiBinderWriter method. (issue1500807)

2011-08-01 Thread hermes
LGTM. http://gwt-code-reviews.appspot.com/1500807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Changing lazy widgets strategy to die in case a given @UiField attribute (issue1453806)

2011-06-06 Thread hermes
Reviewers: rjrjr, rdcastro, Description: Changing lazy widgets strategy to die in case a given @UiField attribute has no counterpart in the template. Please review this at http://gwt-code-reviews.appspot.com/1453806/ Affected files: M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.ja

[gwt-contrib] Re: Promoting LazyDomElement to be used externally. LazyDomElement can be (issue1427809)

2011-05-03 Thread hermes
http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java File user/src/com/google/gwt/uibinder/client/LazyDomElement.java (right): http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java#

[gwt-contrib] Re: Promoting LazyDomElement to be used externally. LazyDomElement can be (issue1427809)

2011-05-03 Thread hermes
http://gwt-code-reviews.appspot.com/1427809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread hermes
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java (right): http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFi

[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread hermes
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java (right): http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFi

[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread hermes
http://gwt-code-reviews.appspot.com/1428807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Promoting LazyDomElement to be used externally. LazyDomElement can be (issue1427809)

2011-05-01 Thread hermes
Reviewers: rjrjr, rdcastro, Description: Promoting LazyDomElement to be used externally. LazyDomElement can be used to boost rendering time. Today, html elements marked with "ui:field" need to call getElementById() by the time the template is created even if is not used. LazyDomElement delays thi

[gwt-contrib] Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-04-29 Thread hermes
Reviewers: rdcastro, rjrjr, Description: Introducing FieldTypeWriter, an enum that identifies field writers and defines precedences useful for disambiguation when sorting builders in the Widgets ctor. Please review this at http://gwt-code-reviews.appspot.com/1428807/ Affected files: M user/s

[gwt-contrib] Killing @deprecated "urn:with" from uibinder tests. (issue1425814)

2011-04-29 Thread hermes
Reviewers: rjrjr, Description: Killing @deprecated "urn:with" from uibinder tests. Please review this at http://gwt-code-reviews.appspot.com/1425814/ Affected files: M user/test/com/google/gwt/uibinder/test/client/DomBasedUi.ui.xml M user/test/com/google/gwt/uibinder/test/client/WidgetBase

[gwt-contrib] Moving back missing clauses from previous changes. (issue1425812)

2011-04-28 Thread hermes
Reviewers: rjrjr, rdcastro, Description: Moving back missing clauses from previous changes. Please review this at http://gwt-code-reviews.appspot.com/1425812/ Affected files: M user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java M user/src/com/google/gwt/uibinder/rebind/UiBind

[gwt-contrib] Making ui:style builders always called in the Widgets ctor. Also add a (issue1422814)

2011-04-27 Thread hermes
Reviewers: rjrjr, rdcastro, Description: Making ui:style builders always called in the Widgets ctor. Also add a final clause in field builders. Please review this at http://gwt-code-reviews.appspot.com/1422814/ Affected files: M user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.jav

[gwt-contrib] Fixing setInnerHTML calls on attach/detach sections. (issue1422811)

2011-04-26 Thread hermes
Reviewers: rdcastro, rjrjr, Description: Fixing setInnerHTML calls on attach/detach sections. Please review this at http://gwt-code-reviews.appspot.com/1422811/ Affected files: M user/src/com/google/gwt/uibinder/elementparsers/WidgetPlaceholderInterpreter.java M user/src/com/google/gwt/

[gwt-contrib] Re: This fix a bug in WidgetPlaceholderInterpreter (missing convertField) (issue1420810)

2011-04-26 Thread hermes
On 2011/04/26 22:11:30, hermes wrote: Yes, Rafa won the race! The bug is already fixed and FieldWriterType doesn't bring any big gain. So I reverted the most of the files. The only change here is the use of LazyDomElement to make all places using the same pattern. http://gwt

[gwt-contrib] Re: This fix a bug in WidgetPlaceholderInterpreter (missing convertField) (issue1420810)

2011-04-26 Thread hermes
http://gwt-code-reviews.appspot.com/1420810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] This fix a bug in WidgetPlaceholderInterpreter (missing convertField) (issue1420810)

2011-04-26 Thread hermes
Reviewers: rdcastro, rjrjr, Description: This fix a bug in WidgetPlaceholderInterpreter (missing convertField) and create a new FieldWriterType to substitute the ugly setBuildPrecedence(). It also make LazyDomElement used in more places. This saved a few bytes. Please review this at http://gwt-

[gwt-contrib] Re: LazyPanel parser should be enabled only if useLazyWidgetBuilders is (issue1423806)

2011-04-25 Thread Hermes Freitas
arser("DateLabel"); >> addWidgetParser("NumberLabel"); >> -addWidgetParser("LazyPanel"); >> +if (useLazyWidgetBuilders) { >> + addWidgetParser("LazyPanel"); >> +} >> } >> >> /** >> >> >> > -- --Hermes Freitas -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Introducing ServiceHelper, a inner class of RemoteServiceProxy that (issue1423808)

2011-04-25 Thread hermes
Reviewers: bobv, Description: Introducing ServiceHelper, a inner class of RemoteServiceProxy that makes ProxyCreator generates less code. Please review this at http://gwt-code-reviews.appspot.com/1423808/ Affected files: M user/src/com/google/gwt/user/client/rpc/impl/RemoteServiceProxy.java

[gwt-contrib] LazyPanel parser should be enabled only if useLazyWidgetBuilders is (issue1423806)

2011-04-22 Thread hermes
Reviewers: rjrjr, jat, Description: LazyPanel parser should be enabled only if useLazyWidgetBuilders is enabled. Please review this at http://gwt-code-reviews.appspot.com/1423806/ Affected files: M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java Index: user/src/com/google/gwt/u

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-21 Thread hermes
http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right): http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-21 Thread hermes
http://gwt-code-reviews.appspot.com/1420804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-21 Thread hermes
http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right): http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-21 Thread hermes
http://gwt-code-reviews.appspot.com/1420804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-20 Thread Hermes Freitas
Once again SQ passed with success and orkut seems ok. I'll take a deeper look at your doc today morning, looks promising... On Wed, Apr 20, 2011 at 8:14 PM, wrote: > http://gwt-code-reviews.appspot.com/1420804/ > -- --Hermes Freitas -- http://groups.google.com/group/Google-

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-20 Thread hermes
http://gwt-code-reviews.appspot.com/1420804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-20 Thread hermes
Both comments are somewhat related and reflect my phobia of big CLs. I'll address them still today. Thanks. http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right): htt

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-20 Thread hermes
ield is gone now. Done. http://gwt-code-reviews.appspot.com/1420804/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java#newcode166 user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java:166: // TODO(hermes): poor naming On 2011/04/19 21:07:20, rjrjr wrote: How about useL

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-20 Thread hermes
http://gwt-code-reviews.appspot.com/1420804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-20 Thread hermes
Reviewers: rjrjr, Description: Structural changes to UiBinder to make fields accessible via getters and creation lazy loaded. LazyPanel support is also added. Please review this at http://gwt-code-reviews.appspot.com/1420804/ Affected files: M user/src/com/google/gwt/uibinder/attributepars