[gwt-contrib] Re: GWT support for Chrome Frame (issue1449808)

2011-05-31 Thread jgw
On 2011/05/31 16:42:35, fabiomfv wrote: LVVTGM. http://gwt-code-reviews.appspot.com/1449808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes a bug in TypeOracle for computing information about single JSO impls. (issue1373803)

2011-03-02 Thread jgw
On 2011/03/02 16:30:22, knorton wrote: lgtm me too http://gwt-code-reviews.appspot.com/1373803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change GWT History to work when multiple applications are loaded within the same page. (issue1322801)

2011-01-25 Thread jgw
On 2011/01/25 00:24:52, jhollenbach wrote: LGTM http://gwt-code-reviews.appspot.com/1322801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing the overflow-x and overflow-y properties in Style to use camelCase instead of hyphenated ... (issue1315801)

2011-01-21 Thread jgw
http://gwt-code-reviews.appspot.com/1315801/diff/1/3 File user/test/com/google/gwt/dom/client/StyleTest.java (right): http://gwt-code-reviews.appspot.com/1315801/diff/1/3#newcode214 user/test/com/google/gwt/dom/client/StyleTest.java:214: assertEquals(Overflow.AUTO, style.getOverflowY()); Do be c

[gwt-contrib] Re: Fixing the overflow-x and overflow-y properties in Style to use camelCase instead of hyphenated ... (issue1315801)

2011-01-21 Thread jgw
On 2011/01/21 16:09:17, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/1315801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Cleanup DOM after DoubleClickEventSinkTest tests complete (issue1150801)

2010-11-24 Thread jgw
On 2010/11/24 17:47:45, fredsa wrote: LGTM. http://gwt-code-reviews.appspot.com/1150801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add support for touch events for supported mobile webkit platforms. (issue867801)

2010-11-23 Thread jgw
On 2010/11/23 21:08:03, fredsa wrote: LGTM http://gwt-code-reviews.appspot.com/867801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds overflow-x and overflow-y to Style since they have at least partial (issue1100801)

2010-11-12 Thread jgw
On 2010/11/11 23:22:56, knorton wrote: LGTM http://gwt-code-reviews.appspot.com/1100801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix issue with FF3.5 and below not having readyState (issue1087801)

2010-11-08 Thread jgw
On 2010/11/08 05:34:00, unnurg wrote: LGTM. Disturbing that we have to do this, but LGTM all the same :) http://gwt-code-reviews.appspot.com/1087801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Loosens up JSO restrictions in the TypeOracle to allow multiple JSO (issue1076801)

2010-11-05 Thread jgw
On 2010/11/04 15:42:44, scottb wrote: http://gwt-code-reviews.appspot.com/1076801/diff/1/2 File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java (right): http://gwt-code-reviews.appspot.com/1076801/diff/1/2#newcode687 dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:6

[gwt-contrib] Re: Loosens up JSO restrictions in the TypeOracle to allow multiple JSO (issue1076801)

2010-11-04 Thread jgw
http://gwt-code-reviews.appspot.com/1076801/diff/1/2 File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java (right): http://gwt-code-reviews.appspot.com/1076801/diff/1/2#newcode676 dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:676: // TODO(jgw): Not sure if

[gwt-contrib] Loosens up JSO restrictions in the TypeOracle to allow multiple JSO (issue1076801)

2010-11-03 Thread jgw
Reviewers: scottb, Description: Loosens up JSO restrictions in the TypeOracle to allow multiple JSO implementations of an interface if the implementations share a common base class that fully implements the interface. Review by: sco...@google.com Please review this at http://gwt-code-reviews.ap

[gwt-contrib] Re: Add support for touch events for supported mobile webkit platforms. (issue867801)

2010-11-03 Thread jgw
LGTM. Comments are advisory only. http://gwt-code-reviews.appspot.com/867801/diff/12001/13003 File user/src/com/google/gwt/dom/client/NativeEvent.java (right): http://gwt-code-reviews.appspot.com/867801/diff/12001/13003#newcode72 user/src/com/google/gwt/dom/client/NativeEvent.java:72: return DO

[gwt-contrib] Re: Fix some issues in the xsiframe linker (issue1057801)

2010-10-27 Thread jgw
On 2010/10/26 22:11:25, unnurg wrote: LGTM http://gwt-code-reviews.appspot.com/1057801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add support for touch events for supported mobile webkit platforms. (issue867801)

2010-10-26 Thread jgw
On 2010/09/14 00:49:29, fredsa wrote: Looks good. That weird sink-all-events stuff in Image is unfortunate, but it looks trickier to deal with than is appropriate with this patch. http://gwt-code-reviews.appspot.com/867801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a constructor override to SplitLayoutPanel so users can specify the width of the splitter. (issue1001801)

2010-10-14 Thread jgw
On 2010/10/14 14:01:05, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/1001801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add Support for server side script selection in linker (issue941802)

2010-10-12 Thread jgw
Wow, that's one hell of a refactoring. I added a couple of 'taste' comments that you're free to do with as you will; and there's one spot where I think you're missing a 'var' or two. No need to re-review. Once you're satisfied, feel free to submit. http://gwt-code-reviews.appspot.com/941802/dif

[gwt-contrib] Re: Add Support for server side script selection in linker (issue941802)

2010-10-11 Thread jgw
On 2010/10/07 21:17:49, unnurg wrote: I thought I already saw this go through -- is this still awaiting review? http://gwt-code-reviews.appspot.com/941802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Let ToggleButton implement HasValue (issue887804)

2010-10-08 Thread jgw
On 2010/09/23 14:32:37, tbroyer wrote: LGTM. Committed at r8982. http://gwt-code-reviews.appspot.com/887804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Let MenuItem implement HasEnabled (issue846801)

2010-09-27 Thread jgw
On 2010/09/20 13:06:07, jgw wrote: Sorry about that. Will look at it this afternoon (US/EST). And apparently "this afternoon" means "several days later"... Sorry about that. The patch seems fine overall, but if you have a moment to add a test of the enabled/disabled

[gwt-contrib] Re: GWT implementation of json2.js parse and stringify, plus removal of json2.js dependency from RF.... (issue922801)

2010-09-24 Thread jgw
On 2010/09/24 20:17:34, rjrjr wrote: Joel, any chance of you getting to this today? That would be huge. On Fri, Sep 24, 2010 at 1:15 PM, <mailto:cromwell...@google.com> wrote: > Reviewers: jgw, rjrjr, > > Description: > GWT implementation of json2.js parse and stringif

[gwt-contrib] Re: Fix for issue 4694. Adds a 'visibility' property to layout layers, along with (issue869801)

2010-09-14 Thread jgw
On 2010/09/14 15:17:21, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/869801/diff/1/5 File user/src/com/google/gwt/layout/client/LayoutImplIE8.java (right): http://gwt-code-reviews.appspot.com/869801/diff/1/5#newcode177 user/src/com/google/gwt/layout/client/LayoutImplIE8.java:177

[gwt-contrib] Fix for issue 4694. Adds a 'visibility' property to layout layers, along with (issue869801)

2010-09-14 Thread jgw
Reviewers: jlabanca, Description: Fix for issue 4694. Adds a 'visibility' property to layout layers, along with a hack to LayoutImplIE8 that ensures relative units are recalculated correctly on visibility change. Also changes LayoutPanel and TabLayoutPanel to ensure that they use this new layer p

[gwt-contrib] Re: Continuation of r8542 to actually properly enables double click for (issue774801)

2010-09-07 Thread jgw
On 2010/09/04 03:36:47, fredsa wrote: LGTM. http://gwt-code-reviews.appspot.com/774801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add Late Loading support to xsiframe linker (issue807801)

2010-09-03 Thread jgw
Excellent. As far as the XHTML thing is concerned, let's just ask him to see if this actually solves the problem. If it's necessary to make those DOM case changes to fix XHTML problems, I'd be ok with that (though I don't really want to sign on to testing all our code in an XHTML context -- that's

[gwt-contrib] Re: Add Late Loading support to xsiframe linker (issue807801)

2010-09-03 Thread jgw
Assuming everything works as expected, everything here looks good to me (not bad for someone who claims to "not know Javascript" :) I'm stuck at home right now, so I don't have the facilities here to test out IE, which is where any problems would likely crop up. In particular, I'd make sure it wo

[gwt-contrib] Re: Adding support for Direction.LINE_START/END to DockLayoutPanel and SplitLayoutPanel. (issue828801)

2010-09-03 Thread jgw
On 2010/09/02 16:33:00, jlabanca wrote: Patch Set 2 updates DOMRtlTest, which was never really in RTL mode until DockLayoutPanelRtlTest came along. The body isn't put into RTL mode until RootPanel.get() is called, but DOMRtlTest never called it. I also renamed DockLayoutPanelTestRtl to Doc

[gwt-contrib] Avoids a hidden NPE in eventGetRelatedTarget() when Mozilla decides to return (issue819801)

2010-08-31 Thread jgw
Reviewers: bobbrose_google.com, Description: Avoids a hidden NPE in eventGetRelatedTarget() when Mozilla decides to return a null value for Event.relatedTarget. This NPE was getting trapped by an exception handler, but was wreaking havoc for people debugging compiled code under Firebug (with "sto

[gwt-contrib] Re: HasEnabled (issue757801)

2010-08-20 Thread jgw
On 2010/08/13 15:01:58, johan.rydberg wrote: Done! On Fri, Aug 13, 2010 at 4:00 PM, wrote: > @johan - > > Can you sign a Contributor License Agreement so we can include your > code: > http://code.google.com/legal/individual-cla-v1.0.html > > If you scroll to the

[gwt-contrib] Re: RR : Add to UiBinder to allow access to static fields. (issue781801)

2010-08-20 Thread jgw
On 2010/08/19 16:56:54, bobv wrote: This patch allows ui.xml files to refer to static fields. Single fields: field='com.google.gwt.uibinder.test.client.Constants.CONST_FOO'> Wildcard (like import static Inner.*): field='com.google.gwt.uibinder.test.client.Constants.Inner.*'> Enum v

[gwt-contrib] Re: Makes Widget.addDomHandler public, so that helpers can add keyboard handlers to panels without c... (issue779802)

2010-08-20 Thread jgw
On 2010/08/19 12:00:39, gryder wrote: Well, I had thought there was a good reason to keep these protected, but I can't seem to find any problem with making them public. LGTM. http://gwt-code-reviews.appspot.com/779802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add mouse position information to ClickEvent and DoubleClickEvent. Manually verified that this (issue763801)

2010-08-13 Thread jgw
On 2010/08/12 22:32:53, fredsa wrote: LGTM. http://gwt-code-reviews.appspot.com/763801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HasEnabled (issue757801)

2010-08-13 Thread jgw
On 2010/08/11 21:21:12, johan.rydberg wrote: LGTM. Will commit momentarily. http://gwt-code-reviews.appspot.com/757801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the ability to change the size of a widget in the (issue719802)

2010-08-03 Thread jgw
On 2010/08/02 18:38:29, toms wrote: On Mon, Aug 2, 2010 at 2:14 PM, wrote: > > http://gwt-code-reviews.appspot.com/719802/diff/1/2 > File user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java > (right): > > http://gwt-code-reviews.appspot.com/719802/diff/1/2#newc

[gwt-contrib] Re: Add the ability to change the size of a widget in the (issue719802)

2010-08-02 Thread jgw
http://gwt-code-reviews.appspot.com/719802/diff/1/2 File user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/719802/diff/1/2#newcode315 user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java:315: public void setWidgetSize(Widget widget, i

[gwt-contrib] Re: Adds a new CrossSiteIframeLinker. This linker works cross-site, (issue726802)

2010-07-30 Thread jgw
Looks great. In response to Matt's question about __COMPUTE_SCRIPT_BASE__, that replacement is done in SelectionScriptLinker.java. It's a fairly recent change to share more stuff among the various linkers -- though hopefully we'll be able to reduce the "various linkers" to one at some point :)

[gwt-contrib] Re: Modifies the cross-site linker to put its code in an iframe (issue674802)

2010-07-23 Thread jgw
[from f2f conversation, for posterity] jgw: I noticed that the code is output in one giant string. Have you tried this with a decent-sized app on IE6/7? I believe there was a restriction on max line-length, but I may be mistaken. spoon: Worked for the AdWords Front End on IE6 and 7, so I&#

[gwt-contrib] Re: Adding NoSelectionModel, which allows selection without saving the selection state. (issue667801)

2010-07-02 Thread jgw
On 2010/06/28 17:44:06, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/667801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Replacing PagingListView.setPageStart/Size with PagingListView.setRange. Replacing CellListImpl... (issue614803)

2010-07-02 Thread jgw
LGTM overall. Some minor comments that shouldn't stop you from committing. And let me just add "w00t, tests!" http://gwt-code-reviews.appspot.com/614803/diff/3001/4013 File user/src/com/google/gwt/user/cellview/client/CellTable.java (right): http://gwt-code-reviews.appspot.com/614803/diff/3001/

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

2010-07-02 Thread jgw
On 2010/07/02 16:26:08, tbroyer wrote: LGTM overall. As a side note, where is the c.g.g.dom.client.EventListener defined? Could it be made generic? I like how the WebSocket proposal added a base Event class mimicking the DOM Event interface, with NativeEvent (and other WebSocket-specific

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

2010-07-02 Thread jgw
http://gwt-code-reviews.appspot.com/623803/diff/1/4 File user/src/com/google/gwt/dom/client/DOMImplTrident.java (right): http://gwt-code-reviews.appspot.com/623803/diff/1/4#newcode161 user/src/com/google/gwt/dom/client/DOMImplTrident.java:161: // TODO: Hang on to enough information to implement

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

2010-07-02 Thread jgw
http://gwt-code-reviews.appspot.com/623803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

2010-07-02 Thread jgw
target, String type, On 2010/07/02 16:12:33, jat wrote: On 2010/07/02 16:07:27, jgw wrote: > I was trying to avoid creating a non-standard DOM interface (EventTarget already > has addEventListener() defined). While your proposal is a simpler solution, it > just pushes the burden on

[gwt-contrib] Re: Add WebSocket API (issue646803)

2010-07-02 Thread jgw
I don't have a particularly strong opinion on the RawWebSocket vs. RawWebSocketImpl dichotomy, but it might be a bit more abstracted that necessary. I'm perfectly fine with the WebSocket vs. RawWebSocket difference, though, because one's a native browser class, while the other provides a more Java

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

2010-07-02 Thread jgw
http://gwt-code-reviews.appspot.com/623803/diff/1/3 File user/src/com/google/gwt/dom/client/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/623803/diff/1/3#newcode115 user/src/com/google/gwt/dom/client/DOMImplStandard.java:115: public native void addEventListener(EventTarget ta

[gwt-contrib] Re: Adds Event.sinkEvent() to make it possible to sink custom events in gwt-user. Reimplements (issue635802)

2010-07-02 Thread jgw
http://gwt-code-reviews.appspot.com/635802/diff/1/3 File user/src/com/google/gwt/user/client/Event.java (right): http://gwt-code-reviews.appspot.com/635802/diff/1/3#newcode556 user/src/com/google/gwt/user/client/Event.java:556: DOM.sinkEvent((com.google.gwt.user.client.Element) elem, type, sink)

[gwt-contrib] Adding microbenchmark for event sinking (using gwt-user Event.sinkEvents()). (issue668802)

2010-07-02 Thread jgw
Reviewers: tbroyer, Description: Adding microbenchmark for event sinking (using gwt-user Event.sinkEvents()). Please review this at http://gwt-code-reviews.appspot.com/668802/show Affected files: M reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/Microbenchmarks

[gwt-contrib] Adds Event.sinkEvent() to make it possible to sink custom events in gwt-user. Reimplements (issue635802)

2010-07-02 Thread jgw
Reviewers: tbroyer, Description: Adds Event.sinkEvent() to make it possible to sink custom events in gwt-user. Reimplements gwt-user event handling in terms of standard dom EventTarget methods. Note: This is not remotely finished, nor the API certain. Please review this at http://gwt-code-revie

[gwt-contrib] Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

2010-07-02 Thread jgw
Reviewers: tbroyer, Description: Adds EventTarget, add/removeEventListener() et al to gwt dom. Note: This is not remotely finished, nor is the API certain. Please review this at http://gwt-code-reviews.appspot.com/623803/show Affected files: M user/src/com/google/gwt/dom/client/DOMImpl.java

[gwt-contrib] Re: Second attempted fix for issue 4532. This time, we revert the IE7 layout (issue628802)

2010-07-01 Thread jgw
On 2010/06/30 15:31:29, jlabanca wrote: LGTM Thanks, committed at r8339. http://gwt-code-reviews.appspot.com/628802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Second attempted fix for issue 4532. This time, we revert the IE7 layout (issue628802)

2010-06-30 Thread jgw
Reviewers: jlabanca, Description: Second attempted fix for issue 4532. This time, we revert the IE7 layout implementation back all the way to IE6. IE7's just too quirky to rely directly on its implementation of top/left/right/bottom/width/height CSS layout. Please review this at http://gwt-code

[gwt-contrib] Re: Making StackLayoutPanel#showWidget(Widget) call showWidget(int) for legacy support. Ditto to Ta... (issue641802)

2010-06-28 Thread jgw
On 2010/06/28 16:54:55, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/641802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: DefaultSelectionModel#setSelected currently adds an exception even if the default selection stat... (issue658801)

2010-06-23 Thread jgw
On 2010/06/23 19:08:30, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/658801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: DefaultSelectionModel#setSelected currently adds an exception even if the default selection stat... (issue658801)

2010-06-23 Thread jgw
On 2010/06/23 18:28:32, jlabanca wrote: Is there a test suite to which tese should be added? http://gwt-code-reviews.appspot.com/658801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Finishing implementation of ListViewAdapter. An extensive test class will be submitted in a lat... (issue636802)

2010-06-23 Thread jgw
On 2010/06/23 18:29:32, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/636802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a null check to ShowcaseGenerator so that we don't try to write to a public resource that... (issue646802)

2010-06-22 Thread jgw
On 2010/06/22 18:32:20, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/646802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: DockPanelParser and width/height attributes (issue633802)

2010-06-21 Thread jgw
On 2010/06/18 15:02:50, Konstantin.Scheglov wrote: Thanks, LGTM. Committed at r8289. http://gwt-code-reviews.appspot.com/633802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: UiBinder. Add tests for horizontal/vertical alignment parsers. (issue633801)

2010-06-21 Thread jgw
On 2010/06/17 08:52:37, Konstantin.Scheglov wrote: Thanks, LGTM. Submitted at r8281. http://gwt-code-reviews.appspot.com/633801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding AbstractListViewAdapter#getViews() to get the views associated with an adapter. Also add... (issue601801)

2010-06-17 Thread jgw
On 2010/06/10 21:11:08, jlabanca wrote: Woohoo, tests! LGTM. http://gwt-code-reviews.appspot.com/601801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding TreeItem#insert methods to insert items into a tree. (issue592801)

2010-06-07 Thread jgw
On 2010/06/07 18:21:24, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/592801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds helpers for UIObject.add/removeStyle(Dependent)Name, to address the frequent use case: (issue576801)

2010-06-03 Thread jgw
On 2010/06/01 16:29:00, Guillaume Ryder wrote: LGTM. http://gwt-code-reviews.appspot.com/576801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding an override to tab based widgets to allow users to choose whether or not an event is fired. (issue559801)

2010-06-03 Thread jgw
On 2010/05/25 18:37:20, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/559801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Deleting the stocks sample in favor of the Expenses sample. (issue580801)

2010-06-03 Thread jgw
On 2010/06/02 16:42:38, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/580801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR : Change ClientBundle ResourcePrototype initialization (issue583801)

2010-06-03 Thread jgw
On 2010/06/03 14:20:33, bobv wrote: Review requested. LGTM http://gwt-code-reviews.appspot.com/583801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR : Rework ImageResourceGenerator to address several issues (issue335802)

2010-06-02 Thread jgw
LGTM. http://gwt-code-reviews.appspot.com/335802/diff/1/4 File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java (left): http://gwt-code-reviews.appspot.com/335802/diff/1/4#oldcode221 user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java:221: interface HasRect { On 2010/04/16

[gwt-contrib] Re: Reapplying r5742 and r5747 to fix RichTextArea issues 3133, 3176, 3503. The original version of... (issue555801)

2010-05-25 Thread jgw
On 2010/05/24 20:40:56, jlabanca wrote: LGTM. Feel free to commit, but allow me to point out that we don't actually support "old mozilla" anymore :) http://gwt-code-reviews.appspot.com/555801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Have IE's DOMImpl invoke its event dispatching function via a (issue543801)

2010-05-25 Thread jgw
On 2010/05/18 20:01:26, Lex wrote: This is ready for review. It is absolutely stunning that this is necessary to avoid leaking on IE, but LGTM. Good work! http://gwt-code-reviews.appspot.com/543801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Firing MenuItem commands using a finally command instead of a deferred command so that the comma... (issue543804)

2010-05-25 Thread jgw
On 2010/05/25 15:42:00, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/543804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adds a mobile-friendly drag-scroll implementation. (issue530801)

2010-05-14 Thread jgw
Reviewers: jlabanca, Description: Adds a mobile-friendly drag-scroll implementation. Changes the standard and mobile expense samples to use said scrolling. (desktop Expense sample still uses regular scrollbars on non-touch devices) Adds onclick='' to cell containers, so that touch devices show ta

[gwt-contrib] Re: Adds a loading animation to the table. Adds timers to desktop and mobile to refresh tables as d... (issue503802)

2010-05-14 Thread jgw
On 2010/05/12 20:09:19, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/503802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: A JS overlay type to handle heterogeneous arrays (issue453801)

2010-05-13 Thread jgw
On 2010/05/04 15:11:06, rchandia wrote: LGTM. Sorry I sat on this so long! http://gwt-code-reviews.appspot.com/453801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Style tweaks to the denied popup on the Expense Details page. Also removing the 'no data' messa... (issue515801)

2010-05-13 Thread jgw
On 2010/05/12 22:05:03, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/515801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updating Mobile expenses app now that prices are stored in dollars instead of cents. (issue514801)

2010-05-12 Thread jgw
On 2010/05/12 16:49:01, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/514801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: The generated data was missing an Expense -> Report link. Fixed it. Updated the sample Json data. (issue512801)

2010-05-12 Thread jgw
On 2010/05/12 14:53:32, amitmanjhi wrote: LGTM. http://gwt-code-reviews.appspot.com/512801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Nicer style for the mobile parts of the sample. (issue502801)

2010-05-10 Thread jgw
Reviewers: jlabanca, Description: Nicer style for the mobile parts of the sample. More useful mobile page stack. Added edit/save for expense entries. Please review this at http://gwt-code-reviews.appspot.com/502801/show Affected files: D /bikeshed/src/com/google/gwt/sample/expenses/gwt/clien

[gwt-contrib] Re: Clickable elements now have pointer cursor style. Fixed gray box around open/close images in Ce... (issue499801)

2010-05-10 Thread jgw
On 2010/05/10 15:06:17, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/499801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enables AppStats for bikeshed. (issue477801)

2010-05-10 Thread jgw
On 2010/05/06 00:26:30, knorton wrote: I have no way of testing this ... but I think it's correct. LGTM. http://gwt-code-reviews.appspot.com/477801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Spiffs up the expenses sample a bit. Adds half-baked page/controller system (issue491802)

2010-05-07 Thread jgw
Reviewers: jlabanca, Description: Spiffs up the expenses sample a bit. Adds half-baked page/controller system for managing pages, which we will need to reconcile with activities/places at some point. Review by: jlaba...@google.com Please review this at http://gwt-code-reviews.appspot.com/491802

[gwt-contrib] Re: Adding functionality to the ExpenseTree. Improving UI of Expense app. Multiple general improve... (issue478801)

2010-05-06 Thread jgw
LGTM (comments are just advisory for the future). http://gwt-code-reviews.appspot.com/478801/diff/1/9 File /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseDetails.java (right): http://gwt-code-reviews.appspot.com/478801/diff/1/9#newcode155 /bikeshed/src/com/google/gwt/sample/expe

[gwt-contrib] Creates the c.g.g.view module, moving the abstract interfaces and non-widget implementations fro... (issue474801)

2010-05-05 Thread jgw
Reviewers: jlabanca, cromwellian, Description: Creates the c.g.g.view module, moving the abstract interfaces and non-widget implementations from the Bikeshed. Creates the (currently empty) c.g.g.user.cellview module, which will eventually hold the Bikeshed widgets. Also cleans up the dependency f

[gwt-contrib] Re: Moves the Cell interfaces and implementations from Bikeshed into c.g.g.cell. (issue467801)

2010-05-05 Thread jgw
All nits picked, fixed, and committed. http://gwt-code-reviews.appspot.com/467801/diff/1/60 File /user/src/com/google/gwt/cell/client/ActionCell.java (right): http://gwt-code-reviews.appspot.com/467801/diff/1/60#newcode55 /user/src/com/google/gwt/cell/client/ActionCell.java:55: On 2010/05/05 16

[gwt-contrib] Moves the Cell interfaces and implementations from Bikeshed into c.g.g.cell. (issue467801)

2010-05-05 Thread jgw
Reviewers: jlabanca, Description: Moves the Cell interfaces and implementations from Bikeshed into c.g.g.cell. Also makes Cell an interface and changes existing cells to extend AbstractCell. Please review this at http://gwt-code-reviews.appspot.com/467801/show Affected files: D /bikeshed/src

[gwt-contrib] Re: Rough first pass at something vaguely resembling mobile versions of the (issue392804)

2010-04-30 Thread jgw
http://gwt-code-reviews.appspot.com/392804/diff/1/3 File /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobileShell.java (right): http://gwt-code-reviews.appspot.com/392804/diff/1/3#newcode34 /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobileShell.java:34: *

[gwt-contrib] Rough first pass at something vaguely resembling mobile versions of the (issue392804)

2010-04-30 Thread jgw
Reviewers: Dan Rice, Description: Rough first pass at something vaguely resembling mobile versions of the scaffold and customized expense apps. Please review this at http://gwt-code-reviews.appspot.com/392804/show Affected files: M /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Ex

[gwt-contrib] Another pass at refactoring the client code. (issue412802)

2010-04-28 Thread jgw
Reviewers: Ray Ryan, Description: Another pass at refactoring the client code. Please review this at http://gwt-code-reviews.appspot.com/412802/show Affected files: M /bikeshed/src/com/google/gwt/sample/expenses/gwt/Expenses.gwt.xml M /bikeshed/src/com/google/gwt/sample/expenses/gwt/Expens

[gwt-contrib] Re: Removing the trivially simple SimpleColumn. (issue420802)

2010-04-28 Thread jgw
On 2010/04/28 21:32:26, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/420802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Refactors the expense sample's entry points as follows (including .gwt.xml (issue399802)

2010-04-28 Thread jgw
Reviewers: Dan Rice, Description: Refactors the expense sample's entry points as follows (including .gwt.xml files, .html files, and entry points): ExpensesCommon Expenses ExpensesMobile ExpensesScaffold ExpensesMobileScaffold The mobile entry points are currently dupes of the desktop entry poin

[gwt-contrib] Re: Templating the Expenses sample. (issue398802)

2010-04-27 Thread jgw
On 2010/04/27 17:30:52, jlabanca wrote: LGTM, but you're going to have some merge conflicts with the ViewData nuking patch I just committed. http://gwt-code-reviews.appspot.com/398802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Refactoring Tree code. SideBySideTreeView now uses SimpleCellList, which a protected method tha... (issue390801)

2010-04-22 Thread jgw
http://gwt-code-reviews.appspot.com/390801/diff/1/3 File bikeshed/src/com/google/gwt/bikeshed/cells/client/CompositeCell.java (right): http://gwt-code-reviews.appspot.com/390801/diff/1/3#newcode32 bikeshed/src/com/google/gwt/bikeshed/cells/client/CompositeCell.java:32: public class CompositeCell

[gwt-contrib] Re: Refactoring Tree code. SideBySideTreeView now uses SimpleCellList, which a protected method tha... (issue390801)

2010-04-22 Thread jgw
LGTM overall, though I freely admit to not having pored over all the code in the tree-views explicitly. There are a bunch of comments, but I'd go ahead and commit -- we can address these questions later. http://gwt-code-reviews.appspot.com/390801/show -- http://groups.google.com/group/Google-Web

[gwt-contrib] Reorganizes styles in bikeshed to use CssResource and ClientBundle. (issue388801)

2010-04-22 Thread jgw
Reviewers: jlabanca, Description: Reorganizes styles in bikeshed to use CssResource and ClientBundle. Moves all styles in stock and cookbook samples to one place. Removes the "hovering boxes" we stole from Wave for a slightly flatter look. Please review this at http://gwt-code-reviews.appspot.c

[gwt-contrib] Re: Fixes a bug in SplitLayoutPanel where calling setWidgetMinSize() on the center widget, the last ... (issue378802)

2010-04-22 Thread jgw
LGTM http://gwt-code-reviews.appspot.com/378802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes incorrect direction of isAssignable check when using @UiField(provided = true) (issue359801)

2010-04-19 Thread jgw
On 2010/04/18 21:38:06, Ray Ryan wrote: Joel, if you can get to this first thing that would be great. Bob, if you're in a charitable mood and get there sooner, that would be great too. LGTM. http://gwt-code-reviews.appspot.com/359801/show -- http://groups.google.com/group/Google-Web-Toolkit

[gwt-contrib] Re: Implement a selection column, sortable columns, and row hovering in MailRecipe (issue356801)

2010-04-19 Thread jgw
On 2010/04/16 21:30:35, Dan Rice wrote: LGTM http://gwt-code-reviews.appspot.com/356801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix for issue 4851 - error in javadoc uibinder example for TabLayoutPanel (issue329802)

2010-04-12 Thread jgw
On 2010/04/12 20:30:19, bduff wrote: LGTM, thanks! http://gwt-code-reviews.appspot.com/329802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply using "remove me" as the subject.

[gwt-contrib] Re: Changes CustomizedShell to use the new Table widget. (issue318801)

2010-04-08 Thread jgw
http://gwt-code-reviews.appspot.com/318801/diff/3001/4002 File bikeshed/src/com/google/gwt/bikeshed/cells/client/EditTextCell.java (right): http://gwt-code-reviews.appspot.com/318801/diff/3001/4002#newcode8 bikeshed/src/com/google/gwt/bikeshed/cells/client/EditTextCell.java:8: public class EditT

[gwt-contrib] Re: Changes CustomizedShell to use the new Table widget. (issue318801)

2010-04-07 Thread jgw
http://gwt-code-reviews.appspot.com/318801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply using "remove me" as the subject.

[gwt-contrib] Changes CustomizedShell to use the new Table widget. (issue318801)

2010-04-07 Thread jgw
Reviewers: Ray Ryan, Description: Changes CustomizedShell to use the new Table widget. Please review this at http://gwt-code-reviews.appspot.com/318801/show Affected files: M bikeshed/src/com/google/gwt/bikeshed/cells/client/DateCell.java M bikeshed/src/com/google/gwt/sample/expenses/gwt

[gwt-contrib] Changes ListRegistration to carry information about its associated handler (issue314801)

2010-04-06 Thread jgw
Reviewers: Ray Ryan, Description: Changes ListRegistration to carry information about its associated handler and range of interest. This allows ListListModel (and theoretically other models) to call back directly to views whose range of interest changes without having to re-render all views. Pl

[gwt-contrib] Re: Adds ProvidesKey and makes the ListModel the source of the key (issue307801)

2010-04-05 Thread jgw
On 2010/04/02 21:22:23, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/307801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

  1   2   3   4   >