Brian Slesinsky has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 7:
As mentioned above, there's a conflict with Sencha which bit us when we
tried
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Add hasClassName method in com.google.gwt.dom.client.Element
Fixes issue 7550
Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 6:
What I was saying is that your overridden getElement will return GxtElement
as
Colin Alworth has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 6: Code-Review+1
Nope, we can work with it - a wrapper isn't really an option, since
Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 6:
Unfortunately JSO's doesn't give us much choice on API management so that
make
Colin Alworth has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 6:
Thanks Goktug - one of the distinct advantages of extending Element is that
we
Hello Colin Alworth, Thomas Broyer, Goktug Gokdogan,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3070
to look at the new patch set (#5).
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
Andrey Korzhevskiy has abandoned this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Abandoned
broken style
--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe,
Andrey Korzhevskiy has restored this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Restored
--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit
Andrey Korzhevskiy has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 5:
Uploaded patch set 5: sorted methods according gwt code style.
--
To view,
Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 5:
Please don't change the order.
It looks like it is previously agreed upon not to
Hello Colin Alworth, Thomas Broyer, Goktug Gokdogan,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3070
to look at the new patch set (#6).
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 6: Code-Review+2
Colin, I'm going +2 this change.
If it is going to be a big
Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 3:
Hi Colin. I understand your concerns.
However, I like to remind that we are
Thomas Broyer has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 3: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3070
To
Hello Colin Alworth, Thomas Broyer, Goktug Gokdogan,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3070
to look at the new patch set (#4).
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
Andrey Korzhevskiy has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 4:
Uploaded patch set 4:
I removed javadoc for trimClassName
--
To view,
Stephen Haberman has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 4:
(1 comment)
File
Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 4: Code-Review+1
(1 comment)
Andrey Korzhevskiy has uploaded a new change for review.
https://gwt-review.googlesource.com/3070
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Add hasClassName method in
Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 2:
(5 comments)
Looks good. Only a few style related comments...
Andrey Korzhevskiy has uploaded a new change for review.
https://gwt-review.googlesource.com/3071
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Add hasClassName method in
Andrey Korzhevskiy has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 2:
Sorry, i accidently pushed to a new review
Goktug Gokdogan has abandoned this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Abandoned
--
To view, visit https://gwt-review.googlesource.com/3071
To unsubscribe, visit
Daniel Kurka has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 2:
You can close off the version you do not want for review
--
To view, visit
Andrey Korzhevskiy has uploaded a new patch set (#3).
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Add hasClassName method in com.google.gwt.dom.client.Element
Fixes issue 7550
Change-Id:
Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 3: Code-Review+1
(1 comment)
LGTM.
Let's wait for tomorrow before +2 so other can
Colin Alworth has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 3: Code-Review-1
As an idea, looks good, but remember that JSOs are a particularly
28 matches
Mail list logo
