On 2 nov 2009, at 2 nov, 08:20, Matt Mastracci wrote:
There might be a way to approach this like Oni does
(http://www.croczilla.com/oni
): provide a set of asynchronous building blocks that you can use to
coordinate asynchronous events. You end up building an asynchronous
lambda function
This patch demonstrates the idea and some of the dispatch semantics
that need to be accounted for. It stringifies individual functions,
which is much too fine-grained for anything that could be deployed.
It seems to me that optimally stringifying a GWT module and performing
runAsync splitting is
Comment by rj...@google.com:
Not yet, though it's on the list.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/UiBinder
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/72802/diff/2001/3006
File dev/core/src/com/google/gwt/dev/GwtVersion.java (right):
http://gwt-code-reviews.appspot.com/72802/diff/2001/3006#newcode30
Line 30: implements ComparableReleaseNumber {
Do we actually want upgrade notifications for non-release
LGTM
http://gwt-code-reviews.appspot.com/89807
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM
http://gwt-code-reviews.appspot.com/89808
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: jat,
Description:
The old message references the Compile/Browse button in hosted mode.
Please review this at http://gwt-code-reviews.appspot.com/89811
Affected files:
dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
Index:
On Mon, Nov 2, 2009 at 12:25 PM, r...@google.com wrote:
Reviewers: jat,
Description:
The old message references the Compile/Browse button in hosted mode.
LGTM, though another cause that could generate this message is if their app
alters the URL and does not retain the gwt.hosted/gwt.codesvr
Reviewers: jlabanca,
Message:
John, got time for a quick one?
Please review this at http://gwt-code-reviews.appspot.com/91803
Affected files:
M user/src/com/google/gwt/event/shared/HandlerManager.java
Index: user/src/com/google/gwt/event/shared/HandlerManager.java
diff --git
LGTM
Based on all those responses, I think users would mutiny if we removed
this.
http://gwt-code-reviews.appspot.com/91803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6580
Author: r...@google.com
Date: Mon Nov 2 08:50:07 2009
Log: Implement a -standardsMode flag for junit tests, but don't enable the
tests just yet.
Review by: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=6580
Added:
Are we sure we want this as a flag to JUnit rather than a module property?
If we're not completely sure, we should make this option undocumented.
(Alternatively, if we're planning to abandon quirks mode in favor of
standards mode, maybe what we want is to change the default, but that's a
Revision: 6581
Author: rj...@google.com
Date: Mon Nov 2 09:21:49 2009
Log: De-deprecate HandlerManager.removeHandler, resolves issue 3102
Review by jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=6581
Modified:
The API is just a skeleton to experiment with all the strong-typing
that would go along with porting Oni to Java, so there's not much
there. It helped prove that the concept was sound if I had a chance to
take a go at it and gave me some code to look at while planning it
out. There's
Reviewers: jgw,
Description:
Description:
We currently enable scrolling by setting overflow to an empty string
instead of ''. In Chrome, setting the overflow to '' does not have any
effect until a window resize.
Actually, we used to set it to auto, but switched at r1949 because of
Revision: 6582
Author: r...@google.com
Date: Mon Nov 2 10:18:58 2009
Log: Merge r6566 into releases/2.0.
http://code.google.com/p/google-web-toolkit/source/detail?r=6582
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
LGTM.
On Mon, Nov 2, 2009 at 1:07 PM, jlaba...@google.com wrote:
Reviewers: jgw,
Description:
Description:
We currently enable scrolling by setting overflow to an empty string
instead of ''. In Chrome, setting the overflow to '' does not have any
effect until a window
Revision: 6583
Author: jlaba...@google.com
Date: Mon Nov 2 10:54:13 2009
Log: When enabling scrolling, we now use 'auto' instead of ''. Chrome
doesn't update with ''.
Patch by: jlabanca
Review by: jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=6583
Modified:
Mark,
The SerializedObject contains a circular reference because each child
has a back reference to the parent. So, parent-childrenList-item0-
parent. The code for the new RPC classes appears to serialize
recursively without accounting for circular references (the existing
RemoteService RPC
This is neat, Bob! It's also timely. I've been looking into
prefetching for runAsync code, and the folks I've talked to are
worried about locking up the browser with giant evals. Lazy eval as
in this patch would enable people to prefetch code more aggressively.
Like you say, it likely needs
Reviewers: jlabanca,
Please review this at http://gwt-code-reviews.appspot.com/89812
Affected files:
M user/src/com/google/gwt/layout/client/Layout.java
Index: user/src/com/google/gwt/layout/client/Layout.java
diff --git a/user/src/com/google/gwt/layout/client/Layout.java
Revision: 6584
Author: j...@google.com
Date: Mon Nov 2 12:05:30 2009
Log: LayoutImpl contains state and should not have been static. Fixing this.
http://code.google.com/p/google-web-toolkit/source/detail?r=6584
Modified:
/trunk/user/src/com/google/gwt/layout/client/Layout.java
On 2009/11/02 19:36:01, jlabanca wrote:
LGTM
Committed at r6584.
http://gwt-code-reviews.appspot.com/89812
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6585
Author: j...@google.com
Date: Mon Nov 2 12:10:23 2009
Log: Merge of /trunk c6584.
http://code.google.com/p/google-web-toolkit/source/detail?r=6585
Modified:
/releases/2.0/user/src/com/google/gwt/layout/client/Layout.java
===
---
Revision: 6586
Author: jlaba...@google.com
Date: Mon Nov 2 12:15:32 2009
Log: tr...@6583 was merged into this branch
Setting overflow to auto when enabling scrolling.
svn merge --ignore-ancestry -c 6583
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Patch by: jlabanca
I've responded to the feedback, and implemented most of it. Will commit
soon.
http://gwt-code-reviews.appspot.com/91801/diff/300/1297
File user/src/com/google/gwt/uibinder/parsers/AttributeParser.java
(right):
http://gwt-code-reviews.appspot.com/91801/diff/300/1297#newcode25
Line 25: public
Revision: 6587
Author: rj...@google.com
Date: Mon Nov 2 12:44:54 2009
Log: merges tr...@6510 into releases/2.0
Fixing svn props on many java files where this was missing.
svn merge --ignore-ancestry -c 6510
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Revision: 6588
Author: jlaba...@google.com
Date: Mon Nov 2 12:47:09 2009
Log: Disabling some tests in ImageTest because Chrome fires onload
synchronously. I will address this issue later.
Patch by: jlabanca
Review by: jgw (desk)
Issue: 863
Revision: 6590
Author: jlaba...@google.com
Date: Mon Nov 2 12:50:41 2009
Log: tr...@6588 was merged into this branch
Disabling some tests in ImageTest to work around synchronous onload in
Chrome.
svn merge --ignore-ancestry -c 6588
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Reviewers: bruce,
Description:
Somehow this was left out of the conversion from SWT to Swing.
Basically, the color shown for a line is inherited from its children if
that is higher than its own log level.
I decided to retain the icon for an entry's own level rather than using
the inherited one,
Committed tr...@6589, releases/2...@6591
http://gwt-code-reviews.appspot.com/91801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM. This might be enough without auto-expanding the nodes in error. We
can wait on that.
http://gwt-code-reviews.appspot.com/89813
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2009/11/02 21:31:36, bruce wrote:
LGTM. This might be enough without auto-expanding the nodes in error.
We can
wait on that.
Committed to trunk at r6592, merging up to releases/2.0.
http://gwt-code-reviews.appspot.com/89813
--~--~-~--~~~---~--~~
At a quick glance, something like this seems way better than a wholesale
sync-async rewriter.
It's actually important not to hide genuine asyncrony from the developer,
because it represents an actual app state the developer should account for
(e.g. what UI should be disabled while an async
Reviewers: Lex,
Description:
Hi Lex,
could you review this patch for me? It makes a number of changes to the
SOYC dashboard, as outlined by John Skidgel in his mock-up.
Thanks,
kathrin
Please review this at http://gwt-code-reviews.appspot.com/91805
Affected files:
Revision: 6593
Author: j...@google.com
Date: Mon Nov 2 13:37:57 2009
Log: Fix missing properties, add missing file for FF3.5 build with recent
changes.
http://code.google.com/p/google-web-toolkit/source/detail?r=6593
Added:
/plugin-sdks/gecko-sdks/gecko-1.9.1/include/nsPIDOMEventTarget.h
LGTM
http://gwt-code-reviews.appspot.com/91805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: jlabanca,
Description:
Added a new method to RunStyle.java that governs how many times the test
should be tried, in case of a failure. Added JUnit infrastructure to do
so, along with tests.
Please review this at http://gwt-code-reviews.appspot.com/91806
Affected files:
Committed tr...@6581, releases/2...@6594
http://gwt-code-reviews.appspot.com/91803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6594
Author: rj...@google.com
Date: Mon Nov 2 13:43:26 2009
Log: Merges tr...@6589 into releases/2.0
De-deprecate HandlerManager.removeHandler, resolves issue 3102
svn merge --ignore-ancestry -c r6581
https://google-web-toolkit.googlecode.com/svn/trunk .
http://gwt-code-reviews.appspot.com/91806/diff/1/3
File user/src/com/google/gwt/junit/JUnitShell.java (right):
http://gwt-code-reviews.appspot.com/91806/diff/1/3#newcode698
Line 698: getTopLogger().log(TreeLogger.ERROR,
This formatting change doesn't look right (the previous version fit fine
in
Revision: 6592
Author: j...@google.com
Date: Mon Nov 2 13:33:37 2009
Log: Propagate log colors to lower-priority ancestors.
Patch by: jat
Review by: bruce
http://code.google.com/p/google-web-toolkit/source/detail?r=6592
Modified:
Revision: 6595
Author: j...@google.com
Date: Mon Nov 2 13:47:14 2009
Log: Merge trunk r6592 into this branch.
Propagate log message colors to lower-priority ancestors.
svn merge --ignore-ancestry -c6592 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Lex or Bob, would one of you mind taking this? I'm kind of heads down in
hosted mode.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On 2009/11/02 22:37:17, Ray Ryan wrote:
Review requested Mr. Joel.
I promise to add tests before committing, just tidying them up now.
LVVGTM.
http://gwt-code-reviews.appspot.com/91807
--~--~-~--~~~---~--~~
Yeah, the formatting is incorrect. The default formatting on my eclipse
seems incorrect.
I will upload a re-formatted patch, after fixing the eclipse issue. Thanks
John.
On Mon, Nov 2, 2009 at 2:09 PM, j...@google.com wrote:
http://gwt-code-reviews.appspot.com/91806/diff/1/3
File
Exactly - a lot of our code is basically something like mark UI as
busy, fetch A and B, then mark UI as ready or mark UI as busy, fetch
A, then fetch B from results of A, then mark UI as ready. In other
places, we'll start a set of asynchronous operations, then have to
cancel them (if a
Reviewers: Ray Ryan,
Message:
Review requested.
Description:
This patch fixes a problem where deRPC cannot encode a circular object
reference if the circularity extends through a type that is serialized
via a CustomFieldSerializer. The reason for this is that the CFS
methods are passed a
Please test the patch at http://gwt-code-reviews.appspot.com/89815 and
let me know if that fails to resolve the problem.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/91806/diff/1/2
File user/src/com/google/gwt/junit/JUnitMessageQueue.java (right):
http://gwt-code-reviews.appspot.com/91806/diff/1/2#newcode413
Line 413: assert (result != null);
This can be null. The result is set to null to indicate that the test
has
As I mentioned before, I'm not all tat familiar with generators,
especially complex ones like this. Scott can probably give you better
feedback than I.
http://gwt-code-reviews.appspot.com/89814/diff/1/2
File
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
Revision: 6596
Author: rj...@google.com
Date: Mon Nov 2 18:05:29 2009
Log: Fix DockLayoutPanelParser and StackLayoutPanelParser
Broken by tr...@6589
tbr jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=6596
Modified:
Joel, I submitted
http://code.google.com/p/google-web-toolkit/source/detail?r=6596 TBR
you
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6598
Author: rj...@google.com
Date: Mon Nov 2 20:08:34 2009
Log: Introduces EnumAttributeParser, makes XMLElement use it, and makes the
layout
panel parsers use that.
Review by jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=6598
Added:
Revision: 6599
Author: rj...@google.com
Date: Mon Nov 2 21:21:03 2009
Log: MERGES tr...@6596 into releases/2.0
Introduces EnumAttributeParser
svn merge --ignore-ancestry -c 6598
https://google-web-toolkit.googlecode.com/svn/trunk .
Revision: 6600
Author: rj...@google.com
Date: Mon Nov 2 21:35:39 2009
Log: Enable good old VerticalAlignmentConstantParser
Also remove unused oracle field
TBR jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=6600
Modified:
Joel, if you would be so kind:
http://code.google.com/p/google-web-toolkit/source/detail?r=6600
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6601
Author: rj...@google.com
Date: Mon Nov 2 21:56:11 2009
Log: Merges tr...@6600 into releases/2.0
Enable good old VerticalAlignmentConstantParser
svn merge --ignore-ancestry -c 6600
https://google-web-toolkit.googlecode.com/svn/trunk .
58 matches
Mail list logo
