[gwt-contrib] Re: TreeTest got upset by Safari 3 too. (issue1271801)

lgtm. http://gwt-code-reviews.appspot.com/1271801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding support for setting column widths in CellTable, and for allowing CellTable to use fixed t... (issue1263801)

committed as r9513 http://gwt-code-reviews.appspot.com/1263801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Optimizations for server-side invocations of CustomFieldSerializers. (issue1273801)

http://gwt-code-reviews.appspot.com/1273801/diff/1/2 File user/src/com/google/gwt/user/client/rpc/CustomFieldSerializer.java (right): http://gwt-code-reviews.appspot.com/1273801/diff/1/2#newcode19 user/src/com/google/gwt/user/client/rpc/CustomFieldSerializer.java:19: * An interface that may be

[gwt-contrib] Re: Add support for mapping ConstraintViolation objects into SimpleBeanEditor. (issue1260801)

Reviewers: rjrjr, Nick Chalko, Message: Patch updated. The whole SimpleViolation class exists to accomodate the interim Violation interface provided by RequestFactory, since ConstraintViolation in the client was in flux when we were designing the RF API. The Violation API needs to be

[gwt-contrib] Re: Add support for mapping ConstraintViolation objects into SimpleBeanEditor. (issue1260801)

LGTM http://gwt-code-reviews.appspot.com/1260801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: This change adds couple of things: (issue1251801)

http://gwt-code-reviews.appspot.com/1251801/diff/11001/12005 File user/src/com/google/gwt/user/server/rpc/AbstractXsrfProtectedServiceServlet.java (right): http://gwt-code-reviews.appspot.com/1251801/diff/11001/12005#newcode80

[gwt-contrib] Re: This change adds couple of things: (issue1251801)

http://gwt-code-reviews.appspot.com/1251801/diff/11001/12009 File user/src/com/google/gwt/user/server/rpc/XsrfTokenServiceServlet.java (right): http://gwt-code-reviews.appspot.com/1251801/diff/11001/12009#newcode192 user/src/com/google/gwt/user/server/rpc/XsrfTokenServiceServlet.java:192:

[gwt-contrib] [GWT Designer] Use per ClassLoader ModuleDef caching (issue1274801)

Reviewers: rdayal, scottb, zundel, Description: In GWT Designer we need separated class loader for every project open in Designer. Please review this at http://gwt-code-reviews.appspot.com/1274801/show Affected files: dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java

[gwt-contrib] Re: Adds some documentation on TypeOracle and JType (issue1268801)

Updated Patch http://gwt-code-reviews.appspot.com/1268801/diff/1/2 File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right): http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode24 dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:24: * Returns this type with no type

[gwt-contrib] Re: Adds some documentation on TypeOracle and JType (issue1268801)

http://gwt-code-reviews.appspot.com/1268801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: This change adds couple of things: (issue1251801)

http://gwt-code-reviews.appspot.com/1251801/diff/11001/12005 File user/src/com/google/gwt/user/server/rpc/AbstractXsrfProtectedServiceServlet.java (right): http://gwt-code-reviews.appspot.com/1251801/diff/11001/12005#newcode80

[gwt-contrib] [GWT Designer] Don't cache rebind results while design time (issue1275801)

Reviewers: rdayal, scottb, zundel, Description: Newly generated type needed every time when user modifies UiBinder-based UI using the Designer Editor (I also set rebindCache to null while instantiating ShellModuleSpaceHost). Please review this at http://gwt-code-reviews.appspot.com/1275801/show

[gwt-contrib] Re: Extend GWTTestCase to support HTTP requests to remote server and moduleBaseURL mismatch (issue1043801)

will upload new patch shortly. Added tests and a sample app, using violator pattern to access private members. http://gwt-code-reviews.appspot.com/1043801/diff/1/8 File user/src/com/google/gwt/junit/JUnitShell.java (right): http://gwt-code-reviews.appspot.com/1043801/diff/1/8#newcode1536

[gwt-contrib] Re: Extend GWTTestCase to support HTTP requests to remote server and moduleBaseURL mismatch (issue1043801)

http://gwt-code-reviews.appspot.com/1043801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: [GWT Designer] Use per ClassLoader ModuleDef caching (issue1274801)

http://gwt-code-reviews.appspot.com/1274801/diff/1/3 File dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java (right): http://gwt-code-reviews.appspot.com/1274801/diff/1/3#newcode145 dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java:145: ModuleDef moduleDef = (ModuleDef)

[gwt-contrib] Re: Extend GWTTestCase to support HTTP requests to remote server and moduleBaseURL mismatch (issue1043801)

patch set 4: sync to latest and convert tabs http://gwt-code-reviews.appspot.com/1043801/diff/44001/45006 File user/src/com/google/gwt/junit/JUnitShell.java (right): http://gwt-code-reviews.appspot.com/1043801/diff/44001/45006#newcode195 user/src/com/google/gwt/junit/JUnitShell.java:195:

[gwt-contrib] Re: This change adds couple of things: (issue1251801)

http://gwt-code-reviews.appspot.com/1251801/diff/11001/12008 File user/src/com/google/gwt/user/server/rpc/XsrfProtectedServiceServlet.java (right): http://gwt-code-reviews.appspot.com/1251801/diff/11001/12008#newcode120