LGTM
http://gwt-code-reviews.appspot.com/1368803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Step-by-step how I was running the tests:
1) Open Eclipse and go to Run-Run Configurations
2) Select GWT JUnit Test on the left and click the new test icon.
3) Put anything for the name, but for the Project put gwt-user and for
the Test Class put com.google.gwt.user.client.ui.ImageTest
4) Click
LGTM
http://gwt-code-reviews.appspot.com/1373802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM: oops, looks like I never sent this comment
http://gwt-code-reviews.appspot.com/1371802/diff/1/eclipse/settings/code-style/gwt-format.xml
File eclipse/settings/code-style/gwt-format.xml (right):
committed as r9788
http://gwt-code-reviews.appspot.com/1368804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jgw,
Description:
Fixes a bug in TypeOracle for computing information about single JSO
impls.
If you have an interface (lets call it B) that doesn't declare any new
methods,
but implements some other interface (lets call it A) that may or may not
declare
methods, then it should be
lgtm
http://gwt-code-reviews.appspot.com/1373803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/03/02 16:30:22, knorton wrote:
lgtm
me too
http://gwt-code-reviews.appspot.com/1373803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2011/03/01 05:40:57, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1367802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Mar 2, 2011 at 6:41 AM, zun...@google.com wrote:
LGTM: oops, looks like I never sent this comment
http://gwt-code-reviews.appspot.com/1371802/diff/1/eclipse/settings/code-style/gwt-format.xml
File eclipse/settings/code-style/gwt-format.xml (right):
Reviewers: doog,
Description:
Fix EZT formatting
Please review this at http://gwt-code-reviews.appspot.com/1367803/
Affected files:
M build-tools/doctool/src/com/google/doctool/custom/EztDoclet.java
Index: build-tools/doctool/src/com/google/doctool/custom/EztDoclet.java
Revision: 9790
Author: jaime...@google.com
Date: Wed Mar 2 06:04:24 2011
Log: Fixes a bug in TypeOracle for computing information about single JSO
impls.
If you have an interface (lets call it B) that doesn't declare any new
methods,
but implements some other interface (lets call it A)
Revision: 9791
Author: ncha...@google.com
Date: Wed Mar 2 06:09:17 2011
Log: Only validate a constraint annotation once.
[JSR 303 TCK Result] 106 of 257 (41.25%) Pass with 24 Failures and 9 Errors.
Review at http://gwt-code-reviews.appspot.com/1373802
Review by: rchan...@google.com
Revision: 9792
Author: ncha...@google.com
Date: Wed Mar 2 06:32:23 2011
Log: To prevent infinite loops, the Bean Validation implementation must
ignore
the cascading operation if the associated object instance has already been
validated in the current navigation path (starting from the root
And I won't review them. Doing the real review now.
On 2011/03/01 22:29:04, bobv wrote:
The changes to the old DynaTable sample are just to have a trivially
simple app
to work with while reducing code size. I won't commit them.
http://gwt-code-reviews.appspot.com/1369803/
--
LGTM
Just nits.
http://gwt-code-reviews.appspot.com/1369803/diff/1/user/src/com/google/gwt/autobean/client/impl/ClientPropertyContext.java
File
user/src/com/google/gwt/autobean/client/impl/ClientPropertyContext.java
(right):
Revision: 9793
Author: r...@google.com
Date: Wed Mar 2 08:46:52 2011
Log: Fix EZT formatting
Review at http://gwt-code-reviews.appspot.com/1367803
Review by: d...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9793
Modified:
http://gwt-code-reviews.appspot.com/1368803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jat,
Description:
Switching to the junit4 jars, although the @annotation stuff isn't
going to work.
Review by: j...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1374801/
Affected files:
M build-tools/ant-gwt/build.xml
M common.ant.xml
M dev/build.xml
Revision: 9794
Author: fabb...@google.com
Date: Wed Mar 2 13:15:19 2011
Log: Adding junit 4.8.2 jars
http://code.google.com/p/google-web-toolkit/source/detail?r=9794
Added:
/tools/lib/junit/junit-4.8.2-src.jar
/tools/lib/junit/junit-4.8.2.jar
===
---
LGTM, assuming the JUnit jar is committed to tools.
http://gwt-code-reviews.appspot.com/1374801/diff/1/user/test/org/hibernate/jsr303/tck/util/TckTestSuiteWrapper.java
File user/test/org/hibernate/jsr303/tck/util/TckTestSuiteWrapper.java
(left):
http://gwt-code-reviews.appspot.com/1368803/diff/1003/user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
File
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
(right):
Yep, the tools update just happened at r9794.
http://gwt-code-reviews.appspot.com/1374801/diff/1/user/test/org/hibernate/jsr303/tck/util/TckTestSuiteWrapper.java
File user/test/org/hibernate/jsr303/tck/util/TckTestSuiteWrapper.java
(left):
http://gwt-code-reviews.appspot.com/1368803/diff/1003/user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
File
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
(right):
Unit test up for review at:
http://gwt-code-reviews.appspot.com/1369805
On Wed, Mar 2, 2011 at 11:32 AM, j...@google.com wrote:
On 2011/03/02 16:30:22, knorton wrote:
lgtm
me too
http://gwt-code-reviews.appspot.com/1373803/
--
BTW, you should probably put your explanation in a comment for the next
guy to edit this code.
http://gwt-code-reviews.appspot.com/1368803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jaimeyap, scottb,
Description:
Adds unit tests for extending JavaScriptObject. Tests a loosening of
the
restriction for mulitple JSOs implementing the same interface added in
http://gwt-code-reviews.appspot.com/1373803/
Please review this at
Ok, LGTM.
It is a pretty odd formulation to have a static initializer only call an
external method, but it is in generated code so I don't guess it matters
as long as it works.
http://gwt-code-reviews.appspot.com/1368803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1369805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: bobv,
Please review this at http://gwt-code-reviews.appspot.com/1370806/
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/ArtificialRescueRecorder.java
M dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
Index:
LGTM, if the smoke tests pass.
http://gwt-code-reviews.appspot.com/1370806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I will let Scott have the final word.
Tests look good. Just a nit on on exposing a public setter for the value
of JSO.
http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java
File
http://gwt-code-reviews.appspot.com/1305801/diff/48001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):
I'm getting lost in the diff cheese. Can you post a review sans
auto-format diffs?
http://gwt-code-reviews.appspot.com/1369805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
In TypeOracleMediatorTestBase, the only thing I changed was to add new unit
tests, and add a tearDown() method. The rest is reformatting cheese. Does
that help?
On Wed, Mar 2, 2011 at 6:56 PM, sco...@google.com wrote:
I'm getting lost in the diff cheese. Can you post a review sans
Reviewers: rchandia,
Description:
Adding a constructor overload to CellTable that takes a loading
indicator widget. For legacy support, CellTable uses the
Resources.cellTableLoading() ImageResource to create a loading
indicator. However, the default loading animation adds 20KB to the
compiled
You'll want to revert your diff-cheese anyhow before committing, but
yes, that help.
LG except for TypeOracle hack. Just make your tests use the correct
FQTN for JavaScriptObject.
It seems like a shame that this is opt in.
Is there anything lighter weight we can use for the default indicator?
http://gwt-code-reviews.appspot.com/1371805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: zundel, jbrosenberg,
Description:
This change allows JClassLiterals to be created apart from a JProgram.
A new normalization pass runs before optimizations and creates all the
ClassLiteralHolder implementation fields.
Please review this at http://gwt-code-reviews.appspot.com/1375801/
updated patch
http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java
File dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java
(right):
@Scott: I was not planning to revert the diff cheese. This uses the recently
updated official gwt-format.xml autoformatting for Eclipse. I've already
volunteered to go through and run the autoformatter to bring existing source
up to date.
On Wed, Mar 2, 2011 at 7:12 PM, sco...@google.com wrote:
http://gwt-code-reviews.appspot.com/1355802/diff/10001/user/src/com/google/gwt/i18n/client/impl/plurals/DefaultRule.java
File user/src/com/google/gwt/i18n/client/impl/plurals/DefaultRule.java
(right):
On Wed, Mar 2, 2011 at 7:21 PM, Eric Ayers zun...@google.com wrote:
@Scott: I was not planning to revert the diff cheese. This uses the
recently updated official gwt-format.xml autoformatting for Eclipse. I've
already volunteered to go through and run the autoformatter to bring
existing
Adding Ray also since he's been looking at some of this.
http://gwt-code-reviews.appspot.com/1375801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
44 matches
Mail list logo
