[gwt-contrib] Re: Promotes Gin's AsyncProvider to GWT, along with a more general (issue1387801)

2011-03-14 Thread bobv
LGTM. http://gwt-code-reviews.appspot.com/1387801/diff/5/user/src/com/google/gwt/core/client/AsyncProvider.java File user/src/com/google/gwt/core/client/AsyncProvider.java (right):

[gwt-contrib] Re: Fixing touch scrolling support for devices that support it natively. Our current touch support o... (issue1369809)

2011-03-14 Thread jlabanca
ping http://gwt-code-reviews.appspot.com/1369809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix problem with user-agent based locale selection (issue1382803)

2011-03-14 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1382803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread jlabanca
http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java File user/src/com/google/gwt/user/client/ui/Frame.java (right): http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java#newcode78

[gwt-contrib] [google-web-toolkit] r9849 committed - creating the 2.3 release branch

2011-03-14 Thread codesite-noreply
Revision: 9849 Author: mrruss...@google.com Date: Mon Mar 14 08:33:12 2011 Log: creating the 2.3 release branch http://code.google.com/p/google-web-toolkit/source/detail?r=9849 Added: /releases/2.3 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] HasDataPresenter's SchedulerImpl coupling

2011-03-14 Thread John LaBanca
Thats fine with me. You could also create a protected HasDataPresenter#scheduleCommand() method and just override it in your mock unit test version. Thanks, John LaBanca jlaba...@google.com On Sun, Mar 13, 2011 at 11:12 PM, Stephen Haberman stephen.haber...@gmail.com wrote: Hi, I was

[gwt-contrib] Re: Promotes Gin's AsyncProvider to GWT, along with a more general (issue1387801)

2011-03-14 Thread Ray Ryan
[+google-...@googlegroups.com] What dependency? DI is a pattern, not a commitment to a particular framework. That said, I agree that taking AsyncProvider from Gin is a bit presumptuous. I meant to include the gin community on this patch, adding them now. What do you think, folks? The goal here

[gwt-contrib] Re: Adding a new annotation SafeHtmlTemplates.SafeForCss to specify that a parameter is known to be ... (issue1384801)

2011-03-14 Thread jlabanca
http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/src/com/google/gwt/safecss/shared/SafeCssProperties.java File user/src/com/google/gwt/safecss/shared/SafeCssProperties.java (right):

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread pdr
http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread jlabanca
iframetest.html still looks weird. I'll assume it looks correct on your system. http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new annotation SafeHtmlTemplates.SafeForCss to specify that a parameter is known to be ... (issue1384801)

2011-03-14 Thread jlabanca
http://gwt-code-reviews.appspot.com/1384801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread pdr
http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java File user/src/com/google/gwt/user/client/ui/Frame.java (right): http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java#newcode78

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread pdr
http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing touch scrolling support for devices that support it natively. Our current touch support o... (issue1369809)

2011-03-14 Thread jlabanca
http://gwt-code-reviews.appspot.com/1369809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing touch scrolling support for devices that support it natively. Our current touch support o... (issue1369809)

2011-03-14 Thread pdr
I had reviewed this after all, but forgot to click send. D'oh! Sorry for the delay. http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml File user/src/com/google/gwt/event/dom/DomEvent.gwt.xml (right):

[gwt-contrib] Re: Fixing touch scrolling support for devices that support it natively. Our current touch support o... (issue1369809)

2011-03-14 Thread jlabanca
http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml File user/src/com/google/gwt/event/dom/DomEvent.gwt.xml (right): http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml#newcode3

[gwt-contrib] Re: Adding a new annotation SafeHtmlTemplates.SafeForCss to specify that a parameter is known to be ... (issue1384801)

2011-03-14 Thread skybrian
Seems basically fine. I'm just wondering if we're missing anything. http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java File user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java (right):

[gwt-contrib] Re: Fixing touch scrolling support for devices that support it natively. Our current touch support o... (issue1369809)

2011-03-14 Thread pdr
On 2011/03/14 18:29:43, jlabanca wrote: http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml File user/src/com/google/gwt/event/dom/DomEvent.gwt.xml (right):

[gwt-contrib] Are there any docs describing internals of gwtc?

2011-03-14 Thread Grzegorz Kossakowski
Hi, More and more often I find myself lacking the big picture of gwtc's internals. I'd like to find answers (or hints where to look for answers) for questions like: 1. What's the difference between TypeMap and TypeOracle and why they seem to have overlapping functionality? 2. Why

Re: [gwt-contrib] Are there any docs describing internals of gwtc?

2011-03-14 Thread Scott Blum
On Mon, Mar 14, 2011 at 3:03 PM, Grzegorz Kossakowski grzegorz.kossakow...@gmail.com wrote: 1. What's the difference between TypeMap and TypeOracle and why they seem to have overlapping functionality? In GWT, there are two major pieces of infrastructure that deal with representing Java

[gwt-contrib] Re: Reintroduces JsInliner patch with minor tweaks (previously submitted by cromwellian at rev 9362) (issue1386801)

2011-03-14 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/1386801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Reintroduces JsInliner patch with minor tweaks (previously submitted by cromwellian at rev 9362) (issue1386801)

2011-03-14 Thread cromwellian
LGTM http://gwt-code-reviews.appspot.com/1386801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Are there any docs describing internals of gwtc?

2011-03-14 Thread Grzegorz Kossakowski
Hi Scott! Thanks for speedy and seriously awesome response! :-) Some questions inline. 2011/3/14 Scott Blum sco...@google.com: On Mon, Mar 14, 2011 at 3:03 PM, Grzegorz Kossakowski grzegorz.kossakow...@gmail.com wrote: 1. What's the difference between TypeMap and TypeOracle and why they

[gwt-contrib] Re: Adding a new annotation SafeHtmlTemplates.SafeForCss to specify that a parameter is known to be ... (issue1384801)

2011-03-14 Thread xtof
http://gwt-code-reviews.appspot.com/1384801/diff/3008/user/src/com/google/gwt/safecss/shared/SafeCssProperties.java File user/src/com/google/gwt/safecss/shared/SafeCssProperties.java (right):

[gwt-contrib] Re: Adding a new annotation SafeHtmlTemplates.SafeForCss to specify that a parameter is known to be ... (issue1384801)

2011-03-14 Thread jlabanca
http://gwt-code-reviews.appspot.com/1384801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new annotation SafeHtmlTemplates.SafeForCss to specify that a parameter is known to be ... (issue1384801)

2011-03-14 Thread jlabanca
http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java File user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java (right):

[gwt-contrib] Re: Adding a new annotation SafeHtmlTemplates.SafeForCss to specify that a parameter is known to be ... (issue1384801)

2011-03-14 Thread xtof
http://gwt-code-reviews.appspot.com/1384801/diff/6006/user/src/com/google/gwt/safecss/shared/SafeCssProperties.java File user/src/com/google/gwt/safecss/shared/SafeCssProperties.java (right):

[gwt-contrib] Re: Adds a cache (PersistenUnitCache) to store CompilationUnits (issue1375802)

2011-03-14 Thread zundel
http://gwt-code-reviews.appspot.com/1375802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a cache (PersistenUnitCache) to store CompilationUnits (issue1375802)

2011-03-14 Thread zundel
Here is a re-working of the cache based on the feedback. I've removed caching inside CompilationStateBuilder, and made all cache lookups by the ContentId. Still TODO on this patch is a unit test, which I will work on tomorrow.

[gwt-contrib] Re: Fix issue 5807 on server side. Previously reviewed at 1370803. (issue1384802)

2011-03-14 Thread drfibonacci
http://gwt-code-reviews.appspot.com/1384802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new annotation SafeHtmlTemplates.SafeForCss to specify that a parameter is known to be ... (issue1384801)

2011-03-14 Thread skybrian
http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java File user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java (right):

Re: [gwt-contrib] Are there any docs describing internals of gwtc?

2011-03-14 Thread Scott Blum
On Mon, Mar 14, 2011 at 4:41 PM, Grzegorz Kossakowski grzegorz.kossakow...@gmail.com wrote: So, if my GWT app doesn't have any generators exact contents of TypeOracle doesn't matter? I'm asking because I'm thinking of creating some stub data structures for jribble units and just move on to