LGTM.
http://gwt-code-reviews.appspot.com/1387801/diff/5/user/src/com/google/gwt/core/client/AsyncProvider.java
File user/src/com/google/gwt/core/client/AsyncProvider.java (right):
ping
http://gwt-code-reviews.appspot.com/1369809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1382803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java
File user/src/com/google/gwt/user/client/ui/Frame.java (right):
http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java#newcode78
Revision: 9849
Author: mrruss...@google.com
Date: Mon Mar 14 08:33:12 2011
Log: creating the 2.3 release branch
http://code.google.com/p/google-web-toolkit/source/detail?r=9849
Added:
/releases/2.3
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thats fine with me. You could also create a protected
HasDataPresenter#scheduleCommand() method and just override it in your mock
unit test version.
Thanks,
John LaBanca
jlaba...@google.com
On Sun, Mar 13, 2011 at 11:12 PM, Stephen Haberman
stephen.haber...@gmail.com wrote:
Hi,
I was
[+google-...@googlegroups.com]
What dependency? DI is a pattern, not a commitment to a particular
framework. That said, I agree that taking AsyncProvider from Gin is a bit
presumptuous. I meant to include the gin community on this patch, adding
them now.
What do you think, folks? The goal here
http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/src/com/google/gwt/safecss/shared/SafeCssProperties.java
File user/src/com/google/gwt/safecss/shared/SafeCssProperties.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1294801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1294801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
iframetest.html still looks weird. I'll assume it looks correct on your
system.
http://gwt-code-reviews.appspot.com/1294801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1384801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java
File user/src/com/google/gwt/user/client/ui/Frame.java (right):
http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java#newcode78
http://gwt-code-reviews.appspot.com/1294801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1294801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1369809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I had reviewed this after all, but forgot to click send. D'oh! Sorry for
the delay.
http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml
File user/src/com/google/gwt/event/dom/DomEvent.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml
File user/src/com/google/gwt/event/dom/DomEvent.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml#newcode3
Seems basically fine. I'm just wondering if we're missing anything.
http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java
File user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java
(right):
On 2011/03/14 18:29:43, jlabanca wrote:
http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml
File user/src/com/google/gwt/event/dom/DomEvent.gwt.xml (right):
Hi,
More and more often I find myself lacking the big picture of gwtc's
internals. I'd like to find answers (or hints where to look for
answers) for questions like:
1. What's the difference between TypeMap and TypeOracle and why they
seem to have overlapping functionality?
2. Why
On Mon, Mar 14, 2011 at 3:03 PM, Grzegorz Kossakowski
grzegorz.kossakow...@gmail.com wrote:
1. What's the difference between TypeMap and TypeOracle and why they
seem to have overlapping functionality?
In GWT, there are two major pieces of infrastructure that deal with
representing Java
http://gwt-code-reviews.appspot.com/1386801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1386801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hi Scott!
Thanks for speedy and seriously awesome response! :-)
Some questions inline.
2011/3/14 Scott Blum sco...@google.com:
On Mon, Mar 14, 2011 at 3:03 PM, Grzegorz Kossakowski
grzegorz.kossakow...@gmail.com wrote:
1. What's the difference between TypeMap and TypeOracle and why they
http://gwt-code-reviews.appspot.com/1384801/diff/3008/user/src/com/google/gwt/safecss/shared/SafeCssProperties.java
File user/src/com/google/gwt/safecss/shared/SafeCssProperties.java
(right):
http://gwt-code-reviews.appspot.com/1384801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java
File user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java
(right):
http://gwt-code-reviews.appspot.com/1384801/diff/6006/user/src/com/google/gwt/safecss/shared/SafeCssProperties.java
File user/src/com/google/gwt/safecss/shared/SafeCssProperties.java
(right):
http://gwt-code-reviews.appspot.com/1375802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Here is a re-working of the cache based on the feedback. I've removed
caching inside CompilationStateBuilder, and made all cache lookups by
the ContentId.
Still TODO on this patch is a unit test, which I will work on tomorrow.
http://gwt-code-reviews.appspot.com/1384802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1384801/diff/3003/user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java
File user/test/com/google/gwt/safehtml/client/SafeHtmlTemplatesTest.java
(right):
On Mon, Mar 14, 2011 at 4:41 PM, Grzegorz Kossakowski
grzegorz.kossakow...@gmail.com wrote:
So, if my GWT app doesn't have any generators exact contents of
TypeOracle doesn't matter? I'm asking because I'm thinking of creating
some stub data structures for jribble units and just move on to
34 matches
Mail list logo