Thanks for reporting the issue! Filed at:
http://code.google.com/p/google-web-toolkit/issues/detail?id=6300
On Fri, Apr 29, 2011 at 3:15 PM, misra.a...@gmail.com wrote:
There is a small issue with cancel button, when you add task. It doesn't
work.
On 2011/04/27 17:38:57, jlabanca wrote:
I addressed the feedback (including Brian's one, adding a paragraph to
SafeUri javadoc) and formatted the files.
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/client/ImageResource.java
File user/src/com/google/gwt/resources/client/ImageResource.java
http://gwt-code-reviews.appspot.com/1422812/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr, robertvawter,
Description:
Add a convenience base class for value type locators
Please review this at http://gwt-code-reviews.appspot.com/1428809/
Affected files:
A user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java
Index:
Reviewers: rjrjr,
Description:
Remove duplicate build target
Please review this at http://gwt-code-reviews.appspot.com/1423812/
Affected files:
M build.xml
Index: build.xml
===
--- build.xml (revision 10116)
+++ build.xml
http://gwt-code-reviews.appspot.com/1428805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I decided to back out the original patch and go with using the output of
resource.getPath() as the key for the cache. This should differentiate
between source and super-source but not include any special prefixes for
.jar files or generated files.
http://gwt-code-reviews.appspot.com/1428805/
I should also mention that this makes a follow-on patch to check
contentId in case jar file timestamps update a little bit easier when
updating the cached unit.
http://gwt-code-reviews.appspot.com/1428805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
My 2c.
http://gwt-code-reviews.appspot.com/1428809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java
File
user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1423812/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Nice change. I like this better.
http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):
LGTM
Nice change. I like this better.
http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):
LGTM
Nice change. I like this better.
http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):
Rietveld is giving me a bunch of errors trying to read files such as
web.xml. I reviewed the one file I could access and that is relevant to
this change, but do you mind re-uploading the patch?
Revision: 10117
Author: jlaba...@google.com
Date: Mon May 2 06:45:06 2011
Log: Adding the SourceElement for use with Audio and Video, and adding
convenience methods in those widgets to use the element. Multiple
SourceElements can be specified for an AudioElement/VideoElement
committed as r10117
http://gwt-code-reviews.appspot.com/1423810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Needs integration test, but let's leave that for a follow up. I want to
land http://gwt-code-reviews.appspot.com/1421811/ first.
http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java
File
LGTM
Nice change. I like this better.
(This failed last time. This might be a duplicate).
http://gwt-code-reviews.appspot.com/1428805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Thanks!
http://gwt-code-reviews.appspot.com/1429801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Some nits. Needs Rafa's LGTM
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
LGTM
On Fri, Apr 29, 2011 at 2:06 PM, rdcas...@google.com wrote:
Reviewers: rjrjr,
Description:
Fix Attachable for those poor fellows who don't have the bliss of
SafeHtml enabled (yet).
Please review this at http://gwt-code-reviews.appspot.com/1426808/
Affected files:
M
Revision: 10118
Author: bd...@google.com
Date: Mon May 2 08:00:17 2011
Log: Implementation of a RecordingEventBus, which is useful for writing
tests that verify whether certain events have been fired.
Review at http://gwt-code-reviews.appspot.com/1429801
Review by: rj...@google.com
Revision: 10119
Author: gwt.mirror...@gmail.com
Date: Mon May 2 11:17:34 2011
Log: Fix Attachable for those poor fellows who don't have the bliss of
SafeHtml enabled (yet).
Review at http://gwt-code-reviews.appspot.com/1426808
Review by: rj...@google.com
Reviewers: rjrjr,
Description:
SafeHtmlRenderer code gen for UiBinder.
Picking-up patch from rietveld issue 1426803
Please review this at http://gwt-code-reviews.appspot.com/1427810/
Affected files:
M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
M
Review will continue at http://gwt-code-reviews.appspot.com/1427810
On 2011/04/26 23:07:59, rjrjr wrote:
Turns out the useLazyWidget stuff isn't passing all of the UiBinder
tests
yet. Ignoring that path for now seems reasonable. Sorry for the flip
flop.
On Mon, Apr 25, 2011 at 3:19 PM,
http://gwt-code-reviews.appspot.com/1427807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2011/04/28 15:12:50, Stephen Chenney wrote:
I have removed the out-of-date comment and ran a smoke test with a
fresh pull of
GWT. Everything is checking out.
http://gwt-code-reviews.appspot.com/1424801/diff/1/user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java
File
Reviewers: rchandia,
Description:
Adding a tutorial video to the MobileWebApp sample as an example of
using HTML5 video. Also fixing issue 6300 (pressing cancel button
doesn't work when adding a new task).
Demo at http://jlabanca-testing.appspot.com/. Click the Need Help?
link in the upper
I also added some conditions to BrowserChannelServerTest to integration
test the way this class works with DevModeSession.
And I had to add a utility class in the dev.shell package for use by
unit tests when working with DevModeSession class (since its constructor
and
LGTM. Awesome!
On 2011/05/02 18:56:59, jlabanca wrote:
http://gwt-code-reviews.appspot.com/1425815/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Makes some private info from AttachableHTMLPanel accessible to
subclasses.
Please review this at http://gwt-code-reviews.appspot.com/1423813/
Affected files:
M user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
Index:
LGTM
http://gwt-code-reviews.appspot.com/1423813/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: unnurg,
Description:
Add runtime-locale support for Localizable subtypes.
This is a prerequisitive for later work moving things from being
generated at compile-time to being mostly pre-generated during the CLDR
import step. What can't be pre-generated is the runtime locales
support,
http://gwt-code-reviews.appspot.com/1425816/diff/1/user/src/com/google/gwt/i18n/client/impl/cldr/LocalizedNamesImplBase.java
File
user/src/com/google/gwt/i18n/client/impl/cldr/LocalizedNamesImplBase.java
(right):
Reviewers: sbrubaker,
Description:
Fixing MediaTest#testAddSource to only compare the end of the src to the
src that was set. Some browsers automatically prepend the host path to
the src file name.
Please review this at http://gwt-code-reviews.appspot.com/1427811/
Affected files:
M
LGTM
http://gwt-code-reviews.appspot.com/1427811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10121
Author: jlaba...@google.com
Date: Mon May 2 09:30:06 2011
Log: Fixing MediaTest#testAddSource to only compare the end of the src
to the src that was set. Some browsers automatically prepend the host path
to the src file name.
Review at
committed as r10121
http://gwt-code-reviews.appspot.com/1427811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10122
Author: jlaba...@google.com
Date: Mon May 2 09:33:23 2011
Log: Adding a tutorial video to the MobileWebApp sample as an example
of using HTML5 video. Also fixing issue 6300 (pressing cancel button
doesn't work when adding a new task).
Demo at
committed as r10122
http://gwt-code-reviews.appspot.com/1425815/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1428807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
Revision: 10123
Author: rj...@google.com
Date: Mon May 2 09:43:22 2011
Log: Guide eclipse users to jdk 1.6, not 1.5
http://code.google.com/p/google-web-toolkit/source/detail?r=10123
Modified:
/trunk/eclipse/README.txt
===
---
Looks good as soon as I see FieldWriterOfExsitingTypeTest.java. It's
okay to hold off on the integration test, but there shouldn't be
anything in the way of writing a unit test a la
FieldWriterOfGeneratedCssResourceTest.
Sorry, I could have sworn I asked for that in the first review. Must
have
Reviewers: rchandia,
Description:
Including the TaskProxy (when available) in TaskEditPlace so we do not
do an extra round trip to the server to lookup the task.
Also fixing a bug where the Task List menu item isn't selected when
the task list is visible because TaskListPlace is no longer a
Revision: 10124
Author: to...@google.com
Date: Mon May 2 13:03:37 2011
Log: Edited wiki page TroubleshootingOOPHM through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=10124
Modified:
/wiki/TroubleshootingOOPHM.wiki
Revision: 10125
Author: to...@google.com
Date: Mon May 2 13:04:25 2011
Log: Edited wiki page TroubleshootingOOPHM through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=10125
Modified:
/wiki/TroubleshootingOOPHM.wiki
http://gwt-code-reviews.appspot.com/1421811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Hermes will follow up with tests posthaste
http://gwt-code-reviews.appspot.com/1428807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Updated with support for type parameters like W extends IsWidget
IsPlaid in @UiChild methods. Unnur, can you take another look?
http://gwt-code-reviews.appspot.com/1421811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hey there Rodrigo. Unnur is on point for this review, but you might find
it interesting.
http://gwt-code-reviews.appspot.com/1421811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: unnurg,
Description:
Improve runtime locales support, so runtime locales that are under a
more specific compile-time locale do not appear under a more general
one. An example would be compile locales of [es, es-419] and runtime
locales of [es-es, es-co, es-ar] -- the runtime locales
LGTM
On Mon, May 2, 2011 at 7:15 PM, rj...@google.com wrote:
LGTM
Hermes will follow up with tests posthaste
http://gwt-code-reviews.appspot.com/1428807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Is this ready for review?
http://gwt-code-reviews.appspot.com/1422812/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10126
Author: gwt.mirror...@gmail.com
Date: Mon May 2 12:51:01 2011
Log: Makes some private info from AttachableHTMLPanel accessible to
subclasses.
http://gwt-code-reviews.appspot.com/1423813/
http://code.google.com/p/google-web-toolkit/source/detail?r=10126
Modified:
This still appears to have all the problems of
http://gwt-code-reviews.appspot.com/1426803.
On Mon, May 2, 2011 at 11:33 AM, rchan...@google.com wrote:
Reviewers: rjrjr,
Description:
SafeHtmlRenderer code gen for UiBinder.
Picking-up patch from rietveld issue 1426803
Please review this
Revision: 10127
Author: her...@google.com
Date: Mon May 2 12:52:38 2011
Log: Introducing FieldTypeWriter, an enum that identifies field
writers and
defines precedences useful for disambiguation when sorting builders
in the Widgets ctor.
Review at
LGTM
On 2011/05/02 22:19:32, rjrjr wrote:
Hey there Rodrigo. Unnur is on point for this review, but you might
find it
interesting.
http://gwt-code-reviews.appspot.com/1421811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2011/05/02 22:31:23, jat wrote:
http://gwt-code-reviews.appspot.com/1421812/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
No; I hope to get it back to you tomorrow or Wednesday.
On Mon, May 2, 2011 at 6:56 PM, rj...@google.com wrote:
Is this ready for review?
http://gwt-code-reviews.appspot.com/1422812/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Lots of nits, but looks pretty good overall. I haven't tried it out
yet, but it'll be a big improvement over truncating excess tabs.
Test cases would also be much appreciated.
http://gwt-code-reviews.appspot.com/1403801/diff/1/user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java
File
63 matches
Mail list logo
