I don't know why, but it outputs an error twice (this is the only
missing ProxyFor annotation I have, so I can't tell whether it's
specific to that interface or more general):
myapp-shared/src/main/java/xxx/shared/breadcrumb/BreadCrumbItemProxy.java:14:
A proxy must be annotated with ProxyFor,
Was curious to see what it'd look like; finally have a few comments.
http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRenderer.java
File user/src/com/google/gwt/uibinder/client/UiRenderer.java (right):
Was curious to see what it'd look like; finally have a few comments.
http://gwt-code-reviews.appspot.com/1466809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM (w/minor cleanup + a suggestion)
I like the management of class literal rescues much better now!
http://gwt-code-reviews.appspot.com/1447821/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
http://gwt-code-reviews.appspot.com/1466809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks Thomas!.
http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRenderer.java
File user/src/com/google/gwt/uibinder/client/UiRenderer.java (right):
http://gwt-code-reviews.appspot.com/1466809/diff/1/tools/api-checker/config/gwt23_24userApi.conf
File tools/api-checker/config/gwt23_24userApi.conf (right):
http://gwt-code-reviews.appspot.com/1466809/diff/1/tools/api-checker/config/gwt23_24userApi.conf#newcode58
Regarding the generics issue, I agree that the checker is behaving
correctly: the ListSubFooProxy would be converted to a ListSubFoo
when being checked against the domain type. A List? extends BaseFoo
can't be assigned to the type ListSubFoo since the list might contain
OtherFoo elements.
Since
On Fri, Jul 1, 2011 at 5:52 PM, b...@google.com wrote:
Regarding the generics issue, I agree that the checker is behaving
correctly: the ListSubFooProxy would be converted to a ListSubFoo
when being checked against the domain type. A List? extends BaseFoo
can't be assigned to the type
Reviewers: jat, conroy,
Description:
Updating npapi plugin to remove gwtId from Jso objects (idenity fix),
adds a second map in LocalObjects.
Please review this at http://gwt-code-reviews.appspot.com/1469803/
Affected files:
M plugins/npapi/LocalObjectTable.h
M
http://gwt-code-reviews.appspot.com/1469803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/07/01 18:28:32, codefu wrote:
We can't rip out the ID hack quite yet-- we'd have to wait until the
fixes roll out to stable users. We need to add some version checking of
chrome to decide if it's safe to do this.
http://gwt-code-reviews.appspot.com/1469803/
--
On 2011/07/01 18:31:43, conroy wrote:
On 2011/07/01 18:28:32, codefu wrote:
We can't rip out the ID hack quite yet-- we'd have to wait until the
fixes roll
out to stable users. We need to add some version checking of chrome to
decide if
it's safe to do this.
Is windows still on
http://gwt-code-reviews.appspot.com/1469803/diff/1/plugins/npapi/LocalObjectTable.h
File plugins/npapi/LocalObjectTable.h (right):
http://gwt-code-reviews.appspot.com/1469803/diff/1/plugins/npapi/LocalObjectTable.h#newcode100
plugins/npapi/LocalObjectTable.h:100: NPObject* get(int id) {
Given
http://gwt-code-reviews.appspot.com/1469803/diff/1/plugins/npapi/LocalObjectTable.h
File plugins/npapi/LocalObjectTable.h (right):
http://gwt-code-reviews.appspot.com/1469803/diff/1/plugins/npapi/LocalObjectTable.h#newcode100
plugins/npapi/LocalObjectTable.h:100: NPObject* get(int id) {
On
http://gwt-code-reviews.appspot.com/1469803/diff/1/plugins/npapi/ScriptableInstance.cpp
File plugins/npapi/ScriptableInstance.cpp (right):
http://gwt-code-reviews.appspot.com/1469803/diff/1/plugins/npapi/ScriptableInstance.cpp#newcode434
plugins/npapi/ScriptableInstance.cpp:434: int id =
Revision: 10418
Author: gwt.mirror...@gmail.com
Date: Fri Jul 1 12:22:05 2011
Log: Update pre-built requestfactory-apt.jar to r10417.
http://code.google.com/p/google-web-toolkit/source/detail?r=10418
Modified:
/tools/lib/requestfactory/requestfactory-apt.jar
http://gwt-code-reviews.appspot.com/1469803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1469803/diff/1/plugins/npapi/ScriptableInstance.cpp
File plugins/npapi/ScriptableInstance.cpp (right):
http://gwt-code-reviews.appspot.com/1469803/diff/1/plugins/npapi/ScriptableInstance.cpp#newcode434
plugins/npapi/ScriptableInstance.cpp:434: int id =
LGTM
http://gwt-code-reviews.appspot.com/1470802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
lgtm2
http://gwt-code-reviews.appspot.com/1470802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I made the fixes and submitted it. Since most people are headed out of
the office for the holiday, I need to get it in early to see if I need
to revert it before everyone is gone. :)
I had a few nits below but I felt a bit out of context. Is there an
overview somewhere of what you guys are trying to accomplish? What
should rendering for Cells look like?
http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRenderer.java
File
On 2011/07/01 20:59:37, rdcastro wrote:
I had a few nits below but I felt a bit out of context. Is there an
overview
somewhere of what you guys are trying to accomplish? What should
rendering for
Cells look like?
Yes, we have a design doc... which I forgot to share. Here is the link,
https://docs.google.com/a/google.com/document/pub?id=1a-_8IdBrBmWCnhV6rnQVmzXB_bXQ9JQ4ya-k1_s1_sA
Is it okay to make that public?
http://gwt-code-reviews.appspot.com/1466809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for sharing, I'll read it tomorrow and try and come up with
more interesting suggestions :-)
On Fri, Jul 1, 2011 at 6:14 PM, rchan...@google.com wrote:
On 2011/07/01 20:59:37, rdcastro wrote:
I had a few nits below but I felt a bit out of context. Is there an
overview
somewhere of
On 2011/07/01 21:19:25, stephenh wrote:
https://docs.google.com/a/google.com/document/pub?id=1a-_8IdBrBmWCnhV6rnQVmzXB_bXQ9JQ4ya-k1_s1_sA
Is it okay to make that public?
I think it is OK. We usually publish them in the Wiki, but Docs is
getting so good that I wanted to try it this way.
Oops, there's a problem, I need one more cycle before I can commit.
Will send patch tonite. :(
On Fri, Jul 1, 2011 at 1:43 PM, cromwell...@google.com wrote:
I made the fixes and submitted it. Since most people are headed out of
the office for the holiday, I need to get it in early to see if
Reviewers: zundel, jbrosenberg,
Message:
Hey guys,
Please review. This fixes the front-end issue withe GwtAstBuilder,
bringing it up to parity with GenerateJavaAST.
However, there *is* in fact a bug in the backend. See:
http://gwt-code-reviews.appspot.com/1470803/
But I want to go ahead and
http://gwt-code-reviews.appspot.com/1447821/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(right):
30 matches
Mail list logo
