[gwt-contrib] Uploaded fixed version of HelloMVP.zip

2010-10-12 Thread Jeff Larsen
The helloMVP.zip file must have been using some of the old package namespaces. I had to go through and fix every import. I also removed the @Override annotations on interfaces so the project will compile on 1.5 JREs. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a ControllerBinder in UiBinder so that UiHandlers can be bound on both the (issue923801)

2010-10-20 Thread Jeff Larsen
This is something I'm really interested in as well Stephen. - How do you test these things? How does the next guy know whether his event handler belongs in the view or the controller? - If the event doesn't change the view state, it doesn't belong in the view. I would argue that clicking

[gwt-contrib] Re: Internal compiler error with GWT 2.1.0 RC1 when using generics

2010-11-10 Thread Jeff Larsen
If I was a guessing man, I'd say you're gettting into an infinite loop with generics here and the SerializableTypeOracleBuilder. ResultNodeT extends ResultNode? The ? is probably what is causing this to break. I'm the serializer, I'm making a serialization policy for ResultNodeT extends

[gwt-contrib] Re: Patch for Issue 5588: Fix Ant warning about includeantruntime not being set (issue1105801)

2010-11-15 Thread Jeff Larsen
The contributing code doc lists Ant 1.7.0 as a minimum to build. http://code.google.com/webtoolkit/makinggwtbetter.html#contributingcode On Nov 15, 12:08 pm, Hilco Wijbenga hilco.wijbe...@gmail.com wrote: On 15 November 2010 09:37, John Tamplin j...@google.com wrote: On Mon, Nov 15, 2010

[gwt-contrib] First pass at Issue 1405 (Dialog Box header fix)

2010-11-29 Thread Jeff Larsen
Please review this at http://gwt-code-reviews.appspot.com/1149803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: First pass at Issue 1405 (Dialog Box header fix)

2010-12-02 Thread Jeff Larsen
to include the new caption stuff but I wanted to make sure I was going down the right path before I jumped too far down that path. On Nov 30, 11:29 am, Ray Ryan rj...@google.com wrote: Thanks for the patch, Jeff. I'll try to look at it today. On Mon, Nov 29, 2010 at 8:04 AM, Jeff Larsen

[gwt-contrib] Re: Breaking change proposed: future proofing Activity in 2.1.1

2010-12-06 Thread Jeff Larsen
Personally, I'm a fan of having both. The default implementation can be an abstract class but have that abstract class implement the Activity interface. Developers will be making a conscious choice to use the interface only knowing that they can introduce bugs. --

[gwt-contrib] Re: First pass at Issue 1405 (Dialog Box header fix)

2010-12-09 Thread Jeff Larsen
bump. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: First pass at Issue 1405 (Dialog Box header fix) (issue1149803)

2011-01-18 Thread Jeff Larsen
I'll hopefully have a chance to poke around at that code tonight and make a decision then as to what I have time to implement. On Tue, Jan 18, 2011 at 12:41 PM, Ray Ryan rj...@google.com wrote: On Tue, Jan 18, 2011 at 10:29 AM, larse...@gmail.com wrote:

[gwt-contrib] Re: Fix for issue 5978 - showcase uses default local instead of en local (issue1337802)

2011-02-04 Thread Jeff Larsen
I figured without the _en.properties file it wasn't picking up the _en local. But after some more testing, it looks like you're right and it does pick it up the _en local some places and not in others. I'll pull the patch and submit a different issue. --

[gwt-contrib] Contributing widgets back, how should styling be implemented?

2011-02-10 Thread Jeff Larsen
I've developed a widget similar to decoratorpanel, except it facilitates drag resizing and uses the layout panel architecture instead of the html table layout of DecoratorPanel. I've got some more javadoc and tests to write before I send it in for review (and possibly additions to showcase).

Re: [gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

2011-02-25 Thread Jeff Larsen
I am really, really excited about this. +1 for aggressive Ruby style deprecation. It would be nice to get rid of the FooListeners/SourcesFoo stuff that is just clutter now and has been deprecated since 1.6 I have no problem with ButtonWidget naming style however. In eclipse you can just type

[gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

2011-02-26 Thread Jeff Larsen
*1) The ButtonCell(DefaultAppearance.Resources) constructor can be confusing, I think it should be dropped. *This constructor gives the impression that you are using the app-wide Appearance where in fact you are using DefaultAppearance. This could lead to the following confusing use case: -

[gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

2011-02-26 Thread Jeff Larsen
I thinks there is a misunderstanding. My proposal is just to not provide the convenience constructor, so instead of: new ButtonCell(resources); You'd do: new ButtonCell(new DefaultAppearance(resources)); Making it crystal-clear that your ButtonCell is using DefaultAppearance. The

Re: [gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

2011-02-28 Thread Jeff Larsen
On Saturday, February 26, 2011 9:14:37 PM UTC+1, Philippe Beaudoin wrote: 1) The ButtonCell(DefaultAppearance.Resources) constructor can be confusing, I think it should be dropped. 2) Providing a custom DefaultAppearance.Resources lead to somewhat smelly code. -1 on both the above (note:

Re: [gwt-contrib] Re: [RFC] GWT Widgets that ROCK!

2011-02-28 Thread Jeff Larsen
at 2:23 PM, Philippe Beaudoin philippe.beaud...@gmail.com wrote: On Mon, Feb 28, 2011 at 10:30 AM, Jeff Larsen larse...@gmail.com wrote: By forcing the user to do new DefaultAppearance(Resource) you're removing their ability to globally change the appearance. You've now

[gwt-contrib] How do I submit a patch with binary files?

2011-03-24 Thread Jeff Larsen
I've got a patch for TabLayoutPanel which will allow for handling tabs that scroll off the viewable area. For this I've got some horrifically ugly images that I created with MSPaint. How do I include those in a patch? SVN patches are just text files. I didn't spend any real time making these

[gwt-contrib] Re: Adding a new SimpleCheckboxCell and LabeledCheckboxCell cells, and a Checkbox widget backed by t... (issue1383810)

2011-03-25 Thread Jeff Larsen
Currently, Cell-backed Widgets redraw themselves every time a change is made. This leads to degenerate performance where you create the widget, then call 4 setters, and the widget is rendered 5 times! I'm going to propose a solution where we defer rendering and add a flush() command

[gwt-contrib] What do you think of adding bidi support to LayoutPanel

2011-03-31 Thread Jeff Larsen
In some instances, it would be nice to have LayoutPanel swap left and right. I was thinking of something like adding a private boolean bidi = false; public void setWidgetLeftWidth(Widget child, double left, Unit leftUnit, double width, Unit widthUnit) { assertIsChild(child);

Re: [gwt-contrib] What do you think of adding bidi support to LayoutPanel

2011-03-31 Thread Jeff Larsen
: The LayoutPanels' already swap properly in RTL locales, don't they? http://gwt.google.com/samples/Showcase/Showcase.html?locale=ar_YE http://gwt.google.com/samples/Showcase/Showcase.html?locale=en On Thu, Mar 31, 2011 at 2:33 PM, Jeff Larsen larse...@gmail.com wrote: In some instances

[gwt-contrib] Re: TabLayoutPanel tab overflow handling, now with more bug testing (issue1403801)

2011-04-04 Thread Jeff Larsen
Here are the images you'll need to get this to compile. Please don't release with these images as they are hideous. On Mon, Apr 4, 2011 at 1:51 PM, larse...@gmail.com wrote: Reviewers: jlabanca, rjrjr, jgw, Description: I've fixed up the TabLayoutPanel to handle overflow. I've tested it both

Re: [gwt-contrib] What do you think of adding bidi support to LayoutPanel

2011-04-04 Thread Jeff Larsen
would have to spend some more time digging through that code to understand which one is the best fit. On Thu, Mar 31, 2011 at 7:42 PM, Jeff Larsen larse...@gmail.com wrote: Huh, I must be doing something wrong then in my test implementations because layouts etc aren't being switched even though

[gwt-contrib] Creating groups of rows in CellTable

2011-04-06 Thread Jeff Larsen
I have a requirement that our users should be able to dynamically create groups of rows inside a celltable. For example, lets say a user was searching for books, and wanted to group by Author. The Author column should be hidden (this isn't a problem), but there should be a new row with a

Re: [gwt-contrib] Re: Future of CellTable

2011-04-19 Thread Jeff Larsen
John, can you elaborate what - Expandable rows (really, a fully customizable table builder, probably post GWT 2.3) means? I'm currently working on adding groupability to a copy of celltable and its hierarchy. Will the fully customizale table builder be the solution I'm looking for?

Re: [gwt-contrib] Re: Future of CellTable

2011-04-19 Thread Jeff Larsen
: On Tue, Apr 19, 2011 at 2:04 PM, Jeff Larsen larse...@gmail.com wrote: John, can you elaborate what - Expandable rows (really, a fully customizable table builder, probably post GWT 2.3) means? I'm currently working on adding groupability to a copy of celltable and its hierarchy

[gwt-contrib] Re: Adding drag and drop support to the mobile web app. The desktop TaskEditView now has a list of t... (issue1420811)

2011-04-26 Thread Jeff Larsen
Drag n Drop doesn't work in ie8 (expected). Perhaps use deferred binding to get rid of the templates portion for all versions of ie9. Otherwise those templates are pretty useless. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] RequestFactoryServlet

2011-05-23 Thread Jeff Larsen
@Bobv One thing about RequestFactoryServlet is that it is somewhat difficult to setup DI from containers such as Spring. I've been working on getting Spring wired into the request factory framework and there are a bunch of examples, but they all are pretty ugly. I think I've found a fairly

Re: [gwt-contrib] RequestFactoryServlet

2011-05-23 Thread Jeff Larsen
Created the issue as well and posted a link to the review. Thanks! http://gwt-code-reviews.appspot.com/1448804/ http://code.google.com/p/google-web-toolkit/issues/list?cursor=6393updated=6393ts=1306206518 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] RequestFactoryServlet

2011-05-23 Thread Jeff Larsen
Oh and I did test this to make sure it would with Spring. If you're interested here is a link to my test project. https://github.com/larsenje/SpringRequestFactoryExample -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding new DataGrid widget. DataGrid is a variation of CellTable that supports a fixed header a... (issue1450805)

2011-05-25 Thread Jeff Larsen
On Wednesday, May 25, 2011 10:21:18 AM UTC-5, Thomas Broyer wrote: On Wednesday, May 25, 2011 3:29:35 PM UTC+2, Jeff Larsen wrote: Wow, this is awesome. +1 I haven't started digging into the code yet, but I would like to point out a minor nit. In Firefox giving the scrollbars

[gwt-contrib] Creating a default Locator for RequestFactoryServlet

2011-05-26 Thread Jeff Larsen
@Bobv Thanks for committing the previous change, and I've got one more change that will make my, and probably a bunch of other people's, lives easier. By being able to setup a DefaultLocator, it would stop me from having to copy/paste @ServiceName(value=com.my.service.MyService *

[gwt-contrib] Re: RR: Retiring Safari 3 in a future release of GWT

2011-07-05 Thread Jeff Larsen
Good riddance. I wish it was possible to do the same with IE versions 9. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introducing a new CellTableBuilder API, which allows users to customize the structure of a CellT... (issue1501803)

2011-07-25 Thread Jeff Larsen
I had about an hour-hour and a half to play with this over the weekend and I have to say it looks great. I have to ask though, is there a reason why ColumnT,? doesn't contain the header and footer cell? It would sure make it easier for things like reordering columns, hiding columns. Also it

[gwt-contrib] Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

2011-08-02 Thread Jeff Larsen
I'm inclined to agree with Stephen here. No where else in GWT widgetry is there a reference to database related things. I don't think this is a big deal either, but it seems like a more application specific thing rather than something that belongs inside GWT proper. --

[gwt-contrib] Re: Replace RequestFactoryInterfaceValidator with an annotation-processor-based approach. (issue1503804)

2011-08-03 Thread Jeff Larsen
Does this mean something similar to RequestFactoryInterfaceValidator will still need to be present? I ask because of http://code.google.com/p/google-web-toolkit/issues/detail?id=6640 where RequestFactoryInterfaceValidator seems to be getting in my way. --

[gwt-contrib] Re: Replace RequestFactoryInterfaceValidator with an annotation-processor-based approach. (issue1503804)

2011-08-03 Thread Jeff Larsen
oops, I missed your first reply. The server code won't accept the RequestFactory interface if it hasn't been validated. A runtime error will occur, telling the user to run the ValidationTool. answers my question. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

2011-08-04 Thread Jeff Larsen
With my minimal spare time right now I'm working on getting a new library based around these Grids, adding more functionality. What I've ended up doing is Extending DataGrid and maintaining my own List of my own Column implementation. I have a bunch more data that lives in Column, its size,

Re: [gwt-contrib] maven source jars

2011-08-19 Thread Jeff Larsen
I'm doing trunk builds as well and I've been pushing files manually into my repo. It is a PITA. It would be awesome if there was an ant target that you could call after the build that would push the artifacts into your local maven repo, probably appending -SNAPSHOT to the version. Would you

Re: [gwt-contrib] Re: Changes setters/clearers com.google.gwt.dom.client.Style to return Style instead of void (issue1530803)

2011-08-23 Thread Jeff Larsen
I cancelled the review. I didn't realize this would cause fat slow apps. Sorry about that. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

2011-08-24 Thread Jeff Larsen
The general practice I've seen the GWT guys do for that is to do an initial patch where they autoformat, then 2nd patch with the actual changes. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] maven source jars

2011-08-27 Thread Jeff Larsen
How about a new dist-maven ant target that would create a maven bundle (folder with the JARs and POMs laid out just like in a Maven repository)? You would then run ant -Dgwt.version=2.4.0 dist dist-maven [1] instead of just ant dist to build a release, and the generated maven bundle would be

Re: [gwt-contrib] maven source jars

2011-09-08 Thread Jeff Larsen
Are you interested in an ant build target that pushes gwt builds into your local repo? If so, I've got that setup on my machine locally, and with some minor tweeks to it, I could use what you guys have for your push script. I've found it useful for myself. On Thu, Sep 8, 2011 at 12:13 PM, David

[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)

2011-09-15 Thread Jeff Larsen
I know I would like it if the RequestFactory stuff was pushed into maven central. Don't make gwt-servlet into a real dependency, add it to the list of dependencies in your plugin. plugin groupIdorg.bsc.maven/groupId artifactIdmaven-processor-plugin/artifactId

[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)

2011-09-15 Thread Jeff Larsen
eclipse run as webapp. I just spent a few hours debugging problems with this around the office and I know where the problem is now. I just haven't implemented the solution. When you do both of these things (note I cut useless bits for clarity) resource

[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)

2011-09-16 Thread Jeff Larsen
For historical purposes, I figured out a working solution ( at least it works for me) and posted it in the gwt-maven-plugin user group. https://groups.google.com/forum/#!topic/codehaus-mojo-gwt-maven-plugin-users/Lha85tfYiz4 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)

2011-09-17 Thread Jeff Larsen
So it does! Turns out if you import a maven project it just works the way you describe, if you import the project as an eclipse project with a maven nature, it just gives you errors in your pom and you have to decide how to deal with them. --

[gwt-contrib] Any interest in having css3pie integrated with GWT?

2011-09-28 Thread Jeff Larsen
To be blunt, Trying to get styling to work right in IE is somewhat of a nightmare. Especially with the lack of css3 support. There is a library out there that fixes some of the major headaches css3pie. http://css3pie.com/ border-radius,

[gwt-contrib] Re: Any interest in having css3pie integrated with GWT?

2011-09-30 Thread Jeff Larsen
If ie8 and 9 didn't need a bunch of heavy lifting to get all of the advantages of css3 styles, then you would probably be right, but unfortunatetly, ie10 is going to be when ie finally starts meeting the standards. The point is semi-moot. I've started a project

[gwt-contrib] gwt issues marked as patcheswelcome don't show up under open issues

2011-10-06 Thread Jeff Larsen
All the issues marked patcheswelcome are reasonably hidden from view because they do not show up as open anymore. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: gwt issues marked as patcheswelcome don't show up under open issues

2011-10-06 Thread Jeff Larsen
Is there a way to add patcheswelcome to the dropdown of the issue tracker? I think people will not find these issues and know to work on them. If I went to the issue tracker hoping to work on something where I would be able to help out the gwt community, I would start looking at open issues. I

Re: [gwt-contrib] Re: gwt issues marked as patcheswelcome don't show up under open issues

2011-10-07 Thread Jeff Larsen
Switch to datagrid, that allows for horizontal scrolling. I've got a local version of drag resizing for columns working locally for the most part. I was waiting to pull a patch in until I figured out how to get the sizes of all the columns first. The only way I could get drag resizing of

Re: [gwt-contrib] Re: gwt issues marked as patcheswelcome don't show up under open issues

2011-10-07 Thread Jeff Larsen
I got my own (slightly buggy version) done in a weekend. If you're not interested in waiting for me to submit either a patch or my own grid component project, you can look at DialogBox for some tips on how to hand the dragging events. The components to build this are all there, they just

[gwt-contrib] InProgressRequestContext Factory

2011-10-07 Thread Jeff Larsen
Do these classes only exist to test RequestFactory in jre mode or are they used for something else as well? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: InProgressRequestContext Factory

2011-10-08 Thread Jeff Larsen
Nevermind, I found the answer in the package-info.java file. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: loading live, instantly-generated data from the server and displaying it as a line graph

2011-10-25 Thread Jeff Larsen
This is probably a better discussion for the users group, but I'll answer it anyway. I'm using HighCharts for some of my charting needs, you'll just need to send the data down to the charting software and either poll for new data, or implement server push/cometd and have it update the graph

[gwt-contrib] Who does RequestFactory stuff now?

2011-10-28 Thread Jeff Larsen
Ray was in the process of reviewing a patch of mine before he left. Who should take that over, or should I continue to try to work with Ray on that? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] CSS3 support in CssResource: Closure Stylesheets?

2011-12-09 Thread Jeff Larsen
Escaping css3 is a PITA. I'm 100% on board. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors