In that case i'll leave it as a single module.
The cookie insert approach to getting around authentication ended up
in a little headache because i forgot that GData requires an image to
be present on the page (loaded from the same domain as the page). So,
after forcing the cookie, the jUnit test
Thanks I didn't thought of just doing an eval. That does the job.
Ganael
On Wed, Jun 10, 2009 at 6:49 PM, Ian Bambury ianbamb...@gmail.com wrote:
Create a jsni method which takes a string and just does an 'eval' - as long
as you are sure that the JS is safe
Ian
http://examples.roughian.com
can anyone explain more how when using dto to serialized object , one
can skip using aync class when using service?
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group,
Anyone have any idea about this or know where I can look/read to find
out more? I'm totally at a loss here. It looks like there are a
bunch of interesting methods for the ServletRequest class but
HttpServletRequest doesn't have much I can do with it.
On Jun 10, 3:31 pm, eags
Hi,
You can take a look at
http://code.google.com/p/net-orcades-spring/source/browse/trunk/orcades-spring-gwt/src/main/java/net/orcades/spring/gwt/component/GWTPayloadHelper.java
And see how it's not so difficult to unmarshall the GWT RPC request.
This code works for GWT 1.5 but is not optimal in
On
http://code.google.com/intl/sv/webtoolkit/doc/1.6/DevGuideOrganizingProjects.html
we can read the following about static content, specifically in the
example an image called logo.gif
An image file available to the application code. You might load this
file programmatically using this URL:
On 11 juin, 10:02, Dalla dalla_man...@hotmail.com wrote:
Onhttp://code.google.com/intl/sv/webtoolkit/doc/1.6/DevGuideOrganizingP...
we can read the following about static content, specifically in the
example an image called logo.gif
An image file available to the application code. You
On 11 juin, 00:38, Ben benzhe...@gmail.com wrote:
I have a text box insides a FlexTable and I am trying to use
SuggestBox.wrap to wrap the text box into a SuggestBox. Code snippet
is like this.
.
FlexTable ft = new FlexTable();
TextBox tb = new TextBox();
ft.setWidget(0,0,tb);
As long as you're obiding by the rules of GWT client-side handling, you can
call anywhere you'd like within the client package.
It looks like your experience a rendering versus service calling effect. I
would review the documentations on best practices for creating a GWT
Application with RPC's.
where you define your servlet in web.xml add load-on-startup1/load-
on-startup
servlet
servlet-nameMyAppServiceImpl/servlet-name
servlet-classmy.package.app.MyAppServiceImpl/servlet-class
load-on-startup1/load-on-startup
/servlet
On Jun 10, 6:29 pm, Jamie
On 10 juin, 23:44, mrpantsuit kevin.peter.w...@gmail.com wrote:
This might be a stupid question, but can I use the same Image created
from an ImageBundle in multiple places on my page? I guess the more
general question is can I use the same Image in multiple places in my
page. I assume
Personally I would say use a ServletContextListener if the structures you are
creating will be
shared by several of your Servlets. That way the init is finished before any of
your Servlets are
created.
Load-on-startup always feels like a bit of a hack to me ;)
Just my 2c
Steve wrote:
On 10 juin, 19:24, Jeff Chimene jchim...@gmail.com wrote:
If you can't get the browser to send an alternate ident string, you
might try hacking the *.nocache.js to handle the Galio browser ident
string and instead reply with either the IE or Firefox branch to the
client. Compile your GWT
Oh... guess you just create a folder rather than a package for the
resources...
On 11 Juni, 11:23, Dalla dalla_man...@hotmail.com wrote:
So if I get you right, I should have
com/example/app/arrivaljournal/client, Sub-package containing all the
client-side source code.
Hi,
Widgets are added to widgets, elements are added to elements.
If you want to put a widget into the dom, I'd use a RootPanel, since
it will take care of the unloading that is needed:
p = RootPanel.get(currentElement.getId());
p.add(someWidget);
if currentElement doesn't have an Id, you
Hey Gert,
Thanks for the reply! I realised my problem with appending an
Element..I was trying to append it to a TextNode which I think isn't
allowed. So I've sorted that, I append to the text node's Parent now.
On adding Widgets to a certain point in the DOM..this seems to work
for me:
I
Hi Mr. Kushner,
Thx for your reply. I've tried to call the service from a class
extending Composite class. And it works! But I still can't find why it
doesn't work when I call it in class extending nothing. But that's not
an urgent problem for me for a while. Hehehe..
Once more thx...
Regards,
Yup. That does the ticket!
Here's the code if anyone's interested...
The listener...
package com.inexas.test.server;
import javax.servlet.*;
public class AppStarter implements ServletContextListener {
public void contextInitialized(ServletContextEvent event) {
If you store the session ID in a cookie so that user logins can persist
beyond browser refreshes (as suggested in the FAQ), then the session ID
will end up in the header anyway.
eags wrote:
I am implementing user logins and authentication using the model
presented in the login security FAQ.
Hi !
Your friend chhatrapal.sharma from , just invited you to his/her online
photo albums and journals at Zorpia.com.
So what is Zorpia?
It is an online community that allows you to upload unlimited amount of photos,
write journals and make friends. We also have a variety of skins in
I'm glad it works fine on your project.
Saludos, Marcelo.
On Jun 10, 6:43 pm, Iván López lopez.i...@gmail.com wrote:
Thank you very much!. It works ok and now, with my code working I
think I understand a little bit better how handlers works!.
Muchas gracias compañero.
Saludos,
No clues anyone?
On 10 Juni, 14:40, Dalla dalla_man...@hotmail.com wrote:
Hi
I´m having trouble understanding how to implement an event handler for
my custom objects with the new event handler system. Let´s pretend I
have a very simple model class like this one:
public class ArrivalData {
I'm running off trunk right now. There's no
Document.createDocumentFragment() method either. Just wondering why
that is.
Could someone comment on issue 2955? --
http://code.google.com/p/google-web-toolkit/issues/detail?id=2955
The issue was created almost a year ago, but it's still in NEW
If your friend (an invisible friend?) wants me on their list, why don't they
ask me themselves?
Preferably not via the GWT group.
Ian
http://examples.roughian.com
2009/6/11 chhatrapal.sharma chhatrapal.sha...@gmail.com
Hi ,
I started using this and love it. If you use the link below you'll
Hi,
Is there any way by which I could know if my Dialog Box has moved? I
mean at run time thru some listener or something? I am trying to find
out the position of the Dialog Box when it has moved for which I need
to know when it moved!!!
regards,
abhiram
The following class appears to be legal java (eclipse accepts it ok)
but it causes an internal error in the gwt compiler (java -
javascript). Has anyone found a workaround to allow code like this to
run?
If you try to instantiate this class with
public enum MyFormField {
FIELD1, OTHER_FIELD;
Hello,
I am currently developping an app using both GWT and GAE. I'd like
this app to use Gears mostly to used offline and also to improve
performance.
Taking first steps with gwt-gears API I found quite convenient to have
an automatically generated manifest for files needed to be downloaded.
My thought on this is that we should modify the manifest generator to
filter out these files, and also add a config option to allow users to
specify files to exclude in case something else like this comes up -
maybe through (yet another) annotation on the Gadget class?
On Thu, Jun 11, 2009 at
Thanks Jason.
I thought it might be possible to do the round trip testing with app
engine but this does not seem to be the case. Thanks for the code
sample.
/johan
On Jun 10, 3:56 pm, Jason Parekh jasonpar...@gmail.com wrote:
Hi Johan,
I don't think there are any frameworks that can let you
On Thu, Jun 11, 2009 at 9:43 AM, Eric Ayerszun...@google.com wrote:
My thought on this is that we should modify the manifest generator to
filter out these files, and also add a config option to allow users to
specify files to exclude in case something else like this comes up -
maybe through
It would be great :) !
I was saying at the end of my previous message that I still could get my
local server to serve and I think I found why.
I am also using GXT which needs its image folder to be in the war one. And
looking at the generated manifest, it seems that files outside the
projectname
I created an issue for the filtering problem:
http://code.google.com/p/gwt-google-apis/issues/detail?id=280
Feel free to come over to the gwt-google-apis group and discuss a
proposal for other changes to the gadget API that might help with the
app you are building.
-Eric.
On Thu, Jun 11,
Hi,
i have a string that contain a javascript function. Within that
function, there is a ActiveXObject(Microsoft.XMLDOM); object.
When i pass that string to the eval function, i get an error
automation server can't create object. I am using IE 6.
Anyone have an idea ?
You can also have your async method return RequestBuilder which will
not dispatch the RPC call, but rather returns the RequestBuilder
already set up and ready to go. You can then make changes to it
before making the call such as setting a timeout. Then you dispatch
the RPC call which will
Images widgets at their core contain a DOM element and you can't have
an element in two places at once.
However the beauty of ImageBundle is that it caches that actual image
so you don't incur additional bandwidth when you create multiple image
widgets using the same image bundle.
-jason
Awesome. Thanks guys.
On Jun 11, 11:19 am, Jason Essington jason.essing...@gmail.com
wrote:
Images widgets at their core contain a DOM element and you can't have
an element in two places at once.
However the beauty of ImageBundle is that it caches that actual image
so you don't incur
You need to make sure that your node is an element.
also .wrap() is not found in widget itself but rather in its
subclasses (Label for instance)
-jason
On Jun 10, 2009, at 3:51 PM, peterk wrote:
Hey Jason,
Thanks for your reply!
I'm afraid I'm still running into problems here. First,
perhaps this little discussion would be of some help:
http://groups.google.com/group/Google-Web-Toolkit/browse_thread/thread/faca1575f306ba0f/3be719c021aa19bd
-jason
On Jun 11, 2009, at 4:05 AM, retha pasalli wrote:
Hi Mr. Kushner,
Thx for your reply. I've tried to call the service from a
On Thu, Jun 11, 2009 at 2:21 AM, Thomas Broyert.bro...@gmail.com wrote:
On 10 juin, 19:24, Jeff Chimene jchim...@gmail.com wrote:
If you can't get the browser to send an alternate ident string, you
might try hacking the *.nocache.js to handle the Galio browser ident
string and instead
It seems that is the only one to avoid it.
Thanks!
On Jun 11, 4:50 am, Thomas Broyer t.bro...@gmail.com wrote:
On 11 juin, 00:38, Ben benzhe...@gmail.com wrote:
I have a text box insides a FlexTable and I am trying to use
SuggestBox.wrap to wrap the text box into a SuggestBox. Code
Could you please post some examples will?
Or maybe send me some code? mnenchevs example was good, but more
examples never hurt :-)
On 11 Juni, 14:08, Will wil...@gmail.com wrote:
That's what I use as well. I created an Abstract Class with
HashmapEventHander,HandlerRegistration for removing a
I'm using GWT 1.6.4, and when I run my JUnit test cases, the GWTShell
installs Tomcat Lite in the tomcat directory under my project root
directory. How can I specify where Tomcat Lite is installed?
--~--~-~--~~~---~--~~
You received this message because you are
Hi all, i'm newbie in techno thingsbut i'm now developing a UI
with gwt ext. I develop on Windows XP.
I'd like to call web services. i have a .wsdl file, compile it using
cxf (wsdl2java) by maven to generate java sources from wsdl. I wrote a
method to call this service in order to get a list
I am having a performance problem. I am trying to build a page that
allows the user to select from a fairly large list of objects (up to
20,000). We have filtering capabilities to trim the list so the user
doesn't have to scroll through all of them. It's a reasonable UI.
Unfortunately, I only
Hello,
I have created the following css style to add a background image to
the html page of my application.
.bg {
background: url(images/bg.gif) 50% 50% no-repeat;
}
and in the .java I have:
RootPanel.get().addStyleName(bg);
In hosted mode I can see the background image but in web mode
I have implemented something similar using a filter.
In the doFilter, you can cast the ServletRequest parameter to an
HttpServletRequest.
You will then have access to cookies and the container's session.
For example,
HttpServletRequest hRequest = (HttpServletRequest)request;
Cookie[] cookies =
Hi Joe,
The trick is to not even try to load that much data into the browser.
We use the SmartGWT widget library which has very good support for
virtual pagination of lists and comboboxes. By default, it only loads
the first 75 rows and then as the user scrolls down, calls are made back
to
Hi eags,
Sorry for the delay in moderation. Unfortunately I'm the primary moderator
for the forum, and so posting in a different timezone does sometimes add a
bit more delay than I'd like to a post. Perhaps I should try a polyphasic
sleep schedule :-)
Regarding moderated posts - you should be
Hi, I've read some past emails on this subject, but I want to know if
anyone has a best practice for this.
Lets say I have MyService(HashMapString,Serializable reportBag) .
I've read it's advisable to narrow down the Serializable to a type
that has a smaller set of implementations, such as using
Hi sbarr10,
Here is the previous thread where you posted about this issue:
http://groups.google.com/group/Google-Web-Toolkit/browse_thread/thread/54e1ffa04907b569
http://groups.google.com/group/Google-Web-Toolkit/browse_thread/thread/54e1ffa04907b569I
replied back on there recommending that you
I think you have to specify an for each if in your replace-with.
Try:
replace-with
class=com.hs.moose.common.client.widget.NextPreviousButtonCSS
when-type-is
class=com.hs.moose.common.client.widget.NextPreviousButton/
any
when-property-is name=user.agent
Hi D L H,
I'm guessing the browser you were testing on when you tried this out was
Firefox 3? There is a known (and fixed) issue for this reported on the Issue
Tracker. See Issue #2902 (link below). The fix for the issue has been
committed all will be included in the next release.
Issue #2902:
Hi
I had a similar problem a few days ago. It was down to an entry in my web.xml
file. Perhaps if you post your xml servlet-mapping entry, someone may be able
to help you with it. I do not see why it should make a difference, I know it
does not in standard browsers, but should there be an
Hi mmenchev,
You should still be able to use hosted mode with -noserver through the
plugin, although there are some steps you need to take first to get
everything setup for hosted mode debugging on your server. Check out the FAQ
link below.
FAQ How do I use my own server instead of GWT's built-in
Hi soncio69,
Try setting the -logLevel DEBUG argument in your hosted mode launch
configuration. It should tell you a lot more about the exception that was
thrown in the hosted mode console. Simply select the exception in the upper
pane of the console window and the exception stack trace should be
I did not attend Google I/O but as soon as the video Google I/O 2009
- Best Practices for Architecting GWT App (http://www.youtube.com/
watch?v=PDuhR18-EdM) was posted I reviewed it and was a bit confused
by the idea of an EventBus.
From what I can tell the idea is that UI widgets requiring data
Thanks for your feedback.
The WEB-INFO (instead of WEB-INF) was a typo.
The issue is resolved. Here is an explanation of why it failed.
First, the request that I wanted to send to my HttpServlet looked like
the following:
String url = GWT.getModuleBaseURL() + RESTProxy/system;
http://groups.google.com/group/Google-Web-Toolkit/browse_thread/thread/9e41d90e33fd294e/668f9b62079b8f0e?lnk=gstq=blank+until+refresh#668f9b62079b8f0e
This thread also seems to have run into the issue. Seems to be a
tomcat issue. Odd though that I haven't been able to find more
instances of
Hi all,
has somebody tried to invoke a GWT service from a J2SE app?
When trying to invoke the service as the same way in a GWT client app
I get the following:
Exception in thread AWT-EventQueue-0
java.lang.UnsupportedOperationException: ERROR: GWT.create() is only
usable in client code! It
Any news on the progress of the 3.5 support? Can we expect a working
plugin in time for the final release of Galileo in two weeks?
On 28 Maj, 20:37, Miguel Méndez mmen...@google.com wrote:
The plugin code is not open sourced at this time, but we do plan to open
source it.
On Tue, May
Hello,
How can I name a function like start() and it will not change while
compliling so that other javascript can call it?
thanks.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post
never mind
On 10 jun, 17:35, Bonor bono...@gmail.com wrote:
When doing a RPC call my Service get's an Access Denied error when
trying to connect with mysql.
java.security.AccessControlException: access denied
(java.lang.RuntimePermission modifyThreadGroup)
Where do i grant access?
Search for GWT Exporter and use that.
On Thu, Jun 11, 2009 at 10:58 AM, Shedokanshedok...@gmail.com wrote:
Hello,
How can I name a function like start() and it will not change while
compliling so that other javascript can call it?
thanks.
Hey Shedokan,
The approach I've used for that is to attach a GWT function to the
window object ($wnd).
There's an example in the docs over here:
http://code.google.com/webtoolkit/doc/1.6/DevGuideCodingBasics.html#DevGuideJavaScriptNativeInterface
Check under the subsection Calling a Java
Hi Steve,
Typically, you wouldn't want to define multiple entrypoints but instead use
a single entrypoint, and potentially divide your project into multiple
modules. More replies inlined to your post below:
Should this be implemented as 4 separate entry points? Should it be
one entry point and
I am trying to figure out what the best way is to handle JavaScript
injection cases. Since any client side input validation handling
doesn't truly prevent one from injecting JS such as using tools like
Firebug to re-post RPC calls etc.
I am wondering if anybody has attempted to intercept JS
On 06/11/2009 04:18 PM, tamsler wrote:
I am trying to figure out what the best way is to handle JavaScript
injection cases. Since any client side input validation handling
doesn't truly prevent one from injecting JS such as using tools like
Firebug to re-post RPC calls etc.
I am wondering
Anyway I got it working.
On Jun 8, 12:19 am, Dagvadorj Galbadrakh dagvad...@gmail.com wrote:
Hello everybody, I am totally new to GWT. I Couldn't run the Getting
Started example with JSON implementation at
address,http://code.google.com/webtoolkit/tutorials/1.6/JSON.html.
The problem is
Hello All,
We've built an application using GWT 1.5.4 that calls a json server and the
memory usage for the browser that it is running in keeps going up, I've
tested this in IE, Firefox and Chrome with the same result. This
application is a widget based application, we have a map widget(open
perhaps this little discussion would be of some
help:http://groups.google.com/group/Google-Web-Toolkit/browse_thread/threa...
-jason
Great illustration!! Thx jason..
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google
It's a good question, but it's not really GWT related.
Sure it is.
You're talking about server-side code. The JS code generated by GWT
executes in the browser.
RPC calls execute where?
http://code.google.com/webtoolkit/articles/security_for_gwt_applications.html
okay, so I dug into this a bit and figured out how to port existing
code to GWT compliant standards. I also included
_CustomFieldSerializers. I am currently only using Key and Text in my
test code, but I ported Key, Text, Blob, ShortBlob, Link and User
however I haven't tested much beyond the
I'd definitely like to see the paging ability as an extension (read
that as you will: interface implementation, derived class, plug-in
behavior, whatever) to the scrolling behavior. I don't really like how
the incubator has two totally separate, unrelated classes.
I wonder if some performance
+1 Ray. Now here's the really tricky question. Is there any way we can take
advantage of Javascript's for (x in y) { ... } syntax (and should we,
given its spotty performance)? My intuition tells me that the only way we
could use it would be through a callback, because there's nothing like .NET
FWIW:
http://code.google.com/p/google-web-toolkit/wiki/BooleanIfExpressionOptimization
http://code.google.com/p/google-web-toolkit/wiki/IfToTernaryExpressionOptimization
Thanks again for banging on these. I've been meaning to do it for ages...
On Wed, Jun 10, 2009 at 9:11 PM,
w00t indeed. This just saved me serious time this morning already.
On Wed, Jun 10, 2009 at 6:35 PM, Scott Blum sco...@google.com wrote:
w00t!!
On Wed, Jun 10, 2009 at 5:47 PM, Freeland Abbott fabb...@google.comwrote:
As of r5537, my no-change ant build takes 1:55 instead of 19:43, and
Author: j...@google.com
Date: Thu Jun 11 06:24:20 2009
New Revision: 5538
Modified:
trunk/dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js
Log:
Fixes typo that confused __MODULE_NAME__ with __MODULE_FUNC__, leading to
startup failures in pre-1.6-hosted-mode.
Review:
On Thu, Jun 11, 2009 at 7:51 AM, Joel Webber j...@google.com wrote:
+1 Ray. Now here's the really tricky question. Is there any way we can take
advantage of Javascript's for (x in y) { ... } syntax (and should we,
given its spotty performance)? My intuition tells me that the only way we
could
Well, if I've saved serious time by 10:30am, I'm happy indeed.
I've got another depends-on-your-hardware-but-I-saw-4min-saving (for
work-to-do rebuild of samples, so no gain if you use buildonly) out to scott
already, though it's small enough that anyone who wants to review at
On 11 juin, 16:11, John Tamplin j...@google.com wrote:
On Thu, Jun 11, 2009 at 7:51 AM, Joel Webber j...@google.com wrote:
+1 Ray. Now here's the really tricky question. Is there any way we can take
advantage of Javascript's for (x in y) { ... } syntax (and should we,
given its spotty
On Thu, Jun 11, 2009 at 3:42 PM, Thomas Broyer t.bro...@gmail.com wrote:
On 11 juin, 16:11, John Tamplin j...@google.com wrote:
On Thu, Jun 11, 2009 at 7:51 AM, Joel Webber j...@google.com wrote:
+1 Ray. Now here's the really tricky question. Is there any way we can
take
advantage of
Nice job Freeland! You're an ant-master!
On Thu, Jun 11, 2009 at 10:40 AM, Freeland Abbott fabb...@google.comwrote:
Well, if I've saved serious time by 10:30am, I'm happy indeed.
I've got another depends-on-your-hardware-but-I-saw-4min-saving (for
work-to-do rebuild of samples, so no gain if
On Thu, Jun 11, 2009 at 10:42 AM, Thomas Broyer t.bro...@gmail.com wrote:
On 11 juin, 16:11, John Tamplin j...@google.com wrote:
On Thu, Jun 11, 2009 at 7:51 AM, Joel Webber j...@google.com wrote:
+1 Ray. Now here's the really tricky question. Is there any way we can
take
advantage of
No problem... I haven't handled the common super-expression case (if
(test) { return a; } else {return b; } - return test ? a : b), but
that one should be pretty easy to tackle for a limited set of common
super-expressions.
On 11-Jun-09, at 5:53 AM, Joel Webber wrote:
FWIW:
Thanks... I think.
On Thu, Jun 11, 2009 at 11:53 AM, Rajeev Dayal rda...@google.com wrote:
Nice job Freeland! You're an ant-master!
On Thu, Jun 11, 2009 at 10:40 AM, Freeland Abbott fabb...@google.comwrote:
Well, if I've saved serious time by 10:30am, I'm happy indeed.
I've got another
Reviewers: scottb,
Description:
Shaves 10min off a dist-one build vs dist (aka old build).
Please review this at http://gwt-code-reviews.appspot.com/37803
Affected files:
build.xml
--~--~-~--~~~---~--~~
Thanks, Bob! I have several things to change; my plans are in the
line-by-line comments.
http://gwt-code-reviews.appspot.com/33848/diff/1/4
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
(right):
http://gwt-code-reviews.appspot.com/33848/diff/1/4#newcode107
Line
LGTM, we've been needing this for a while. :)
http://gwt-code-reviews.appspot.com/36802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
http://gwt-code-reviews.appspot.com/37803/diff/1/2
File build.xml (right):
http://gwt-code-reviews.appspot.com/37803/diff/1/2#newcode21
Line 21: target name=dist-one depends=buildonly, tools, samples,
doc description=Make this platform's distributions
Now would be a good opportunity to add
http://gwt-code-reviews.appspot.com/37803/diff/1/2
File build.xml (right):
http://gwt-code-reviews.appspot.com/37803/diff/1/2#newcode21
Line 21: target name=dist-one depends=buildonly, tools, samples,
doc description=Make this platform's distributions
On 2009/06/11 17:41:56, zundel wrote:
Now
Author: j...@google.com
Date: Thu Jun 11 11:36:32 2009
New Revision: 5539
Modified:
branches/snapshot-2009.06.02-r5498/branch-info.txt
branches/snapshot-2009.06.02-r5498/dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js
Log:
Merge trunk 5538 to the 6/2 snapshot branch.
How about now? In addition to the requested changes, I changed two
other things:
1. The SOYC timings use PerfLogger now, rather than inlined timing code
2. There is a check for the same split point being specified multiple
times in the initial sequence
Author: sco...@google.com
Date: Thu Jun 11 12:08:45 2009
New Revision: 5540
Modified:
trunk/dev/core/src/com/google/gwt/dev/js/JsStaticEval.java
trunk/dev/core/test/com/google/gwt/dev/js/JsStaticEvalTest.java
Log:
JsStaticEval now optimizes certain if statements to conditional
Reviewers: scottb,
Description:
In trunk, -draftCompile does one full outer loop of the optimization
loop. This patch pares that one loop down much further.
A one-permutation draft compile of Showcase now takes about 25 seconds,
as compared to 27 seconds before. Additionally, the actual
LGTM. Committed at r5540 with minor tweaks.
http://gwt-code-reviews.appspot.com/36801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Matt,
Could you review these two follow-on patches? The second depends on the
first. This is mostly non-functional cleanup to make things a little
simpler to read. The only substantive change is this:
Presently, if we have a CanBooleanEval that fails to resolve, we do nothing
else. My second
LGTM.
By the way, instant hosted mode should reduce CompilationState.compile
drastically, so help is on the way!
http://gwt-code-reviews.appspot.com/38801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Both LGTM. Good catch, thanks. :)
On 11-Jun-09, at 1:15 PM, Scott Blum wrote:
Matt,
Could you review these two follow-on patches? The second depends on
the first. This is mostly non-functional cleanup to make things a
little simpler to read. The only substantive change is this:
Author: sco...@google.com
Date: Thu Jun 11 13:01:10 2009
New Revision: 5541
Modified:
trunk/dev/core/src/com/google/gwt/dev/js/JsStaticEval.java
Log:
Simple refactoring of SourceInfo generation in JsStaticEval.
Review by: mmastrac
Modified:
Author: sco...@google.com
Date: Thu Jun 11 13:01:57 2009
New Revision: 5542
Modified:
trunk/dev/core/src/com/google/gwt/dev/js/JsStaticEval.java
Log:
Refactor JsStaticEval to allow additional simplification when static eval
of the condition fails.
Review by: mmastrac
Modified:
1 - 100 of 109 matches
Mail list logo
