Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Willy Tarreau
Tim, I've just added the following patch after finding another affected place in smp_fetch_sc_trackers(). Fortunately this one couldn't happen, but the checks on the code path definitely are wrong for the same reaons as in the two other ones. Thus I prefer to make stktable_release() safe against

Re: Haproxy 1.8 with OpenSSL 1.1.1-pre4 stops working after 1 hour

2018-06-26 Thread Willy Tarreau
On Wed, Jun 27, 2018 at 01:44:08AM +0200, Lukas Tribus wrote: > Hey guys, > > > FYI after lots of discussions with openssl folks: > > https://github.com/openssl/openssl/issues/5330 > https://github.com/openssl/openssl/pull/6388 > https://github.com/openssl/openssl/pull/6432 > > > OpenSSL

Re: Haproxy 1.8 with OpenSSL 1.1.1-pre4 stops working after 1 hour

2018-06-26 Thread Lukas Tribus
Hey guys, FYI after lots of discussions with openssl folks: https://github.com/openssl/openssl/issues/5330 https://github.com/openssl/openssl/pull/6388 https://github.com/openssl/openssl/pull/6432 OpenSSL 1.1.1 will now keep the FD open by default:

Re: [PATCH 0/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Willy Tarreau
On Tue, Jun 26, 2018 at 03:57:28PM +0200, Tim Duesterhus wrote: > attached is a patch that fixes the remaining crash and adds a > .vtc file verifying the fix. > > As the .vtc is shipped in the same patch I am not able to add the > commit message / commit id to the top of it. I hope the comment is

Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Willy Tarreau
On Tue, Jun 26, 2018 at 04:30:38PM +0200, Tim Düsterhus wrote: > Willy, > > Am 26.06.2018 um 16:24 schrieb Willy Tarreau: > > I *think* your patch is OK. I just hate having multiple exit points when > > refcounts are involved, we're pretty sure that in a future version we'll > > As we sent

Re: Haproxy health check interval value is not being respected

2018-06-26 Thread Adwait Gokhale
Hi Baptiste, Here is the haproxy configuration I have. Please let me know if you need anything else. global log 127.0.0.1 local0 nbthread 2 cpu-map auto:1/1-2 0-1 maxconn 5000 tune.bufsize 18432 tune.maxrewrite 9216 user haproxy group haproxy daemon stats socket

FW: Need Help!

2018-06-26 Thread Ray Jender
-Original Message- From: Ray Jender [mailto:rayjen...@gmail.com] Sent: Tuesday, June 26, 2018 9:34 AM To: 'Jonathan Matthews' Subject: RE: Need Help! Thanks for the response Jonathan, Could you explain how I can set up the 4 front-ends? I am confused on how the routing would look?

Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Tim Düsterhus
Willy, Am 26.06.2018 um 16:24 schrieb Willy Tarreau: > I *think* your patch is OK. I just hate having multiple exit points when > refcounts are involved, we're pretty sure that in a future version we'll As we sent almost at the same time: I intentionally wrote it with the new return, instead of

Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Tim Düsterhus
Willy, Am 26.06.2018 um 16:17 schrieb Willy Tarreau: > On Tue, Jun 26, 2018 at 03:57:29PM +0200, Tim Duesterhus wrote: >> diff --git a/src/stick_table.c b/src/stick_table.c >> index 42946545..8e16830d 100644 >> --- a/src/stick_table.c >> +++ b/src/stick_table.c >> @@ -1596,8 +1596,10 @@ static

Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Willy Tarreau
On Tue, Jun 26, 2018 at 04:17:37PM +0200, Willy Tarreau wrote: > Hi Tim, > > On Tue, Jun 26, 2018 at 03:57:29PM +0200, Tim Duesterhus wrote: > > diff --git a/src/stick_table.c b/src/stick_table.c > > index 42946545..8e16830d 100644 > > --- a/src/stick_table.c > > +++ b/src/stick_table.c > > @@

Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Willy Tarreau
Hi Tim, On Tue, Jun 26, 2018 at 03:57:29PM +0200, Tim Duesterhus wrote: > diff --git a/src/stick_table.c b/src/stick_table.c > index 42946545..8e16830d 100644 > --- a/src/stick_table.c > +++ b/src/stick_table.c > @@ -1596,8 +1596,10 @@ static int sample_conv_table_trackers(const struct arg >

[PATCH 0/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Tim Duesterhus
Hi attached is a patch that fixes the remaining crash and adds a .vtc file verifying the fix. As the .vtc is shipped in the same patch I am not able to add the commit message / commit id to the top of it. I hope the comment is fine. Feel free to edit the file to suit your preferences. Best

[PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Tim Duesterhus
This commit completes the incomplete segmentation fault fix in commit ac1f3ed64b58bd178865c6f2cc8f6f306d9e1e15. Likewise it must be backported to haproxy 1.8. --- reg-tests/stick-table/h0.vtc | 30 ++ src/stick_table.c| 6 -- 2 files changed,

Re: [Patch] Re: Segfault with haproxy 1.8.10

2018-06-26 Thread Tim Düsterhus
Hi Am 26.06.2018 um 13:56 schrieb Willy Tarreau: > Your patch is obviously good, I've just merged it. > Should sample_conv_table_trackers also be updated? It also checks whether `ts` is valid, before accessing it, but unconditionally calls stktable_release later on. Best regards Tim Düsterhus

Re: Fails to build HAProxy 1.8.10 without USE_THREAD

2018-06-26 Thread William Lallemand
On Sun, Jun 24, 2018 at 10:05:48AM +, Zero King wrote: > On Sun, Jun 24, 2018 at 11:45:35AM +0200, William Lallemand wrote: > >On Sun, Jun 24, 2018 at 09:35:11AM +, Zero King wrote: > >> On Sun, Jun 24, 2018 at 09:42:54AM +0200, William Lallemand wrote: > >> >On Sun, Jun 24, 2018 at

[ANNOUNCE] haproxy-1.8.11

2018-06-26 Thread William Lallemand
Hi, HAProxy 1.8.11 was released on 2018/06/26. It added 2 new commits after version 1.8.10. This version appeared earlier than expected because of a regression in 1.8.10. A fix in the stick table was causing a segfault which is triggered when trying to lookup a key that does not exist. It also

Re: Fails to build HAProxy 1.8.10 without USE_THREAD

2018-06-26 Thread Willy Tarreau
On Sun, Jun 24, 2018 at 11:16:05AM +0200, William Lallemand wrote: > From 081e7f64b1f2ff882be5eb1cb13e44fd2587e806 Mon Sep 17 00:00:00 2001 > From: William Lallemand > Date: Sun, 24 Jun 2018 09:37:03 +0200 > Subject: [PATCH] BUG/BUILD: threads: unbreak build without threads > > The build without

Re: [Patch] Re: Segfault with haproxy 1.8.10

2018-06-26 Thread William Lallemand
On Tue, Jun 26, 2018 at 02:04:21PM +0200, Thierry Fournier wrote: > >> William, The backport in 1.8 stable is trivial. > > > > William / Christopher, given that 1.8.10 is very recent and few people > > had the time to upgrade, I think it would make sense to issue 1.8.11 > > to limit the risks. I

Re: [Patch] Re: Segfault with haproxy 1.8.10

2018-06-26 Thread Thierry Fournier
> On 26 Jun 2018, at 13:56, Willy Tarreau wrote: > > Hi Thierry, > > On Tue, Jun 26, 2018 at 10:20:38AM +0200, thierry.fourn...@arpalert.org wrote: >> BR,Hi, >> >> I found the bug. The segfault is unavoidable, because is trigged if an >> entry doesn't exists in the stick-tables. At the

Re: [Patch] Re: Segfault with haproxy 1.8.10

2018-06-26 Thread Willy Tarreau
Hi Thierry, On Tue, Jun 26, 2018 at 10:20:38AM +0200, thierry.fourn...@arpalert.org wrote: > BR,Hi, > > I found the bug. The segfault is unavoidable, because is trigged if an > entry doesn't exists in the stick-tables. At the start, the stick table > is empty. > > It is a regression introduced

Re: Need Help!

2018-06-26 Thread Jonathan Matthews
You may not have had many replies as your email was marked as spam. You might want to address this by, amongst other things, using plain text and not HTML. On 24 June 2018 at 18:32, Ray Jender wrote: > I am sending rtmp from OBS with the streaming set to rtmp://”HAproxy server > IP”:1935/LPC1

[Patch] Re: Segfault with haproxy 1.8.10

2018-06-26 Thread thierry . fournier
BR,Hi, I found the bug. The segfault is unavoidable, because is trigged if an entry doesn't exists in the stick-tables. At the start, the stick table is empty. It is a regression introduced in 1.8.10 by this patch: BUG/MEDIUM: stick-tables: Decrement ref_cnt in table_* converters commit