Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Alexander, On Mon, Sep 11, 2023 at 03:44:16PM +, Stephan, Alexander wrote: > Hi Willy and Ilya, > > Sorry for the absence, I was mostly out-of-office the last week. I am really > sorry for causing this bug. No worries, stuff like this happens, that's why we have regtests, CI, this

RE: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

, Alexander From: Илья Шипицин Sent: Thursday, August 31, 2023 8:56 PM To: Willy Tarreau Cc: Stephan, Alexander ; haproxy@formilux.org Subject: Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values You don't often get email from chipits...@gmail.com

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

cirrus-ci backtrace freebsd (cirrus-ci) crash · Issue #2275 · haproxy/haproxy (github.com) as usual, I'll send CI improvements once polished чт, 31 авг. 2023 г. в 18:22, Илья Шипицин : > while trying to enable "gdb bt" on cirrus-ci, I noticed

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

while trying to enable "gdb bt" on cirrus-ci, I noticed that we have similar crashes on musl (where gdb implemented already) https://github.com/haproxy/haproxy/issues/2274 ср, 30 авг. 2023 г. в 05:29, Willy Tarreau : > On Tue, Aug 29, 2023 at 11:16:32PM +0200, ??? wrote: > > ??, 29

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

On Tue, Aug 29, 2023 at 11:16:32PM +0200, ??? wrote: > ??, 29 ???. 2023 ?. ? 16:45, Willy Tarreau : > > > On Tue, Aug 29, 2023 at 04:31:31PM +0200, Willy Tarreau wrote: > > > On Tue, Aug 29, 2023 at 02:16:55PM +, Stephan, Alexander wrote: > > > > However, I noticed there is a problem

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

вт, 29 авг. 2023 г. в 16:45, Willy Tarreau : > On Tue, Aug 29, 2023 at 04:31:31PM +0200, Willy Tarreau wrote: > > On Tue, Aug 29, 2023 at 02:16:55PM +, Stephan, Alexander wrote: > > > However, I noticed there is a problem now with the FreeBSD test. Have > you > > > already looked into it? > >

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

On Tue, Aug 29, 2023 at 04:31:31PM +0200, Willy Tarreau wrote: > On Tue, Aug 29, 2023 at 02:16:55PM +, Stephan, Alexander wrote: > > However, I noticed there is a problem now with the FreeBSD test. Have you > > already looked into it? > > Ah no, I had not noticed. I first pushed into a

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

On Tue, Aug 29, 2023 at 02:16:55PM +, Stephan, Alexander wrote: > However, I noticed there is a problem now with the FreeBSD test. Have you > already looked into it? Ah no, I had not noticed. I first pushed into a temporary branch and everything was OK so I pushed into master again without

RE: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Willy, > And I was wrong, they were indeed for the first one. However I had to also > remove the NOT_LAST from the intermediate patches using the list_for_each(). > I put quotes around the symbolic names in the doc to make it clearer which > one was to be used and which one it corresponds

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

On Tue, Aug 29, 2023 at 03:15:48PM +0200, Willy Tarreau wrote: > Overall yes. There are just two small parts in the first patch that are > for the immediately following patches ("refactor...") that I'm going to > move there. And I was wrong, they were indeed for the first one. However I had to

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Alexander, On Mon, Aug 28, 2023 at 12:38:45PM +, Stephan, Alexander wrote: > > I'm fine with this, however I find that the doc is not very clear about > > what is permitted > I agree that doc needs some more details. I added the note about the > iterations and described all the symbolic

RE: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Willy, > finally back to this! Overall it's a great and very clean series, I really > want to thank you for this high quality work! Thanks for the compliment, really glad to hear! :) > Yeah it initially gave me a bit of head scratching when reading this part but > I understood what you did

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Alexander, finally back to this! Overall it's a great and very clean series, I really want to thank you for this high quality work! On Wed, Aug 16, 2023 at 04:24:21PM +, Stephan, Alexander wrote: > I was not able to use a check function for authority and unique_id without > modifying

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Alexander, On Fri, Aug 25, 2023 at 09:34:08AM +, Stephan, Alexander wrote: > Hi Willy, > > Did you already have the chance to take a look at the updated patches? > No hurry though, I just wanted to make sure that the message didn't get lost. Not yet, I'm still burried under annoying bugs

RE: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Willy, Did you already have the chance to take a look at the updated patches? No hurry though, I just wanted to make sure that the message didn't get lost. As mentioned, I am aware that sending individual patches is better in the common case. If that is a problem here, please just let me

RE: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

sample fetch for arbitrary PROXY protocol v2 TLV values [You don't often get email from w...@1wt.eu. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hi Alexander, On Fri, Aug 11, 2023 at 02:08:37PM +, Stephan, Alexander wrote: > Hi Willy, > &g

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Alexander, On Fri, Aug 11, 2023 at 02:08:37PM +, Stephan, Alexander wrote: > Hi Willy, > > Thanks for the nice, detailed feedback. > Overall, I agree with all of your listed points, so no need for further > discussions. ? > I will hopefully send the separated patches at the beginning of

RE: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

r -Original Message- From: Willy Tarreau Sent: Thursday, August 10, 2023 9:18 AM To: Stephan, Alexander Cc: haproxy@formilux.org Subject: Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values [You don't often get email from w...@1wt.eu

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Alexander, On Mon, Jul 31, 2023 at 01:11:35PM +, Stephan, Alexander wrote: > Dear HAProxy-maintainers, > > As proposed by my colleague Christian Menges in [1], I've implemented support > for fetching arbitrary TLV values for PROXY protocol V2 via a sample fetch. I'm afraid I don't

Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Hi Alexander, On Mon, Jul 31, 2023 at 01:11:35PM +, Stephan, Alexander wrote: > Dear HAProxy-maintainers, > > As proposed by my colleague Christian Menges in [1], I've implemented support > for fetching arbitrary TLV values for PROXY protocol V2 via a sample fetch. > It can be used by

[PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values

Dear HAProxy-maintainers, As proposed by my colleague Christian Menges in [1], I’ve implemented support for fetching arbitrary TLV values for PROXY protocol V2 via a sample fetch. It can be used by calling ‘fc_pp_tlv’ with the numerical value of the desired TLV type. This also fixes issue [2].