Re: Recommendations for deleting headers by regexp in 2.x?

2020-09-21 Thread Tim Düsterhus
Ricardo, Am 21.09.20 um 11:29 schrieb Ricardo Fraile: > One mail on this thread said Your MUA appears to not specify the 'references' or 'in-reply-to' headers that are required for proper threading. This makes it unnecessarily hard to find the thread. To prevent all the others from searching

Re: Recommendations for deleting headers by regexp in 2.x?

2020-09-21 Thread Ricardo Fraile
Hello, I'm testing this behaviour with 2.2.3-0e58a34 with the line "http-request del-header x- -m beg" but it reports an error: [ALERT] 264/110329 (5812) : parsing [/etc/haproxy//haproxy.cfg:91]: 'http-request del-header' expects either 'if' or 'unless' followed by a condition but found

Re: Recommendations for deleting headers by regexp in 2.x?

2020-03-09 Thread Ricardo Fraile
Hello, +1 for this feature I have some rspidel and rspirep waiting to be migrated to 2.2 when this feature will be available. Thanks, El vie, 14-02-2020 a las 09:59 +0100, Willy Tarreau escribió: > Hi James, > > On Fri, Jan 31, 2020 at 12:44:24PM -0800, James Brown wrote: > > So how

Re: Recommendations for deleting headers by regexp in 2.x?

2020-02-14 Thread Willy Tarreau
Hi James, On Fri, Jan 31, 2020 at 12:44:24PM -0800, James Brown wrote: > So how should we move this proposal forward? I'm glad to contribute more > patches... Sorry for the very late response, we needed to discuss this with Christopher then both got busy and then forgot :-/ So after discussion,

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-31 Thread James Brown
So how should we move this proposal forward? I'm glad to contribute more patches... On Fri, Jan 24, 2020 at 2:15 AM Willy Tarreau wrote: > On Fri, Jan 24, 2020 at 10:26:34AM +0100, Christopher Faulet wrote: > > Le 24/01/2020 à 09:17, Willy Tarreau a écrit : > > > On Fri, Jan 24, 2020 at

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-24 Thread Willy Tarreau
On Fri, Jan 24, 2020 at 10:26:34AM +0100, Christopher Faulet wrote: > Le 24/01/2020 à 09:17, Willy Tarreau a écrit : > > On Fri, Jan 24, 2020 at 08:28:33AM +0100, Christopher Faulet wrote: > > > Le 23/01/2020 à 19:59, James Brown a écrit : > > > > I spent a couple of minutes and made the attached

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-24 Thread Christopher Faulet
Le 24/01/2020 à 09:17, Willy Tarreau a écrit : On Fri, Jan 24, 2020 at 08:28:33AM +0100, Christopher Faulet wrote: Le 23/01/2020 à 19:59, James Brown a écrit : I spent a couple of minutes and made the attached (pretty bad) patch to add a del-header-by-prefix. Just an idea. Instead of adding

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-24 Thread Willy Tarreau
On Fri, Jan 24, 2020 at 08:28:33AM +0100, Christopher Faulet wrote: > Le 23/01/2020 à 19:59, James Brown a écrit : > > I spent a couple of minutes and made the attached (pretty bad) patch to > > add a del-header-by-prefix. > > > > Just an idea. Instead of adding a new action, it could be cleaner

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-24 Thread Aleksandar Lazic
+1 Jan 24, 2020 8:28:33 AM Christopher Faulet : > Le 23/01/2020 à 19:59, James Brown a écrit : > > > I spent a couple of minutes and made the attached (pretty bad) patch to add > > a > > del-header-by-prefix. > > > > > > Just an idea. Instead of adding a new action, it could be cleaner to

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread Christopher Faulet
Le 23/01/2020 à 19:59, James Brown a écrit : I spent a couple of minutes and made the attached (pretty bad) patch to add a del-header-by-prefix. Just an idea. Instead of adding a new action, it could be cleaner to extend the del-header action adding some keywords. Something like:

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread Tim Düsterhus
Willy, Am 23.01.20 um 21:40 schrieb Willy Tarreau: > On Thu, Jan 23, 2020 at 12:05:55PM -0800, James Brown wrote: >> Glad to do any other debugging you'd like. Just running `make >> TARGET=linux-glibc USE_NS=` or `make TARGET=osx`; nothing fancy. > > Ah now I have it. I think that it happens

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread Willy Tarreau
On Thu, Jan 23, 2020 at 12:05:55PM -0800, James Brown wrote: > Glad to do any other debugging you'd like. Just running `make > TARGET=linux-glibc USE_NS=` or `make TARGET=osx`; nothing fancy. Ah now I have it. I think that it happens when we skip the code paths that get ifdef'd out when openssl

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread James Brown
Oh, and the crash is introduced in 8af03b396a6025437b675f9ecaa5db321ec4918c; 56dd354b3c55876c4e693fe5eee919e85b2bad53 is the last version that doesn't crash for me. On Thu, Jan 23, 2020 at 12:06 PM Tim Düsterhus wrote: > Willy, > James, > > Am 23.01.20 um 21:00 schrieb Willy Tarreau: > > I'm

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread Tim Düsterhus
Willy, James, Am 23.01.20 um 21:00 schrieb Willy Tarreau: > I'm impressed, I'm unable to reproduce it! FWIW, I can reproduce it: > [timwolla@/s/haproxy ((f22758d1…))]./haproxy -vv > HA-Proxy version 2.2-dev1-f22758-30 2020/01/23 - https://haproxy.org/ > Status: development branch - not safe for

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread James Brown
Glad to do any other debugging you'd like. Just running `make TARGET=linux-glibc USE_NS=` or `make TARGET=osx`; nothing fancy. On Thu, Jan 23, 2020 at 12:00 PM Willy Tarreau wrote: > On Thu, Jan 23, 2020 at 11:54:17AM -0800, James Brown wrote: > > Where master ==

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread Willy Tarreau
On Thu, Jan 23, 2020 at 11:54:17AM -0800, James Brown wrote: > Where master == f22758d12af5e9f3919f24bf913b883a62df7d93, the following > config fails on both linux-glibc and osx: > > global > maxconn 1024 > > defaults > timeout client 9s > timeout server 9s > timeout connect 1s >

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread James Brown
Where master == f22758d12af5e9f3919f24bf913b883a62df7d93, the following config fails on both linux-glibc and osx: global maxconn 1024 defaults timeout client 9s timeout server 9s timeout connect 1s frontend test_fe mode http bind ::: use_backend test_be backend

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread Willy Tarreau
On Thu, Jan 23, 2020 at 11:05:57AM -0800, James Brown wrote: > Update: I rebased back to the last non-segfaulting commit and this patch's > functionality appears to work in very limited testing. Cool, thanks for doing it. I've quickly read it and I'm also convinced it must work. I'll take more

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread James Brown
Update: I rebased back to the last non-segfaulting commit and this patch's functionality appears to work in very limited testing. On Thu, Jan 23, 2020 at 10:59 AM James Brown wrote: > I spent a couple of minutes and made the attached (pretty bad) patch to > add a del-header-by-prefix. > >

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread James Brown
I spent a couple of minutes and made the attached (pretty bad) patch to add a del-header-by-prefix. Unfortunately, I made it off of master before noticing that master segfaults on every request, so I haven't tested it yet. At least it compiles... Feel free to use it, throw it away, or whatever

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread James Brown
Yes, they’re all identified by a prefix. On Thu, Jan 23, 2020 at 02:03 Willy Tarreau wrote: > Hi James, > > On Wed, Jan 22, 2020 at 04:19:41PM -0800, James Brown wrote: > > We're upgrading from 1.8 to 2.x and one of the things I've noticed is > that > > reqidel and rspidel seem to be totally

Re: Recommendations for deleting headers by regexp in 2.x?

2020-01-23 Thread Willy Tarreau
Hi James, On Wed, Jan 22, 2020 at 04:19:41PM -0800, James Brown wrote: > We're upgrading from 1.8 to 2.x and one of the things I've noticed is that > reqidel and rspidel seem to be totally gone in 2.1... What's the new > recommendation to delete headers from request/response based on a regular >

Recommendations for deleting headers by regexp in 2.x?

2020-01-22 Thread James Brown
We're upgrading from 1.8 to 2.x and one of the things I've noticed is that reqidel and rspidel seem to be totally gone in 2.1... What's the new recommendation to delete headers from request/response based on a regular expression? Do I have to write a Lua action to do this now? I read through the