Re: Travis Matrix (was: Re: [PATCH] wurfl device detection build fixes and dummy library)

2019-06-13 Thread Willy Tarreau
On Fri, Jun 14, 2019 at 01:34:34AM +0500, ??? wrote: > well, I am going to play with cron jobs say "after haproxy-2.0 release" OK, that works for me! > as for being good citizens, when I look at > > https://travis-ci.org/openssl/openssl/builds > > (25k builds 1hr each ), I'm sure

Re: Travis Matrix (was: Re: [PATCH] wurfl device detection build fixes and dummy library)

2019-06-13 Thread Илья Шипицин
пт, 14 июн. 2019 г. в 01:27, Willy Tarreau : > On Thu, Jun 13, 2019 at 10:28:19PM +0500, ??? wrote: > > > > or we can drop boringssl build in favour of Manu :) > > > > > > I suggest to drop BoringSSL. It's not intended to be used outside of > > > Google anyway. So if it breaks the user

Re: Travis Matrix (was: Re: [PATCH] wurfl device detection build fixes and dummy library)

2019-06-13 Thread Willy Tarreau
On Thu, Jun 13, 2019 at 10:28:19PM +0500, ??? wrote: > > > or we can drop boringssl build in favour of Manu :) > > > > I suggest to drop BoringSSL. It's not intended to be used outside of > > Google anyway. So if it breaks the user gets to keep both pieces and can > > report the issue in

Re: Travis Matrix (was: Re: [PATCH] wurfl device detection build fixes and dummy library)

2019-06-13 Thread Илья Шипицин
чт, 13 июн. 2019 г. в 22:25, Tim Düsterhus : > Ilya, > Willy, > > Am 13.06.19 um 19:11 schrieb Илья Шипицин: > > чт, 13 июн. 2019 г. в 22:07, Willy Tarreau : > > > >> On Thu, Jun 13, 2019 at 10:01:52PM +0500, ??? wrote: > >>> "everything enabled" is impossible. 51degrees may be enabled

Re: Travis Matrix (was: Re: [PATCH] wurfl device detection build fixes and dummy library)

2019-06-13 Thread Tim Düsterhus
Ilya, Willy, Am 13.06.19 um 19:11 schrieb Илья Шипицин: > чт, 13 июн. 2019 г. в 22:07, Willy Tarreau : > >> On Thu, Jun 13, 2019 at 10:01:52PM +0500, ??? wrote: >>> "everything enabled" is impossible. 51degrees may be enabled in two >>> mutually exclusive ways. it doubles number of

Re: Travis Matrix (was: Re: [PATCH] wurfl device detection build fixes and dummy library)

2019-06-13 Thread Willy Tarreau
On Thu, Jun 13, 2019 at 10:01:52PM +0500, ??? wrote: > "everything enabled" is impossible. 51degrees may be enabled in two > mutually exclusive ways. it doubles number of build configurations. It's not big deal, the haproxy-specific code remains the same and only the 51D-specific one

Re: Travis Matrix (was: Re: [PATCH] wurfl device detection build fixes and dummy library)

2019-06-13 Thread Willy Tarreau
On Thu, Jun 13, 2019 at 06:28:09PM +0200, Tim Düsterhus wrote: > I'm unhappy with that patch: > > a) It makes unrelated changes to the OpenSSL version (that should be a > separate patch). I'm also at fault here because I saw this and didn't bother that much, being busy on other stuff :-/ > b)

Re: Travis Matrix (was: Re: [PATCH] wurfl device detection build fixes and dummy library)

2019-06-13 Thread Илья Шипицин
чт, 13 июн. 2019 г. в 21:28, Tim Düsterhus : > Ilya, > > (removed Ben and Christopher from Cc, as this no longer about 51d) > > Am 13.06.19 um 17:01 schrieb Илья Шипицин: > > please find "travis-ci + 51degree" patch attached. > > I'm unhappy with that patch: > > a) It makes unrelated changes to

Re: Travis Matrix (was: Re: [PATCH] wurfl device detection build fixes and dummy library)

2019-06-13 Thread Илья Шипицин
чт, 13 июн. 2019 г. в 21:28, Tim Düsterhus : > Ilya, > > (removed Ben and Christopher from Cc, as this no longer about 51d) > > Am 13.06.19 um 17:01 schrieb Илья Шипицин: > > please find "travis-ci + 51degree" patch attached. > > I'm unhappy with that patch: > > a) It makes unrelated changes to

Travis Matrix (was: Re: [PATCH] wurfl device detection build fixes and dummy library)

2019-06-13 Thread Tim Düsterhus
Ilya, (removed Ben and Christopher from Cc, as this no longer about 51d) Am 13.06.19 um 17:01 schrieb Илья Шипицин: > please find "travis-ci + 51degree" patch attached. I'm unhappy with that patch: a) It makes unrelated changes to the OpenSSL version (that should be a separate patch). b) It

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
Cc: ??? ; Christopher Faulet ; HAProxy Subject: Re: [PATCH] wurfl device detection build fixes and dummy library On Thu, Jun 13, 2019 at 03:57:04PM +, Ben Shillito wrote: > Also, after thinking earlier about making it more obvious that it is a > dummy library, I have at

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Willy Tarreau
On Thu, Jun 13, 2019 at 03:57:04PM +, Ben Shillito wrote: > Also, after thinking earlier about making it more obvious that it is a dummy > library, I have attached a patch which adds "(dummy library)" to the output > of REGISTER_BUILD_OPTS macro. Ah perfect, I also wanted to do it but

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: 13 June 2019 16:30 To: Ben Shillito Cc: ??? ; Christopher Faulet ; HAProxy Subject: Re: [PATCH] wurfl device detection build fixes and dummy library On Thu, Jun 13, 2019 at 03:21:36PM +, Ben Shillito wrote: > Thanks both

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Willy Tarreau
On Thu, Jun 13, 2019 at 03:21:36PM +, Ben Shillito wrote: > Thanks both, > > Ilya, I will take a look at that now. I suspect it's totally unrelated, the failure was on this reg test and may be just a race : ## Test case: reg-tests/checks/4be_1srv_health_checks.vtc ## ## test results

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
Cc: Ben Shillito ; Christopher Faulet ; HAProxy Subject: Re: [PATCH] wurfl device detection build fixes and dummy library Ben, I enabled "trie" on one build configuration and ... it failed https://travis-ci.com/haproxy/haproxy/jobs/207816969 it never failed before. can you have a look ? (a

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Илья Шипицин
Ben, I enabled "trie" on one build configuration and ... it failed https://travis-ci.com/haproxy/haproxy/jobs/207816969 it never failed before. can you have a look ? (also, it did NOT fail in my own fork) чт, 13 июн. 2019 г. в 20:03, Willy Tarreau : > On Thu, Jun 13, 2019 at 08:01:14PM +0500,

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Willy Tarreau
On Thu, Jun 13, 2019 at 08:01:14PM +0500, ??? wrote: > please find "travis-ci + 51degree" patch attached. applied, thanks Ilya. willy

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Илья Шипицин
please find "travis-ci + 51degree" patch attached. чт, 13 июн. 2019 г. в 19:06, Willy Tarreau : > On Thu, Jun 13, 2019 at 02:02:33PM +, Ben Shillito wrote: > > Hi Willy, > > > > Yes, I agree the paths in the dummy library should match that of the > actual library. And yes, that patch is good

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Willy Tarreau
On Thu, Jun 13, 2019 at 02:02:33PM +, Ben Shillito wrote: > Hi Willy, > > Yes, I agree the paths in the dummy library should match that of the actual > library. And yes, that patch is good with me. Thanks for the fast response, now merged. Willy

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
: 13 June 2019 14:59 To: Ben Shillito Cc: ??? ; Christopher Faulet ; HAProxy Subject: Re: [PATCH] wurfl device detection build fixes and dummy library Ben, what do you think of this one ? Willy This email and any attachments are confidential and may also be privileged. If you

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Willy Tarreau
Ben, what do you think of this one ? Willy commit 5e4c5003c5cd5709e599aedbfdd5ef223dd3dc79 Author: Willy Tarreau Date: Thu Jun 13 15:56:10 2019 +0200 CLEANUP: 51d: move the 51d dummy lib to contrib/51d/src to match the real lib This way the directory structure remains the same

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Willy Tarreau
On Thu, Jun 13, 2019 at 12:59:33PM +, Ben Shillito wrote: > Thanks for the link, that's useful. Looks like the path to the source is the > issue. > > It should be "51DEGREES_SRC=contrib/51d/pattern" rather than > "51DEGREES_SRC=contrib/51d/src/pattern". That's what I just noticed as well,

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
c: Willy Tarreau ; Christopher Faulet ; HAProxy Subject: Re: [PATCH] wurfl device detection build fixes and dummy library чт, 13 июн. 2019 г. в 17:09, Ben Shillito mailto:b...@51degrees.com>>: In Travis the contrib version would be fine. But if you are testing something which will late

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Илья Шипицин
ROXY_DATE=\"2019/06/11\" -c > -o src/da.o src/da.c > > make: *** No rule to make target 'contrib/src/trie/../cityhash/city.o', > needed by 'haproxy'. Stop. > > make: *** Waiting for unfinished jobs.... > > is documentation correct ? or I should use some different way

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
н [mailto:chipits...@gmail.com] Sent: 13 June 2019 11:31 To: Ben Shillito Cc: Willy Tarreau ; Christopher Faulet ; HAProxy Subject: Re: [PATCH] wurfl device detection build fixes and dummy library чт, 13 июн. 2019 г. в 15:25, Ben Shillito mailto:b...@51degrees.com>>: Hi, The docs are co

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Илья Шипицин
n.com/company/2171864> > > [image: Find out More] <https://51degrees.com/emailsig.aspx> > > > > *From:* Илья Шипицин [mailto:chipits...@gmail.com] > *Sent:* 13 June 2019 11:07 > *To:* Ben Shillito > *Cc:* Willy Tarreau ; Christopher Faulet ; > HAProxy > *Subj

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
y Tarreau ; Christopher Faulet ; HAProxy Subject: Re: [PATCH] wurfl device detection build fixes and dummy library Ben, what is the proper way of building 51degree ? I added "USE_51DEGREES=1 51DEGREES_SRC=contrib/51d/src/pattern" (as I seen in documentation) gcc -Iinclude -Iebtree

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Илья Шипицин
lto:w...@1wt.eu] > Sent: 12 June 2019 17:07 > To: Ben Shillito > Cc: Christopher Faulet ; HAProxy < > haproxy@formilux.org> > Subject: Re: [PATCH] wurfl device detection build fixes and dummy library > > On Wed, Jun 12, 2019 at 02:49:37PM +, Ben Shillito wrote: >

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-12 Thread Ben Shillito
-Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: 12 June 2019 17:07 To: Ben Shillito Cc: Christopher Faulet ; HAProxy Subject: Re: [PATCH] wurfl device detection build fixes and dummy library On Wed, Jun 12, 2019 at 02:49:37PM +, Ben Shillito wrote: > While I was work

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-12 Thread Willy Tarreau
On Wed, Jun 12, 2019 at 02:49:37PM +, Ben Shillito wrote: > While I was working on the HTX changes, I thought it was probably a good time > to also implement the dummy library as I had my brain in 'HAProxy mode'. Ah, excellent, thank you : $./haproxy -vv|grep -i 51d Feature list : +EPOLL

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-12 Thread Ben Shillito
Subject: Re: [PATCH] wurfl device detection build fixes and dummy library On Wed, Jun 12, 2019 at 08:52:53AM +, Ben Shillito wrote: > Hi Willy, > > This unfortunately fell down our list of priorities in the last few weeks. Oh I certainly can understand, and I'm sorry I forgot abou

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-12 Thread Willy Tarreau
On Wed, Jun 12, 2019 at 08:52:53AM +, Ben Shillito wrote: > Hi Willy, > > This unfortunately fell down our list of priorities in the last few weeks. Oh I certainly can understand, and I'm sorry I forgot about it so I didn't ping you earlier. > However, as this is a bit more urgent now with

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-12 Thread Ben Shillito
287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: 12 June 2019 09:14 To: Ben Shillito Cc: Christopher Faulet ; HAProxy Subject: Re: [PATCH] wurfl device detection build fixes and dummy library Hi Ben, On Wed, Apr 24, 2019 at 06

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-06-12 Thread Willy Tarreau
Hi Ben, On Wed, Apr 24, 2019 at 06:20:16PM +0200, Christopher Faulet wrote: > Le 24/04/2019 à 17:56, Ben Shillito a écrit : > > Hi Willy, > > > > Thanks for the update. We will take a look and get a patch over to you. > > > > Hi, > > Ben, the function _51d_fetch() is not HTX aware. Take > a

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-05-09 Thread Willy Tarreau
Hi Max, I'll respond on some points here. On Thu, May 09, 2019 at 06:03:58PM +0200, Massimiliano Bellomi wrote: > Hi Christopher, > > here Massimiliano, from Scientiamobile Engineering team. > > We started working on your suggestions. > > Doing this, I noticed that *send_log()* seems not

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-05-09 Thread Massimiliano Bellomi
Hi Christopher, here Massimiliano, from Scientiamobile Engineering team. We started working on your suggestions. Doing this, I noticed that *send_log()* seems not working if called inside module's init function. e.g. *send_log(NULL, LOG_NOTICE, "WURFL: Loading module v.%s\n",

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-05-07 Thread Aaron Park (Support)
# Please type your reply above this line # You are registered as a cc on this help desk request and are thus receiving email notifications on all updates to the request. Reply to this email to add a comment to the request. -- Aaron Park, May 7, 15:30

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-04-24 Thread Paul Stephen Borile
Hi Christopher, thanks for all suggestions : I'll be working on a patch to address the various issues. Yes, the callback should be called (once with an existing header, once with a non existing one) as that is code to be tested as well : I'll include this issue in the patch. Best -Paul On Wed,

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-04-24 Thread Willy Tarreau
On Wed, Apr 24, 2019 at 03:56:06PM +, Ben Shillito wrote: > Thanks for the update. We will take a look and get a patch over to you. Thank you Ben, Willy

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-04-24 Thread Christopher Faulet
Le 24/04/2019 à 17:56, Ben Shillito a écrit : Hi Willy, Thanks for the update. We will take a look and get a patch over to you. Hi, Ben, the function _51d_fetch() is not HTX aware. Take a look at other HTTP sample fetches in src/http_fetch.c. David, the same is true for the function

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-04-24 Thread Christopher Faulet
Le 23/04/2019 à 11:10, Willy Tarreau a écrit : Hi Paul, On Fri, Apr 19, 2019 at 06:45:22PM +0200, Paul Stephen Borile wrote: Hi Willy, fine for me, thanks for the adjustments and no problem backporting this to 1.9. I also confirm that the contact email address is working correctly. Fine

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-04-24 Thread Ben Shillito
: HAProxy Subject: Re: [PATCH] wurfl device detection build fixes and dummy library Hi Paul, On Fri, Apr 19, 2019 at 06:45:22PM +0200, Paul Stephen Borile wrote: > Hi Willy, > > fine for me, thanks for the adjustments and no problem backporting > this to 1.9. > I also confirm that th

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-04-23 Thread Willy Tarreau
Hi Paul, On Fri, Apr 19, 2019 at 06:45:22PM +0200, Paul Stephen Borile wrote: > Hi Willy, > > fine for me, thanks for the adjustments and no problem backporting this to > 1.9. > I also confirm that the contact email address is working correctly. Fine thank you. I could finish the polishing (add

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-04-19 Thread Paul Stephen Borile
Hi Willy, fine for me, thanks for the adjustments and no problem backporting this to 1.9. I also confirm that the contact email address is working correctly. Thanks! -Paul On Fri, Apr 19, 2019 at 4:46 PM Willy Tarreau wrote: > Hi Paul, > > On Thu, Apr 18, 2019 at 02:46:17PM +0200, Paul

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-04-19 Thread Willy Tarreau
Sorry, with the patches this time. Willy >From 806aebcba5b7c5e3b780c63ff37a54b38a510e19 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Fri, 19 Apr 2019 16:12:08 +0200 Subject: [PATCH 07/13] WIP: wurfl: pass -fPIC when compiling --- contrib/wurfl/makefile | 3 +++ 1 file changed, 3

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-04-19 Thread Willy Tarreau
Hi Paul, On Thu, Apr 18, 2019 at 02:46:17PM +0200, Paul Stephen Borile wrote: > please find attached to this email the 6 patches that cover various areas > of restyling of > the WURFL device detection feature for HAProxy. All patches can be back > ported to 1.9 if necessary. > Last patch is a

Re: [PATCH] wurfl device detection build fixes and dummy library

2019-04-18 Thread Willy Tarreau
Hi Paul, On Thu, Apr 18, 2019 at 02:46:17PM +0200, Paul Stephen Borile wrote: > Hi All, Willy, > > please find attached to this email the 6 patches that cover various areas > of restyling of > the WURFL device detection feature for HAProxy. All patches can be back > ported to 1.9 if necessary. >