[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[ https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537572#comment-16537572 ] Hudson commented on HDDS-90: SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14547 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14547/]) HDDS-90: Create ContainerData, Container classes. Contributed by Bharat (hanishakoneru: rev 6cd19b45efbbcce6d6ca4b5c0eb3beb42d95e558) * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ChunkLayOutVersion.java * (add) hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestKeyValueContainerData.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/KeyValueContainer.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/interfaces/Container.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/KeyValueContainerData.java * (add) hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestChunkLayOutVersion.java * (edit) hadoop-hdds/common/src/main/proto/DatanodeContainerProtocol.proto * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerData.java > Create ContainerData, Container classes > --- > > Key: HDDS-90 > URL: https://issues.apache.org/jira/browse/HDDS-90 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch, > HDDS-90-HDDS-48.03.patch, HDDS-90-HDDS-48.04.patch, HDDS-90-HDDS-48.05.patch, > HDDS-90.00.patch > > > This Jira is to create following classes: > ContainerData (to have generic fields for different types of containers) > KeyValueContainerData (To extend ContainerData and have fields specific to > KeyValueContainer) > Container (For Container meta operations) > KeyValueContainer(To extend Container) > > In this Jira implementation of KeyValueContainer is not done, as this > requires volume classes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[ https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491333#comment-16491333 ] Bharat Viswanadham commented on HDDS-90: Thank You [~arpitagarwal] and [~anu] for review. I have changed the NO_CHECKSUM_WITH_DATA to Data without checksums. I have committed this to feature branch HDDS-48. > Create ContainerData, Container classes > --- > > Key: HDDS-90 > URL: https://issues.apache.org/jira/browse/HDDS-90 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch, > HDDS-90-HDDS-48.03.patch, HDDS-90-HDDS-48.04.patch, HDDS-90-HDDS-48.05.patch, > HDDS-90.00.patch > > > This Jira is to create following classes: > ContainerData (to have generic fields for different types of containers) > KeyValueContainerData (To extend ContainerData and have fields specific to > KeyValueContainer) > Container (For Container meta operations) > KeyValueContainer(To extend Container) > > In this Jira implementation of KeyValueContainer is not done, as this > requires volume classes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[ https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491314#comment-16491314 ] Arpit Agarwal commented on HDDS-90: --- Thanks for the updated patch [~bharatviswa]. +1 Two comments that can be addressed later: # NO_CHECKSUM_WITH_DATA - this can be arbitrary string so it can be a more detailed sentence. # ChunkLayoutVersion can be an enumeration similar to NameNodeLayoutVersion. Not a blocker to commit. > Create ContainerData, Container classes > --- > > Key: HDDS-90 > URL: https://issues.apache.org/jira/browse/HDDS-90 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch, > HDDS-90-HDDS-48.03.patch, HDDS-90-HDDS-48.04.patch, HDDS-90-HDDS-48.05.patch, > HDDS-90.00.patch > > > This Jira is to create following classes: > ContainerData (to have generic fields for different types of containers) > KeyValueContainerData (To extend ContainerData and have fields specific to > KeyValueContainer) > Container (For Container meta operations) > KeyValueContainer(To extend Container) > > In this Jira implementation of KeyValueContainer is not done, as this > requires volume classes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[ https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491302#comment-16491302 ] Anu Engineer commented on HDDS-90: -- +1, Thanks for the clarifications. Please commit when you get a chance. > Create ContainerData, Container classes > --- > > Key: HDDS-90 > URL: https://issues.apache.org/jira/browse/HDDS-90 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch, > HDDS-90-HDDS-48.03.patch, HDDS-90-HDDS-48.04.patch, HDDS-90-HDDS-48.05.patch, > HDDS-90.00.patch > > > This Jira is to create following classes: > ContainerData (to have generic fields for different types of containers) > KeyValueContainerData (To extend ContainerData and have fields specific to > KeyValueContainer) > Container (For Container meta operations) > KeyValueContainer(To extend Container) > > In this Jira implementation of KeyValueContainer is not done, as this > requires volume classes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[ https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491300#comment-16491300 ] Bharat Viswanadham commented on HDDS-90: Thank you [~anu] for review. # createContainerData in this patch is used only in getFromProtoBuf. It will be used in actual request, when KeyValueHandler comes in to picture. Still I have not integrated these classes into current code. # Will address this during committing the patch, (as Jenkins gave a clean run, want to get this patch in as HDDS-123 is dependant on this) # I/O Stats are not persisted into the container file. > Create ContainerData, Container classes > --- > > Key: HDDS-90 > URL: https://issues.apache.org/jira/browse/HDDS-90 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch, > HDDS-90-HDDS-48.03.patch, HDDS-90-HDDS-48.04.patch, HDDS-90-HDDS-48.05.patch, > HDDS-90.00.patch > > > This Jira is to create following classes: > ContainerData (to have generic fields for different types of containers) > KeyValueContainerData (To extend ContainerData and have fields specific to > KeyValueContainer) > Container (For Container meta operations) > KeyValueContainer(To extend Container) > > In this Jira implementation of KeyValueContainer is not done, as this > requires volume classes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491291#comment-16491291
]
Anu Engineer commented on HDDS-90:
--
Really good improvement to the current code. Thank you for getting this done. I
am +1 , on this patch. Some minor comments, feel free to address them in this
Jira or in the follow up JIRAs.
1. DatanodeContainerProtocol.proto:
{{// This is used for create Container Request.}}
I don't see this used in the create request.
2. nit: ChunkLayoutVersion.java -
NO_CHECKSUM_WITH_DATA, since this is description we can rewrite this as "Data
without checksums."
3. ContainerData.java
{{/** parameters for read/write statistics on the container. **/}}
I hope we are not presisting I/O stats in the .container file.
> Create ContainerData, Container classes
> ---
>
> Key: HDDS-90
> URL: https://issues.apache.org/jira/browse/HDDS-90
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch,
> HDDS-90-HDDS-48.03.patch, HDDS-90-HDDS-48.04.patch, HDDS-90-HDDS-48.05.patch,
> HDDS-90.00.patch
>
>
> This Jira is to create following classes:
> ContainerData (to have generic fields for different types of containers)
> KeyValueContainerData (To extend ContainerData and have fields specific to
> KeyValueContainer)
> Container (For Container meta operations)
> KeyValueContainer(To extend Container)
>
> In this Jira implementation of KeyValueContainer is not done, as this
> requires volume classes.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490117#comment-16490117
]
genericqa commented on HDDS-90:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 27m
27s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
57s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 34s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
57s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
16s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 53s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
50s{color} | {color:red} hadoop-hdds/container-service generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
6s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
30s{color} | {color:green} container-service in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
25s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 65m 10s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/container-service |
| | Unread field:KeyValueContainer.java:[line 43] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-90 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12925067/HDDS-90-HDDS-48.05.patch
|
| Optional Tests | asflicense compile cc mvnsite javac unit javadoc
mvninstall shadedclient findbugs checkstyle |
| uname | Linux 5652b582be1e 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[ https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490040#comment-16490040 ] Bharat Viswanadham commented on HDDS-90: Fixed Jenkins reported issues. Attached patch v05. Unread field:KeyValueContainer.java:[line 25] This will be still there, as in next continuation patch, we shall have an implementation for it. > Create ContainerData, Container classes > --- > > Key: HDDS-90 > URL: https://issues.apache.org/jira/browse/HDDS-90 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch, > HDDS-90-HDDS-48.03.patch, HDDS-90-HDDS-48.04.patch, HDDS-90-HDDS-48.05.patch, > HDDS-90.00.patch > > > This Jira is to create following classes: > ContainerData (to have generic fields for different types of containers) > KeyValueContainerData (To extend ContainerData and have fields specific to > KeyValueContainer) > Container (For Container meta operations) > KeyValueContainer(To extend Container) > > In this Jira implementation of KeyValueContainer is not done, as this > requires volume classes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489805#comment-16489805
]
genericqa commented on HDDS-90:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m
30s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
57s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 40s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
54s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
14s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 19s{color} | {color:orange} hadoop-hdds: The patch generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 37s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
45s{color} | {color:red} hadoop-hdds/container-service generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
24s{color} | {color:red} hadoop-hdds_container-service generated 2 new + 4
unchanged - 0 fixed = 6 total (was 4) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
4s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} container-service in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
25s{color} | {color:red} The patch generated 13 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 65m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/container-service |
| | Unread field:KeyValueContainer.java:[line 25] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-90 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12925014/HDDS-90-HDDS-48.04.patch
|
| Optional Tests | asflicense compile cc mvnsite javac unit javadoc
mvninstall shadedclient findbugs checkstyle |
| uname | Linux 7cbd2abe64a7
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[ https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489684#comment-16489684 ] Bharat Viswanadham commented on HDDS-90: Fixed find bug synchornization issue. For another Unread field issue, it will be used in later patches. > Create ContainerData, Container classes > --- > > Key: HDDS-90 > URL: https://issues.apache.org/jira/browse/HDDS-90 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch, > HDDS-90-HDDS-48.03.patch, HDDS-90-HDDS-48.04.patch, HDDS-90.00.patch > > > This Jira is to create following classes: > ContainerData (to have generic fields for different types of containers) > KeyValueContainerData (To extend ContainerData and have fields specific to > KeyValueContainer) > Container (For Container meta operations) > KeyValueContainer(To extend Container) > > In this Jira implementation of KeyValueContainer is not done, as this > requires volume classes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488428#comment-16488428
]
genericqa commented on HDDS-90:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 32m
0s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
59s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 35s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
58s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 47s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
48s{color} | {color:red} hadoop-hdds/container-service generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
7s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} container-service in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
27s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 71m 25s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/container-service |
| | Inconsistent synchronization of
org.apache.hadoop.ozone.container.common.impl.ContainerData.state; locked 60%
of time Unsynchronized access at ContainerData.java:60% of time
Unsynchronized access at ContainerData.java:[line 107] |
| | Unread field:KeyValueContainer.java:[line 43] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-90 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12924874/HDDS-90-HDDS-48.03.patch
|
| Optional Tests | asflicense compile cc mvnsite javac
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[ https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488375#comment-16488375 ] Bharat Viswanadham commented on HDDS-90: I am not sure about compilation issue. I think it was not compiled proto files. I am able to successfully build locally on my dev machine. Fixed java docs issue. > Create ContainerData, Container classes > --- > > Key: HDDS-90 > URL: https://issues.apache.org/jira/browse/HDDS-90 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch, > HDDS-90-HDDS-48.03.patch, HDDS-90.00.patch > > > This Jira is to create following classes: > ContainerData (to have generic fields for different types of containers) > KeyValueContainerData (To extend ContainerData and have fields specific to > KeyValueContainer) > Container (For Container meta operations) > KeyValueContainer(To extend Container) > > In this Jira implementation of KeyValueContainer is not done, as this > requires volume classes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488257#comment-16488257
]
genericqa commented on HDDS-90:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
49s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 30m
34s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
2s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 17s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
57s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
13s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
28s{color} | {color:red} common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
16s{color} | {color:red} container-service in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 17s{color} | {color:orange} hadoop-hdds: The patch generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
18s{color} | {color:red} container-service in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 23s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
21s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
25s{color} | {color:red} hadoop-hdds_container-service generated 3 new + 4
unchanged - 0 fixed = 7 total (was 4) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
4s{color} | {color:green} common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 21s{color}
| {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
29s{color} | {color:red} The patch generated 13 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 67m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-90 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12924845/HDDS-90-HDDS-48.02.patch
|
| Optional Tests | asflicense compile cc mvnsite javac unit javadoc
mvninstall shadedclient findbugs checkstyle |
| uname | Linux 82e2441ce181 4.4.0-121-generic #145-Ubuntu SMP Fri Apr
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488214#comment-16488214
]
Bharat Viswanadham commented on HDDS-90:
Hi [~arpitagarwal] Thanks for review.
Addressed all of your review comments.
#
{quote}Should the {{createContainer}} call be a part of the {{Container}}
interface? Sounds like it should be a part of ContainerSet.{quote}creation of
container will be specific for the container, as for KeyValue type we create a
DB file for the container. So, I think this is specific for the container. Let
me know if I am missing something here.
> Create ContainerData, Container classes
> ---
>
> Key: HDDS-90
> URL: https://issues.apache.org/jira/browse/HDDS-90
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch,
> HDDS-90.00.patch
>
>
> This Jira is to create following classes:
> ContainerData (to have generic fields for different types of containers)
> KeyValueContainerData (To extend ContainerData and have fields specific to
> KeyValueContainer)
> Container (For Container meta operations)
> KeyValueContainer(To extend Container)
>
> In this Jira implementation of KeyValueContainer is not done, as this
> requires volume classes.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487757#comment-16487757
]
Arpit Agarwal commented on HDDS-90:
---
Thanks for the patch [~bharatviswa]. My comments below:
# Can you add a couple of lines to FIRST_LAYOUT_VERSION to describe what the
layout looks like on disk? Also perhaps we can use a more descriptive name than
FIRST_LAYOUT_VERSION.
# Should the {{createContainer}} call be a part of the {{Container}}
interface? Sounds like it should be a part of ContainerSet.
# deleteContainer, updateContainer, readContainer, closeContainer can be
renamed to delete, update, read, close etc. since they are already part of the
Container interface.
# Could you clarify the javadoc for readContainer? Does it read the
containerData from disk? If it is returning from memory perhaps we can just
call it getContainerData().
# Let's make the javadoc on ContainerData class little more descriptive. We
can say something like _ContainerData is the in-memory representation of
container metadata and is represented on disk by the .container file._
# Comments like the following can be removed as they don't give much useful
info:
{code:java}
/**
* Construct ContainerData object.
*/
{code}
# Make immutable fields of ContainerData final.
# Do we need {{ContainerData#setContainerType}}? I assume this is immutable
once the object is constructed.
# Can you add a brief comment to describe what {{ContainerData#metadata}} is
expected to hold?
# Similar comments for KeyValueContainerData. Let's improve class Javadocs for
this and also KeyValueContainer.
> Create ContainerData, Container classes
> ---
>
> Key: HDDS-90
> URL: https://issues.apache.org/jira/browse/HDDS-90
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90.00.patch
>
>
> This Jira is to create following classes:
> ContainerData (to have generic fields for different types of containers)
> KeyValueContainerData (To extend ContainerData and have fields specific to
> KeyValueContainer)
> Container (For Container meta operations)
> KeyValueContainer(To extend Container)
>
> In this Jira implementation of KeyValueContainer is not done, as this
> requires volume classes.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484673#comment-16484673
]
genericqa commented on HDDS-90:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 36m
59s{color} | {color:red} root in HDDS-48 failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
59s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 35s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
0s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 19 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
29s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 59s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
56s{color} | {color:red} hadoop-hdds/container-service generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
25s{color} | {color:red} hadoop-hdds_container-service generated 1 new + 4
unchanged - 0 fixed = 5 total (was 4) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
6s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} container-service in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
27s{color} | {color:red} The patch generated 11 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 77m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/container-service |
| | Unchecked/unconfirmed cast from
org.apache.hadoop.ozone.container.common.impl.ContainerData to
org.apache.hadoop.ozone.container.common.impl.KeyValueContainerData in new
org.apache.hadoop.ozone.container.common.impl.KeyValueContainer(ContainerData)
At
KeyValueContainer.java:org.apache.hadoop.ozone.container.common.impl.KeyValueContainerData
in new
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[ https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484498#comment-16484498 ] Arpit Agarwal commented on HDDS-90: --- Targeting the patch to the HDDS-48 branch. > Create ContainerData, Container classes > --- > > Key: HDDS-90 > URL: https://issues.apache.org/jira/browse/HDDS-90 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90.00.patch > > > This Jira is to create following classes: > ContainerData (to have generic fields for different types of containers) > KeyValueContainerData (To extend ContainerData and have fields specific to > KeyValueContainer) > Container (For Container meta operations) > KeyValueContainer(To extend Container) > > In this Jira implementation of KeyValueContainer is not done, as this > requires volume classes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483141#comment-16483141
]
genericqa commented on HDDS-90:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 32m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 50s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
5s{color} | {color:red} hadoop-hdds/common in trunk has 19 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 45s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
7s{color} | {color:red} hadoop-hdds/container-service generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
25s{color} | {color:red} hadoop-hdds_container-service generated 1 new + 1
unchanged - 0 fixed = 2 total (was 1) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
57s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} container-service in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
23s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 73m 21s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/container-service |
| | Unchecked/unconfirmed cast from
org.apache.hadoop.ozone.container.common.impl.ContainerData to
org.apache.hadoop.ozone.container.common.impl.KeyValueContainerData in new
org.apache.hadoop.ozone.container.common.impl.KeyValueContainer(ContainerData)
At
KeyValueContainer.java:org.apache.hadoop.ozone.container.common.impl.KeyValueContainerData
in new
[jira] [Commented] (HDDS-90) Create ContainerData, Container classes
[ https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481131#comment-16481131 ] Bharat Viswanadham commented on HDDS-90: This is dependant on HDDS-71. > Create ContainerData, Container classes > --- > > Key: HDDS-90 > URL: https://issues.apache.org/jira/browse/HDDS-90 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Attachments: HDDS-90.00.patch > > > This Jira is to create following classes: > ContainerData (to have generic fields for different types of containers) > KeyValueContainerData (To extend ContainerData and have fields specific to > KeyValueContainer) > Container (For Container meta operations) > KeyValueContainer(To extend Container) > > In this Jira implementation of KeyValueContainer is not done, as this > requires volume classes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
