[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537578#comment-16537578 ] Hudson commented on HDDS-156: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14547 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14547/]) HDDS-156. Implement HDDSVolume to manage volume state (hanishakoneru: rev 9a5552bf762880c38a233597b7c6e9ea09441108) * (delete) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/VolumeUsage.java * (add) hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/volume/TestVolumeSet.java * (add) hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/volume/TestHddsVolume.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/DataNodeLayoutVersion.java * (edit) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/interfaces/VolumeChoosingPolicy.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeSet.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/RoundRobinVolumeChoosingPolicy.java * (add) hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestDatanodeLayOutVersion.java * (edit) hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeVersionFile.java * (delete) hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestRoundRobinVolumeChoosingPolicy.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/HddsVolumeUtil.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeUsage.java * (delete) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/RoundRobinVolumeChoosingPolicy.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/package-info.java * (delete) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/VolumeInfo.java * (add) hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/helpers/TestDatanodeVersionFile.java * (add) hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/volume/TestRoundRobinVolumeChoosingPolicy.java * (delete) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/VolumeSet.java * (delete) hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/interfaces/TestVolumeSet.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java * (add) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeInfo.java > Implement HDDSVolume to manage volume state > --- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch, > HDDS-156-HDDS-48.003.patch, HDDS-156-HDDS-48.004.patch, > HDDS-156-HDDS-48.005.patch, HDDS-156-HDDS-48.006.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > ** VolumeInfo container disk specific information such as capacity, usage, > storageType. HddsVolume has hdds specific fields for volume such as > VolumeState, VolumeStats (will be added later). > # Write volume level Version file > ** clusterID, storageID, datanodeUUID, creationTime and layoutVersion. > # Read Version file while instantiating HDDSVolumes. > ** When the volume Version file already exists (for example, when a DN is > restarted), then the version file is read for the stored clusterID, > datanodeUuid, lahyoutVersion etc. Some checks will be performed to verify the > sanity of the volume. > ** When a fresh Datanode is started, the Version file is not written to the > volume uptill the clusterID is received from the SCM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512946#comment-16512946 ] Hanisha Koneru commented on HDDS-156: - The shadedclient error is unrelated. Committed to branch HDDS-48. Thank you [~bharatviswa] and [~anu] for the reviews. > Implement HDDSVolume to manage volume state > --- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch, > HDDS-156-HDDS-48.003.patch, HDDS-156-HDDS-48.004.patch, > HDDS-156-HDDS-48.005.patch, HDDS-156-HDDS-48.006.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > ** VolumeInfo container disk specific information such as capacity, usage, > storageType. HddsVolume has hdds specific fields for volume such as > VolumeState, VolumeStats (will be added later). > # Write volume level Version file > ** clusterID, storageID, datanodeUUID, creationTime and layoutVersion. > # Read Version file while instantiating HDDSVolumes. > ** When the volume Version file already exists (for example, when a DN is > restarted), then the version file is read for the stored clusterID, > datanodeUuid, lahyoutVersion etc. Some checks will be performed to verify the > sanity of the volume. > ** When a fresh Datanode is started, the Version file is not written to the > volume uptill the clusterID is received from the SCM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[
https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512910#comment-16512910
]
genericqa commented on HDDS-156:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
28s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m
45s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
2s{color} | {color:green} HDDS-48 passed {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 3m
49s{color} | {color:red} branch has errors when building and testing our client
artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
38s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
25s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 2 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 2m
35s{color} | {color:red} patch has errors when building and testing our client
artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
4s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
43s{color} | {color:green} container-service in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m 32s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-156 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12927865/HDDS-156-HDDS-48.006.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 04f7589f5ca7 4.4.0-121-generic #145-Ubuntu SMP Fri Apr 13
13:47:23 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDDS-48 / 418cff4 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| whitespace |
https://builds.apache.org/job/PreCommit-HDDS-Build/309/artifact/out/whitespace-tabs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/309/testRep
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512882#comment-16512882 ] Hanisha Koneru commented on HDDS-156: - Thanks [~anu] for the review. There are a few checkstyle issues which I fixed in patch v06. Will commit after the Jenkins run. > Implement HDDSVolume to manage volume state > --- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch, > HDDS-156-HDDS-48.003.patch, HDDS-156-HDDS-48.004.patch, > HDDS-156-HDDS-48.005.patch, HDDS-156-HDDS-48.006.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > ** VolumeInfo container disk specific information such as capacity, usage, > storageType. HddsVolume has hdds specific fields for volume such as > VolumeState, VolumeStats (will be added later). > # Write volume level Version file > ** clusterID, storageID, datanodeUUID, creationTime and layoutVersion. > # Read Version file while instantiating HDDSVolumes. > ** When the volume Version file already exists (for example, when a DN is > restarted), then the version file is read for the stored clusterID, > datanodeUuid, lahyoutVersion etc. Some checks will be performed to verify the > sanity of the volume. > ** When a fresh Datanode is started, the Version file is not written to the > volume uptill the clusterID is received from the SCM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[
https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511903#comment-16511903
]
Anu Engineer commented on HDDS-156:
---
+1, Please go ahead and commit this when you get a chance.
One minor comment, It would be good to file a JIRA for this future feature.
{noformat}
private final String storageId;
private final String clusterId;
private final String datanodeUuid;
{noformat}
Storage ID - identifies the storage.
cluster ID - identifies the cluster.
datanode UUID - identifies the data node.
We might want to add 1 more identifiers.
# ScmGroupID - it identifies the set of SCMs that this datanode talks to, or
takes commands from if you want we can call this SCM ID.
This value is not same as Cluster ID – since a cluster can technically have
more than one SCM group.
> Implement HDDSVolume to manage volume state
> ---
>
> Key: HDDS-156
> URL: https://issues.apache.org/jira/browse/HDDS-156
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch,
> HDDS-156-HDDS-48.003.patch, HDDS-156-HDDS-48.004.patch,
> HDDS-156-HDDS-48.005.patch
>
>
> This Jira proposes the following:
> # Implement HDDSVolume to encompass VolumeInfo along with other HDDS
> specific fields.
> ** VolumeInfo container disk specific information such as capacity, usage,
> storageType. HddsVolume has hdds specific fields for volume such as
> VolumeState, VolumeStats (will be added later).
> # Write volume level Version file
> ** clusterID, storageID, datanodeUUID, creationTime and layoutVersion.
> # Read Version file while instantiating HDDSVolumes.
> ** When the volume Version file already exists (for example, when a DN is
> restarted), then the version file is read for the stored clusterID,
> datanodeUuid, lahyoutVersion etc. Some checks will be performed to verify the
> sanity of the volume.
> ** When a fresh Datanode is started, the Version file is not written to the
> volume uptill the clusterID is received from the SCM.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[
https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511869#comment-16511869
]
genericqa commented on HDDS-156:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m
1s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
1s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 22s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
55s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
23s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 20s{color} | {color:orange} hadoop-hdds: The patch generated 6 new + 6
unchanged - 6 fixed = 12 total (was 12) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 15s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
5s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
39s{color} | {color:green} container-service in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
27s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 63m 24s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-156 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12927741/HDDS-156-HDDS-48.005.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux cd5eb836c7ac 4.4.0-121-generic #145-Ubuntu SMP Fri Apr 13
13:47:23 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDDS-48 / 7e228e5 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HD
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[
https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511781#comment-16511781
]
Hanisha Koneru commented on HDDS-156:
-
Thanks for the review [~bharatviswa].
I fixed the checkstyle issues. But had to refactor
{{TestRoundRobinVolumeChoosingPolicy}} for that.
> Implement HDDSVolume to manage volume state
> ---
>
> Key: HDDS-156
> URL: https://issues.apache.org/jira/browse/HDDS-156
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch,
> HDDS-156-HDDS-48.003.patch, HDDS-156-HDDS-48.004.patch,
> HDDS-156-HDDS-48.005.patch
>
>
> This Jira proposes the following:
> # Implement HDDSVolume to encompass VolumeInfo along with other HDDS
> specific fields.
> ** VolumeInfo container disk specific information such as capacity, usage,
> storageType. HddsVolume has hdds specific fields for volume such as
> VolumeState, VolumeStats (will be added later).
> # Write volume level Version file
> ** clusterID, storageID, datanodeUUID, creationTime and layoutVersion.
> # Read Version file while instantiating HDDSVolumes.
> ** When the volume Version file already exists (for example, when a DN is
> restarted), then the version file is read for the stored clusterID,
> datanodeUuid, lahyoutVersion etc. Some checks will be performed to verify the
> sanity of the volume.
> ** When a fresh Datanode is started, the Version file is not written to the
> volume uptill the clusterID is received from the SCM.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511765#comment-16511765 ] Bharat Viswanadham commented on HDDS-156: - +1 LGTM.( Check style issues need to be fixed) > Implement HDDSVolume to manage volume state > --- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch, > HDDS-156-HDDS-48.003.patch, HDDS-156-HDDS-48.004.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > ** VolumeInfo container disk specific information such as capacity, usage, > storageType. HddsVolume has hdds specific fields for volume such as > VolumeState, VolumeStats (will be added later). > # Write volume level Version file > ** clusterID, storageID, datanodeUUID, creationTime and layoutVersion. > # Read Version file while instantiating HDDSVolumes. > ** When the volume Version file already exists (for example, when a DN is > restarted), then the version file is read for the stored clusterID, > datanodeUuid, lahyoutVersion etc. Some checks will be performed to verify the > sanity of the volume. > ** When a fresh Datanode is started, the Version file is not written to the > volume uptill the clusterID is received from the SCM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[
https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511722#comment-16511722
]
genericqa commented on HDDS-156:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
42s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m
44s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
57s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 54s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
1s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
18s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 20s{color} | {color:orange} hadoop-hdds: The patch generated 9 new + 7
unchanged - 5 fixed = 16 total (was 12) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 39s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
59s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
36s{color} | {color:green} container-service in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
26s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 66m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-156 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12927706/HDDS-156-HDDS-48.004.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 499611e1d15b 3.13.0-141-generic #190-Ubuntu SMP Fri Jan 19
12:52:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDDS-48 / 7e228e5 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-H
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511633#comment-16511633 ] Hanisha Koneru commented on HDDS-156: - In Patch v04, fixed review comments, checkstyle and findbug issues, unit test failures. > Implement HDDSVolume to manage volume state > --- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch, > HDDS-156-HDDS-48.003.patch, HDDS-156-HDDS-48.004.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > # Read Version file while instantiating HDDSVolumes. > # Write volume level Version file. > > [Edit]: Adding below information, which might be useful to add in to the Jira > description. > 1. DN is restarted (volumes already exist). In this case, the clusterId is > inferred from version file > New setup, in this case, we do not know the clusterID till we contact the > SCM. So the volumes will be in NOT_FORMATTED state and the version file will > not be written. > > In case 2, once we get the clusterID from SCM, we need to format the volumes. > This is not done in the current patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[
https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510522#comment-16510522
]
genericqa commented on HDDS-156:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m
22s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
59s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 46s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
59s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
21s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 20s{color} | {color:orange} hadoop-hdds: The patch generated 17 new + 10
unchanged - 2 fixed = 27 total (was 12) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 7 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 47s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
50s{color} | {color:red} hadoop-hdds/container-service generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
9s{color} | {color:green} common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 37s{color}
| {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
26s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 66m 48s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/container-service |
| | Redundant nullcheck of clusterID, which is known to be non-null in
org.apache.hadoop.ozone.container.common.utils.HddsVolumeUtil.getClusterID(Properties,
File, String) Redundant null check at HddsVolumeUtil.java:is known to be
non-null in
org.apache.hadoop.ozone.container.common.utils.HddsVolumeUtil.getClusterID(Properties,
File, String) Redundant null check at HddsVolumeUtil.java:[line 70] |
| | Redundant nullcheck of props, which is known to be non-null in
org.apache.hadoop.ozone.container.common.volume.HddsVolume.readVersionFile()
Redundant null check at HddsVolume.java:is known to be non-null in
org.apache.hadoop.ozone.containe
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510453#comment-16510453 ] Hanisha Koneru commented on HDDS-156: - Thanks for the review [~bharatviswa]. Addressed your comments in patch v03. > Implement HDDSVolume to manage volume state > --- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch, > HDDS-156-HDDS-48.003.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > # Read Version file while instantiating HDDSVolumes. > # Write volume level Version file. > > [Edit]: Adding below information, which might be useful to add in to the Jira > description. > 1. DN is restarted (volumes already exist). In this case, the clusterId is > inferred from version file > New setup, in this case, we do not know the clusterID till we contact the > SCM. So the volumes will be in NOT_FORMATTED state and the version file will > not be written. > > In case 2, once we get the clusterID from SCM, we need to format the volumes. > This is not done in the current patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508995#comment-16508995 ] Bharat Viswanadham commented on HDDS-156: - Hi [~hanishakoneru] Thanks for the patch. Few comments. # HddsVolume.java Line 101: can we add not nullcheck for volumeRoot. (I don't think we need this check, but if these classes are used directly, it might be needed) # Some of the methods in DatanodeVersionFile.java and HddsVolumeUtil.java looks same. getClusterID, getDatanodeUUID, getLayOutVersion, getProperty and getCreationTime. Can we remove in one of the file. # HddsVolume.java Line 112: If data node paths are configured like this [TYPE][URI] then we need to pass parsed path from StorageLocation. # Can we add some test cases for above type of paths (which add type to the path) to validate HddsVolumes works properly or not? # Can we add test case for HddsVolume.java which tests end to end HddsVolume? # TestDatanodeVersionFile Line 96: has some Tab spaces. # And also address the checkstyle and findbug issues reported by jenkins. > Implement HDDSVolume to manage volume state > --- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > # Read Version file while instantiating HDDSVolumes. > # Write volume level Version file. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[
https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508751#comment-16508751
]
genericqa commented on HDDS-156:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m
38s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
59s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 57s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
54s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
22s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 19s{color} | {color:orange} hadoop-hdds: The patch generated 48 new + 10
unchanged - 2 fixed = 58 total (was 12) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 13 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 41s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
46s{color} | {color:red} hadoop-hdds/container-service generated 4 new + 0
unchanged - 0 fixed = 4 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
6s{color} | {color:green} common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 35s{color}
| {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
27s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 66m 27s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/container-service |
| | Redundant nullcheck of clusterID, which is known to be non-null in
org.apache.hadoop.ozone.container.common.helpers.DatanodeVersionFile.getClusterID(Properties,
File, String) Redundant null check at DatanodeVersionFile.java:is known to be
non-null in
org.apache.hadoop.ozone.container.common.helpers.DatanodeVersionFile.getClusterID(Properties,
File, String) Redundant null check at DatanodeVersionFile.java:[line 133] |
| | Redundant nullcheck of props, which is known to be non-null in
org.apache.hadoop.ozone.container.common.impl.HddsVolume.readVersionFile()
Redundant null check at HddsVolume.java:is known to be non-null in
org.apac
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508649#comment-16508649 ] Hanisha Koneru commented on HDDS-156: - Reverted HDDS-97 and refactored the patch. > Implement HDDSVolume to manage volume state > --- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > # Read Version file while instantiating HDDSVolumes. > # Write volume level Version file. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[
https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508585#comment-16508585
]
genericqa commented on HDDS-156:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 29m
21s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
26s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 11s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
5s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
53s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 21s{color} | {color:orange} hadoop-hdds: The patch generated 52 new + 10
unchanged - 2 fixed = 62 total (was 12) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 8 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 53s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
50s{color} | {color:red} hadoop-hdds/container-service generated 4 new + 0
unchanged - 0 fixed = 4 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
15s{color} | {color:green} common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 39s{color}
| {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 2m 11s{color}
| {color:red} server-scm in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
28s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 74m 15s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/container-service |
| | Redundant nullcheck of clusterID, which is known to be non-null in
org.apache.hadoop.ozone.container.common.helpers.DatanodeVersionFile.getClusterID(Properties,
File, String) Redundant null check at DatanodeVersionFile.java:is known to be
non-null in
org.apache.hadoop.ozone.container.common.helpers.DatanodeVersionFile.getClusterID(Properties,
File, String) Redundant null check at DatanodeVersionFile.java:[line 133] |
| | Redundant nullcheck of props, which is known to be non-null in
org.apache.hadoop.
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508444#comment-16508444 ] Hanisha Koneru commented on HDDS-156: - Thanks Bharat. Updated the patch name. > Implement HDDSVolume to manage volume state > --- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156-HDDS-48.001.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > # Read Version file while instantiating HDDSVolumes. > # Write volume level Version file. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508289#comment-16508289 ] Bharat Viswanadham commented on HDDS-156: - Hi [~hanishakoneru] Thanks for the patch. Patch needs to be renamed to add branch name. > Implement HDDSVolume to manage volume state > --- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156.001.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > # Read Version file while instantiating HDDSVolumes. > # Write volume level Version file. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[
https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506744#comment-16506744
]
genericqa commented on HDDS-156:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HDDS-156 does not apply to trunk. Rebase required? Wrong Branch?
See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDDS-156 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12927146/HDDS-156.001.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/269/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Implement HDDSVolume to manage volume state
> ---
>
> Key: HDDS-156
> URL: https://issues.apache.org/jira/browse/HDDS-156
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-156.001.patch
>
>
> This Jira proposes the following:
> # Implement HDDSVolume to encompass VolumeInfo along with other HDDS
> specific fields.
> # Read Version file while instantiating HDDSVolumes.
> # Write volume level Version file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-156) Implement HDDSVolume to manage volume state
[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506741#comment-16506741 ] Hanisha Koneru commented on HDDS-156: - HDDS-97 adds Version file per SCM in the Datanode. The Version file should be per volume in the Datanode. As such, we should not have the SCM_ID in the Version File. This requires either reverting or refactoring HDDS-97 patch. > Implement HDDSVolume to manage volume state > --- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156.001.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > # Read Version file while instantiating HDDSVolumes. > # Write volume level Version file. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
