e more similar functions (with more or less
features) in other tests. Some of them are not even using hardcoded
magic numbers.
Adding as TODO for future.
Other than that,
Reviewed-by: Joonas Lahtinen
This not need be a "basic" test?
Regards, Joonas
--
Joonas Lahtinen
Open Source
Use atomic type and operands for dev_priv->mm.bsd_engine_dispatch_index
to avoid one struct_mutex locking scenario.
Cc: Chris Wilson
Cc: Imre Deak
Cc: Zhao Yakui
Cc: Daniel Vetter
Signed-off-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_drv.h| 2 +-
drivers/gpu/drm/i
c(i915, 0, &bo[0], fb_id[0]))
**** END
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On to, 2016-09-01 at 15:32 +0300, Joonas Lahtinen wrote:
> On to, 2016-09-01 at 13:27 +0100, Chris Wilson wrote:
> >
> > On Thu, Sep 01, 2016 at 12:20:18PM -, Patchwork wrote:
> > >
> > > Test prime_vgem:
> > > Subgroup basic-fence-flip
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ked.
I'd myself vote for loosing the temporary for 20 bytes too.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
riv->uncore.funcs.mmio_readq(dev_priv,
> (reg), true)
>
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
hris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
by: Zhenyu Wang
Reviewed-by: Joonas Lahtinen
> ---
> drivers/gpu/drm/i915/i915_vgpu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_vgpu.c
> b/drivers/gpu/drm/i915/i915_vgpu.c
> index ca2e912..dae340c 100644
> --- a/drivers/
On ti, 2016-09-06 at 12:04 +0800, Zhenyu Wang wrote:
> From: Zhi Wang
>
> Disable 48bit full PPGTT on vGPU too for now.
>
> Signed-off-by: Zhi Wang
> Signed-off-by: Zhenyu Wang
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Quoting Tomasz Lis (2018-11-05 15:50:21)
> +++ b/drivers/gpu/drm/i915/intel_mocs.c
> @@ -44,6 +44,8 @@ struct drm_i915_mocs_table {
> #define LE_SCC(value) ((value) << 8)
> #define LE_PFM(value) ((value) << 11)
> #define LE_SCF(value) ((value) << 14)
> +#define LE_CoS(
> Testcase: igt/benchmarks/gem_syslatency
> Signed-off-by: Chris Wilson
> Cc: Kuo-Hsin Yang
> Cc: Matthew Auld
> Cc: Joonas Lahtinen
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-g
Quoting Zhenyu Wang (2018-10-26 09:43:20)
> On 2018.10.25 16:07:14 +0300, Joonas Lahtinen wrote:
> > Quoting Zhenyu Wang (2018-10-23 06:46:59)
> > >
> > > Hi,
> > >
> > > Here's gvt-next-fixes for 4.20 with three changes. Mostly
> > &g
Quoting Zhenyu Wang (2018-11-07 04:31:37)
>
> Hi,
>
> Here's re-generated -fixes pull for 4.20. Mostly on fixing
> possible guest arbitrary update of GGTT entries, with one mask
> fix for chicken register, and with one to fix eDP warning in guest.
>
> Thanks.
Pulled. Thanks for re-spinning.
Re
en update ggtt entry
drm/i915/gvt: support inconsecutive partial gtt entry write
Joonas Lahtinen (1):
Merge tag 'gvt-fixes-2018-11-07' of https://github.com/intel/gvt-linux
into drm-intel-fixes
Longhe Zheng (1):
drm/i915/gvt: Handle values of EDP_PSR_IMR and EDP_PSR_II
The following patches with Fixes: do not cleanly apply
to drm-intel-fixes:
- 5a3aeca97af1 ("drm/i915: Fix hpd handling for pins with two encoders")
Please provide a backported patch ASAP, if they are relevant to be
backported. If they should not be included in drm-intel-fixes,
please confirm that
Thanks for a quick backport, applied this now.
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Joonas Lahtinen (2018-11-12 14:49:14)
> The following patches with Fixes: do not cleanly apply
> to drm-intel-fixes:
>
> - 5a3aeca97af1 ("drm/i915: Fix hpd handling for pins with two encoders")
One more:
- e7a278a329dd ("drm/i915: Account for scale factor when
Hi Dave,
Most importantly we have a fix for an incorrect EU count reported
from kernel, Gen9+ scaled output fix, and avoiding OOPS on MST
display systems.
So looking pretty stable.
Regards, Joonas
PS. Had some CI turbulence for this PR as we raised the bar
so that now a loss of lockdep coverage
Quoting Jani Nikula (2018-11-15 14:01:22)
> Reduce bloat in one of the bigger header files. Fix some indentation
> while at it. No functional changes.
>
> Signed-off-by: Jani Nikula
Do add include guards. Then this is:
Reviewed-by: Joonas Lahtinen
Reg
Quoting Jani Nikula (2018-11-15 14:01:23)
> While at it, conform to kernel spacing (i.e. no space) after cast. No
> functional changes.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing li
Quoting Jani Nikula (2018-11-15 14:01:24)
> No need to use a compound statement enclosed in parenthesis where a C99
> compound literal will do. No functional changes.
>
> Signed-off-by: Jani Nikula
Out of curiosity, did this have an effect on asm generation?
Presumably not.
Reviewe
Quoting Jani Nikula (2018-11-15 14:01:25)
> Simply return the condition. No functional changes.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.
gt; WARN_ON(val > U32_MAX);
> - fp.val = (u32)val;
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
adjust
> > their request (and not restrict raising the minimum to privileged
> > CAP_SYS_NICE clients).
> >
> > Testcase: igt/gem_ctx_freq
> > Signed-off-by: Chris Wilson
> > Cc: Joonas Lahtinen
> > Cc: Tvrtko Ursulin
> > Cc: Praveen Paneri
> Cc: John Harrison
> Cc: Tvrtko Ursulin
> Cc: Joonas Lahtinen
> Cc: Daniel Vetter
Might be worthy splurting something to the dmesg?
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Lionel Landwerlin (2018-10-23 13:07:07)
> The way our hardware is designed doesn't seem to let us use the
> MI_RECORD_PERF_COUNT command without setting up a circular buffer.
>
> In the case where the user didn't request OA reports to be available
> through the i915 perf stream, we can set
Userspace portion is still missing.
This reverts commit cd956bfcd0f58d20485ac0a785415f7d9327a95f.
Cc: Lionel Landwerlin
Cc: Matthew Auld
Signed-off-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_drv.h | 1 -
drivers/gpu/drm/i915/i915_perf.c | 99 +++-
drivers
Userspace portion is still missing.
This reverts commit 9fa6e2f7609fdbb7d6f86be86371a5719bec0376.
Cc: Lionel Landwerlin
Cc: Matthew Auld
Signed-off-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_perf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b
Quoting Xu, Terrence (2018-10-19 10:04:47)
> Platform Support:
>
> -Server platforms: Intel(r) Xeon(r) E3_v4, E3_v5 and E3_v6 with Intel
> Graphics processor
>
> -Client platforms: Intel(r) Core(tm) 5th generation (code name:
> Broadwell),
> 6th generation (code name: Skylake), 7th gener
Hide the enable_gvt modparam in the default scenario where
support has not been compiled in.
Cc: Zhenyu Wang
Cc: Zhi Wang
Cc: Chris Wilson
Signed-off-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_params.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915
115628d567 ("drm/i915: Implement pwrite without struct-mutex")
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
> Cc: Tvrtko Ursulin
> ---
> drivers/gpu/drm/i915/i915_gem.c | 195
> 1 file changed, 25 insertions(+), 170 deletions(-
Quoting Chris Wilson (2018-10-09 14:12:59)
> If we have released no firmware yet for a platform, stop scaring the
> consumer and merely note its expected absence.
>
> Signed-off-by: Chris Wilson
> Cc: Petri Latvala
Reviewed-by: Joonas Lahtinen
no firmware yet for a platform, stop scaring the
> > consumer and merely note its expected absence.
> >
> > By simply removing the warning and early return we hit the condition
> > with the appropriate message.
> >
> > Cc: Chris Wilson
> > Cc: Joonas Lahtin
Quoting Matthew Auld (2018-11-19 12:36:00)
> On Fri, 16 Nov 2018 at 13:55, Joonas Lahtinen
> wrote:
> >
> > Userspace portion is still missing.
> >
> > This reverts commit cd956bfcd0f58d20485ac0a785415f7d9327a95f.
> >
> > Cc: Lionel Landwerlin
>
Thanks for the reviews, pushed now.
Regards, Joonas
Quoting Patchwork (2018-11-16 17:31:58)
> == Series Details ==
>
> Series: drm/i915: Hide enable_gvt modparam when not compiled in
> URL : https://patchwork.freedesktop.org/series/52616/
> State : success
>
> == Summary ==
>
> = CI Bug Log
lits # blb/pnv
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
> +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> @@ -1268,7 +1268,7 @@ relocate_entry(struct i915_vma *vma,
> else if (gen >= 4)
> len = 4
context_create(fd),
> + .size = sizeof(sseu),
> + .value = to_user_pointer(&sseu) };
... and this don't seem to be consitent with kernel coding
style, which I thought we try to use in IGT?
There seems to be some other strangely indented structs too,
+ Haihaho who's been involved with gem_media_fill test, if you could
provide review, too.
Quoting Tvrtko Ursulin (2018-11-13 16:36:28)
> From: Tony Ye
>
> Simple test which exercises the VME fixed function block.
>
> v2: (Tvrtko Ursulin)
> * Small cleanups like copyright date, tabs, remove unu
ug of the above bug, I'm not
seeing other connection.
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Hans Holmberg (2018-11-21 11:54:23)
> From: Hans Holmberg
>
> There is no need to rebuild i915_gpu_error.o when the version string
> changes as the version is available in init_utsname()->release.
>
> Signed-off-by: Hans Holmberg
Seems reasonable to me.
Reviewe
+ Chris
Quoting Pavel Machek (2018-11-08 19:58:03)
> Hi!
>
> My machine locked hard (thinkpad x220). After reboot, I found this in
> syslog:
>
> Sounds like memory corruption..? Does not sound like easy to debug.
Were you doing something GPU intense when you experienced the hard hang?
And if s
Quoting Hans Holmberg (2018-11-21 13:35:19)
> On Wed, Nov 21, 2018 at 11:10 AM Joonas Lahtinen
> wrote:
> >
> > Quoting Hans Holmberg (2018-11-21 11:54:23)
> > > From: Hans Holmberg
> > >
> > > There is no need to rebuild i915_gpu_error.o when the v
Merged now, thanks for the patch and reviews.
Quoting Patchwork (2018-11-22 02:05:03)
> == Series Details ==
>
> Series: drm/i915: avoid rebuilding i915_gpu_error.o on version string updates
> URL : https://patchwork.freedesktop.org/series/52822/
> State : success
>
> == Summary ==
>
> = CI B
Hi Dave,
Here's the -fixes for 4.20-rc4. Stuck backlight/flickering
fix for DSI screen and GPU hang fix for SNB are the main
user visible ones.
Then two more fixes to prevent GPU hangs in more rare
scenarios.
Regards, Joonas
***
drm-intel-fixes-2018-11-22:
- Fix for fastboot DSI panel boot tim
from kernel point of view, is that it does no longer
> have a fast path with get_user_pages_fast() this can eventually added
> back through HMM.
>
> Signed-off-by: Jérôme Glisse
> Cc: dri-de...@lists.freedesktop.org
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Chris Wil
Quoting Pavel Machek (2018-11-21 13:54:49)
> Hi!
>
> > > My machine locked hard (thinkpad x220). After reboot, I found this in
> > > syslog:
> > >
> > > Sounds like memory corruption..? Does not sound like easy to debug.
> >
> > Were you doing something GPU intense when you experienced the hard
nt err_print_to_sgl(struct i915_gpu_state *error)
> +{
> + struct drm_i915_error_state_buf m;
> struct drm_i915_error_object *obj;
> struct timespec64 ts;
> int i, j;
>
> - if (!error) {
> - err_printf(m, "No error st
Pulled this now.
Regards, Joonas
Quoting Zhenyu Wang (2018-11-26 04:18:20)
>
> Hi,
>
> Here's regular gvt fixes for 4.20-rc5. One to correct MOCS registers
> load on engine list, one for rpm lock warning fix, and another for
> use-after-free fix for partial ggtt list destroy. Details below.
>
out the ancient
gens, where display gets clobbered by reset or not.
With these mentioned, this is:
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
it has to perform.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=108735
> Signed-off-by: Chris Wilson
Won't affect later Gens using ELSP, so:
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-
Quoting Kasiviswanathan, Harish (2018-11-26 22:59:30)
> Thanks Tejun,Eric and Christian for your replies.
>
> We want GPUs resource management to work seamlessly with containers and
> container orchestration. With the Intel / bpf based approach this is not
> possible.
>
> From your response we
gt; @@ -1422,10 +1674,11 @@ static struct i915_vma *eb_parse(struct
> i915_execbuffer *eb, bool is_master)
> goto out;
>
> vma->exec_entry =
> - memset(&eb->shadow_exec_entry, 0, sizeof(*vma->e
t; CHV_COLORS,
> };
>
> +#define GEN9_DEFAULT_PAGE_SZ \
> + .page_size_mask = I915_GTT_PAGE_SIZE_4K | I915_GTT_PAGE_SIZE_64K |
> I915_GTT_PAGE_SIZE_2M | I915_GTT_PAGE_SIZE_1G
GEN9_DEFAULT_PAGE_SIZES, also split long line.
With above,
Reviewed-by: Joonas Lahtinen
Regards, Joona
size));
Patches should be split functionally, not for the sake of splitting.
Tt's rather hard to complete review when the appearing code is pretty
much no-op, so for next you could squash them a bit. For now, as a leap
of faith;
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtin
Commit message for why we do this.
On ti, 2017-04-04 at 23:11 +0100, Matthew Auld wrote:
> Signed-off-by: Matthew Auld
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-
first check the is_ggtt() because it's more important one, and drop
a comment here as to why we can make the decision.
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx ma
On ti, 2017-04-04 at 23:11 +0100, Matthew Auld wrote:
> Export color_differs so that we can use it elsewhere.
>
> v2: better naming
>
> Signed-off-by: Matthew Auld
> Cc: Mika Kuoppala
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Techn
in resume time, and we instead should be telling GuC
to suspend and not reset the GPU, at most only reset the engines.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@list
n of the series.
Except if the feature is implemented in increments, but I already
mentioned in another patch that the ordering could be shuffled to allow
for easier review (which will lead to easier bisecting, too).
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
In
Jason Ekstrand
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100594
> Fixes: 24f8e00a8a2e ("drm/i915: Prefer to report ENOMEM rather than incur the
> oom for gfx allocations")
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
> Cc: Daniel Vetter
Revie
> + ret = i915_gem_object_pin_pages(obj);
> + if (ret)
> + return ret;
> +
> + i915_gem_object_flush_cpu_write_domain(obj);
> + i915_gem_object_flush_gtt_write_domain(obj);
I was thinking if WC should be a "substate" of CPU domain, because
supposed to wait_for_idle before calling us to update the seqno, so
> let's assert they have and the engine is indeed idle.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technolog
e block to its own function for some clarity.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100144
> Testcase: igt/gem_exec_whisper/hang-*
> Signed-off-by: Chris Wilson
> Cc: Mika Kuoppala
Reviewed-by: Joonas Lahtinen
Re
? process_one_work+0x3b0/0x3b0
? kthread_create_on_node+0x40/0x40
? ret_from_fork+0x23/0x30
Fixes: 3d3d18f086cd ("drm/i915: Avoid rcu_barrier() from reclaim paths
(shrinker)")
Reported-by: Andrea Arcangeli
Signed-off-by: Joonas Lahtinen
Cc: Andrea Arcangeli
Cc: Chris Wilson
Cc: Daniel
ase struct_mutex.
> + */
> + synchronize_rcu_expedited();
> +
> return freed;
> }
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Joonas Lahtinen
Open Source Technol
> Signed-off-by: Chris Wilson
Please re-spin this over Oscar's series (and R-b the remaining two
patches).
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@list
wildest dreams considers exporting them.
Signed-off-by: Joonas Lahtinen
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h | 6
drivers/gpu/drm/i915/i915_gem.c | 2 --
drivers/gpu/drm/i915/i915_gem_shrinker.c | 56 +++-
drivers/gpu/drm/i915
? process_one_work+0x3b0/0x3b0
? kthread_create_on_node+0x40/0x40
? ret_from_fork+0x23/0x30
Fixes: 3d3d18f086cd ("drm/i915: Avoid rcu_barrier() from reclaim paths
(shrinker)")
Reported-by: Andrea Arcangeli
Signed-off-by: Joonas Lahtinen
Cc: Andrea Arcangeli
Cc: Chris Wilson
Cc: Daniel
can be more aggressive when we know the caller isn't holding
> struct_mutex.
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
nation image.
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://
ed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On pe, 2017-04-07 at 11:25 +0100, Chris Wilson wrote:
> As we may have very many objects to free, check to see if the task needs
> to be rescheduled whilst freeing them.
>
> Suggested-by: Andrea Arcangeli
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
Reviewed-b
72a98636e9dfebc0 drm-tip: 2017y-04m-07d-10h-32m-49s
> UTC integration manifest
> 08e143d drm/i915: Simplify shrinker locking
> 60dc19c drm/i915: Don't call synchronize_rcu_expedited under struct_mutex
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/CI/Pa
reserve 0 to mean unordered (DMA_FENCE_NO_CONTEXT) to
> have the same semantics everywhere.
>
> Signed-off-by: Chris Wilson
> Cc: Daniel Vetter
> Cc: Joonas Lahtinen
> @@ -157,7 +156,7 @@ void i915_gem_clflush_object(struct drm_i915_gem_object
> *obj,
>
ce() (before the dependency is added)
> using the observation that requests along the same timeline are
> explicitly ordered via i915_add_request (along with the dependencies).
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
On pe, 2017-04-07 at 20:42 +0100, Chris Wilson wrote:
> The void *data passed to debugfs callbacks is actually the
> drm_i915_private pointer, so use it thusly and avoid the to_i915(dev)
> indirection.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Jo
rtko Ursulin
> CC: Zhipeng Gong
> CC: Joonas Lahtinen
> CC: Chris Wilson
Maybe this patch should get rid of the "!IS_SKYLAKE(dev_priv)"
restriction in the setter function, too?
Regards, Joonas
--
Joonas Lahtinen
Open Sourc
/0x190
> [ 383.589026] kthread+0xf7/0x130
> [ 383.589030] ? sort_range+0x20/0x20
> [ 383.589034] ? kthread_park+0x90/0x90
> [ 383.589040] ret_from_fork+0x2c/0x40
>
> Fixes: 2ca9faa551c4 ("drm/i915: Assert the engine is idle before overwiting
> the HWS")
> Signed-off
>
> - i915_gem_object_flush_gtt_write_domain(obj);
> + flush_write_domain(obj, I915_GEM_DOMAIN_CPU);
Let me tell ya, this reads really confusing. Maybe
flush_write_domain(obj, ~I915_GEM_DOMAIN_CPU);
and call the parameter "mask" instead of "exclude..."
On ke, 2017-04-12 at 00:44 +0100, Chris Wilson wrote:
> Provide dummy function pointers for the mock device in case we do hit
> mmio during testing.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel
ts idle bit and we get upset.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://l
during HW access" warnings.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://l
combine the existing two into one and
> flushing WC writes will then be automatically handled as well.
>
> v2: Be smarter and clearer by passing in the write domains to flush (Joonas)
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
> @@ -266,7 +266,7 @@ static
;ggtt.reserved;
>
> and doesn't need to know the identity of every possible consumer.
I was writing an e-mail about the same thing. So +1 on the idea.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
)PTR_ERR(dmabuf));
> + err = PTR_ERR(dmabuf);
You could hoist this assignment on line up. and just make the pr_err
use err, just saying.
Maybe you could use phases array in this function too.
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technolo
On ke, 2017-04-12 at 10:21 +0100, Chris Wilson wrote:
> Provide dummy function pointers for the mock device in case we do hit
> mmio during testing.
>
> v2: Use ASSIGN_READ/WRITE_MMIO_FUNCS macros
>
> Signed-off-by: Chris Wilson
> Reviewed-by: Joonas Lahtinen #v1
Reviewe
comes to my mind is exporting function like device_has_rmrr() from
intel-iommu.com and consuming that, if we end up doing this. That way,
if somebody, some day, goes and write RMRR pass-through code currently
missing, it'll start working, just like it should.
Regards, Joonas
--
Joonas Laht
On ke, 2017-04-12 at 13:48 +0100, Chris Wilson wrote:
> Rather than use a global modparam, we can just check to see if the
> engine has semaphores configured upon it.
>
> Signed-off-by: Chris Wilson
Should be good.
Reviewed-by: Joonas Lahtinen
Regars, Joonas
--
Joonas Lahtinen
On to, 2017-04-13 at 01:01 +, Li, Weinan Z wrote:
> >
> > -Original Message-
> > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com]
> > Sent: Wednesday, April 12, 2017 6:19 PM
> > To: Chris Wilson ; Li, Weinan Z
> >
> > Cc:
;
> Signed-off-by: Chris Wilson
Well, it's not going to hurt.
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https:
rt to the
> global seqno.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lis
rites in the intel_uc_init_hw function instead of moving it earlier
> to make sure we attempt them every time we try to load GuC.
>
> Cc: Jeff McGee
> Cc: Anusha Srivatsa
> Signed-off-by: Daniele Ceraolo Spurio
This is an improvement, so:
Reviewed-by: Joonas Lahtinen
To be exact, shouldn
On pe, 2017-04-07 at 00:39 +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/guc: write wopcm related register once during uc init
> URL : https://patchwork.freedesktop.org/series/22625/
> State : success
Pushed the patch.
Regards, Joonas
--
Joonas Lahti
On to, 2017-04-13 at 14:02 +0300, Joonas Lahtinen wrote:
> On pe, 2017-04-07 at 00:39 +, Patchwork wrote:
> >
> > == Series Details ==
> >
> > Series: drm/i915/guc: write wopcm related register once during uc init
> > URL : https://patchwork.freede
ytes [-Werror=frame-larger-than=]
>
> Reported-by: Arnd Bergmann
> Fixes: 66d9cb5d805a ("drm/i915: Mock the GEM device for self-testing")
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
> Cc: Tvrtko Ursulin
> Cc: Matthew Auld
> Cc: Arnd Bergmann
>
ain some magic and hide other magic behind macros.
>
> Signed-off-by: Chris Wilson
Changelog checks out. Assuming you peeked at the generated html docs:
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
00
>
> On the other hand, by ignoring the interrupt do we risk running out of
> space in CSB ring? Testing for a few hours suggests not, i.e. that we
> only seem to get the odd delayed CSB idle notification.
>
> Signed-off-by: Chris Wilson
> Cc: Tvrtko Ursulin
Slap your T
memory for rings.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
KEN1_RCS,
> +
> _MASKED_BIT_ENABLE(GEN9_PREEMPT_GPGPU_SYNC_SWITCH_DISABLE));
To make grepping easier, how about?
I915_WRITE(GUC_REG(GEN9_CSFE_CHICKEN1_RCS),
...);
Regards, Joonas
--
Joonas Lahtinen
Open Source Technolo
901 - 1000 of 2919 matches
Mail list logo
