RE: [v2] powerpc: Fix incorrect PPC32 PAMU dependency

2016-03-23 Thread Varun Sethi
d on COMPILE_TEST) restricted PAMU to > > PPC32. PPC covers both. > > > > Signed-off-by: Andy Fleming <aflem...@gmail.com> > > Tested-by: Madalin Bucur <madalin.bu...@freescale.com> > Ackd-by: Varun Sethi <varun.se...@freescale.com> ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

RE: [RFC PATCH 0/2] VFIO no-iommu

2015-10-11 Thread Varun Sethi
Hi Alex, Thanks for the patch Alex. This would also require support in Qemu to expose the physical address to the VM. Are you looking at that part as well? Regards Varun -Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu-boun...@lists.linux-foundation.org]

RE: [PATCH v2] iommu/fsl: Really fix init section(s) content

2015-08-17 Thread Varun Sethi
, This fixes the modpost warning(s), the unbind/bind sequence crashes and the random errors/crashes Fixes: 0f1fb99b62ce (iommu/fsl: Fix section mismatch) Fixes: cd70d4659ff3 (iommu/fsl: Various cleanups) Signed-off-by: Emil Medve emilian.me...@freescale.com Acked-by: Varun Sethi varun.se

RE: [PATCH 2/3] Docs: dt: Add PCI MSI map bindings

2015-08-08 Thread Varun Sethi
...@huawei.com; Yoder Stuart-B08248 Subject: Re: [PATCH 2/3] Docs: dt: Add PCI MSI map bindings On Wed, Aug 05, 2015 at 05:39:33PM +0100, Varun Sethi wrote: Hi Mark Thanks for the patch. Please find my comment inline. Regards Varun -Original Message- From: iommu-boun...@lists.linux

RE: [PATCH 2/3] Docs: dt: Add PCI MSI map bindings

2015-08-05 Thread Varun Sethi
Hi Mark Thanks for the patch. Please find my comment inline. Regards Varun -Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Mark Rutland Sent: Thursday, July 23, 2015 10:23 PM To:

RE: [PATCH v2] iommu/fsl: Really fix init section(s) content

2015-08-03 Thread Varun Sethi
Acked-by: Varun Sethi varun.se...@freescale.com Cc: sta...@vger.kernel.org --- drivers/iommu/fsl_pamu.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c index abeedc9..2570f2a 100644

RE: [RFC 0/6] vSMMU initialization

2015-07-15 Thread Varun Sethi
initialization On Tue, Jul 14, 2015 at 03:21:03AM +0100, Varun Sethi wrote: Hi Will, Hi Varun, On Fri, Jun 12, 2015 at 03:20:04PM +0100, Baptiste Reynal wrote: The ARM SMMU has support for 2-stages address translations, allowing a virtual address to be translated at two levels: - Stage

RE: [RFC 0/6] vSMMU initialization

2015-07-15 Thread Varun Sethi
] vSMMU initialization On Tue, Jul 14, 2015 at 1:04 PM, Will Deacon will.dea...@arm.com wrote: On Tue, Jul 14, 2015 at 03:21:03AM +0100, Varun Sethi wrote: Hi Will, Hi Varun, On Fri, Jun 12, 2015 at 03:20:04PM +0100, Baptiste Reynal wrote: The ARM SMMU has support for 2-stages

RE: [RFC 0/6] vSMMU initialization

2015-07-13 Thread Varun Sethi
Hi Will, -Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Will Deacon Sent: Friday, June 12, 2015 7:53 PM To: Baptiste Reynal Cc: iommu@lists.linux-foundation.org; t...@virtualopensystems.com;

RE: [PATCH] iommu/fsl: Fix the dependency check for PAMU driver.

2015-05-14 Thread Varun Sethi
driver. On Thu, 2015-05-14 at 23:11 +0530, Varun Sethi wrote: Fix the build dependency for the PAMU driver. PPC32 build dependecy is incorrect. Add the CORENET_GENERIC build dependency for PAMU driver. Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/Kconfig

[PATCH] iommu/fsl: Fix the dependency check for PAMU driver.

2015-05-14 Thread Varun Sethi
Fix the build dependency for the PAMU driver. PPC32 build dependecy is incorrect. Add the CORENET_GENERIC build dependency for PAMU driver. Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

RE: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal error: asm/fsl_pamu_stash.h: No such file or directory

2015-05-05 Thread Varun Sethi
:32: fatal error: asm/fsl_pamu_stash.h: No such file or directory Hi Varun, On Wed, Apr 08, 2015 at 01:24:16PM +, Varun Sethi wrote: Following issue was observed while building (compile test) for a non-powerpc (e500mc) based platform. The pamu driver includes a file which

RE: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal error: asm/fsl_pamu_stash.h: No such file or directory

2015-05-05 Thread Varun Sethi
:32: fatal error: asm/fsl_pamu_stash.h: No such file or directory On Tue, May 05, 2015 at 01:22:24PM +, Varun Sethi wrote: Which means the driver was only buildable on e500mc and now you are telling me that this is broken. What am I missing? PPC_E500MC dependency is fine

RE: SMMU 2-stage support

2015-04-14 Thread Varun Sethi
Hi Will, -Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Will Deacon Sent: Monday, April 13, 2015 4:11 PM To: Baptiste Reynal Cc: Linux IOMMU Subject: Re: SMMU 2-stage support On Fri, Apr 03, 2015

RE: [PATCH 15/16] iommu/fsl: Make use of domain_alloc and domain_free

2015-04-12 Thread Varun Sethi
domain_lock; }; Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

RE: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal error: asm/fsl_pamu_stash.h: No such file or directory

2015-04-08 Thread Varun Sethi
^ compilation terminated. vim +24 drivers/iommu/fsl_pamu.h 695093e3 Varun Sethi 2013-07-15 8 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 695093e3 Varun Sethi 2013-07-15 9 * GNU General Public License for more details. 695093e3 Varun Sethi

RE: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal error: asm/fsl_pamu_stash.h: No such file or directory

2015-03-25 Thread Varun Sethi
:21:0: drivers/iommu/fsl_pamu.h:24:32: fatal error: asm/fsl_pamu_stash.h: No such file or directory #include asm/fsl_pamu_stash.h ^ compilation terminated. vim +24 drivers/iommu/fsl_pamu.h 695093e3 Varun Sethi 2013-07-15 8

RE: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal error: asm/fsl_pamu_stash.h: No such file or directory

2015-03-24 Thread Varun Sethi
^ compilation terminated. vim +24 drivers/iommu/fsl_pamu.h 695093e3 Varun Sethi 2013-07-15 8 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 695093e3 Varun Sethi 2013-07-15 9 * GNU General Public License for more details

RE: [PATCH] iommu/fsl: Really fix init section(s) content

2015-02-15 Thread Varun Sethi
; } -static struct platform_driver fsl_of_pamu_driver __initdata = { +static struct platform_driver fsl_of_pamu_driver = { .driver = { .name = fsl-of-pamu, }, -- 2.3.0 Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu

RE: [PATCH] iommu/fsl: Really fix init section(s) content

2015-02-12 Thread Varun Sethi
Thanks Emil, Has this also been tested in context of DPAA? -Original Message- From: Emil Medve [mailto:emilian.me...@freescale.com] Sent: Friday, February 13, 2015 3:15 AM To: iommu@lists.linux-foundation.org; j...@8bytes.org; jroe...@suse.de; Sethi Varun-B16395 Cc: Medve

RE: [PATCH v2 01/26] iommu/fsl: Sprinkle some __init* annotations

2015-02-11 Thread Varun Sethi
Hi Emil, -Original Message- From: Emil Medve [mailto:emilian.me...@freescale.com] Sent: Wednesday, February 11, 2015 4:37 PM To: Sethi Varun-B16395; iommu@lists.linux-foundation.org; j...@8bytes.org; jroe...@suse.de Subject: Re: [PATCH v2 01/26] iommu/fsl: Sprinkle some __init*

RE: [PATCH v2 01/26] iommu/fsl: Sprinkle some __init* annotations

2015-02-11 Thread Varun Sethi
Hi Emil, -Original Message- From: Sethi Varun-B16395 Sent: Wednesday, February 11, 2015 5:00 PM To: 'Emil Medve'; iommu@lists.linux-foundation.org; j...@8bytes.org; jroe...@suse.de Subject: RE: [PATCH v2 01/26] iommu/fsl: Sprinkle some __init* annotations Hi Emil,

RE: [PATCH 00/26] iommu/fsl: Various cleanup

2015-01-31 Thread Varun Sethi
-foundation.org] On Behalf Of Joerg Roedel Sent: Friday, January 30, 2015 9:06 PM To: Sethi Varun-B16395 Cc: iommu@lists.linux-foundation.org; jroe...@suse.de; Medve Emilian- EMMEDVE1 Subject: Re: [PATCH 00/26] iommu/fsl: Various cleanup On Fri, Jan 30, 2015 at 02:50:17PM +, Varun Sethi wrote

RE: [PATCH 11/26] iommu/fsl: Fix checkpatch type OOM_MESSAGE

2015-01-30 Thread Varun Sethi
, there are other places as well where we have error prints while setting the ENOMEM as the return code. This is a checkpatch report and I quote from the log: Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux

RE: [PATCH 00/26] iommu/fsl: Various cleanup

2015-01-30 Thread Varun Sethi
? Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

RE: [PATCH v2 01/26] iommu/fsl: Sprinkle some __init* annotations

2015-01-30 Thread Varun Sethi
Hi Emil, -Original Message- From: Emil Medve [mailto:emilian.me...@freescale.com] Sent: Friday, January 30, 2015 12:26 PM To: Sethi Varun-B16395; iommu@lists.linux-foundation.org; j...@8bytes.org; jroe...@suse.de Subject: Re: [PATCH v2 01/26] iommu/fsl: Sprinkle some __init*

RE: [PATCH 18/26] iommu/fsl: Fix checkpatch type PARENTHESIS_ALIGNMENT

2015-01-30 Thread Varun Sethi
)); +((w_count 1) ? w_count : 0)); if (!ret) { kfree(dma_domain-win_arr); dma_domain-win_arr = kcalloc(w_count, -- 2.2.2 Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu

RE: [PATCH 24/26] iommu/fsl: Remove unneeded semicolon

2015-01-30 Thread Varun Sethi
; break; - }; + } return ret; } -- 2.2.2 Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

RE: [PATCH 23/26] iommu/fsl: Use NULL instead of zero

2015-01-30 Thread Varun Sethi
(node, next-level-cache, 0); + prop = of_get_property(node, next-level-cache, NULL); if (!prop) { pr_debug(can't find next-level-cache at %s\n, node-full_name); -- 2.2.2 Acked-by: Varun Sethi varun.se

RE: [PATCH 20/26] iommu/fsl: Fix alignment of some stray lines

2015-01-30 Thread Varun Sethi
-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

RE: [PATCH 26/26] iommu/fsl: Remove extra paranthesis

2015-01-30 Thread Varun Sethi
-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

RE: [PATCH 19/26] iommu/fsl: Fix some comments alignment

2015-01-30 Thread Varun Sethi
version is = 0x204 we can partition endpoints */ if (version = 0x204) return 1; -- 2.2.2 Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman

RE: [PATCH 25/26] iommu/fsl: Don't use integers values with bool type

2015-01-30 Thread Varun Sethi
group information from peer devices or devices on the parent bus */ -- 2.2.2 Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

RE: [PATCH 11/26] iommu/fsl: Fix checkpatch type OOM_MESSAGE

2015-01-30 Thread Varun Sethi
Hi Emil, -Original Message- From: Emil Medve [mailto:emilian.me...@freescale.com] Sent: Wednesday, January 28, 2015 8:05 PM To: iommu@lists.linux-foundation.org; j...@8bytes.org; jroe...@suse.de; Sethi Varun-B16395 Cc: Medve Emilian-EMMEDVE1 Subject: [PATCH 11/26] iommu/fsl: Fix

RE: [PATCH 06/26] iommu/fsl: Fix checkpatch type LEADING_SPACE

2015-01-29 Thread Varun Sethi
(PAACE_ATM_WINDOW_XLATE | +PAACE_ATM_PAGE_XLATE) #define PAACE_OTM_NO_XLATE 0x00 #define PAACE_OTM_IMMEDIATE 0x01 #define PAACE_OTM_INDEXED 0x02 -- 2.2.2 Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux

RE: [PATCH 16/26] iommu/fsl: Use a device pointer to make lines shorter

2015-01-29 Thread Varun Sethi
); if (!spaace_pool) { ret = -ENOMEM; - dev_err(pdev-dev, PAMU : failed to allocate spaace gen pool\n); + dev_err(dev, PAMU : failed to allocate spaace gen pool\n); goto error; } -- 2.2.2 Acked-by: Varun Sethi varun.se...@freescale.com

RE: [PATCH 17/26] iommu/fsl: Remove pr/dev_*() prefixes

2015-01-29 Thread Varun Sethi
; } /* iova must be page size aligned*/ if (iova (size - 1)) { - pr_debug(%s: address is not aligned with window size\n, __func__); + pr_debug(Address is not aligned with window size\n); return -EINVAL; } -- 2.2.2 Acked-by: Varun Sethi

RE: [PATCH] iommu/fsl: Fix section mismatch

2015-01-22 Thread Varun Sethi
Hi Emil, Thanks for pointing this out. Please find my comment inline. Regards Varun -Original Message- From: Emil Medve [mailto:emilian.me...@freescale.com] Sent: Thursday, January 22, 2015 3:36 AM To: iommu@lists.linux-foundation.org; j...@8bytes.org; jroe...@suse.de; Sethi

RE: [PATCH v2 1/3] iommu/fsl: Fix section mismatch

2015-01-22 Thread Varun Sethi
fsl_of_pamu_driver = { +static struct platform_driver fsl_of_pamu_driver __initdata = { .driver = { .name = fsl-of-pamu, }, -- 2.2.2 Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux-foundation.org

RE: [PATCH 2/3] iommu/fsl: Remove unused fsl_of_pamu_ids[]

2015-01-22 Thread Varun Sethi
platform_driver fsl_of_pamu_driver __initdata = { .driver = { .name = fsl-of-pamu, -- 2.2.2 Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman

RE: [PATCH 3/3] iommu/fsl: Sprinkle some __init* annotations

2015-01-22 Thread Varun Sethi
Thanks Emil, please find my comments inline. Regards Varun -Original Message- From: Emil Medve [mailto:emilian.me...@freescale.com] Sent: Thursday, January 22, 2015 8:17 PM To: iommu@lists.linux-foundation.org; j...@8bytes.org; jroe...@suse.de; Sethi Varun-B16395 Cc: Medve

RE: [PATCH 2/2] iommu/arm-smmu: remove homebrew PCI dma alias parsing

2015-01-19 Thread Varun Sethi
Hi Will, Please find my query inline. Regards Varun -Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Will Deacon Sent: Friday, January 16, 2015 10:29 PM To: alex.william...@redhat.com Cc:

RE: [PATCH 2/4] iommu: add ARM LPAE page table allocator

2014-12-15 Thread Varun Sethi
...@codeaurora.org; laurent.pinch...@ideasonboard.com; j...@8bytes.org; m.szyprow...@samsung.com Subject: Re: [PATCH 2/4] iommu: add ARM LPAE page table allocator On Mon, Dec 15, 2014 at 01:30:20PM +, Will Deacon wrote: On Sun, Dec 14, 2014 at 05:45:49PM +, Varun Sethi wrote: [varun] ok

RE: [PATCH 2/4] iommu: add ARM LPAE page table allocator

2014-12-14 Thread Varun Sethi
...@broadcom.com; Robin Murphy; lau...@codeaurora.org; mitch...@codeaurora.org; laurent.pinch...@ideasonboard.com; j...@8bytes.org; m.szyprow...@samsung.com Subject: Re: [PATCH 2/4] iommu: add ARM LPAE page table allocator On Fri, Dec 05, 2014 at 10:55:11AM +, Varun Sethi wrote: Hi Will, Hi Varun

RE: [PATCH 2/4] iommu: add ARM LPAE page table allocator

2014-12-05 Thread Varun Sethi
Hi Will, Please find my comments inline. Search for varun -Original Message- From: Will Deacon [mailto:will.dea...@arm.com] Sent: Thursday, November 27, 2014 5:21 PM To: linux-arm-ker...@lists.infradead.org; iommu@lists.linux-foundation.org Cc: prem.malla...@broadcom.com;

[RFC][PATCH] iommu/arm-smmu: Huge page mapping support for ARM SMMU driver.

2014-11-12 Thread Varun Sethi
(exported by the arm smmu driver). The code doesn't support creation of new mapping, without unmaping an existing mapping. Code does support splitting up of huge page mappings in to smaller mappings, as a part of unmap. Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/arm

[RFC][PATCH 2/2] Add support of the IOMMU_DEVICE flag.

2014-10-06 Thread Varun Sethi
or reordered. Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/arm-smmu.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index ca18d6d..f8338d6 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c

[RFC][PATCH 1/2] Introduce the IOMMU_DEVICE flag.

2014-10-06 Thread Varun Sethi
This is used for indicating device memory type for a DMA transaction. IOMMU driver would set up attributes indicationg access to device memory. Signed-off-by: Varun Sethi varun.se...@freescale.com --- include/linux/iommu.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/linux

RE: [RFC][PATCH 2/2] Add support of the IOMMU_DEVICE flag.

2014-10-06 Thread Varun Sethi
, Varun Sethi wrote: This flag is used for specifying access to device memory. SMMU would apply device memory attributes for a DMA transaction. This is required for setting access to GIC registers, for generating message interrupts. This would ensure that transactions targetting device memory

RE: [RFC][PATCH 1/2] Introduce the IOMMU_DEVICE flag.

2014-10-06 Thread Varun Sethi
flag. Hi Varun, [adding the Qualcomm guys, as I have an open question below] On Mon, Oct 06, 2014 at 11:28:15AM +0100, Varun Sethi wrote: This is used for indicating device memory type for a DMA transaction. IOMMU driver would set up attributes indicationg access to device memory

RE: [PATCH] iommu/arm-smmu: fix bug in pmd construction

2014-09-21 Thread Varun Sethi
Hi Mitchel, I have made changes to the arm smmu driver paging support, as a part of the huge page support patch. Will is currently reviewing changes made by me. I should be able to post my patch in the next couple of weeks. Regards Vaun -Original Message- From:

RE: [RFC][PATCH] devicetree: Add master-id-bits property to the iommu device

2014-09-16 Thread Varun Sethi
...@nvidia.com; will.dea...@arm.com; Yoder Stuart-B08248; robh...@kernel.org; iommu@lists.linux-foundation.org; thierry.red...@gmail.com; linux-arm-ker...@lists.infradead.org Subject: Re: [RFC][PATCH] devicetree: Add master-id-bits property to the iommu device On Monday 15 September 2014, Varun

RE: [RFC][PATCH] devicetree: Add master-id-bits property to the iommu device

2014-09-15 Thread Varun Sethi
...@nvidia.com; swar...@nvidia.com; robh...@kernel.org; linux-arm- ker...@lists.infradead.org; Yoder Stuart-B08248 Subject: Re: [RFC][PATCH] devicetree: Add master-id-bits property to the iommu device On Sunday 14 September 2014, Varun Sethi wrote: master-id-bits property added to the IOMMU device

[PATCH] iommu/fsl: Fix warning resulting from adding PCI device twice

2014-09-04 Thread Varun Sethi
] [c0002078] .kernel_init+0x1c/0xfa4 [c001fe047e30] [c884] .ret_from_kernel_thread+0x58/0xd4 Instruction dump: 7c7f1b79 4182001c 7fe4fb78 7f83e378 38a01000 4bffc905 6000 7c641b78 e87e8008 7fa5eb78 48482ff5 6000 0fe0 7fe3fb78 4bf7bd39 6000 Signed-off-by: Varun

[PATCH v2] iommu/fsl: Fix warning resulting from adding PCI device twice

2014-09-04 Thread Varun Sethi
] [c0002078] .kernel_init+0x1c/0xfa4 [c001fe047e30] [c884] .ret_from_kernel_thread+0x58/0xd4 Instruction dump: 7c7f1b79 4182001c 7fe4fb78 7f83e378 38a01000 4bffc905 6000 7c641b78 e87e8008 7fa5eb78 48482ff5 6000 0fe0 7fe3fb78 4bf7bd39 6000 Signed-off-by: Varun

RE: [PATCH v3 3/3] iommu/arm-smmu: add support for DOMAIN_ATTR_NESTING attribute

2014-09-02 Thread Varun Sethi
Hi Will, We would still need a mechanism to distinguish stage1 mapping from stage2 mapping i.e. for nested translation we should be able to specify whether the mapping corresponds to stage1 or stage 2 translation. Also, correspondingly we would require different context banks for stage 1 and

RE: [RFC PATCH 1/7] iommu: provide early initialisation hook for IOMMU drivers

2014-09-02 Thread Varun Sethi
Hi Will, -Original Message- From: Will Deacon [mailto:will.dea...@arm.com] Sent: Friday, August 29, 2014 9:24 PM To: linux-arm-ker...@lists.infradead.org; iommu@lists.linux-foundation.org Cc: a...@arndb.de; dw...@infradead.org; jroe...@suse.de; hd...@nvidia.com; Sethi Varun-B16395;

RE: [RFC PATCH 4/7] iommu: provide helper function to configure an IOMMU for an of master

2014-09-02 Thread Varun Sethi
Hi Will, I am not clear on the functionality we want to achieve with this new API. Is this a way to link devices to a particular IOMMU? Would this be used to filter out add_device invocations i.e. iommu group creations just for the devices attached to a particular IOMMU? What is the purpose

RE: [PATCH v5] devicetree: Add generic IOMMU device tree bindings

2014-08-19 Thread Varun Sethi
@lists.linux-foundation.org; Rob Herring; linux-te...@vger.kernel.org; linux-arm-ker...@lists.infradead.org Subject: Re: [PATCH v5] devicetree: Add generic IOMMU device tree bindings Hi Varun, Varun Sethi varun.se...@freescale.com writes: -Original Message- From: iommu-boun

RE: [PATCH v5] devicetree: Add generic IOMMU device tree bindings

2014-08-19 Thread Varun Sethi
- foundation.org; Rob Herring; linux-te...@vger.kernel.org; linux-arm- ker...@lists.infradead.org; Yoder Stuart-B08248 Subject: Re: [PATCH v5] devicetree: Add generic IOMMU device tree bindings Varun Sethi varun.se...@freescale.com writes: Hi Hiroshi, -Original Message- From

RE: [PATCH v5] devicetree: Add generic IOMMU device tree bindings

2014-08-19 Thread Varun Sethi
- foundation.org; Rob Herring; linux-te...@vger.kernel.org; linux-arm- ker...@lists.infradead.org; Yoder Stuart-B08248 Subject: Re: [PATCH v5] devicetree: Add generic IOMMU device tree bindings Varun Sethi varun.se...@freescale.com writes: Also, for dynamic stream ID allocation we would

RE: [PATCH v5] devicetree: Add generic IOMMU device tree bindings

2014-08-19 Thread Varun Sethi
Hi Will, -Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Will Deacon Sent: Friday, August 15, 2014 5:21 PM To: Hiroshi Doyu Cc: Mark Rutland; devicet...@vger.kernel.org; Stephen Warren; Arnd Bergmann;

RE: [PATCH v5] devicetree: Add generic IOMMU device tree bindings

2014-08-14 Thread Varun Sethi
-Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Hiroshi Doyu Sent: Thursday, August 14, 2014 12:18 PM To: Thierry Reding; Stephen Warren; Arnd Bergmann; Will Deacon Cc: Mark Rutland;

RE: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices

2014-07-09 Thread Varun Sethi
; ohau...@codeaurora.org; j...@8bytes.org; a.mota...@virtualopensystems.com; Marc Zyngier Subject: Re: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices [Adding Alex; question below] On Thu, Jul 03, 2014 at 03:22:37PM +0100, Varun Sethi wrote: +static int

RE: [PATCH 0/3] iommu/fsl: Fixes for the PAMU driver.

2014-07-07 Thread Varun Sethi
0/3] iommu/fsl: Fixes for the PAMU driver. On Tue, Jun 24, 2014 at 07:27:14PM +0530, Varun Sethi wrote: This patch set contains fixes for the PAMU driver. The patches are based on 3.16-rc1. Varun Sethi (3): Fix PAMU window size check. Fix the device domain attach condition

RE: [PATCH v3 02/10] devicetree: Add generic IOMMU device tree bindings

2014-07-04 Thread Varun Sethi
-Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Thierry Reding Sent: Friday, June 27, 2014 2:20 AM To: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Stephen Warren; Arnd Bergmann;

RE: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices

2014-07-04 Thread Varun Sethi
...@8bytes.org; a.mota...@virtualopensystems.com; Marc Zyngier Subject: Re: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices On Thu, Jul 03, 2014 at 03:22:37PM +0100, Varun Sethi wrote: Hi Will, Hi Varun, Thanks for taking a look at this! +static struct

RE: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.

2014-07-04 Thread Varun Sethi
/fsl: Fix PAMU window size check. On Tue, Jun 24, 2014 at 07:27:15PM +0530, Varun Sethi wrote: /* window size is 2^(WSE+1) bytes */ - return __ffs(addrspace_size) - 1; + return fls64(addrspace_size) - 2; This looks bogus, why do you replace ffs (find-first-bit) by fls (find- last

RE: [RFC 01/10] iommu: Add IOMMU device registry

2014-07-03 Thread Varun Sethi
-Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Thierry Reding Sent: Friday, June 27, 2014 12:29 PM To: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Stephen Warren; Arnd Bergmann;

RE: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.

2014-07-02 Thread Varun Sethi
...@redhat.com Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check. On 06/24/2014 08:57 AM, Varun Sethi wrote: is_power_of_2 requires an unsigned long parameter which would lead to truncation of 64 bit values on 32 bit architectures. __ffs also expects an unsigned long parameter thus

RE: [PATCH 1/1] iommu/fsl_pamu: Remove unnecessary null test before kfree

2014-06-29 Thread Varun Sethi
) * w_count, GFP_ATOMIC); if (!dma_domain-win_arr) { Acked-by: Varun Sethi varun.se...@freescale.com ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH 0/3] iommu/fsl: Fixes for the PAMU driver.

2014-06-24 Thread Varun Sethi
This patch set contains fixes for the PAMU driver. The patches are based on 3.16-rc1. Varun Sethi (3): Fix PAMU window size check. Fix the device domain attach condition. Fix the error condition during iommu group creation. drivers/iommu/fsl_pamu.c|8 drivers/iommu

[PATCH 1/3] iommu/fsl: Fix PAMU window size check.

2014-06-24 Thread Varun Sethi
is_power_of_2 requires an unsigned long parameter which would lead to truncation of 64 bit values on 32 bit architectures. __ffs also expects an unsigned long parameter thus won't work for 64 bit values on 32 bit architectures. Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers

[PATCH 3/3] iommu/fsl: Fix the error condition during iommu group

2014-06-24 Thread Varun Sethi
Earlier PTR_ERR was being returned even if group was set to null. Now, we explicitly set an ERR_PTR value in case the group pointer is NULL. Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/fsl_pamu_domain.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions

[PATCH 2/3] iommu/fsl: Fix the device domain attach condition.

2014-06-24 Thread Varun Sethi
___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

RE: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-17 Thread Varun Sethi
-Original Message- From: Yoder Stuart-B08248 Sent: Tuesday, June 17, 2014 12:24 AM To: Will Deacon Cc: Sethi Varun-B16395; Thierry Reding; Mark Rutland; devicet...@vger.kernel.org; linux-samsung-...@vger.kernel.org; Pawel Moll; Arnd Bergmann; Ian Campbell; Grant Grundler; Stephen

RE: [RFC PATCH v6 04/20] iommu/arm-smmu: add capability IOMMU_CAP_INTR_REMAP

2014-06-05 Thread Varun Sethi
-Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Antonios Motakis Sent: Thursday, June 05, 2014 10:33 PM To: alex.william...@redhat.com; kvm...@lists.cs.columbia.edu; iommu@lists.linux-foundation.org

RE: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-05 Thread Varun Sethi
-Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Will Deacon Sent: Wednesday, June 04, 2014 10:12 PM To: Thierry Reding Cc: Mark Rutland; devicet...@vger.kernel.org; linux-samsung-

RE: [RFC][PATCH] iommu/arm: Add hotplugged devices support for arm-smmu.

2014-03-13 Thread Varun Sethi
will.dea...@arm.com wrote: Hi Varun, On Sat, Mar 08, 2014 at 07:05:40PM +, Varun Sethi wrote: Currently the ARM SMMU driver only considers the bus master devices in the device tree. The master device and stream ID information is maintained per SMMU. Currently there is no mechanism

[RFC][PATCH] iommu/arm: Add hotplugged devices support for arm-smmu.

2014-03-08 Thread Varun Sethi
a mechanism for representing this information for hot plugged/PCI devices. Patch doesn't contain the add_device callback modification for hot plug devices. This would be bus specific and would be responsible for populating the hot plug devices masters list for the SMMU. Signed-off-by: Varun Sethi varun.se

RE: [RFC PATCH] vfio/iommu_type1: Multi-IOMMU domain support

2014-01-27 Thread Varun Sethi
support On Tue, Jan 21, 2014 at 2:30 AM, Varun Sethi varun.se...@freescale.com wrote: -Original Message- From: Alex Williamson [mailto:alex.william...@redhat.com] Sent: Monday, January 20, 2014 9:51 PM To: Sethi Varun-B16395 Cc: iommu@lists.linux-foundation.org; linux-ker

RE: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Varun Sethi
/arm-smmu: Introduce iommu_group notifier block Hi Varun, Andreas, On Tue, Jan 21, 2014 at 05:48:02PM +, Varun Sethi wrote: +static int arm_smmu_group_notifier(struct notifier_block *nb, + unsigned long action, void *data) { + struct device *dev = data

RE: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Varun Sethi
/arm-smmu: Introduce iommu_group notifier block On Wed, Jan 22, 2014 at 01:54:11PM +, Varun Sethi wrote: Ok, so are you suggesting that we perform the isolation mapping in arm_smmu_add_device and drop the notifier altogether? I think that should be fine, until we want to delay

RE: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-21 Thread Varun Sethi
that for device isolation dma_base and size are fixed as 0 and SZ_128M at the moment. Additional patches will address this restriction and allow automatic growth of mapping size. Cc: Varun Sethi varun.se...@freescale.com Cc: Andreas Herrmann herrmann.der.u...@googlemail.com Signed-off-by: Andreas

RE: [RFC PATCH] vfio/iommu_type1: Multi-IOMMU domain support

2014-01-20 Thread Varun Sethi
-Original Message- From: Alex Williamson [mailto:alex.william...@redhat.com] Sent: Saturday, January 18, 2014 2:06 AM To: Sethi Varun-B16395 Cc: iommu@lists.linux-foundation.org; linux-ker...@vger.kernel.org Subject: [RFC PATCH] vfio/iommu_type1: Multi-IOMMU domain support RFC:

RE: [PATCH 02/11] iommu/arm-smmu: Introduce bus notifier block

2014-01-18 Thread Varun Sethi
-Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Andreas Herrmann Sent: Thursday, January 16, 2014 6:14 PM To: Will Deacon Cc: Andreas Herrmann; iommu@lists.linux-foundation.org; linux-arm-

[RFC][PATCH] Remove bus dependency for iommu_domain_alloc.

2014-01-17 Thread Varun Sethi
, that there is a single iommu for all bus types on the system. We maintain a list of bus types (for which iommu ops are registered). In the iommu_domain_alloc function we ensure that all bus types correspond to the same set of iommu operations. Signed-off-by: Varun Sethi varun.se...@freescale.com --- arch

RE: [PATCH] iommu/fsl_pamu: use physical cpu index to find the matched cpu nodes

2013-11-18 Thread Varun Sethi
For the DSP case again we have to set up the stash attribute. Are you saying that this should be a separate attribute? -Varun -Original Message- From: Wood Scott-B07421 Sent: Tuesday, November 19, 2013 1:07 AM To: Sethi Varun-B16395 Cc: Wang Haiying-R54964; j...@8bytes.org;

RE: [PATCH] iommu/fsl_pamu: use physical cpu index to find the matched cpu nodes

2013-11-18 Thread Varun Sethi
the matched cpu nodes On Mon, 2013-11-18 at 20:42 -0600, Varun Sethi wrote: For the DSP case again we have to set up the stash attribute. Are you saying that this should be a separate attribute? Not necessarily a separate attribute, but there should be some way to distinguish whether

RE: [PATCH] iommu/fsl_pamu: use physical cpu index to find the matched cpu nodes

2013-11-14 Thread Varun Sethi
Haiying/Scott, Forgot to mention this, the PAMU driver has to handle stash destination settings both for power and dsp cores (on B4 platform). For the dsp cores we would expect the physical core id (not controlled by Linux). To make the interface consistent, I would expect the caller (for

[PATCH 2/3 v2] iommu/fsl: Enable default DMA window for PCIe devices

2013-10-16 Thread Varun Sethi
corresponding to the device and subsequently enabling the PAMU table entry. Before we enable the entry, we ensure that the device's bus master capability is disabled (device quiesced). Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/fsl_pamu.c| 43

[PATCH 0/3 v2] iommu/fsl: PAMU driver fixes.

2013-10-16 Thread Varun Sethi
. The last patch adds the maintainer entry for the Freescale PAMU driver. Varun Sethi (3): iommu/fsl: Factor out PCI specific code. iommu/fsl: Enable default DMA window for PCIe devices once detached Add maintainers entry for the Freescale PAMU driver. MAINTAINERS |7

[PATCH 1/3 v2] iommu/fsl: Factor out PCI specific code.

2013-10-16 Thread Varun Sethi
Factor out PCI specific code in the PAMU driver. Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/fsl_pamu_domain.c | 88 +++ 1 file changed, 43 insertions(+), 45 deletions(-) diff --git a/drivers/iommu/fsl_pamu_domain.c b/drivers

[PATCH 2/3] iommu/fsl: Enable default DMA window for PCIe devices once detached

2013-10-12 Thread Varun Sethi
DMA window corresponding to the device and subsequently enabling the PAMU table entry. Before we enable the entry, we ensure that the device's bus master capability is disabled (device quiesced). Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/fsl_pamu.c| 43

[PATCH 0/3] iommu/fsl: PAMU driver fixes.

2013-10-12 Thread Varun Sethi
. The last patch adds the maintainer entry for the Freescale PAMU driver. Varun Sethi (3): iommu/fsl: Factor out PCI specific code. iommu/fsl: Enable default DMA window for PCIe devices once detached Add maintainers entry for the Freescale PAMU driver. MAINTAINERS |7

[PATCH 1/3] iommu/fsl: Factor out PCI specific code.

2013-10-12 Thread Varun Sethi
Factor out PCI specific code in the PAMU driver. Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/fsl_pamu_domain.c | 81 +++ 1 file changed, 40 insertions(+), 41 deletions(-) diff --git a/drivers/iommu/fsl_pamu_domain.c b/drivers

[PATCH 2/2] iommu/fsl: Enable default DMA window for PCIe devices once detached

2013-10-09 Thread Varun Sethi
corresponding to the device and subsequently enabling the PAMU table entry. Before we enable the entry, we ensure that the device's bus master capability is disabled (device quiesced). Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/fsl_pamu.c| 43

[PATCH 1/2 v15] iommu/fsl: Add additional iommu attributes required by the PAMU driver.

2013-04-24 Thread Varun Sethi
to check for PAMUV1 specific constraints. Signed-off-by: Varun Sethi varun.se...@freescale.com --- v15 changes: - Moved fsl_pamu_stash.h under arch/powerpc/include/asm. v14 changes: - Add FSL prefix to PAMU attributes. v13 changes: - created a new file include/linux/fsl_pamu_stash.h for stash attributes

[PATCH 1/3 v2] iommu: Move swap_pci_ref function to pci.h.

2013-04-22 Thread Varun Sethi
that the implementation can be shared across various IOMMU drivers. Signed-off-by: Varun Sethi varun.se...@freescale.com --- v2 changes: - created a new file drivers/iommu/pci.h. drivers/iommu/amd_iommu.c |7 +-- drivers/iommu/intel-iommu.c |7 +-- drivers/iommu/pci.h | 29

[PATCH 2/3 v14] iommu/fsl: Add additional iommu attributes required by the PAMU driver.

2013-04-22 Thread Varun Sethi
to check for PAMUV1 specific constraints. Signed-off-by: Varun Sethi varun.se...@freescale.com --- v14 changes: - Add FSL prefix to PAMU attributes. v13 changes: - created a new file include/linux/fsl_pamu_stash.h for stash attributes. v12 changes: - Moved PAMU specifc stash ids and structures to PAMU

  1   2   >