[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853520#comment-16853520 ] Danny Chan commented on CALCITE-2969: - Thanks [~rubenql], i would recheck the doc to see if i

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853085#comment-16853085 ] Ruben Quesada Lopez commented on CALCITE-2969: -- I think there's one small detail that we

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852065#comment-16852065 ] Julian Hyde commented on CALCITE-2969: -- There are a whole bunch of deprecation warnings. Generally

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851949#comment-16851949 ] Ruben Quesada Lopez commented on CALCITE-2969: -- Another belated +1 from me. Thanks

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851819#comment-16851819 ] Michael Mior commented on CALCITE-2969: --- A belated +1 from me. Thanks [~danny0405]! > Improve

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851455#comment-16851455 ] Danny Chan commented on CALCITE-2969: - Thanks so much for all your nice review comments 

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851365#comment-16851365 ] Haisheng Yuan commented on CALCITE-2969: Regarding

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851356#comment-16851356 ] Stamatis Zampetakis commented on CALCITE-2969: -- +1, apart from great work nothing more to

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851339#comment-16851339 ] Haisheng Yuan commented on CALCITE-2969: +1, I think it is good to go, except for small comment

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851327#comment-16851327 ] Julian Hyde commented on CALCITE-2969: -- +1 I think this change is ready to go in now (i.e. before

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850114#comment-16850114 ] Julian Hyde commented on CALCITE-2969: -- Yes. We have until Friday, right? I'm going to do a final

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849099#comment-16849099 ] Michael Mior commented on CALCITE-2969: --- [~julianhyde] Do you still think 1.20.0 should wait on

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842244#comment-16842244 ] Danny Chan commented on CALCITE-2969: - Thanks [~julianhyde] and [~zabetak], i think it is okey to

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842224#comment-16842224 ] Julian Hyde commented on CALCITE-2969: -- I agree with [~zabetak]. I am on vacation until Monday and

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842134#comment-16842134 ] Stamatis Zampetakis commented on CALCITE-2969: -- Thanks for the reminder [~danny0405]!

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841860#comment-16841860 ] Danny Chan commented on CALCITE-2969: - Thanks for all of your nice review comments [~julianhyde]

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829782#comment-16829782 ] Haisheng Yuan commented on CALCITE-2969: The PR in Github is stuffed with our comments, I will

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827538#comment-16827538 ] Danny Chan commented on CALCITE-2969: - [~zabetak] Thx so much for your suggestions, {quote}To sum

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827499#comment-16827499 ] Stamatis Zampetakis commented on CALCITE-2969: -- Thanks again for pushing this forward

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823651#comment-16823651 ] Danny Chan commented on CALCITE-2969: - [~julianhyde] Thanks for your review, i have made the

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823296#comment-16823296 ] Julian Hyde commented on CALCITE-2969: -- I have reviewed. This looks very promising, and I think we

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816820#comment-16816820 ] Danny Chan commented on CALCITE-2969: - [~hyuan] I also think so, so for the first PR, i almost

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816681#comment-16816681 ] Haisheng Yuan commented on CALCITE-2969: I was assuming this is just an umbrella issue and