[jira] [Closed] (CALCITE-3480) Special treatment for unordered child policy when trying to match a rule

2019-11-07 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan closed CALCITE-3480. - Resolution: Not A Problem Closing this as we find this bug is already fixed. We need to swtich to the

[jira] [Created] (CALCITE-3480) Special treatment for unordered child policy when trying to match a rule

2019-11-06 Thread Liya Fan (Jira)
Liya Fan created CALCITE-3480: - Summary: Special treatment for unordered child policy when trying to match a rule Key: CALCITE-3480 URL: https://issues.apache.org/jira/browse/CALCITE-3480 Project:

[jira] [Updated] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-02-26 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-3827: -- Description: In the current graph implementation, it takes O(1) time to find the out-edges of a

[jira] [Created] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-02-26 Thread Liya Fan (Jira)
Liya Fan created CALCITE-3827: - Summary: Reduce the time complexity of finding in-edges of a vertex in the graph Key: CALCITE-3827 URL: https://issues.apache.org/jira/browse/CALCITE-3827 Project: Calcite

[jira] [Commented] (CALCITE-3836) The hash codes of RelNodes are unreliable

2020-03-01 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048739#comment-17048739 ] Liya Fan commented on CALCITE-3836: --- [~zabetak] and [~julianhyde] Thanks a lot for your valuable

[jira] [Commented] (CALCITE-3836) The hash codes of RelNodes are unreliable

2020-03-05 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051944#comment-17051944 ] Liya Fan commented on CALCITE-3836: --- Hi all, thanks for the fruitful discussion. I have added a

[jira] [Commented] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-03-02 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049179#comment-17049179 ] Liya Fan commented on CALCITE-3827: --- [~julianhyde] and [~xndai], thanks a lot for your good comments.

[jira] [Commented] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-02-27 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047227#comment-17047227 ] Liya Fan commented on CALCITE-3827: --- > Im cautious about paying the extra cost. Thanks for your

[jira] [Created] (CALCITE-3836) The hash codes of RelNodes are unreliable

2020-02-27 Thread Liya Fan (Jira)
Liya Fan created CALCITE-3836: - Summary: The hash codes of RelNodes are unreliable Key: CALCITE-3836 URL: https://issues.apache.org/jira/browse/CALCITE-3836 Project: Calcite Issue Type: Bug

[jira] [Commented] (CALCITE-3836) The hash codes of RelNodes are unreliable

2020-02-28 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047324#comment-17047324 ] Liya Fan commented on CALCITE-3836: --- [~julianhyde] Sorry it did not directly say that hash code may

[jira] [Commented] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-03-02 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049849#comment-17049849 ] Liya Fan commented on CALCITE-3827: --- [~julianhyde] Thanks a lot for your effort for investigating the

[jira] [Commented] (CALCITE-3790) Make the URL of FileSource available

2020-02-13 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036688#comment-17036688 ] Liya Fan commented on CALCITE-3790: --- [~julianhyde] Thanks a lot for your kind reminder. The

[jira] [Created] (CALCITE-3790) Make the URL of FileSource available

2020-02-12 Thread Liya Fan (Jira)
Liya Fan created CALCITE-3790: - Summary: Make the URL of FileSource available Key: CALCITE-3790 URL: https://issues.apache.org/jira/browse/CALCITE-3790 Project: Calcite Issue Type: Bug

[jira] [Updated] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-11 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-3851: -- Summary: Replace the node importance map with a set for pruned nodes (was: Store nodes with zero

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-11 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057621#comment-17057621 ] Liya Fan commented on CALCITE-3851: --- [~Chunwei Lei][~hyuan] Thanks for your feedback. [~Chunwei Lei]

[jira] [Commented] (CALCITE-3851) Store nodes with zero importance with a set

2020-03-11 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057576#comment-17057576 ] Liya Fan commented on CALCITE-3851: --- [~julianhyde] Thanks a lot for your feedback. I think this

[jira] [Created] (CALCITE-3851) Store nodes with zero importance with a set

2020-03-10 Thread Liya Fan (Jira)
Liya Fan created CALCITE-3851: - Summary: Store nodes with zero importance with a set Key: CALCITE-3851 URL: https://issues.apache.org/jira/browse/CALCITE-3851 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-03-06 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053864#comment-17053864 ] Liya Fan commented on CALCITE-3827: --- [~julianhyde] Thanks a lot for the good suggestion. We added

[jira] [Commented] (CALCITE-3836) The hash codes of RelNodes are unreliable

2020-03-06 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053867#comment-17053867 ] Liya Fan commented on CALCITE-3836: --- [~julianhyde] Thanks a lot for the suggestion and the additional

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-13 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058495#comment-17058495 ] Liya Fan commented on CALCITE-3851: --- [~julianhyde] Thanks a lot for your valuable comments. We have

[jira] [Commented] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-04-08 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078899#comment-17078899 ] Liya Fan commented on CALCITE-3827: --- [~julianhyde] Thanks for the additional performance data. The

[jira] [Commented] (CALCITE-3910) Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin

2020-04-12 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082012#comment-17082012 ] Liya Fan commented on CALCITE-3910: --- [~Chunwei Lei] Thanks for opening this issue. It looks

[jira] [Assigned] (CALCITE-3910) Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin

2020-04-12 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan reassigned CALCITE-3910: - Assignee: Liya Fan > Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin >

[jira] [Commented] (CALCITE-3790) Make the URL of FileSource available

2020-04-17 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085634#comment-17085634 ] Liya Fan commented on CALCITE-3790: --- [~julianhyde] Test cases for both relative and absolute paths

[jira] [Created] (CALCITE-3901) Introduce an option to disable metadata handler regeneration

2020-04-08 Thread Liya Fan (Jira)
Liya Fan created CALCITE-3901: - Summary: Introduce an option to disable metadata handler regeneration Key: CALCITE-3901 URL: https://issues.apache.org/jira/browse/CALCITE-3901 Project: Calcite

[jira] [Comment Edited] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-03-26 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053864#comment-17053864 ] Liya Fan edited comment on CALCITE-3827 at 3/27/20, 4:21 AM: - [~julianhyde]

[jira] [Commented] (CALCITE-3872) Simplify expressions with unary minus

2020-03-26 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068237#comment-17068237 ] Liya Fan commented on CALCITE-3872: --- [~julianhyde] Thanks a lot for your kind reminder. I have

[jira] [Commented] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-03-29 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070642#comment-17070642 ] Liya Fan commented on CALCITE-3827: --- [~julianhyde] Thanks again for your attention. We set the

[jira] [Commented] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

2020-04-01 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073363#comment-17073363 ] Liya Fan commented on CALCITE-3891: --- Nice catch. [~hyuan] Do you have any idea what has caused the

[jira] [Commented] (CALCITE-3872) Simplify expressions with unary minus

2020-03-25 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066539#comment-17066539 ] Liya Fan commented on CALCITE-3872: --- [~donnyzone] Thanks for your comments. Calcite uses BigDecimal

[jira] [Created] (CALCITE-3872) Simplify expressions with unary minus

2020-03-25 Thread Liya Fan (Jira)
Liya Fan created CALCITE-3872: - Summary: Simplify expressions with unary minus Key: CALCITE-3872 URL: https://issues.apache.org/jira/browse/CALCITE-3872 Project: Calcite Issue Type: Improvement

[jira] [Updated] (CALCITE-3872) Simplify expressions with unary minus

2020-03-25 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-3872: -- Description: Support simplifying expression -(-( x ) ) as x. (was: Support simplifying expression

[jira] [Updated] (CALCITE-3872) Simplify expressions with unary minus

2020-03-25 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-3872: -- Description: Support simplifying expression - ( - ( x ) ) as x. (was: Support simplifying

[jira] [Updated] (CALCITE-3956) Unify comparison logic for RelOptCost

2020-04-24 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-3956: -- Description: Currently, comparisons between RelOptCost objects are based on 3 methods: 1. {{boolean

[jira] [Created] (CALCITE-3956) Unify comparison logic for RelOptCost

2020-04-24 Thread Liya Fan (Jira)
Liya Fan created CALCITE-3956: - Summary: Unify comparison logic for RelOptCost Key: CALCITE-3956 URL: https://issues.apache.org/jira/browse/CALCITE-3956 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-3956) Unify comparison logic for RelOptCost

2020-04-25 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092449#comment-17092449 ] Liya Fan commented on CALCITE-3956: --- [~julianhyde] Thanks a lot for your quick response. IMO,

[jira] [Commented] (CALCITE-3956) Unify comparison logic for RelOptCost

2020-04-26 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092936#comment-17092936 ] Liya Fan commented on CALCITE-3956: --- [~julianhyde] Thanks again for your further feedback. I agree

[jira] [Comment Edited] (CALCITE-3956) Unify comparison logic for RelOptCost

2020-04-28 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094451#comment-17094451 ] Liya Fan edited comment on CALCITE-3956 at 4/28/20, 12:12 PM: -- How about

[jira] [Commented] (CALCITE-3956) Unify comparison logic for RelOptCost

2020-04-28 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094451#comment-17094451 ] Liya Fan commented on CALCITE-3956: --- How about making the comparison method return an enum? {{enum

[jira] [Commented] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-04-29 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096051#comment-17096051 ] Liya Fan commented on CALCITE-3827: --- [~julianhyde] Thanks a lot for your effort, and thank you all

[jira] [Commented] (CALCITE-3956) Unify comparison logic for RelOptCost

2020-04-29 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096050#comment-17096050 ] Liya Fan commented on CALCITE-3956: --- Sure. I agree with you that the combined method will be more

[jira] [Commented] (CALCITE-3836) The hash codes of RelNodes are unreliable

2020-04-29 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096113#comment-17096113 ] Liya Fan commented on CALCITE-3836: --- According to all the discussions, it seems there is not enough

[jira] [Commented] (CALCITE-3836) The hash codes of RelNodes are unreliable

2020-05-07 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101535#comment-17101535 ] Liya Fan commented on CALCITE-3836: --- Closing this issue. Thanks a lot for the fruitful discussions

[jira] [Closed] (CALCITE-3836) The hash codes of RelNodes are unreliable

2020-05-07 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan closed CALCITE-3836. - Resolution: Not A Problem > The hash codes of RelNodes are unreliable >

[jira] [Commented] (CALCITE-3956) Unify comparison logic for RelOptCost

2020-05-07 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101532#comment-17101532 ] Liya Fan commented on CALCITE-3956: --- I have updated the PR. Would you please take a look. In the

[jira] [Created] (CALCITE-3976) Generify the DefaultEdge class

2020-05-07 Thread Liya Fan (Jira)
Liya Fan created CALCITE-3976: - Summary: Generify the DefaultEdge class Key: CALCITE-3976 URL: https://issues.apache.org/jira/browse/CALCITE-3976 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-3976) Generify the DefaultEdge class

2020-05-10 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104003#comment-17104003 ] Liya Fan commented on CALCITE-3976: --- The PR is here: https://github.com/apache/calcite/pull/1963

[jira] [Commented] (CALCITE-3976) Generify the DefaultEdge class

2020-05-09 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103166#comment-17103166 ] Liya Fan commented on CALCITE-3976: --- [~julianhyde] Sounds good. Thanks for your feedback. I have

[jira] [Commented] (CALCITE-3956) Unify comparison logic for RelOptCost

2020-05-09 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103185#comment-17103185 ] Liya Fan commented on CALCITE-3956: --- Thanks a lot for your feedback. > I'm dubious about this

[jira] [Updated] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-02 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4197: -- Attachment: screenshot-5.png > Provide utility to visualize RelNode plans >

[jira] [Commented] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-02 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189151#comment-17189151 ] Liya Fan commented on CALCITE-4197: --- New screen shots after accepting [~danny0405] and [~Chunwei

[jira] [Updated] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-02 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4197: -- Attachment: screenshot-4.png > Provide utility to visualize RelNode plans >

[jira] [Comment Edited] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-01 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188307#comment-17188307 ] Liya Fan edited comment on CALCITE-4197 at 9/1/20, 9:38 AM: To make it

[jira] [Updated] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-01 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4197: -- Attachment: screenshot-1.png > Provide utility to visualize RelNode plans >

[jira] [Updated] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-01 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4197: -- Attachment: screenshot-2.png > Provide utility to visualize RelNode plans >

[jira] [Updated] (CALCITE-4241) Some improvements to metadata query

2020-09-11 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4241: -- Description: # For {{RelMdColumnUniqueness#areColumnsUnique(RelSubset, RelMetadataQuery,

[jira] [Updated] (CALCITE-4241) Some improvements to metadata query

2020-09-10 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4241: -- Description: # For {{RelMdColumnUniqueness#areColumnsUnique(RelSubset, RelMetadataQuery,

[jira] [Created] (CALCITE-4241) Some improvements to metadata query

2020-09-10 Thread Liya Fan (Jira)
Liya Fan created CALCITE-4241: - Summary: Some improvements to metadata query Key: CALCITE-4241 URL: https://issues.apache.org/jira/browse/CALCITE-4241 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-4155) Simplify IN expression of discrete values

2020-09-15 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196623#comment-17196623 ] Liya Fan commented on CALCITE-4155: --- Since we have supported Sarg (in CALCITE-4173), the problem

[jira] [Commented] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-02 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189838#comment-17189838 ] Liya Fan commented on CALCITE-4197: --- [~julianhyde][~danny0405] Thanks for your feedback. Your

[jira] [Updated] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-03 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4197: -- Attachment: screenshot-6.png > Provide utility to visualize RelNode plans >

[jira] [Updated] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-03 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4197: -- Attachment: screenshot-7.png > Provide utility to visualize RelNode plans >

[jira] [Commented] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-03 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190007#comment-17190007 ] Liya Fan commented on CALCITE-4197: --- New screen shots after accepting [~julianhyde] and

[jira] [Updated] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-01 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4197: -- Attachment: screenshot-3.png > Provide utility to visualize RelNode plans >

[jira] [Commented] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-01 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188419#comment-17188419 ] Liya Fan commented on CALCITE-4197: --- [~danny0405] Thank you for your feedback. I am not sure if I

[jira] [Created] (CALCITE-4322) Inconsistent parameter types for splittable agg function

2020-10-09 Thread Liya Fan (Jira)
Liya Fan created CALCITE-4322: - Summary: Inconsistent parameter types for splittable agg function Key: CALCITE-4322 URL: https://issues.apache.org/jira/browse/CALCITE-4322 Project: Calcite Issue

[jira] [Created] (CALCITE-4342) More aggregate functions should be marked as splittable and duplicate-insensitive

2020-10-16 Thread Liya Fan (Jira)
Liya Fan created CALCITE-4342: - Summary: More aggregate functions should be marked as splittable and duplicate-insensitive Key: CALCITE-4342 URL: https://issues.apache.org/jira/browse/CALCITE-4342

[jira] [Commented] (CALCITE-4342) More aggregate functions should be marked as splittable and ignore distinct optionality

2020-10-18 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216403#comment-17216403 ] Liya Fan commented on CALCITE-4342: --- [~julianhyde] Thanks a lot for your feedback. I have changed the

[jira] [Updated] (CALCITE-4342) More aggregate functions should be marked as splittable and ignore distinct optionality

2020-10-18 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4342: -- Description: As discussed in the mailing list, there are more aggregate functions (e.g.

[jira] [Updated] (CALCITE-4342) More aggregate functions should be marked as splittable and ignore distinct optionality

2020-10-18 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4342: -- Summary: More aggregate functions should be marked as splittable and ignore distinct optionality

[jira] [Commented] (CALCITE-4322) Inconsistent parameter types for splittable agg function

2020-10-09 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211516#comment-17211516 ] Liya Fan commented on CALCITE-4322: --- [~liupengcheng] Thanks for your attention. Please let me

[jira] [Updated] (CALCITE-4322) Inconsistent parameter types for splittable agg function

2020-10-09 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4322: -- Attachment: image-2020-10-10-10-36-50-697.png > Inconsistent parameter types for splittable agg

[jira] [Updated] (CALCITE-4322) Inconsistent parameter types for splittable agg function

2020-10-09 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4322: -- Attachment: image-2020-10-10-10-34-37-193.png > Inconsistent parameter types for splittable agg

[jira] [Commented] (CALCITE-4191) Improve the logic of creating aggregate calls

2020-08-25 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183808#comment-17183808 ] Liya Fan commented on CALCITE-4191: --- Thanks for your kind reminder. My example above is not a good

[jira] [Commented] (CALCITE-4191) Improve the logic of creating aggregate calls

2020-08-25 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183776#comment-17183776 ] Liya Fan commented on CALCITE-4191: --- [~julianhyde] Thanks for your kind reminder. Sorry I forgot to

[jira] [Commented] (CALCITE-4191) Improve the logic of creating aggregate calls

2020-08-25 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183868#comment-17183868 ] Liya Fan commented on CALCITE-4191: --- Sure. I see. > Improve the logic of creating aggregate calls >

[jira] [Commented] (CALCITE-4191) Improve the logic of creating aggregate calls

2020-08-26 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185096#comment-17185096 ] Liya Fan commented on CALCITE-4191: --- [~Chunwei Lei] Thanks for your feedback. It seems the indirect

[jira] [Commented] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-08-28 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186450#comment-17186450 ] Liya Fan commented on CALCITE-4197: --- [~zabetak] Sounds reasonable. Thanks for your feedback and

[jira] [Created] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-08-27 Thread Liya Fan (Jira)
Liya Fan created CALCITE-4197: - Summary: Provide utility to visualize RelNode plans Key: CALCITE-4197 URL: https://issues.apache.org/jira/browse/CALCITE-4197 Project: Calcite Issue Type: New

[jira] [Commented] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-08-27 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186233#comment-17186233 ] Liya Fan commented on CALCITE-4197: --- [~amaliujia] I think we can use it to dump any plan, including

[jira] [Created] (CALCITE-4191) Improve the logic of creating aggregate calls

2020-08-24 Thread Liya Fan (Jira)
Liya Fan created CALCITE-4191: - Summary: Improve the logic of creating aggregate calls Key: CALCITE-4191 URL: https://issues.apache.org/jira/browse/CALCITE-4191 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-4287) Fix the bug in checking aggregate input references in AggregateJoinRemoveRule

2020-09-27 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202952#comment-17202952 ] Liya Fan commented on CALCITE-4287: --- Done. Thank you for the kind reminder.  > Fix the bug in

[jira] [Updated] (CALCITE-4287) Fix the bug in checking aggregate input references in some rules

2020-09-27 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4287: -- Summary: Fix the bug in checking aggregate input references in some rules (was: Fix the bug in

[jira] [Updated] (CALCITE-4287) Fix the bug in checking aggregate input references in some rules

2020-09-27 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4287: -- Description: In some rules (e.g. {{AggregateJoinRemoveRule#onMatch)}}, the logic of checking if the

[jira] [Updated] (CALCITE-4287) Fix the bug in checking aggregate input references in AggregateJoinRemoveRule

2020-09-27 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4287: -- Summary: Fix the bug in checking aggregate input references in AggregateJoinRemoveRule (was: Fix a

[jira] [Commented] (CALCITE-4287) AggregateJoinRemoveRule and ProjectJoinRemoveRule are not fired if the last column of the join's left input is referenced

2020-09-28 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203102#comment-17203102 ] Liya Fan commented on CALCITE-4287: --- [~rubenql] Thanks for your for your good suggestion. The title

[jira] [Commented] (CALCITE-4287) The logic of checking aggregate input references is incorrect in some rules

2020-09-28 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203081#comment-17203081 ] Liya Fan commented on CALCITE-4287: --- [~julianhyde] [~rubenql] I have updated the Jira title and

[jira] [Updated] (CALCITE-4287) AggregateJoinRemoveRule and ProjectJoinRemoveRule are not fired if the last column of the join's left input is referenced

2020-09-28 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4287: -- Summary: AggregateJoinRemoveRule and ProjectJoinRemoveRule are not fired if the last column of the

[jira] [Updated] (CALCITE-4287) The logic of checking aggregate input references is incorrect in some rules

2020-09-28 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4287: -- Summary: The logic of checking aggregate input references is incorrect in some rules (was: Fix the

[jira] [Updated] (CALCITE-4287) Fix a bug in AggregateJoinRemoveRule

2020-09-27 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-4287: -- Description: In {{AggregateJoinRemoveRule#onMatch}}, the logic of checking if the aggregate

[jira] [Created] (CALCITE-4287) Fix a bug in AggregateJoinRemoveRule

2020-09-27 Thread Liya Fan (Jira)
Liya Fan created CALCITE-4287: - Summary: Fix a bug in AggregateJoinRemoveRule Key: CALCITE-4287 URL: https://issues.apache.org/jira/browse/CALCITE-4287 Project: Calcite Issue Type: Bug

[jira] [Commented] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-16 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197365#comment-17197365 ] Liya Fan commented on CALCITE-4197: --- To make discussions clearer, I have opened another issue

[jira] [Commented] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-16 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197327#comment-17197327 ] Liya Fan commented on CALCITE-4197: --- [~julianhyde] Please don't worry. I will provide a follow-up PR

[jira] [Created] (CALCITE-4260) Support plan explain with dot format

2020-09-16 Thread Liya Fan (Jira)
Liya Fan created CALCITE-4260: - Summary: Support plan explain with dot format Key: CALCITE-4260 URL: https://issues.apache.org/jira/browse/CALCITE-4260 Project: Calcite Issue Type: Task

[jira] [Resolved] (CALCITE-4241) Some improvements to metadata query

2020-09-21 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan resolved CALCITE-4241. --- Resolution: Fixed > Some improvements to metadata query > --- > >

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-21 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199349#comment-17199349 ] Liya Fan commented on CALCITE-4223: --- IMHO, I like the idea of a quick path for some important table

[jira] [Commented] (CALCITE-4351) RelMdUtil#numDistinctVals always returns 0 for large inputs

2020-10-23 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219564#comment-17219564 ] Liya Fan commented on CALCITE-4351: --- [~TsReaper] Thanks for reporting the problem. The solution of

[jira] [Commented] (CALCITE-4350) The reverse operation of collation direction is overly relaxed

2020-10-25 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220442#comment-17220442 ] Liya Fan commented on CALCITE-4350: --- [~julianhyde] Thanks a lot for your feedback. I have prepared a

[jira] [Created] (CALCITE-4350) The reverse operation of collation direction is overly relaxed

2020-10-23 Thread Liya Fan (Jira)
Liya Fan created CALCITE-4350: - Summary: The reverse operation of collation direction is overly relaxed Key: CALCITE-4350 URL: https://issues.apache.org/jira/browse/CALCITE-4350 Project: Calcite

[jira] [Commented] (CALCITE-4126) Stackoverflow error when applying JoinCommuteRule

2020-07-22 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162608#comment-17162608 ] Liya Fan commented on CALCITE-4126: --- [~hyuan] Is this issue intended for pick-up? > Stackoverflow

  1   2   3   >