GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1432
[WIP][CARBONDATA-1608]Support Column Comment for Create Table
add column comment during carbon create table and when table is described
if comment is not mentioned, default comment
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1500
@ravipesala @jackylk please review
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1500
@QiangCai please review
---
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1500
[WIP]Remove spark broadcast for gettting hadoop configurations
why?
with the new conf set in hadoop conf, after broadcast conf will not get
reflected, hence these changes
Be sure
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1567
retest this please
---
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1567
[CARBONDATA-1809]Add create table event
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [*] Any interfaces changed
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1608
@ravipesala handled comments please review
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1610
retest this please
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1610
@ravipesala i have added test case for both scenario
---
Github user akashrn5 closed the pull request at:
https://github.com/apache/carbondata/pull/1438
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1682
retest this please
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1682
retest sdv please
---
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1688
[CARBONDATA-1916]Correct the database location path during carbon drop
database
Correct the database location path during carbon drop database
when drop database is called, to delete
Github user akashrn5 closed the pull request at:
https://github.com/apache/carbondata/pull/1687
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1688
retest sdv please
---
Github user akashrn5 closed the pull request at:
https://github.com/apache/carbondata/pull/1506
---
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1524
[CARBONDATA-1762] Remove existing column level dateformat and support
dateformat, timestampformat in the load option
(1) Remove column level dateformat option
(2) Support dateformat
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1512
@xubo245 this change is already being handled in #1507
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1435#discussion_r151421484
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -606,4 +609,53 @@ public static FileSystem
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1432#discussion_r150883724
--- Diff:
integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/booleantype/BooleanDataTypesInsertTest.scala
---
@@ -945,4 +948,41
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1506
[CARBONDATA-1734] Ignore empty line while reading CSV
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1507
[CARBONDATA-1326] Fixed high priority findbug issue
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1432#discussion_r151345870
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/CarbonDescribeFormattedCommand.scala
---
@@ -65,6 +65,7 @@ private
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1500
retest this please
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1500
retest sdv pleaase
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1438
@jackylk handled your comment, please review
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1438#discussion_r151332421
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/LoadTableCommand.scala
---
@@ -186,6 +186,12 @@ case
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1435#discussion_r148957017
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1376,6 +1376,32 @@
public static
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1608
[CARBONDATA-1761]do not change status of segment to marked for delete if it
is in progress
do not change status of segment to marked for delete if it is in progress
Be sure to do all
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1610
[CARBONDATA-1879]do not drop the table if the load, insert or insert
overwrite is in progress
do not drop the table if the load, insert or insert overwrite is in progress
Be sure
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1610#discussion_r155435306
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/concurrent/TestLoadTableConcurrentScenario.scala
Github user akashrn5 closed the pull request at:
https://github.com/apache/carbondata/pull/1567
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1627
retest sdv please
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1610
retest this please
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1637
retest this please
---
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1637
[CARBONDATA-1876]clean all the InProgress segments for all databases during
session initialization
clean all the InProgress segments for all databases during session
initialization
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1627
retest this please
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1615
handled comment, plesae review @jackylk
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1608
retest this please
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1615#discussion_r155253089
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/events/CreateTableEvents.scala
---
@@ -20,14 +20,16 @@ package
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1615
[CARBONDATA-1592]added new parameters for create and load events
added new parameters for create and load events, which will help for some
specific validations on table during create and load
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1608
retest this please
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1615#discussion_r155267087
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -148,7 +148,9
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1627
[CARBONDATA-1759]make visibility of segments as false eventhough file is
not present To take care show segments after clean files operation
make visibility of segments as false eventhough
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1432
@manishgupta88 please review
---
Github user akashrn5 closed the pull request at:
https://github.com/apache/carbondata/pull/1682
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1682#discussion_r158022056
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/UpdateCarbonTableTestCase.scala
---
@@ -569,6
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/2269
[WIP][LUCENE]close the lucene index reader after every task and clean the
resource and other functional issues
Be sure to do all of the following checklist to help us incorporate
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2269#discussion_r186694695
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/AbstractDataMapJob.java
---
@@ -36,7 +36,7 @@
}
@Override public
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2269#discussion_r186694178
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java
---
@@ -302,9 +302,20 @@ public boolean
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2269#discussion_r186724944
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/DistributableDataMapFormat.java
---
@@ -100,14 +103,18 @@ private static
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/2310
[WIP]refactor distributable code and lauch job to clear the segmentmap and
cache from executor
Be sure to do all of the following checklist to help us incorporate
your contribution
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2310
retest this please
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2310#discussion_r19978
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapUtil.java ---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2310#discussion_r188869927
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapUtil.java ---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2310
retest this please
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2215#discussion_r189227705
--- Diff: docs/datamap/lucene-datamap-guide.md ---
@@ -0,0 +1,213 @@
+# CarbonData Lucene DataMap
+
+* [Quick Example](#quick-example
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2215#discussion_r189228188
--- Diff: docs/datamap/lucene-datamap-guide.md ---
@@ -0,0 +1,213 @@
+# CarbonData Lucene DataMap
+
+* [Quick Example](#quick-example
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2215
@chenliang613 please review and merge
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2321
retest sdv please
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2321
retest this please
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2269#discussion_r189267374
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/DistributableDataMapFormat.java
---
@@ -100,14 +103,18 @@ private static
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/2321
[WIP]clean and close datamap writers on any task failure during load
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2310#discussion_r188847767
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapUtil.java ---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2215
@xuchuanyin and @jackylk please review
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2215#discussion_r189507649
--- Diff: docs/datamap/lucene-datamap-guide.md ---
@@ -0,0 +1,133 @@
+# CarbonData Lucene DataMap (Alpha feature in 1.4.0)
+
+* [DataMap
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/2375
[CARBONDATA-2585][CARBONDATA-2586][Local Dictionary]Support adding local
dictionary configuration in create table statement and show the configs in
describe formatted table
## What changes
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2321
retest this please
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2321
retest sdv please
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2321#discussion_r191123185
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -85,8 +86,9 @@ public
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2321#discussion_r191151271
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/AbstractDataLoadProcessorStep.java
---
@@ -149,6 +153,22 @@ protected
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2422#discussion_r199402195
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
---
@@ -299,17 +303,112
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2422#discussion_r199402754
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
---
@@ -440,7 +544,7 @@ class
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2422#discussion_r199401982
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
---
@@ -278,14 +282,14
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2422#discussion_r199402608
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
---
@@ -391,7 +495,7 @@ object
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2422#discussion_r199402356
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
---
@@ -341,7 +445,7 @@ class
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2422#discussion_r199402465
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
---
@@ -318,6 +417,11 @@ class
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2422#discussion_r199402302
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
---
@@ -299,17 +303,112
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2404#discussion_r197816298
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/TestDataMapCommand.scala
---
@@ -204,6 +204,37
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2401
retest this please
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2404#discussion_r197682680
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/TestDataMapCommand.scala
---
@@ -204,6 +204,37
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2404#discussion_r197682568
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/TestDataMapCommand.scala
---
@@ -204,6 +204,37
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2402#discussion_r197604074
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -482,7 +482,7 @@ public String
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2402#discussion_r197602851
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/blocklet/BlockletEncodedColumnPage.java
---
@@ -0,0 +1,187
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2402#discussion_r197603140
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/blocklet/BlockletEncodedColumnPage.java
---
@@ -0,0 +1,187
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2402#discussion_r197602985
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/blocklet/BlockletEncodedColumnPage.java
---
@@ -0,0 +1,187
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2402#discussion_r197603924
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
---
@@ -0,0 +1,319 @@
+/*
+ * Licensed
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2402#discussion_r197604250
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/util/ExampleUtils.scala
---
@@ -96,8 +96,8 @@ object ExampleUtils
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2402#discussion_r197604461
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
@@ -104,19 +105,27
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/2401
[CARBONDATA-2585][CARBONDATA-2586][Local Dictionary]Local dictionary
support for alter table, preaggregate and varchar datatype
What changes were proposed in this pull request?
In this PR
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2377
LGTM
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2401#discussion_r198441455
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3041,24 +3041,30 @@ public static String
getBlockId
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2401#discussion_r198443241
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
---
@@ -615,4 +618,114 @@ object
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2401#discussion_r198443925
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
---
@@ -615,4 +618,114 @@ object
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2395
@xuchuanyin please review it again, and then we can take this fix
---
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/2424
[CARBONDATA-2587][CARBONDATA-2588]added test cases for local dictioanry
load support
**What changes are proposed in this PR**
test cases are added for local dictionary load support. All
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/2202
retest this please
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1432
@jackylk please review
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1438
@ravipesala @gvramana @QiangCai @manishgupta88 please review this PR
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1435
@gvramana please review
---
1 - 100 of 377 matches
Mail list logo
