Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157133238
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -18,22 +18,311 @@
package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157133369
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -18,22 +18,311 @@
package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157133386
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -18,22 +18,311 @@
package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157136520
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -18,22 +18,311 @@
package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157136710
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -18,22 +18,311 @@
package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157137239
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/iterator/CarbonOutputIteratorWrapper.java
---
@@ -0,0 +1,118
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157137510
--- Diff:
hadoop/src/test/java/org/apache/carbondata/hadoop/ft/CarbonOutputMapperTest.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157137503
--- Diff:
hadoop/src/test/java/org/apache/carbondata/hadoop/ft/CarbonOutputMapperTest.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157137538
--- Diff:
hadoop/src/test/java/org/apache/carbondata/hadoop/ft/CarbonOutputMapperTest.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157137633
--- Diff:
hadoop/src/test/java/org/apache/carbondata/hadoop/ft/CarbonOutputMapperTest.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157137798
--- Diff:
hadoop/src/test/java/org/apache/carbondata/hadoop/ft/CarbonOutputMapperTest.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157137958
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157138219
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -18,22 +18,311 @@
package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157138255
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -18,22 +18,311 @@
package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157138236
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -18,22 +18,311 @@
package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157138376
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -18,22 +18,311 @@
package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157138950
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/iterator/CarbonOutputIteratorWrapper.java
---
@@ -0,0 +1,118
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157139051
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/iterator/CarbonOutputIteratorWrapper.java
---
@@ -0,0 +1,118
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157139216
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -329,6 +329,47 @@ public static String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157139961
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -329,6 +329,47 @@ public static String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157140010
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/iterator/CarbonOutputIteratorWrapper.java
---
@@ -0,0 +1,118
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157140055
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/iterator/CarbonOutputIteratorWrapper.java
---
@@ -0,0 +1,118
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1654
@ravipesala This PR implements Hive dynamic partition. Load into static
partition is still pending?
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1654#discussion_r157148797
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/PartitionFileStore.java
---
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1654#discussion_r157148902
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/PartitionFileStore.java
---
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1654#discussion_r157149342
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/partition/PartitionType.java
---
@@ -23,5 +23,6 @@
RANGE
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1654#discussion_r157149579
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -573,6 +574,11 @@ public boolean
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157150591
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/EscapeSequences.java
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157150632
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/EscapeSequences.java
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157151580
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157151611
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157151644
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157151775
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157152181
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -649,6 +650,25 @@ object CommonUtil
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157152320
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -649,6 +650,25 @@ object CommonUtil
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1641#discussion_r157155410
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -505,7 +516,11 @@ object
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157339584
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -1394,20 +1394,20 @@ public static String printLine(String a, int
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157339661
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoCommand.scala
---
@@ -40,7 +41,11
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157339670
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -316,16 +332,35
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157339682
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -345,23 +380,172
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157339685
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -345,23 +380,172
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157339790
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -345,23 +380,172
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157339822
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/CarbonFileFormat.scala
---
@@ -0,0 +1,228
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157339835
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/CarbonFileFormat.scala
---
@@ -0,0 +1,228
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157355991
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableAsSelectCommand.scala
---
@@ -0,0 +1,86
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157356007
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableAsSelectCommand.scala
---
@@ -0,0 +1,86
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157356072
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableAsSelectCommand.scala
---
@@ -0,0 +1,86
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157356062
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableAsSelectCommand.scala
---
@@ -0,0 +1,86
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157356091
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -528,4 +529,46 @@ class CarbonFileMetastore
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157356103
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -528,4 +529,46 @@ class CarbonFileMetastore
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157356121
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetaStore.scala
---
@@ -144,6 +145,15 @@ trait CarbonMetaStore
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157356131
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetaStore.scala
---
@@ -144,6 +145,15 @@ trait CarbonMetaStore
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157356143
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
@@ -210,13 +211,40 @@ class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157356168
--- Diff: integration/spark2/src/main/spark2.2/CarbonSessionState.scala ---
@@ -280,25 +280,26 @@ class CarbonOptimizer
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157356181
--- Diff: integration/spark2/src/main/spark2.1/CarbonSessionState.scala ---
@@ -259,25 +259,26 @@ object CarbonOptimizerUtil
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157356189
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetaStore.scala
---
@@ -144,6 +145,15 @@ trait CarbonMetaStore
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1642#discussion_r157356282
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -18,22 +18,342 @@
package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1669#discussion_r157356331
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1277,6 +1277,10 @@
public static final
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1669#discussion_r157356347
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala
---
@@ -49,29 +59,21 @@ object
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1669#discussion_r157356369
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala
---
@@ -160,4 +162,112
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1669#discussion_r157356409
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/package.scala
---
@@ -0,0 +1,25 @@
+/*
+ * Licensed
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1666#discussion_r157356451
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/LoadMetadataDetails.java
---
@@ -241,26 +248,28 @@ private long
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1657
LGTM
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1670#discussion_r157356774
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataretention/ConcurrencyTest.scala
---
@@ -0,0 +1,309
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1642
LGTM
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1654
LGTM
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1666#discussion_r157420112
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/LoadMetadataDetails.java
---
@@ -211,25 +234,32 @@ public long
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1666#discussion_r157420051
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/LoadMetadataDetails.java
---
@@ -241,26 +248,28 @@ private long
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1666#discussion_r157420301
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/LoadMetadataDetails.java
---
@@ -211,25 +234,32 @@ public long
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1559
LGTM
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1654#discussion_r157426573
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/CarbonFileFormat.scala
---
@@ -0,0 +1,247
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1654#discussion_r157426782
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/CarbonFileFormat.scala
---
@@ -0,0 +1,247
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1654#discussion_r157427128
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/CarbonFileFormat.scala
---
@@ -0,0 +1,247
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1654
retest this please
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157473214
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
@@ -210,13 +208,40 @@ class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1668#discussion_r157477612
--- Diff: docs/data-management-on-carbondata.md ---
@@ -355,6 +355,12 @@ This tutorial is going to introduce all commands and
data operations on
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157646660
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
---
@@ -152,6 +154,22 @@ object
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157646748
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -479,22 +479,52
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157646893
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -479,22 +479,52
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157647527
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -445,13 +447,11
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157649340
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -445,13 +447,11
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157649569
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
---
@@ -130,6 +130,35 @@ private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157649480
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/CarbonFileFormat.scala
---
@@ -98,6 +97,8 @@ with Serializable
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157652020
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
---
@@ -313,8 +330,9 @@ private[sql
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157652034
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
---
@@ -313,8 +330,9 @@ private[sql
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157652168
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
---
@@ -395,4 +391,14 @@ object CarbonFilters
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157652296
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
---
@@ -395,4 +391,14 @@ object CarbonFilters
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1665
LGTM, thanks for working on this
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1674#discussion_r157675550
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
@@ -42,6 +42,17 @@
*/
List prune(FilterResolverIntf
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1674#discussion_r157675599
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
@@ -42,6 +42,17 @@
*/
List prune(FilterResolverIntf
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1674#discussion_r157675696
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
---
@@ -71,12 +72,14 @@ public BlockletDataMap
get
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1674#discussion_r157676422
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
---
@@ -102,18 +105,26 @@ public BlockletDataMap
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1674#discussion_r157677188
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -379,10 +397,21 @@ private void
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1674#discussion_r157677564
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -491,6 +520,23 @@ public boolean
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1674#discussion_r157678533
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapModel.java
---
@@ -16,18 +16,35
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1597
please close this PR if not required anymore @kunal642
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1672
LGTM
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157702204
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
---
@@ -146,27 +184,13 @@ private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157702403
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
---
@@ -130,6 +130,44 @@ private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157703591
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
---
@@ -130,6 +130,44 @@ private
801 - 900 of 3249 matches
Mail list logo
