[GitHub] carbondata issue #2778: [CARBONDATA-2980][BloomDataMap] Fix bug in clearing ...

2018-09-30 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2778 LGTM ---

[GitHub] carbondata issue #2778: [CARBONDATA-2980][BloomDataMap] Fix bug in clearing ...

2018-09-28 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2778 @xuchuanyin .`CarbonLRUCache` instance is one per JVM but cache implementation is different for different purpose like we have separate cache provider implementation for blockDataMap

[GitHub] carbondata issue #2778: [CARBONDATA-2980][BloomDataMap] Fix bug in clearing ...

2018-09-28 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2778 @xuchuanyin ...I think this PR changes are not correct...you are calling `lruCache.clear()` which will clear the complete LRU cache mapthat means all the entries for all the tables

[GitHub] carbondata pull request #2774: [CARBONDATA-2979] select count fails when car...

2018-09-27 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2774 [CARBONDATA-2979] select count fails when carbondata file is written through SDK and read through sparkfileformat for complex datatype map(struct->array->map) **Problem**

[GitHub] carbondata issue #2758: [CARBONDATA-2972] Debug Logs and function added for ...

2018-09-27 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2758 LGTM ---

[GitHub] carbondata issue #2766: [CARBONDATA-2973] Added documentation for fallback c...

2018-09-26 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2766 LGTM ---

[GitHub] carbondata pull request #2758: [CARBONDATA-2972] Debug Logs and function add...

2018-09-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2758#discussion_r220531471 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java --- @@ -78,6 +78,13 @@ public DataType

[GitHub] carbondata pull request #2759: [HOTFIX] Fix NPE in LRU cache when entry from...

2018-09-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2759#discussion_r220505034 --- Diff: core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java --- @@ -182,10 +224,15 @@ public long getUsableMemory

[GitHub] carbondata pull request #2759: [HOTFIX] Fix NPE in LRU cache when entry from...

2018-09-25 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2759 [HOTFIX] Fix NPE in LRU cache when entry from the same table is getting evicted to load another entry from same table **Problem** When driver LRU cache size is configured to a small

[GitHub] carbondata issue #2654: [CARBONDATA-2896] Adaptive Encoding for Primitive da...

2018-09-18 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2654 LGTM ---

[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2725 @xuchuanyin ...please check my reply on the mailing list http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Optimizing-the-writing-of-min-max

[GitHub] carbondata pull request #2725: [CARBONDATA-2942] Add read and write support ...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2725#discussion_r218298762 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1831,6 +1831,16 @@ public

[GitHub] carbondata pull request #2725: [CARBONDATA-2942] Add read and write support ...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2725#discussion_r218298776 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/DataRefNode.java --- @@ -125,4 +125,12 @@ DimensionRawColumnChunk

[GitHub] carbondata pull request #2725: [CARBONDATA-2942] Add read and write support ...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2725#discussion_r218298749 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapRowIndexes.java --- @@ -40,12 +40,14

[GitHub] carbondata issue #2725: [CARBONDATA-2942] Add read and write support for wri...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2725 @ravipesala ..Fixed review comments. Kindly review ---

[GitHub] carbondata pull request #2725: [CARBONDATA-2942] Add read and write support ...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2725#discussion_r218139529 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/DataRefNode.java --- @@ -125,4 +125,12 @@ DimensionRawColumnChunk

[GitHub] carbondata pull request #2725: [CARBONDATA-2942] Add read and write support ...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2725#discussion_r218139409 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java --- @@ -194,9 +198,12

[GitHub] carbondata pull request #2725: [CARBONDATA-2942] Add read and write support ...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2725#discussion_r218139494 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataRefNode.java --- @@ -133,6 +134,21

[GitHub] carbondata pull request #2725: [CARBONDATA-2942] Add read and write support ...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2725#discussion_r218139378 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java --- @@ -122,11 +122,11 @@ public boolean

[GitHub] carbondata pull request #2725: [CARBONDATA-2942] Add read and write support ...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2725#discussion_r218139444 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java --- @@ -108,10 +108,13 @@ public

[GitHub] carbondata pull request #2725: [CARBONDATA-2942] Add read and write support ...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2725#discussion_r218139467 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/blocklet/index/BlockletIndex.java --- @@ -75,4 +80,12 @@ public void

[GitHub] carbondata pull request #2725: [CARBONDATA-2942] Add read and write support ...

2018-09-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2725#discussion_r218138883 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonMetadataUtil.java --- @@ -250,6 +275,42 @@ public static BlockletIndex

[GitHub] carbondata pull request #2725: [WIP] Added code to support storing min max f...

2018-09-16 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2725 [WIP] Added code to support storing min max for string columns based on number of characacters - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted

[GitHub] carbondata issue #2716: [HOTFIX] Fixed 2.3 CI

2018-09-14 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2716 LGTM ---

[GitHub] carbondata pull request #2702: [WIP] Fixed multiple complex type issue

2018-09-10 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2702 [WIP] Fixed multiple complex type issue **This PR contains** 1. Fix to support nested complex type till integer length. When the data length in one row for nested complex type

[GitHub] carbondata issue #2687: [CARBONDATA-2876]Fix Avro decimal datatype with prec...

2018-09-10 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2687 LGTM ---

[GitHub] carbondata issue #2698: [HOTFIX] Fixed LRU cache bug to invalidate the cache...

2018-09-07 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2698 @ravipesala ..handled review comment. Kindly review and merge ---

[GitHub] carbondata pull request #2698: [HOTFIX] Fixed LRU cache bug to invalidate th...

2018-09-07 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2698#discussion_r215984873 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCacheKeyValue.java --- @@ -100,6 +100,10 @@ public long

[GitHub] carbondata issue #2685: [CARBONDATA-2910] Support backward compatability in ...

2018-09-07 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2685 LGTM ---

[GitHub] carbondata issue #2694: [CARBONDATA-2876]AVRO datatype support through SDK

2018-09-06 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2694 LGTM ---

[GitHub] carbondata pull request #2698: [HOTFIX] Fixed LRU cache bug to invalidate th...

2018-09-06 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2698 [HOTFIX] Fixed LRU cache bug to invalidate the cacheable object to clean up the resources This PR contains the fix for LRU cache bug to invalidate the Cacheable object while removing

[GitHub] carbondata pull request #2687: [CARBONDATA-2876]Fix Avro decimal datatype wi...

2018-09-03 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2687#discussion_r214790148 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -407,6 +413,19 @@ private Object

[GitHub] carbondata pull request #2663: [CARBONDATA-2894] Add support for complex map...

2018-09-03 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2663#discussion_r214717788 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/Field.java --- @@ -213,4 +218,58 @@ public String getColumnComment

[GitHub] carbondata issue #2663: [CARBONDATA-2894] Add support for complex map type t...

2018-09-03 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2663 @ravipesala ...handled review comments. Kindly review and merge ---

[GitHub] carbondata pull request #2663: [CARBONDATA-2894] Add support for complex map...

2018-09-03 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2663#discussion_r214643424 --- Diff: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/SparkCarbonFileFormat.scala

[GitHub] carbondata pull request #2663: [CARBONDATA-2894] Add support for complex map...

2018-09-03 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2663#discussion_r214643373 --- Diff: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonSparkDataSourceUtil.scala

[GitHub] carbondata issue #2654: [CARBONDATA-2896] Adaptive Encoding for Primitive da...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2654 @dhatchayani You can raise one more to improvise the code at some places: 1. Unify isScanRequired code in all the filter classes using ENUM and flag based on min max comparison

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214371546 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java --- @@ -331,8 +332,18 @@ private

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214361007 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java --- @@ -110,8 +112,19 @@ public

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214356896 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/CompressedDimensionChunkFileBasedReaderV3.java

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214354541 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java --- @@ -363,7 +398,16 @@ public EncodedTablePage

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214352965 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java --- @@ -346,12 +371,21 @@ static

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214351650 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/TableSpec.java --- @@ -91,6 +92,30 @@ private void addMeasures(List measures

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214338168 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/SortStepRowHandler.java --- @@ -375,6 +454,47 @@ public void

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214336180 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/SortStepRowHandler.java --- @@ -224,10 +237,15 @@ public

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214341633 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/partition/impl/RawRowComparator.java --- @@ -30,24 +33,39

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214341135 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/IntermediateSortTempRowComparator.java --- @@ -45,18 +52,31

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214341442 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparator.java --- @@ -43,15 +53,31 @@ public

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214337384 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/SortStepRowHandler.java --- @@ -359,9 +433,14 @@ public void

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214341815 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/comparator/UnsafeRowComparator.java --- @@ -60,26 +64,50

[GitHub] carbondata issue #2644: [CARBONDATA-2853] Implement file-level min/max index...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2644 @QiangCai In General I can see that you put empty lines at many places in the code. Please remove those empty lines everywhere and add some code comments for better understanding ---

[GitHub] carbondata pull request #2644: [CARBONDATA-2853] Implement file-level min/ma...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2644#discussion_r214310465 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonMetadataUtil.java --- @@ -96,14 +96,35 @@ private static FileFooter3

[GitHub] carbondata pull request #2644: [CARBONDATA-2853] Implement file-level min/ma...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2644#discussion_r214303472 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/StreamDataMap.java --- @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #2644: [CARBONDATA-2853] Implement file-level min/ma...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2644#discussion_r214307411 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/StreamDataMap.java --- @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #2644: [CARBONDATA-2853] Implement file-level min/ma...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2644#discussion_r214313170 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/StreamHandoffRDD.scala --- @@ -205,8 +205,9 @@ class

[GitHub] carbondata pull request #2644: [CARBONDATA-2853] Implement file-level min/ma...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2644#discussion_r214311953 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -342,60 +341,52 @@ public void

[GitHub] carbondata pull request #2644: [CARBONDATA-2853] Implement file-level min/ma...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2644#discussion_r214311329 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -342,60 +341,52 @@ public void

[GitHub] carbondata pull request #2644: [CARBONDATA-2853] Implement file-level min/ma...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2644#discussion_r214305126 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/StreamDataMap.java --- @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #2644: [CARBONDATA-2853] Implement file-level min/ma...

2018-08-31 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2644#discussion_r214316607 --- Diff: streaming/src/main/java/org/apache/carbondata/streaming/CarbonStreamRecordWriter.java --- @@ -212,9 +271,13 @@ private void

[GitHub] carbondata issue #2671: [CARBONDATA-2876]AVRO datatype support through SDK

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2671 LGTM...can be merged once build passes ---

[GitHub] carbondata pull request #2671: [CARBONDATA-2876]AVRO datatype support throug...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2671#discussion_r214244301 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -213,6 +181,124 @@ private Object avroFieldToObject

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214047186 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortParameters.java --- @@ -88,6 +88,12

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214044420 --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java --- @@ -976,4 +978,122 @@ public static long

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214051061 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -450,6 +450,114 @@ public static

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214049718 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -450,6 +450,114 @@ public static

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214055038 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java --- @@ -320,12 +325,22 @@ public

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214038515 --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java --- @@ -976,4 +978,122 @@ public static long

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214038624 --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java --- @@ -976,4 +978,122 @@ public static long

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214049002 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -450,6 +450,114 @@ public static

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214049631 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -450,6 +450,114 @@ public static

[GitHub] carbondata pull request #2654: [CARBONDATA-2896] Adaptive Encoding for Primi...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2654#discussion_r214055654 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java --- @@ -320,12 +325,22 @@ public

[GitHub] carbondata pull request #2671: [CARBONDATA-2876]AVRO datatype support throug...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2671#discussion_r214024187 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -310,6 +503,31 @@ private static Field

[GitHub] carbondata pull request #2671: [CARBONDATA-2876]AVRO datatype support throug...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2671#discussion_r214023293 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -213,6 +181,126 @@ private Object avroFieldToObject

[GitHub] carbondata pull request #2671: [CARBONDATA-2876]AVRO datatype support throug...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2671#discussion_r214024597 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -310,6 +503,31 @@ private static Field

[GitHub] carbondata pull request #2671: [CARBONDATA-2876]AVRO datatype support throug...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2671#discussion_r214022747 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -213,6 +181,126 @@ private Object avroFieldToObject

[GitHub] carbondata issue #2663: [CARBONDATA-2894] Add support for complex map type t...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2663 retest this please ---

[GitHub] carbondata issue #2671: [CARBONDATA-2876]AVRO datatype support through SDK

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2671 @Indhumathi27 ..please modify the code as per the comments then we can continue with further review of code ---

[GitHub] carbondata pull request #2671: [CARBONDATA-2876]AVRO datatype support throug...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2671#discussion_r213914935 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -213,6 +218,225 @@ private Object avroFieldToObject

[GitHub] carbondata pull request #2671: [CARBONDATA-2876]AVRO datatype support throug...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2671#discussion_r213916136 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -213,6 +218,225 @@ private Object avroFieldToObject

[GitHub] carbondata pull request #2671: [CARBONDATA-2876]AVRO datatype support throug...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2671#discussion_r213915304 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -213,6 +218,225 @@ private Object avroFieldToObject

[GitHub] carbondata pull request #2671: [CARBONDATA-2876]AVRO datatype support throug...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2671#discussion_r213922678 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -213,6 +218,225 @@ private Object avroFieldToObject

[GitHub] carbondata issue #2663: [CARBONDATA-2894] Add support for complex map type t...

2018-08-30 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2663 retest this please ---

[GitHub] carbondata issue #2649: [CARBONDATA-2869] Add support for Avro Map data type...

2018-08-29 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2649 @ravipesala ...fixed review comment. Kindly review and merge ---

[GitHub] carbondata pull request #2663: [CARBONDATA-2894] Add support for complex map...

2018-08-27 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2663 [CARBONDATA-2894] Add support for complex map type through spark carbon file format API This PR supports loading querying complex map type through spark carbon file format API

[GitHub] carbondata issue #2651: [HOTFIX] Support TableProperties Map API for SDK

2018-08-24 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2651 LGTM...can be merged once build is passed ---

[GitHub] carbondata pull request #2651: [HOTFIX] Support TableProperties Map API for ...

2018-08-24 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2651#discussion_r212582796 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -272,6 +272,56 @@ public CarbonWriterBuilder

[GitHub] carbondata issue #2649: [WIP] Add support for Avro Map data type support for...

2018-08-23 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2649 @jackylk 1. This PR is only for SDK support 2. Yes map is implemented as an array of struct. For more details you can check the design document https://docs.google.com

[GitHub] carbondata pull request #2649: [WIP] Add support for Avro Map data type supp...

2018-08-22 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2649 [WIP] Add support for Avro Map data type support for SDK Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any

[GitHub] carbondata pull request #2613: [HOTFIX] Modified code to fix the degrade in ...

2018-08-07 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2613#discussion_r208182587 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/iterator/RawResultIterator.java --- @@ -53,153 +39,124

[GitHub] carbondata pull request #2613: [HOTFIX] Modified code to fix the degrade in ...

2018-08-07 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2613 [HOTFIX] Modified code to fix the degrade in compaction performance Problem Compaction performance for 3.5 billion degraded by 16-20% Analysis: Code modification

[GitHub] carbondata issue #2608: [CARBONDATA-2829][CARBONDATA-2832] Fix creating merg...

2018-08-06 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2608 LGTM ---

[GitHub] carbondata issue #2601: [CARBONDATA-2804][DataMap] fix the bug when bloom fi...

2018-08-03 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2601 LGTM ---

[GitHub] carbondata pull request #2601: [CARBONDATA-2804][DataMap] fix the bug when b...

2018-08-02 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2601#discussion_r207224591 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -3212,28 +3213,27 @@ public static ColumnarFormatVersion

[GitHub] carbondata pull request #2601: [CARBONDATA-2804][DataMap] fix the bug when b...

2018-08-02 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2601#discussion_r207223659 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -3212,28 +3213,27 @@ public static ColumnarFormatVersion

[GitHub] carbondata pull request #2601: [CARBONDATA-2804][DataMap] fix the bug when b...

2018-08-02 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2601#discussion_r207225748 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -3212,28 +3213,27 @@ public static ColumnarFormatVersion

[GitHub] carbondata issue #2600: [CARBONDATA-2813] Fixed code to get data size from L...

2018-08-02 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2600 LGTM ---

[GitHub] carbondata issue #2595: [Documentation] [Unsafe Configuration] Added carbon....

2018-08-01 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2595 @xuchuanyin Usually in production scenarios driver memory will be less than the executor memory. Now we are using unsafe for caching block/blocklet dataMap in driver. Current unsafe

[GitHub] carbondata pull request #2595: [Documentation] [Unsafe Configuration] Added ...

2018-08-01 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2595 [Documentation] [Unsafe Configuration] Added carbon.unsafe.driver.working.memory.in.mb parameter to differentiate between driver and executor unsafe memory Added

[GitHub] carbondata pull request #2593: [CARBONDATA-2753][Compatibility] Merge Index ...

2018-08-01 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2593 [CARBONDATA-2753][Compatibility] Merge Index file not getting created with blocklet information for old store **Problem** Merge Index file not getting created with blocklet

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

2018-08-01 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2585 LGTM ---

<    1   2   3   4   5   6   7   8   >