[GitHub] carbondata pull request #2669: [Documentation] Added the missing links for o...

2018-08-29 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/2669 [Documentation] Added the missing links for online documentation Added the missing links for the online documentation: > S3 Guide > Bloom filter Datamap > Lucen

[GitHub] carbondata pull request #2708: [CARBONDATA-2886] Select Filter Comppatibilit...

2018-09-11 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/2708 [CARBONDATA-2886] Select Filter Comppatibility Fixed Problem : Select Filter Query with INT data type was showing incorrect result in case of table creation and loading on old version

[GitHub] carbondata pull request #2708: [CARBONDATA-2886] Select Filter Compatibility...

2018-09-12 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2708#discussion_r216908025 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java --- @@ -383,8 +383,9 @@ private void

[GitHub] carbondata pull request #2821: [CARBONDATA-3017] Map DDL Support

2018-10-16 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/2821 [CARBONDATA-3017] Map DDL Support Support Create DDL for Map type. - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted

[GitHub] carbondata issue #2821: [CARBONDATA-3017] Map DDL Support

2018-10-18 Thread manishnalla1994
Github user manishnalla1994 commented on the issue: https://github.com/apache/carbondata/pull/2821 retest this please ---

[GitHub] carbondata issue #2821: [CARBONDATA-3017] Map DDL Support

2018-10-16 Thread manishnalla1994
Github user manishnalla1994 commented on the issue: https://github.com/apache/carbondata/pull/2821 Retest this please ---

[GitHub] carbondata issue #2848: [CARBONDATA-3036] Cache Columns And Refresh Table Is...

2018-10-24 Thread manishnalla1994
Github user manishnalla1994 commented on the issue: https://github.com/apache/carbondata/pull/2848 retest this please ---

[GitHub] carbondata pull request #2848: [CARBONDATA-3036] Cache Columns And Refresh T...

2018-10-23 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/2848 [CARBONDATA-3036] Cache Columns And Refresh Table Isuue Fix Refresh Table Issue : Refresh Table command acting in case sensitive manner. Cache Columns Issue : Results inconsistent

[GitHub] carbondata pull request #2918: [CARBONDATA-3098] Fix for negative exponents ...

2018-11-13 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/2918 [CARBONDATA-3098] Fix for negative exponents value giving wrong results in Float datatype Problem: When the value of exponent is a negative number then the data is incorrect due

[GitHub] carbondata issue #2918: [CARBONDATA-3098] Fix for negative exponents value g...

2018-11-13 Thread manishnalla1994
Github user manishnalla1994 commented on the issue: https://github.com/apache/carbondata/pull/2918 retest this please ---

[GitHub] carbondata pull request #2747: [CARBONDATA-2960] SDK Reader fix with project...

2018-09-21 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/2747 [CARBONDATA-2960] SDK Reader fix with projection columns SDK Reader was not working when all projection columns were given. Added exception for Complex child projections too

[GitHub] carbondata issue #2747: [CARBONDATA-2960] SDK Reader fix with projection col...

2018-09-23 Thread manishnalla1994
Github user manishnalla1994 commented on the issue: https://github.com/apache/carbondata/pull/2747 retest this please ---

[GitHub] carbondata pull request #2758: [CARBONDATA-2972] Debug Logs and function add...

2018-09-26 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2758#discussion_r220553863 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java --- @@ -78,6 +78,14 @@ public DataType

[GitHub] carbondata pull request #2747: [CARBONDATA-2960] SDK Reader fix with project...

2018-09-24 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2747#discussion_r220062362 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java --- @@ -775,9 +775,18 @@ public static boolean

[GitHub] carbondata issue #2758: [CARBONDATA-2972] Debug Logs and function added for ...

2018-09-27 Thread manishnalla1994
Github user manishnalla1994 commented on the issue: https://github.com/apache/carbondata/pull/2758 retest this please ---

[GitHub] carbondata pull request #2747: [CARBONDATA-2960] SDK Reader fix with project...

2018-09-25 Thread manishnalla1994
Github user manishnalla1994 closed the pull request at: https://github.com/apache/carbondata/pull/2747 ---

[GitHub] carbondata pull request #2758: Debug Logs and function added for Adaptive En...

2018-09-25 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/2758 Debug Logs and function added for Adaptive Encoding Added a function to get the type of encoding used. Added the debug log for checking which type of encoding is used

[GitHub] carbondata issue #2758: [CARBONDATA-2972] Debug Logs and function added for ...

2018-09-26 Thread manishnalla1994
Github user manishnalla1994 commented on the issue: https://github.com/apache/carbondata/pull/2758 retest this please ---

[GitHub] carbondata issue #2758: [WIP] Debug Logs and function added for Adaptive Enc...

2018-09-25 Thread manishnalla1994
Github user manishnalla1994 commented on the issue: https://github.com/apache/carbondata/pull/2758 retest this please ---

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-02 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3047#discussion_r244911752 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -101,14 +102,21 @@ object CarbonStore

[GitHub] carbondata issue #3047: [CARBONDATA-3223] Fixed Wrong Datasize and Indexsize...

2019-01-03 Thread manishnalla1994
Github user manishnalla1994 commented on the issue: https://github.com/apache/carbondata/pull/3047 retest this please ---

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-03 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3047#discussion_r244957693 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -46,9 +47,9 @@ object CarbonStore

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-03 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3047#discussion_r244957746 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -101,14 +102,23 @@ object CarbonStore

[GitHub] carbondata pull request #2993: [CARBONDATA-3179] Map data load failure

2018-12-18 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2993#discussion_r242448934 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateDDLForComplexMapType.scala

[GitHub] carbondata pull request #2993: [CARBONDATA-3179] Map data load failure

2018-12-18 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2993#discussion_r242448914 --- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/parser/FieldConverter.scala --- @@ -66,30 +65,57 @@ object FieldConverter

[GitHub] carbondata pull request #3016: [CARBONDATA-3192] Fix for compaction compatib...

2018-12-21 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/3016 [CARBONDATA-3192] Fix for compaction compatibilty issue Problem: Table Created, Loaded and Altered(Column added) in 1.5.1 version and Refreshed, Altered(Added Column dropped) , Loaded

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-27 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244118775 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java --- @@ -356,9 +359,20 @@ public

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240900542 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java --- @@ -65,8 +65,7 @@ private

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240900720 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateDDLForComplexMapType.scala

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240900751 --- Diff: examples/spark2/src/main/resources/maptest2.csv --- @@ -0,0 +1,2 @@ +1\002Nalla\0012\002Singh\0011\002Gupta\0014\002Kumar +10

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240900767 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java --- @@ -338,12 +338,15 @@ public static

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240900612 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/parser/CarbonParserFactory.java --- @@ -51,23 +54,37 @@ public

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240900728 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java --- @@ -338,12 +338,15 @@ public static

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240900706 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala --- @@ -188,11

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240900666 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java --- @@ -631,7 +651,7 @@ public void

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240900628 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java --- @@ -119,6 +119,10

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240900688 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/DataLoadProcessBuilder.java --- @@ -222,8 +222,8 @@ public static

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240900568 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/parser/impl/RowParserImpl.java --- @@ -34,8 +37,12

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240591596 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/parser/impl/RowParserImpl.java --- @@ -34,8 +37,12

[GitHub] carbondata pull request #2993: [WIP] Map data load failure

2018-12-16 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/2993 [WIP] Map data load failure Problem : Data Load failing for Insert into Select from same table in containing Map datatype. Solution: Map type was not handled for this scenario

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-24 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/3022 [CARBONDATA-3196] Fixed Compaction for Complex types with Dictionary Include Problem: Compaction Failing for Complex datatypes with Dictionary Include as KeyGenenrator was not being

[GitHub] carbondata pull request #3006: [CARBONDATA-3187] Supported Global Dictionary...

2018-12-20 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3006#discussion_r243187905 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala --- @@ -182,7 +182,7 @@ object

[GitHub] carbondata pull request #2979: [CARBONDATA-3153] Complex delimiters change

2018-12-07 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/2979 [CARBONDATA-3153] Complex delimiters change Changed the two Complex Delimiters used to '\001' and '\002'. Be sure to do all of the following checklist to help us incorporate

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-07 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/2980 [CARBONDATA-3017] Map DDL Support Support Create DDL for Map type. This PR is dependant on PR#2979 for the change of delimiters. Be sure to do all of the following

[GitHub] carbondata pull request #2821: [CARBONDATA-3017] Map DDL Support

2018-12-09 Thread manishnalla1994
Github user manishnalla1994 closed the pull request at: https://github.com/apache/carbondata/pull/2821 ---

[GitHub] carbondata pull request #3056: [CARBONDATA-3236] Fix for JVM Crash for inser...

2019-01-08 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/3056 [CARBONDATA-3236] Fix for JVM Crash for insert into new table from old table Problem: Insert into new table from old table fails with JVM crash. This happened because both the query

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-03 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3047#discussion_r245003004 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -101,14 +102,23 @@ object CarbonStore

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-02 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/3047 [CARBONDATA-3223] Fixed Wrong Datasize and Indexsize calculation for old store using Show Segments Problem: Table Created and Loading on older version(1.1) was showing data-size

[GitHub] carbondata issue #3056: [CARBONDATA-3236] Fix for JVM Crash for insert into ...

2019-01-09 Thread manishnalla1994
Github user manishnalla1994 commented on the issue: https://github.com/apache/carbondata/pull/3056 @xuchuanyin Datasource table uses direct filling flow. As in direct flow there is no intermediate buffer so we are not using off-heap to store the page data in memory(filling all

[GitHub] carbondata pull request #3002: [CARBONDATA-3182] Fixed SDV Testcase failures...

2018-12-19 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/3002 [CARBONDATA-3182] Fixed SDV Testcase failures Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any

[GitHub] carbondata pull request #3006: [CARBONDATA-3187] Supported Global Dictionary...

2018-12-19 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/3006 [CARBONDATA-3187] Supported Global Dictionary For Map Added the case for Global Dictionary to be created in case the datatype is Complex Map. Be sure to do all