[
https://issues.apache.org/jira/browse/CARBONDATA-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799944#comment-16799944
]
xuchuanyin edited comment on CARBONDATA-3327 at 3/24/19 8:3
[
https://issues.apache.org/jira/browse/CARBONDATA-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799944#comment-16799944
]
xuchuanyin edited comment on CARBONDATA-3327 at 3/24/19 8:3
[
https://issues.apache.org/jira/browse/CARBONDATA-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799944#comment-16799944
]
xuchuanyin commented on CARBONDATA-3327:
Besides, I noticed that if w
xuchuanyin created CARBONDATA-3327:
--
Summary: Errors lies in query with small blocklet size
Key: CARBONDATA-3327
URL: https://issues.apache.org/jira/browse/CARBONDATA-3327
Project: CarbonData
[
https://issues.apache.org/jira/browse/CARBONDATA-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuchuanyin resolved CARBONDATA-3281.
Resolution: Fixed
> Limit the LRU cache s
[
https://issues.apache.org/jira/browse/CARBONDATA-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuchuanyin reassigned CARBONDATA-3281:
--
Assignee: (was: xuchuanyin)
> Limit the LRU cache s
[
https://issues.apache.org/jira/browse/CARBONDATA-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuchuanyin reassigned CARBONDATA-3281:
--
Assignee: xuchuanyin
> Limit the LRU cache s
[
https://issues.apache.org/jira/browse/CARBONDATA-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuchuanyin resolved CARBONDATA-2447.
Resolution: Fixed
Fix Version/s: (was: NONE)
> Range Partition Table。W
[
https://issues.apache.org/jira/browse/CARBONDATA-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuchuanyin resolved CARBONDATA-3107.
Resolution: Fixed
> Optimize error/exception coding for better debugg
[
https://issues.apache.org/jira/browse/CARBONDATA-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuchuanyin resolved CARBONDATA-3278.
Resolution: Fixed
> Remove duplicate code to get filter string of date/timest
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/3056
@manishnalla1994
> Solution:
Check if any other RDD is sharing the same task context. If so, don't the
clear the resource at that time, the other RDD which shared the
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/3046
We do not need to expose this threshold to the user. Instead, we can judge
ourselves in carbondata.
Step1. We can get the size of non-dictionary-encoded page (say M) and the
size of
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3054#discussion_r246427391
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/AlluxioExample.scala
---
@@ -28,46 +33,86 @@ import
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/3046
> This PR is just to add the size based limitation so that the map size can
be controlled.
@kunal642 Yeah, I noticed that. So my proposal is that please make a
reservation for mini
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r246056127
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -2076,4 +2076,15 @@ private
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/3053
Does this PR fix two problems?
If it is yes, better to separate it into two. And for the first problem,
I'm also concerning about the performance decrease. The rawCompress can save
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3054#discussion_r246047276
--- Diff: docs/documentation.md ---
@@ -29,15 +29,15 @@ Apache CarbonData is a new big data file format for
faster interactive query usi
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3054#discussion_r246049322
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/AlluxioExample.scala
---
@@ -28,46 +33,86 @@ import
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3054#discussion_r246050916
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/AlluxioExample.scala
---
@@ -28,46 +33,86 @@ import
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3054#discussion_r246044066
--- Diff: docs/alluxio-guide.md ---
@@ -0,0 +1,42 @@
+
+
+
+# Presto guide
--- End diff --
presto?
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3054#discussion_r246047576
--- Diff: docs/quick-start-guide.md ---
@@ -54,7 +54,8 @@ CarbonData can be integrated with Spark,Presto and Hive
Execution Engines. The b
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/3056
> because both the query and load flow were assigned the same taskId and
once query finished it freed the unsafe memory while the insert still in
progress.
How do you handle
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2963
@jackylk Actually after applying the above commit, the size of the shade
decrease from 40652 Bytes to 40620 Bytes
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2963#discussion_r245633754
--- Diff: pom.xml ---
@@ -527,6 +526,7 @@
examples/spark2
datamap/lucene
datamap/bloom
+datamap
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/3045
LGTM
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245534858
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,7
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/3046
Hi @kunal642 ï¼in your PR, the threshold size for storage of the local
dictionary is specified by system (maybe later can be specified by user). But
it will come up with an obvious problem
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r245510146
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/DecoderBasedFallbackEncoder.java
---
@@ -57,10 +57,7 @@ public
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r245510098
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -2076,4 +2076,15 @@ private
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245509909
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,7
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r245509625
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala ---
@@ -184,6 +184,9 @@ object CarbonEnv {
.addListener
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r245509427
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala
---
@@ -24,59 +24,96 @@ import
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/3023
Besides, I think the title of the PR can be optimized to 'Include the
merging bloomindex procedure in data loading transaction' -- just for your
reference
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r245469143
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala
---
@@ -24,59 +24,96 @@ import
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r245469279
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala
---
@@ -24,59 +24,96 @@ import
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r245469201
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala ---
@@ -184,6 +184,9 @@ object CarbonEnv {
.addListener
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3031#discussion_r244639643
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
---
@@ -140,6 +140,7 @@ public boolean
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3036#discussion_r244535093
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java
---
@@ -287,31 +287,31 @@ private void
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2963#discussion_r244344781
--- Diff:
datamap/example/src/main/java/org/apache/carbondata/datamap/minmax/MinMaxDataMapFactory.java
---
@@ -0,0 +1,353
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2970#discussion_r244015783
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonThreadFactory.java ---
@@ -34,14 +34,26 @@
*/
private String name
[
https://issues.apache.org/jira/browse/CARBONDATA-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuchuanyin resolved CARBONDATA-3181.
Resolution: Fixed
Fix Version/s: 1.5.2
> IllegalAccessError
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/3000
LGTM
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2999
LGTM
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2988#discussion_r242377558
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2992
@xubo245
"and plan to support alluxio path too."
---
I think there is no need to add this currently. We should only describe the
feature implemented.
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2992
LGTM
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuchuanyin resolved CARBONDATA-3166.
Resolution: Fixed
Fix Version/s: 1.5.2
> Changes in Document and Display
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2986
LGTM
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2984#discussion_r241616785
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
---
@@ -227,6 +231,12 @@ private String
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2986
I am with @KanakaKumar 's comments. We'd better not to show the system
default value in the desc command for columncompressor, since the values can
vary each time we changed
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2963
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2963
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2963
retest this please
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2963#discussion_r240581684
--- Diff:
integration/spark2/src/test/scala/org/apache/carbondata/datamap/minmax/MinMaxDataMapFunctionSuite.scala
---
@@ -0,0 +1,415
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2963#discussion_r240580992
--- Diff:
datamap/example/src/main/java/org/apache/carbondata/datamap/minmax/MinMaxDataMapFactory.java
---
@@ -0,0 +1,365
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2963#discussion_r240579947
--- Diff:
datamap/example/src/main/java/org/apache/carbondata/datamap/minmax/AbstractMinMaxDataMapWriter.java
---
@@ -0,0 +1,248
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2963#discussion_r240579236
--- Diff:
datamap/example/src/main/java/org/apache/carbondata/datamap/minmax/AbstractMinMaxDataMapWriter.java
---
@@ -0,0 +1,248
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2963#discussion_r240578382
--- Diff:
datamap/example/src/main/java/org/apache/carbondata/datamap/minmax/AbstractMinMaxDataMapWriter.java
---
@@ -0,0 +1,248
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2969
LGTM
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2732
better to have this PR tested using more data and queries to check whether
it has some advantages than other compressors.
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2969
@SteNicholas Nice to see your work on the existed problems. And it seems
the previous code has some problem which is extend by your code. So I suggest
you to fix them at the same time
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r239070652
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r239070613
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r239071026
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r239070238
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r239069684
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2878
LGTM
Please fix the conflicts
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2961
LGTM
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2961
LGTM
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2961
LGTM
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2914
Have you rebased with the latest master code and recheck again? Since 18
days had passed after your last commit.
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2961
+1 for @zzcclp 's comments
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2963
> Can consider writing an example:how to use MinMaxDataMap to build index
for CSV file.
@chenliang613 This will requires carbondata support external file format
(such as CSV)
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2963
[CARBONDATA-3139] Fix bugs in MinMaxDataMap
make minmax datamap usable and add more tests for it.
MinMax DataMap may be useful if we want to implement datamap for external
file format
xuchuanyin created CARBONDATA-3139:
--
Summary: Fix bugs in datamap example
Key: CARBONDATA-3139
URL: https://issues.apache.org/jira/browse/CARBONDATA-3139
Project: CarbonData
Issue Type: Bug
[
https://issues.apache.org/jira/browse/CARBONDATA-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuchuanyin resolved CARBONDATA-3133.
Resolution: Fixed
> Update carbondata build docum
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2955
Merged. Thanks for your contribution ð
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2955
LGTM
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2949#discussion_r236907065
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java ---
@@ -205,26 +195,53 @@ public BlockletDetailsFetcher
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2949#discussion_r236907320
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java ---
@@ -205,26 +195,53 @@ public BlockletDetailsFetcher
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2949#discussion_r236571984
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
@@ -70,4 +70,6 @@ void init(DataMapModel dataMapModel
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2936#discussion_r236568719
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java ---
@@ -487,6 +487,8 @@ private int getBlockCount(List
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2936#discussion_r236565153
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1399,6 +1399,17 @@ private
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2936#discussion_r236565449
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1399,6 +1399,17 @@ private
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2936#discussion_r236564769
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java ---
@@ -63,6 +75,8 @@
private
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2955#discussion_r236563139
--- Diff: build/README.md ---
@@ -29,10 +29,40 @@ Build with different supported versions of Spark, by
default using Spark 2.2.1 t
```
mvn
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2943
This PR uses the version 1.5.2-snapshot, but the main pom uses
1.6.0-snapshot.
Is it intended?
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2926
Will it be a table property or just leave it as a system property?
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuchuanyin resolved CARBONDATA-3031.
Resolution: Fixed
Fix Version/s: 1.5.1
> Find wrong description in
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2907
LGTM
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2920
LGTM
Waiting for the builds
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2920#discussion_r234098865
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -438,13 +438,13 @@ public CarbonWriter build
[
https://issues.apache.org/jira/browse/CARBONDATA-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuchuanyin resolved CARBONDATA-3087.
Resolution: Fixed
Assignee: Jacky Li
Fix Version/s: 1.5.1
> Prett
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2908
LGTM
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2920#discussion_r233458367
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -438,13 +438,13 @@ public CarbonWriter build
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2920#discussion_r233458646
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -438,13 +438,13 @@ public CarbonWriter build
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2909
Besides, can we gain any benefits from this PRï¼
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2909
LGTM
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2904
LGTM
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2911
LGTM
---
1 - 100 of 1832 matches
Mail list logo
