Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2396
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197724441
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -67,17 +69,38 @@
int
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197724373
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -102,6 +123,9 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197723962
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -67,17 +69,38 @@
int
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197723498
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -67,17 +69,38 @@
int
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197678648
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -67,17 +69,38 @@
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197678288
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -27,6 +28,7 @@
import
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197678273
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -19,6 +19,7 @@
import
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197645303
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/complextypes/ArrayQueryType.java
---
@@ -97,4 +99,56 @@ public void
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197645280
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDatasourceHadoopRelation.scala
---
@@ -67,14 +68,68 @@ case class
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197645259
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -417,6 +417,44 @@ public static Object
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197645177
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -136,28 +189,81 @@ void
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197645154
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java
---
@@ -146,4 +148,58 @@ public
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197645152
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/complextypes/StructQueryType.java
---
@@ -109,4 +111,53 @@ public
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197645136
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
---
@@ -156,8 +162,70 @@ private static boolean
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197645133
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/model/QueryModelBuilder.java
---
@@ -54,18 +58,134 @@ public QueryModelBuilder
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197645110
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/complextypes/ArrayQueryType.java
---
@@ -97,4 +99,56 @@ public void
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197645070
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -67,17 +69,38 @@
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197644958
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/CarbonDimension.java
---
@@ -51,6 +51,16 @@
*/
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197644949
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -665,6 +665,34 @@ public CarbonDimension
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197502390
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/complextypes/ArrayQueryType.java
---
@@ -97,4 +99,56 @@ public void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197502370
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/complextypes/ArrayQueryType.java
---
@@ -97,4 +99,56 @@ public void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197502251
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDatasourceHadoopRelation.scala
---
@@ -67,14 +68,68 @@ case class
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197501751
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -417,6 +417,44 @@ public static Object
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197501384
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/model/QueryModelBuilder.java
---
@@ -54,18 +58,134 @@ public QueryModelBuilder
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197499107
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/model/QueryModelBuilder.java
---
@@ -54,18 +58,134 @@ public QueryModelBuilder
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197496409
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
---
@@ -156,8 +162,70 @@ private static boolean
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197492221
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/complextypes/StructQueryType.java
---
@@ -109,4 +111,53 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197491159
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java
---
@@ -146,4 +148,58 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197488859
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -136,28 +189,81 @@ void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197488819
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -136,28 +189,81 @@ void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197488339
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -67,17 +69,38 @@
int
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197486428
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -119,9 +143,38 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197483516
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -67,17 +69,38 @@
int
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197482635
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -27,6 +28,7 @@
import
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197473335
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -19,6 +19,7 @@
import
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197472622
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/CarbonDimension.java
---
@@ -51,6 +51,16 @@
*/
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2396#discussion_r197470593
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -665,6 +665,34 @@ public CarbonDimension
38 matches
Mail list logo
