[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

2018-07-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2420 ---

[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

2018-07-04 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2420#discussion_r200234399 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/BadRecordsLoggerProvider.java --- @@ -92,13 +90,7 @@ public static String

[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

2018-07-04 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2420#discussion_r200234454 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonHiveMetaStore.scala --- @@ -158,13 +158,11 @@ class CarbonHiveMetaStore

[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

2018-07-04 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2420#discussion_r200234535 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala --- @@ -107,19 +107,10 @@ object AlterTableUtil { *

[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

2018-07-04 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2420#discussion_r200237355 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java --- @@ -378,8 +377,14 @@ private static void

[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

2018-07-04 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2420#discussion_r200167194 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala --- @@ -255,6 +256,29 @@ object

[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

2018-07-04 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2420#discussion_r200166867 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java --- @@ -345,14 +346,18 @@ public static CarbonLoadModel

[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

2018-07-04 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2420#discussion_r200155277 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java --- @@ -72,6 +72,28 @@ public

[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

2018-07-04 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2420#discussion_r200151855 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala --- @@ -255,6 +256,29 @@ object

[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

2018-07-04 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2420#discussion_r200150569 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java --- @@ -345,14 +346,18 @@ public static CarbonLoadModel