ali-ghanbari commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-886430226
Hello,
Thank you @kinow for the insightful comment regarding `StringBuilder` object
used in `algorithmC`.
It took me a while to understand that it is possible t
[
https://issues.apache.org/jira/browse/IO-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ronald Brill reopened IO-744:
-
The 'optimized' fix introduces another problem - have done another PR having a
test case that shows the new prob
[
https://issues.apache.org/jira/browse/IO-744?focusedWorklogId=627549&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627549
]
ASF GitHub Bot logged work on IO-744:
-
Author: ASF GitHub Bot
Cre
rbri commented on a change in pull request #251:
URL: https://github.com/apache/commons-io/pull/251#discussion_r676328916
##
File path:
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##
@@ -227,7 +227,12 @@ private static Writer initWriter(final File fi
[
https://issues.apache.org/jira/browse/IO-744?focusedWorklogId=627548&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627548
]
ASF GitHub Bot logged work on IO-744:
-
Author: ASF GitHub Bot
Cre
rbri opened a new pull request #252:
URL: https://github.com/apache/commons-io/pull/252
one more test - this time the test shows that the 'optimized' fix for
issue_IO-744 breaks the append constructor option
--
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/GEOMETRY-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386994#comment-17386994
]
Matt Juntunen commented on GEOMETRY-138:
Sounds good. Based on what I'm reading
kinow commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-886260831
I think I fixed the Javadoc error in `master`. If you could rebase it later,
then CI should be OK again. BTW, when we are ready to merge it, if I am the one
doing the merge, I
kinow commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-886260131
There is already a JMH test somewhere in the code, added recently to Text (I
was looking at Numbers & Imaging, as I recalled we added one somewhere really
recently - turns out
coveralls edited a comment on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-846470672
[](https://coveralls.io/builds/41630204)
Coverage decreased (-0.08%) to 97.877% when pulling
ali-ghanbari commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-886259223
> @ali-ghanbari , I will review it once I have some spare time. Thanks a lot
for updating the PR and fixing CI issues.
>
> We can definitely ignore that issue sinc
kinow commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-886258537
@ali-ghanbari , I will review it once I have some spare time. Thanks a lot
for updating the PR and fixing CI issues.
We can definitely ignore that issue since it is not b
ali-ghanbari edited a comment on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-886257991
Thank you @kinow for mentioning the CI issue.
It looks like that the issue is due to a recent changes in CI configuration
which makes the older version of `
ali-ghanbari commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-886257991
Thank you @kinow for mentioning the CI issue.
It looks like that the issue is due to a recent
change([see](https://github.com/apache/commons-text/commit/87640ed259
coveralls edited a comment on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-846470672
[](https://coveralls.io/builds/41630153)
Coverage decreased (-0.08%) to 97.877% when pulling
garydgregory merged pull request #118:
URL: https://github.com/apache/commons-dbcp/pull/118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues
[
https://issues.apache.org/jira/browse/IO-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved IO-744.
Fix Version/s: 2.12.0
Resolution: Fixed
[~rbri]
May you please see git master, verify that your
[
https://issues.apache.org/jira/browse/IO-744?focusedWorklogId=627474&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627474
]
ASF GitHub Bot logged work on IO-744:
-
Author: ASF GitHub Bot
Cre
[
https://issues.apache.org/jira/browse/IO-744?focusedWorklogId=627475&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627475
]
ASF GitHub Bot logged work on IO-744:
-
Author: ASF GitHub Bot
Cre
garydgregory commented on a change in pull request #251:
URL: https://github.com/apache/commons-io/pull/251#discussion_r676186568
##
File path:
src/test/java/org/apache/commons/io/output/FileWriterWithEncodingTest.java
##
@@ -197,6 +198,25 @@ public void constructor_File_nullF
garydgregory commented on a change in pull request #251:
URL: https://github.com/apache/commons-io/pull/251#discussion_r676186513
##
File path:
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##
@@ -227,7 +227,12 @@ private static Writer initWriter(final
[
https://issues.apache.org/jira/browse/IO-744?focusedWorklogId=627472&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627472
]
ASF GitHub Bot logged work on IO-744:
-
Author: ASF GitHub Bot
Cre
[
https://issues.apache.org/jira/browse/IO-744?focusedWorklogId=627473&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627473
]
ASF GitHub Bot logged work on IO-744:
-
Author: ASF GitHub Bot
Cre
garydgregory closed pull request #251:
URL: https://github.com/apache/commons-io/pull/251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-u
garydgregory commented on pull request #251:
URL: https://github.com/apache/commons-io/pull/251#issuecomment-886241849
@rbri
Thank you for your PR. See comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/IO-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated IO-744:
---
Summary: FileWriterWithEncoding for an existing file no longer truncates
the file. (was: FileWriterWithE
garydgregory merged pull request #205:
URL: https://github.com/apache/commons-vfs/pull/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
garydgregory merged pull request #206:
URL: https://github.com/apache/commons-vfs/pull/206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
ali-ghanbari commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-886238608
> I think CI was passing before, but apparently some Javadoc needs updating
@ali-ghanbari ?
>
> ```
> Error: Failed to execute goal
org.apache.maven.plugins:
coveralls edited a comment on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-846470672
[](https://coveralls.io/builds/41629198)
Coverage decreased (-0.09%) to 97.874% when pulling
[
https://issues.apache.org/jira/browse/GEOMETRY-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386928#comment-17386928
]
Gilles Sadowski commented on GEOMETRY-138:
--
IMO, specific exceptions are not n
[
https://issues.apache.org/jira/browse/IO-744?focusedWorklogId=627460&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627460
]
ASF GitHub Bot logged work on IO-744:
-
Author: ASF GitHub Bot
Cre
coveralls commented on pull request #251:
URL: https://github.com/apache/commons-io/pull/251#issuecomment-886223344
[](https://coveralls.io/builds/41628568)
Coverage decreased (-0.01%) to 89.097% when pulling
**c41c4b
[
https://issues.apache.org/jira/browse/IO-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386904#comment-17386904
]
Ronald Brill commented on IO-744:
-
https://github.com/apache/commons-io/pull/251
> FileWrite
[
https://issues.apache.org/jira/browse/IO-744?focusedWorklogId=627456&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627456
]
ASF GitHub Bot logged work on IO-744:
-
Author: ASF GitHub Bot
Cre
rbri opened a new pull request #251:
URL: https://github.com/apache/commons-io/pull/251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-uns
[
https://issues.apache.org/jira/browse/IO-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386896#comment-17386896
]
Ronald Brill commented on IO-744:
-
No problem, will submit one soon.
> FileWriterWithEncodin
garydgregory commented on a change in pull request #206:
URL: https://github.com/apache/commons-vfs/pull/206#discussion_r676147277
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/operations/vcs/package-info.java
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apac
garydgregory commented on a change in pull request #206:
URL: https://github.com/apache/commons-vfs/pull/206#discussion_r676147247
##
File path:
commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/libcheck/package.html
##
@@ -1,21 +0,0 @@
-
-
-Sample clients for common
[
https://issues.apache.org/jira/browse/IO-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386891#comment-17386891
]
Gary D. Gregory commented on IO-744:
[~rbri]
Thank your for your report. PRs are welcome
SethFalco commented on a change in pull request #206:
URL: https://github.com/apache/commons-vfs/pull/206#discussion_r676146700
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/operations/vcs/package-info.java
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache
SethFalco commented on a change in pull request #206:
URL: https://github.com/apache/commons-vfs/pull/206#discussion_r676145926
##
File path:
commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/libcheck/package.html
##
@@ -1,21 +0,0 @@
-
-
-Sample clients for commons-n
garydgregory commented on a change in pull request #206:
URL: https://github.com/apache/commons-vfs/pull/206#discussion_r676145871
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/operations/vcs/package-info.java
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apac
garydgregory commented on a change in pull request #206:
URL: https://github.com/apache/commons-vfs/pull/206#discussion_r676145677
##
File path:
commons-vfs2-examples/src/main/java/org/apache/commons/vfs2/libcheck/package.html
##
@@ -1,21 +0,0 @@
-
-
-Sample clients for common
[
https://issues.apache.org/jira/browse/GEOMETRY-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386877#comment-17386877
]
Matt Juntunen commented on GEOMETRY-138:
[~erans], why would we create a librar
Matt Juntunen created GEOMETRY-138:
--
Summary: Use unchecked exceptions in IO modules
Key: GEOMETRY-138
URL: https://issues.apache.org/jira/browse/GEOMETRY-138
Project: Apache Commons Geometry
[
https://issues.apache.org/jira/browse/IO-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ronald Brill updated IO-744:
Description:
Creating a new FileWriterWithEncoding for an existing file no longer truncates
the file. This was
Ronald Brill created IO-744:
---
Summary: FileWriterWithEncoding is not backward compatible to
version 2.10.0
Key: IO-744
URL: https://issues.apache.org/jira/browse/IO-744
Project: Commons IO
Issue T
[
https://issues.apache.org/jira/browse/POOL-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory deleted POOL-398:
-
> Project space.
> --
>
> Key: POOL-398
> URL: https://iss
[
https://issues.apache.org/jira/browse/POOL-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory deleted POOL-397:
-
> Api federated entity
> -
>
> Key: POOL-397
> UR
[
https://issues.apache.org/jira/browse/RNG-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Herbert resolved RNG-156.
--
Fix Version/s: 1.4
Resolution: Implemented
Added in commit:
b930e7ba3e6c5c623d2c04c3100b8dcdd2bba2
asfgit merged pull request #96:
URL: https://github.com/apache/commons-rng/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
coveralls edited a comment on pull request #96:
URL: https://github.com/apache/commons-rng/pull/96#issuecomment-885724011
[](https://coveralls.io/builds/41626548)
Coverage increased (+0.004%) to 99.621% when pulling
*
53 matches
Mail list logo
