[jira] [Updated] (COMPRESS-641) add getLinkFlag for TarArchiveEntry
[ https://issues.apache.org/jira/browse/COMPRESS-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COMPRESS-641: Description: Hi. I'm making a tar compressing tool. And I need to know what the original flag of a tar entry I read, otherwise I would make it changed in the decompressed result... https://github.com/apache/commons-compress/pull/365 > add getLinkFlag for TarArchiveEntry > --- > > Key: COMPRESS-641 > URL: https://issues.apache.org/jira/browse/COMPRESS-641 > Project: Commons Compress > Issue Type: New Feature >Reporter: Jin Xu >Priority: Minor > > Hi. > I'm making a tar compressing tool. > And I need to know what the original flag of a tar entry I read, otherwise I > would make it changed in the decompressed result... > https://github.com/apache/commons-compress/pull/365 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (COMPRESS-641) add getLinkFlag for TarArchiveEntry
Jin Xu created COMPRESS-641: --- Summary: add getLinkFlag for TarArchiveEntry Key: COMPRESS-641 URL: https://issues.apache.org/jira/browse/COMPRESS-641 Project: Commons Compress Issue Type: New Feature Reporter: Jin Xu -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NET-708) should use yyyy instead of YYYY in SimpleDateFormat
Jin Xu created NET-708: -- Summary: should use instead of in SimpleDateFormat Key: NET-708 URL: https://issues.apache.org/jira/browse/NET-708 Project: Commons Net Issue Type: Bug Reporter: Jin Xu should use instead of in SimpleDateFormat https://github.com/apache/commons-net/pull/97 represents the year of the week I don't think we should use it in those 2 usecases. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (VFS-812) fix bug about closing file content output stream when using BufferedOutputStream
[ https://issues.apache.org/jira/browse/VFS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated VFS-812: --- Description: fix bug about closing file content output stream when using BufferedOutputStream see the test for details. https://github.com/apache/commons-vfs/pull/228 was: fix bug about closing file content output stream when using BufferedOutputStream see the test for details. > fix bug about closing file content output stream when using > BufferedOutputStream > > > Key: VFS-812 > URL: https://issues.apache.org/jira/browse/VFS-812 > Project: Commons VFS > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > > fix bug about closing file content output stream when using > BufferedOutputStream > see the test for details. > https://github.com/apache/commons-vfs/pull/228 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (VFS-812) fix bug about closing file content output stream when using BufferedOutputStream
Jin Xu created VFS-812: -- Summary: fix bug about closing file content output stream when using BufferedOutputStream Key: VFS-812 URL: https://issues.apache.org/jira/browse/VFS-812 Project: Commons VFS Issue Type: Improvement Reporter: Jin Xu fix bug about closing file content output stream when using BufferedOutputStream see the test for details. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (TEXT-208) refine RandomStringGenerator to not check if random==null each time.also add a function for getting secured RandomStringGenerator conveniently.
Jin Xu created TEXT-208: --- Summary: refine RandomStringGenerator to not check if random==null each time.also add a function for getting secured RandomStringGenerator conveniently. Key: TEXT-208 URL: https://issues.apache.org/jira/browse/TEXT-208 Project: Commons Text Issue Type: Improvement Reporter: Jin Xu https://github.com/apache/commons-text/pull/238 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COMMONSSITE-145: --- Description: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. including: https://github.com/apache/commons-lang/pull/752 https://github.com/apache/commons-configuration/pull/118 https://github.com/apache/commons-dbutils/pull/68 https://github.com/apache/commons-geometry/pull/160 https://github.com/apache/commons-collections/pull/235 https://github.com/apache/commons-vfs/pull/181 was: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. including: https://github.com/apache/commons-lang/pull/752 https://github.com/apache/commons-configuration/pull/118 https://github.com/apache/commons-dbutils/pull/68 https://github.com/apache/commons-geometry/pull/160 https://github.com/apache/commons-collections/pull/235 > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > including: > https://github.com/apache/commons-lang/pull/752 > https://github.com/apache/commons-configuration/pull/118 > https://github.com/apache/commons-dbutils/pull/68 > https://github.com/apache/commons-geometry/pull/160 > https://github.com/apache/commons-collections/pull/235 > https://github.com/apache/commons-vfs/pull/181 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COMMONSSITE-145: --- Description: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. including: https://github.com/apache/commons-lang/pull/752 https://github.com/apache/commons-configuration/pull/118 https://github.com/apache/commons-dbutils/pull/68 https://github.com/apache/commons-geometry/pull/160 https://github.com/apache/commons-collections/pull/235 was: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. including: https://github.com/apache/commons-lang/pull/752 https://github.com/apache/commons-configuration/pull/118 https://github.com/apache/commons-dbutils/pull/68 https://github.com/apache/commons-geometry/pull/160 > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > including: > https://github.com/apache/commons-lang/pull/752 > https://github.com/apache/commons-configuration/pull/118 > https://github.com/apache/commons-dbutils/pull/68 > https://github.com/apache/commons-geometry/pull/160 > https://github.com/apache/commons-collections/pull/235 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COMMONSSITE-145: --- Description: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. including: https://github.com/apache/commons-lang/pull/752 https://github.com/apache/commons-configuration/pull/118 https://github.com/apache/commons-dbutils/pull/68 https://github.com/apache/commons-geometry/pull/160 was: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. including: https://github.com/apache/commons-lang/pull/752 https://github.com/apache/commons-configuration/pull/118 https://github.com/apache/commons-dbutils/pull/68 > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > including: > https://github.com/apache/commons-lang/pull/752 > https://github.com/apache/commons-configuration/pull/118 > https://github.com/apache/commons-dbutils/pull/68 > https://github.com/apache/commons-geometry/pull/160 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COMMONSSITE-145: --- Description: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. including: https://github.com/apache/commons-lang/pull/752 https://github.com/apache/commons-configuration/pull/118 https://github.com/apache/commons-dbutils/pull/68 was: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. including: https://github.com/apache/commons-lang/pull/752 https://github.com/apache/commons-configuration/pull/118 > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > including: > https://github.com/apache/commons-lang/pull/752 > https://github.com/apache/commons-configuration/pull/118 > https://github.com/apache/commons-dbutils/pull/68 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COMMONSSITE-145: --- Description: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. including: https://github.com/apache/commons-lang/pull/752 https://github.com/apache/commons-configuration/pull/118 was: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. including: https://github.com/apache/commons-lang/pull/752 > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > including: > https://github.com/apache/commons-lang/pull/752 > https://github.com/apache/commons-configuration/pull/118 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COMMONSSITE-145: --- Description: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. including: https://github.com/apache/commons-lang/pull/752 was:[checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > including: > https://github.com/apache/commons-lang/pull/752 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COMMONSSITE-145: --- Summary: upgrade checkstyle in several commons repos (was: upgrade checkstyles in several commons repos) > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMMONSSITE-145) upgrade checkstyles in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COMMONSSITE-145: --- Description: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to checkstyles 8.42. (was: [checkstyle](https://github.com/checkstyle/checkstyle) 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to checkstyles 8.42.) > upgrade checkstyles in several commons repos > > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > checkstyles 8.42. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMMONSSITE-145) upgrade checkstyles in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COMMONSSITE-145: --- Description: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. (was: [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to checkstyles 8.42.) > upgrade checkstyles in several commons repos > > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COMMONSSITE-145) upgrade checkstyles in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COMMONSSITE-145: --- Description: [checkstyle](https://github.com/checkstyle/checkstyle) 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to checkstyles 8.42. (was: checkstyles 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to checkstyles 8.42.) > upgrade checkstyles in several commons repos > > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > > [checkstyle](https://github.com/checkstyle/checkstyle) 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > checkstyles 8.42. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COMMONSSITE-145) upgrade checkstyles in several commons repos
Jin Xu created COMMONSSITE-145: -- Summary: upgrade checkstyles in several commons repos Key: COMMONSSITE-145 URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 Project: Apache Commons All Issue Type: Improvement Reporter: Jin Xu checkstyles 8.42 changes its grammar, which means some of our repos need a manual change to upgrade to checkstyles 8.42. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (VFS-798) [bug] find a bug about chinese characters in FileObject path then call toFile
Jin Xu created VFS-798: -- Summary: [bug] find a bug about chinese characters in FileObject path then call toFile Key: VFS-798 URL: https://issues.apache.org/jira/browse/VFS-798 Project: Commons VFS Issue Type: Improvement Environment: linux Reporter: Jin Xu https://github.com/apache/commons-vfs/pull/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IO-720) fix error about usage of DirectBuffer in jdk 16/17
[ https://issues.apache.org/jira/browse/IO-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated IO-720: -- Description: https://github.com/apache/commons-io/pull/205 usage of DirectBuffer will cause IllegalAccessError. This pr aims to fix it. was: usage of DirectBuffer will cause IllegalAccessError. This pr aims to fix it. Remaining Estimate: (was: 0h) > fix error about usage of DirectBuffer in jdk 16/17 > -- > > Key: IO-720 > URL: https://issues.apache.org/jira/browse/IO-720 > Project: Commons IO > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 10m > > https://github.com/apache/commons-io/pull/205 > usage of DirectBuffer will cause IllegalAccessError. > This pr aims to fix it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IO-720) fix error about usage of DirectBuffer in jdk 16/17
Jin Xu created IO-720: - Summary: fix error about usage of DirectBuffer in jdk 16/17 Key: IO-720 URL: https://issues.apache.org/jira/browse/IO-720 Project: Commons IO Issue Type: Improvement Reporter: Jin Xu usage of DirectBuffer will cause IllegalAccessError. This pr aims to fix it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286827#comment-17286827 ] Jin Xu edited comment on IO-670 at 2/19/21, 2:46 AM: - [~ggregory] Please review this pr again. I rebased. Thanks. There still be some things in this pr. was (Author: xenoamess): [~ggregory] Please review this pr again. I rebased. Thanks. > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: Jin Xu >Priority: Critical > Attachments: jmh-result.org.apache.json > > Time Spent: 14h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286827#comment-17286827 ] Jin Xu commented on IO-670: --- [~ggregory] Please review this pr again. I rebased. Thanks. > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: Jin Xu >Priority: Critical > Attachments: jmh-result.org.apache.json > > Time Spent: 14h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[ https://issues.apache.org/jira/browse/IO-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated IO-698: -- Description: https://github.com/apache/commons-io/pull/184 > add UnsyncBufferedInputStream and UnsyncBufferedReader and tests > > > Key: IO-698 > URL: https://issues.apache.org/jira/browse/IO-698 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Reporter: Jin Xu >Priority: Minor > > https://github.com/apache/commons-io/pull/184 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
Jin Xu created IO-698: - Summary: add UnsyncBufferedInputStream and UnsyncBufferedReader and tests Key: IO-698 URL: https://issues.apache.org/jira/browse/IO-698 Project: Commons IO Issue Type: Improvement Components: Streams/Writers Reporter: Jin Xu -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COLLECTIONS-766) fix ci build (or to say, fix everything that wrongly blocked the ci build.)
[ https://issues.apache.org/jira/browse/COLLECTIONS-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COLLECTIONS-766: --- Priority: Major (was: Critical) > fix ci build (or to say, fix everything that wrongly blocked the ci build.) > --- > > Key: COLLECTIONS-766 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-766 > Project: Commons Collections > Issue Type: Bug >Reporter: Jin Xu >Priority: Major > > Hi. > The current ci build fails for 3 reasons. > I fixed them all in https://github.com/apache/commons-collections/pull/178 > please have a look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (COLLECTIONS-766) fix ci build (or to say, fix everything that wrongly blocked the ci build.)
[ https://issues.apache.org/jira/browse/COLLECTIONS-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated COLLECTIONS-766: --- Priority: Critical (was: Major) > fix ci build (or to say, fix everything that wrongly blocked the ci build.) > --- > > Key: COLLECTIONS-766 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-766 > Project: Commons Collections > Issue Type: Bug >Reporter: Jin Xu >Priority: Critical > > Hi. > The current ci build fails for 3 reasons. > I fixed them all in https://github.com/apache/commons-collections/pull/178 > please have a look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COLLECTIONS-766) fix ci build (or to say, fix everything that wrongly blocked the ci build.)
Jin Xu created COLLECTIONS-766: -- Summary: fix ci build (or to say, fix everything that wrongly blocked the ci build.) Key: COLLECTIONS-766 URL: https://issues.apache.org/jira/browse/COLLECTIONS-766 Project: Commons Collections Issue Type: Bug Reporter: Jin Xu Hi. The current ci build fails for 3 reasons. I fixed them all in https://github.com/apache/commons-collections/pull/178 please have a look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NUMBERS-152) add a private constructor for already known reduced num and den, to avoid unneeded gcd.
[ https://issues.apache.org/jira/browse/NUMBERS-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated NUMBERS-152: --- Description: https://github.com/apache/commons-numbers/pull/85 currently, even if we already know the num and den be already reduced, we must run a gcd when creating the Fraction object. I think we can provide a private constructor, specially for situations when we can make sure the num and den be already reduced, then we do not invoke the additional gcd round. > add a private constructor for already known reduced num and den, to avoid > unneeded gcd. > --- > > Key: NUMBERS-152 > URL: https://issues.apache.org/jira/browse/NUMBERS-152 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/85 > currently, even if we already know the num and den be already reduced, we > must run a gcd when creating the Fraction object. > I think we can provide a private constructor, specially for situations when > we can make sure the num and den be already reduced, then we do not invoke > the additional gcd round. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NUMBERS-152) add a private constructor for already known reduced num and den, to avoid unneeded gcd.
Jin Xu created NUMBERS-152: -- Summary: add a private constructor for already known reduced num and den, to avoid unneeded gcd. Key: NUMBERS-152 URL: https://issues.apache.org/jira/browse/NUMBERS-152 Project: Commons Numbers Issue Type: Improvement Components: fraction Reporter: Jin Xu -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-150) Fraction.pow to correctly handle Integer.MIN_VALUE as the argument
[ https://issues.apache.org/jira/browse/NUMBERS-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184923#comment-17184923 ] Jin Xu commented on NUMBERS-150: [~erans] ??I vote for x.pow(0) to return 1.?? OK, I will keep in mind not to change this feature. > Fraction.pow to correctly handle Integer.MIN_VALUE as the argument > -- > > Key: NUMBERS-150 > URL: https://issues.apache.org/jira/browse/NUMBERS-150 > Project: Commons Numbers > Issue Type: Bug > Components: fraction >Affects Versions: 1.0-beta1 >Reporter: Jin Xu >Priority: Major > Fix For: 1.0 > > Time Spent: 5h 50m > Remaining Estimate: 0h > > a bug was discovered by [NUMBERS-149]. > here is the fix pr. > https://github.com/apache/commons-numbers/pull/83 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-150) Fraction.pow to correctly handle Integer.MIN_VALUE as the argument
[ https://issues.apache.org/jira/browse/NUMBERS-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184627#comment-17184627 ] Jin Xu commented on NUMBERS-150: [~aherbert] Hi. I suddenly found something not quite right about this. What should returen for Fraction.ZERO.pow(0) ? Shouldn't it throw an Exception or something? > Fraction.pow to correctly handle Integer.MIN_VALUE as the argument > -- > > Key: NUMBERS-150 > URL: https://issues.apache.org/jira/browse/NUMBERS-150 > Project: Commons Numbers > Issue Type: Bug > Components: fraction >Reporter: Jin Xu >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > a bug was discovered by [NUMBERS-149]. > here is the fix pr. > https://github.com/apache/commons-numbers/pull/83 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-151) performance refine for ArithmeticUtils.pow(maybe also bugfix?)
[ https://issues.apache.org/jira/browse/NUMBERS-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184624#comment-17184624 ] Jin Xu commented on NUMBERS-151: Hi. I think this performance refine too obvious, that need not a jmh benchmark. However if you think it need one, then I'm glad to bake one, just reply and ask me :) > performance refine for ArithmeticUtils.pow(maybe also bugfix?) > -- > > Key: NUMBERS-151 > URL: https://issues.apache.org/jira/browse/NUMBERS-151 > Project: Commons Numbers > Issue Type: Improvement > Components: core >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Hi. > right now ArithmeticUtils.pow(0,0) = 1, but not throw an Exception, which I > think not quite right... > Is it a bug? > Anyway, we found a way to faster the calculate, so at least we can get an > performance refine pr. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NUMBERS-151) performance refine for ArithmeticUtils.pow(maybe also bugfix?)
Jin Xu created NUMBERS-151: -- Summary: performance refine for ArithmeticUtils.pow(maybe also bugfix?) Key: NUMBERS-151 URL: https://issues.apache.org/jira/browse/NUMBERS-151 Project: Commons Numbers Issue Type: Improvement Components: core Reporter: Jin Xu Hi. right now ArithmeticUtils.pow(0,0) = 1, but not throw an Exception, which I think not quite right... Is it a bug? Anyway, we found a way to faster the calculate, so at least we can get an performance refine pr. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NUMBERS-150) fix bug in Fraction.pow
[ https://issues.apache.org/jira/browse/NUMBERS-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated NUMBERS-150: --- Description: a bug was discovered by [NUMBERS-149]. here is the fix pr. https://github.com/apache/commons-numbers/pull/83 was: a bug was discovered by [NUMBERS-149]. here is the fix pr. > fix bug in Fraction.pow > --- > > Key: NUMBERS-150 > URL: https://issues.apache.org/jira/browse/NUMBERS-150 > Project: Commons Numbers > Issue Type: Bug > Components: fraction >Reporter: Jin Xu >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > a bug was discovered by [NUMBERS-149]. > here is the fix pr. > https://github.com/apache/commons-numbers/pull/83 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NUMBERS-150) fix bug in Fraction.pow
[ https://issues.apache.org/jira/browse/NUMBERS-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated NUMBERS-150: --- Summary: fix bug in Fraction.pow (was: fix Fraction.pow) > fix bug in Fraction.pow > --- > > Key: NUMBERS-150 > URL: https://issues.apache.org/jira/browse/NUMBERS-150 > Project: Commons Numbers > Issue Type: Bug > Components: fraction >Reporter: Jin Xu >Priority: Major > > a bug was discovered by [NUMBERS-149]. > here is the fix pr. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NUMBERS-150) fix Fraction.pow
Jin Xu created NUMBERS-150: -- Summary: fix Fraction.pow Key: NUMBERS-150 URL: https://issues.apache.org/jira/browse/NUMBERS-150 Project: Commons Numbers Issue Type: Bug Components: fraction Reporter: Jin Xu a bug was discovered by [NUMBERS-149]. here is the fix pr. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-149) port tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184206#comment-17184206 ] Jin Xu commented on NUMBERS-149: [~erans] [~aherbert] I changed the title of this pr to "port tests in commons-lang for Fraction." now change completed/sqruashed, so please re-review again. thanks. notice that some of the tests MUST fail, and they have a reason to. will fix these test errors in another pr.(for pow.) > port tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NUMBERS-149) port tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated NUMBERS-149: --- Summary: port tests in commons-lang for Fraction. (was: port functions / tests in commons-lang for Fraction.) > port tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-149) port functions / tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184198#comment-17184198 ] Jin Xu commented on NUMBERS-149: [~aherbert] got it. thanks for your detailed explanations. > port functions / tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (NUMBERS-149) port functions / tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184183#comment-17184183 ] Jin Xu edited comment on NUMBERS-149 at 8/25/20, 4:40 PM: -- [~erans] btw about ValJO: If you think java.lang.String be ValJO, then actually String cached its hashcode. caching some things doesn't mean it is not ValJO IMO. But I agree this should be on a new seperate pr. was (Author: xenoamess): [~erans] btw about ValJO: If you think java.lang.String be ValJO, then actually String cached its hashcode. caching some things doesn't mean it is not ValJO IMO. > port functions / tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-149) port functions / tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184183#comment-17184183 ] Jin Xu commented on NUMBERS-149: [~erans] btw about ValJO: If you think java.lang.String be ValJO, then actually String cached its hashcode. caching some things doesn't mean it is not ValJO IMO. > port functions / tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-149) port functions / tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184181#comment-17184181 ] Jin Xu commented on NUMBERS-149: [~erans] got it. will do the changes :) > port functions / tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184179#comment-17184179 ] Jin Xu commented on LANG-1601: -- ??Developers willing to do the switch should make the effort to adapt to a different design in exchange for the benefits (like bug fixes). If they don't want to touch their code, they can keep on using the [Lang3] for Fraction even if they upgrade for the rest.?? got it. will change the parts you mentioned. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-149) port functions / tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184156#comment-17184156 ] Jin Xu commented on NUMBERS-149: [~erans] Hi. I deprecated them to make people tend to use api in numbers directly Maybe I shouldn't add the @Deprecated tag? The toString() function is only changed for adding a cache, which I think good, and not change any format IMO. > port functions / tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184127#comment-17184127 ] Jin Xu edited comment on LANG-1601 at 8/25/20, 3:30 PM: [~aherbert] Hi. You are correct in general. You can see what I wanna do in [NUMBERS-149] and https://github.com/apache/commons-numbers/pull/82 In short, this pr contains more things than you said are: 1. modified tests from commons-lang. 2. cached toString and hashCode property, to avoid calculate twice. 3. some changes in function pow (which I think good). 4. more public static Fraction class fields from commons-lang's Fraction. The reduce() method is not required, and become meaningless, but other than deleting it, I found a new usage to give it. You can see more details in that pr. I just, tried to make users feel as less un-familiar as I can, when they try to turn from lang's Fraction to numbers' Fraction. was (Author: xenoamess): [~aherbert] Hi. You are correct in general. You can see what I wanna do in [NUMBERS-149] and https://github.com/apache/commons-numbers/pull/82 In short, this pr contains more things than you said are: 1. modified tests from commons-lang. 2. cached toString and hashCode property, to avoid calculate twice. 3. some changes in function pow (which I think good). The reduce() method is not required, and become meaningless, but other than deleting it, I found a new usage to give it. You can see more details in that pr. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184127#comment-17184127 ] Jin Xu edited comment on LANG-1601 at 8/25/20, 3:28 PM: [~aherbert] Hi. You are correct in general. You can see what I wanna do in [NUMBERS-149] and https://github.com/apache/commons-numbers/pull/82 In short, this pr contains more things than you said are: 1. modified tests from commons-lang. 2. cached toString and hashCode property, to avoid calculate twice. 3. some changes in function pow (which I think good). The reduce() method is not required, and become meaningless, but other than deleting it, I found a new usage to give it. You can see more details in that pr. was (Author: xenoamess): [~aherbert] Hi. You are correct in general. You can see what I wanna do in [NUMBERS-149] and https://github.com/apache/commons-numbers/pull/82 > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184127#comment-17184127 ] Jin Xu commented on LANG-1601: -- [~aherbert] Hi. You are correct in general. You can see what I wanna do in [NUMBERS-149] and https://github.com/apache/commons-numbers/pull/82 > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NUMBERS-149) port functions / tests in commons-lang for Fraction.
[ https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated NUMBERS-149: --- Description: https://github.com/apache/commons-numbers/pull/82 > port functions / tests in commons-lang for Fraction. > > > Key: NUMBERS-149 > URL: https://issues.apache.org/jira/browse/NUMBERS-149 > Project: Commons Numbers > Issue Type: Improvement > Components: fraction >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-numbers/pull/82 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NUMBERS-149) port functions / tests in commons-lang for Fraction.
Jin Xu created NUMBERS-149: -- Summary: port functions / tests in commons-lang for Fraction. Key: NUMBERS-149 URL: https://issues.apache.org/jira/browse/NUMBERS-149 Project: Commons Numbers Issue Type: Improvement Components: fraction Reporter: Jin Xu -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184026#comment-17184026 ] Jin Xu commented on LANG-1601: -- [~ggregory] Hi gary. Gilles suggest we can do *deprecate/remove in lang-4* on Fraction in commons-lang, and suggest use Fraction in commons-number instead. I think it good, and it sounds just like what we've done about removing some StringUtils things into commons-text. But we wanna ask about your opinions. Thanks. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1601) refine performance of Fraction.pow
[
https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184013#comment-17184013
]
Jin Xu edited comment on LANG-1601 at 8/25/20, 1:04 PM:
[~aherbert]
A further thought:
this can be done in ArithmeticUtils.pow(int k, int e),
{code:java}
if ( abs(k) >= 2 && e>=32) {
throw overflow directly.
}
{code}
was (Author: xenoamess):
[~aherbert]
A further thought:
this can be done in ArithmeticUtils.pow(int k, int e),
if ( abs(k) >= 2 && e>=32) {
throw overflow directly.
}
> refine performance of Fraction.pow
> --
>
> Key: LANG-1601
> URL: https://issues.apache.org/jira/browse/LANG-1601
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.math.*
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> https://github.com/apache/commons-lang/pull/611
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (LANG-1601) refine performance of Fraction.pow
[
https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184013#comment-17184013
]
Jin Xu commented on LANG-1601:
--
[~aherbert]
A further thought:
this can be done in ArithmeticUtils.pow(int k, int e),
if ( abs(k) >= 2 && e>=32) {
throw overflow directly.
}
> refine performance of Fraction.pow
> --
>
> Key: LANG-1601
> URL: https://issues.apache.org/jira/browse/LANG-1601
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.math.*
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> https://github.com/apache/commons-lang/pull/611
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183970#comment-17183970 ] Jin Xu edited comment on LANG-1601 at 8/25/20, 12:01 PM: - [~aherbert] Yep, I know why we do this there. Just asking about whether we should handle this also in numbers. I've started a "porting" try, means port every public function interfaces in commons-lang's Fraction into commons-numbers's Fractions. (Though the designing differences I mentioned above might cause some logic/test changes, but we can remain the public interfaces). And next step I will see through all tests in original commons-lang, and delete/renew ones who now not quite correct with the logic in commons-number. Then we can discuss about deprecate commons-lang's Fraction. was (Author: xenoamess): [~aherbert] Yep, I know why we do this there. Just asking about whether we should handle this also in numbers. I've started a "porting" try, means port every public functions in commons-lang's Fraction into commons-numbers's Fractions. (Though the designing differences I mentioned above might cause some logic/test changes, but we can remain the public interfaces). And next step I will see through all tests in original commons-lang, and delete/renew ones who now not quite correct with the logic in commons-number. Then we can discuss about deprecate commons-lang's Fraction. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183970#comment-17183970 ] Jin Xu commented on LANG-1601: -- [~aherbert] Yep, I know why we do this there. Just asking about whether we should handle this also in numbers. I've started a "porting" try, means port every public functions in commons-lang's Fraction into commons-numbers's Fractions. (Though the designing differences I mentioned above might cause some logic/test changes, but we can remain the public interfaces). And next step I will see through all tests in original commons-lang, and delete/renew ones who now not quite correct with the logic in commons-number. Then we can discuss about deprecate commons-lang's Fraction. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183939#comment-17183939 ] Jin Xu commented on LANG-1601: -- [~erans] Hi. After a deeper look at the two sources, I noticed two things. 1. there be some designing differences between the two versions. In commons-lang's version of Fraction, a Fraction is allowed to be created as 6/10, and only when people invoke reduce() will it returns a 3/5. But in commons-numbers's version of Fraction, we make sure the Fraction MUST be redueced when build, i.e. we get Fraction(6,10) , the result we get is actually 3/5, not 6/10. If we want to merge these two Classes, we must write some additional documents for this. 2. in commons-lang's version of Fraction.pow, they have a special treatement to make sure Integer.MIN_VALUE can be used as exponent. Is this valuable? Should I port this feature to the version in commons-numbers? > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183917#comment-17183917 ] Jin Xu edited comment on LANG-1601 at 8/25/20, 10:44 AM: - So I personally agree to remove this function in 4.0, and to deprecate it now. Just like what we did to some functions in StringUtils (move them to commons-text). was (Author: xenoamess): So I personally agree to remove this function in 4.0, and deprecate it now. Just like what we did to some functions in StringUtils (move them to commons-text). > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183917#comment-17183917 ] Jin Xu commented on LANG-1601: -- So I personally agree to remove this function in 4.0, and deprecate it now. Just like what we did to some functions in StringUtils (move them to commons-text). > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183914#comment-17183914 ] Jin Xu edited comment on LANG-1601 at 8/25/20, 10:24 AM: - [~erans] Hi. ??Isn't this class the typical example of why code duplication is to be avoided??? Agreed. ??My remark aimed at deprecating/removing the code in [Lang] after ensuring that the functionality is correctly implemented in [Numbers].?? Agreed, but we'd better discuss about this with gary. ??The differences which you note are implementation details: They don't pertain to the concept of fraction; so a user of [Lang]'s implementation should be able to switch to [Numbers]'s implementation without loosing any important functionality.?? Well, not quite. They have a very strict test for each of the points I pointed out... So if we want to change Fraction.pow in commons-lang's sources to versions in commons-numbers directly, tests about those features will fail. But yes, the main ideas/logics be same, and I don't think any human user will have trouble in switching to numbers. was (Author: xenoamess): [~erans] Hi. ??Isn't this class the typical example of why code duplication is to be avoided??? Agreed. ??My remark aimed at deprecating/removing the code in [Lang] after ensuring that the functionality is correctly implemented in [Numbers].?? Agreed, but we'd better discuss about this with gary. ??The differences which you note are implementation details: They don't pertain to the concept of fraction; so a user of [Lang]'s implementation should be able to switch to [Numbers]'s implementation without loosing any important functionality.?? Well, not quite. They have a very strict test for each of the points I pointed out... So if we want to change Fraction.pow in commons-lang's sources to versions in commons-numbers, tests about those features will fail. But yes, the main ideas/logics be same, and I don't think any human user will have trouble in switching to numbers. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183914#comment-17183914 ] Jin Xu edited comment on LANG-1601 at 8/25/20, 10:21 AM: - [~erans] Hi. ??Isn't this class the typical example of why code duplication is to be avoided??? Agreed. ??My remark aimed at deprecating/removing the code in [Lang] after ensuring that the functionality is correctly implemented in [Numbers].?? Agreed, but we'd better discuss about this with gary. ??The differences which you note are implementation details: They don't pertain to the concept of fraction; so a user of [Lang]'s implementation should be able to switch to [Numbers]'s implementation without loosing any important functionality.?? Well, not quite. They have a very strict test for each of the points I pointed out... So if we want to change Fraction.pow in commons-lang's sources to versions in commons-numbers, tests about those features will fail. But yes, the main ideas/logics be same, and I don't think any human user will have trouble in switching to numbers. was (Author: xenoamess): [~erans] Hi. ??Isn't this class the typical example of why code duplication is to be avoided??? Agreed. ??My remark aimed at deprecating/removing the code in [Lang] after ensuring that the functionality is correctly implemented in [Numbers].?? Agreed, but we'd better discuss about this with gary. ??The differences which you note are implementation details: They don't pertain to the concept of fraction; so a user of [Lang]'s implementation should be able to switch to [Numbers]'s implementation without loosing any important functionality.?? Well, not quite. They have a test for each of the points I pointed out... So if we want to change Fractionpow in commons-lang's sources to versions in commons-numbers, tests about those features will fail. But yes, the main ideas/logics be same, and I don't think any human user will have trouble in switching to numbers. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183914#comment-17183914 ] Jin Xu commented on LANG-1601: -- [~erans] Hi. ??Isn't this class the typical example of why code duplication is to be avoided??? Agreed. ??My remark aimed at deprecating/removing the code in [Lang] after ensuring that the functionality is correctly implemented in [Numbers].?? Agreed, but we'd better discuss about this with gary. ??The differences which you note are implementation details: They don't pertain to the concept of fraction; so a user of [Lang]'s implementation should be able to switch to [Numbers]'s implementation without loosing any important functionality.?? Well, not quite. They have a test for each of the points I pointed out... So if we want to change Fractionpow in commons-lang's sources to versions in commons-numbers, tests about those features will fail. But yes, the main ideas/logics be same, and I don't think any human user will have trouble in switching to numbers. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183831#comment-17183831 ] Jin Xu commented on LANG-1601: -- [~erans] Done. It got really far faster now. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183777#comment-17183777 ] Jin Xu edited comment on LANG-1601 at 8/25/20, 7:27 AM: [~erans] Hi. I checked commons-number's class Fraction's function pow. It looks good, and seems can be ported to commons-lang after several changes. But it also differs slightly in some ways. 1. if exponent == 1, then the pow in commons-lang MUST return the original Fraction Object itself, but MUST NOT return a new created Fraction. 2. if exponent == -1, then the pow in commons-lang MUST return the reversed Fraction Object, but cannot do reduce. 3. otherwise MUST reduce for example, (6/10 , -1) MUST return 10/6 , but MUST NOT return 5/3 However, it really helps, as I get some new ideas about how do a deeper refine. will commit soon. was (Author: xenoamess): [~erans] Hi. I checked commons-number's class Fraction's function pow. It looks good, and seems can be ported to commons-lang after several changes. But it also differs slightly in some ways. 1. if exponent == 1, then the pow in commons-lang MUST return the original Fraction Object itself, but MUST NOT return a new created Fraction. 2. if exponent == -1, then the pow in commons-lang MUST return the reversed Fraction Object, but cannot do trim. for example, (6/10 , -1) MUST return 10/6 , but MUST NOT return 5/3 However, it really helps, as I get some new ideas about how do a deeper refine. will commit soon. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183777#comment-17183777 ] Jin Xu edited comment on LANG-1601 at 8/25/20, 7:21 AM: [~erans] Hi. I checked commons-number's class Fraction's function pow. It looks good, and seems can be ported to commons-lang after several changes. But it also differs slightly in some ways. 1. if exponent == 1, then the pow in commons-lang MUST return the original Fraction Object itself, but MUST NOT return a new created Fraction. 2. if exponent == -1, then the pow in commons-lang MUST return the reversed Fraction Object, but cannot do trim. for example, (6/10 , -1) MUST return 10/6 , but MUST NOT return 5/3 However, it really helps, as I get some new ideas about how do a deeper refine. will commit soon. was (Author: xenoamess): [~erans] Hi. I checked commons-number's class Fraction's function pow. It looks good, and seems can be ported to commons-lang after several changes. But it also differs slightly in some ways. 1. if exponent == 1, then the pow in commons-lang MUST return the original Fraction Object itself. 2. if exponent == -1, then the pow in commons-lang MUST return the reversed Fraction Object, but cannot do trim. for example, (6/10 , -1) MUST return 10/6 , but MUST NOT return 5/3 3. must trim otherwise before do the pow. However, it really helps, as I get some new ideas about how do a deeper refine. will commit soon. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183777#comment-17183777 ] Jin Xu commented on LANG-1601: -- [~erans] Hi. I checked commons-number's class Fraction's function pow. It looks good, and seems can be ported to commons-lang after several changes. But it also differs slightly in some ways. 1. if exponent == 1, then the pow in commons-lang MUST return the original Fraction Object itself. 2. if exponent == -1, then the pow in commons-lang MUST return the reversed Fraction Object, but cannot do trim. for example, (6/10 , -1) MUST return 10/6 , but MUST NOT return 5/3 3. must trim otherwise before do the pow. However, it really helps, as I get some new ideas about how do a deeper refine. will commit soon. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1598) Use JSR-305 (javax.annotation) for Null-Analysis to avoid unexpected NullPointerExceptions
[
https://issues.apache.org/jira/browse/LANG-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183732#comment-17183732
]
Jin Xu commented on LANG-1598:
--
Agreed this idea, but it is a HUGE work if we want to add NotNull and Nullable
to all public functions in commons-lang.
Also I'd prefer using jetbrains Annotations
{code:java}
org.jetbrains
annotations
20.0.0
provided
{code}
for example.
Well it might not be politely but I really doubt any java codes from google
people.
I had a bad experience in handling a really awful google java repo, so I just,
don't think google people can write normal java codes.
> Use JSR-305 (javax.annotation) for Null-Analysis to avoid unexpected
> NullPointerExceptions
> --
>
> Key: LANG-1598
> URL: https://issues.apache.org/jira/browse/LANG-1598
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
>Affects Versions: 3.11
>Reporter: Alexander Guril
>Priority: Major
> Labels: newbie
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Use the javax.annotation-API for Null-Analysis to avoid NPEs.
> {code:XML}
>
>
> com.google.code.findbugs
> jsr305
> 3.0.2
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183722#comment-17183722 ] Jin Xu commented on LANG-1601: -- [~erans] OK. Will find some time to look up at the codes you pointed and see if the refine can port onto them. > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1601) refine performance of Fraction.pow
[ https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1601: - Description: https://github.com/apache/commons-lang/pull/611 > refine performance of Fraction.pow > -- > > Key: LANG-1601 > URL: https://issues.apache.org/jira/browse/LANG-1601 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Jin Xu >Priority: Minor > > https://github.com/apache/commons-lang/pull/611 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1601) refine performance of Fraction.pow
Jin Xu created LANG-1601: Summary: refine performance of Fraction.pow Key: LANG-1601 URL: https://issues.apache.org/jira/browse/LANG-1601 Project: Commons Lang Issue Type: Improvement Components: lang.math.* Reporter: Jin Xu -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IO-680) add more tests for IOUtils.contentEqualsIgnoreEOL
Jin Xu created IO-680: - Summary: add more tests for IOUtils.contentEqualsIgnoreEOL Key: IO-680 URL: https://issues.apache.org/jira/browse/IO-680 Project: Commons IO Issue Type: Test Reporter: Jin Xu [https://github.com/apache/commons-io/pull/137] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (LANG-1581) refine StringUtils.getFuzzyDistance
[ https://issues.apache.org/jira/browse/LANG-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed LANG-1581. Resolution: Not A Problem jmh test shows this pr is meaningless. > refine StringUtils.getFuzzyDistance > --- > > Key: LANG-1581 > URL: https://issues.apache.org/jira/browse/LANG-1581 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/570] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (LANG-1575) remake StringUtils.capitalize
[ https://issues.apache.org/jira/browse/LANG-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed LANG-1575. Resolution: Won't Do nope, this pr is meaningless. will close it. > remake StringUtils.capitalize > - > > Key: LANG-1575 > URL: https://issues.apache.org/jira/browse/LANG-1575 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/563] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (TEXT-180) Minor improvements
[ https://issues.apache.org/jira/browse/TEXT-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed TEXT-180. --- Resolution: Fixed > Minor improvements > -- > > Key: TEXT-180 > URL: https://issues.apache.org/jira/browse/TEXT-180 > Project: Commons Text > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > > Minor improvements to Commons Text -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (TEXT-181) Fix Javadocs
[ https://issues.apache.org/jira/browse/TEXT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed TEXT-181. --- > Fix Javadocs > > > Key: TEXT-181 > URL: https://issues.apache.org/jira/browse/TEXT-181 > Project: Commons Text > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Major > Fix For: 1.9 > > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-text/pull/135] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (TEXT-183) Make ConstantStringLookup.constantCache final
[ https://issues.apache.org/jira/browse/TEXT-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed TEXT-183. --- > Make ConstantStringLookup.constantCache final > - > > Key: TEXT-183 > URL: https://issues.apache.org/jira/browse/TEXT-183 > Project: Commons Text > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 1.9 > > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-text/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (TEXT-182) Fix typos
[ https://issues.apache.org/jira/browse/TEXT-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed TEXT-182. --- > Fix typos > - > > Key: TEXT-182 > URL: https://issues.apache.org/jira/browse/TEXT-182 > Project: Commons Text > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 1.9 > > Time Spent: 20m > Remaining Estimate: 0h > > https://github.com/apache/commons-text/pull/137 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (TEXT-184) Simplify if in CaseUtils
[ https://issues.apache.org/jira/browse/TEXT-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed TEXT-184. --- > Simplify if in CaseUtils > > > Key: TEXT-184 > URL: https://issues.apache.org/jira/browse/TEXT-184 > Project: Commons Text > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 1.9 > > Time Spent: 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-text/pull/134] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TEXT-183) add final to ConstantStringLookup.constantCache
Jin Xu created TEXT-183: --- Summary: add final to ConstantStringLookup.constantCache Key: TEXT-183 URL: https://issues.apache.org/jira/browse/TEXT-183 Project: Commons Text Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-text/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TEXT-184) simplify if in CaseUtils
Jin Xu created TEXT-184: --- Summary: simplify if in CaseUtils Key: TEXT-184 URL: https://issues.apache.org/jira/browse/TEXT-184 Project: Commons Text Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-text/pull/134] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TEXT-182) fix typos
Jin Xu created TEXT-182: --- Summary: fix typos Key: TEXT-182 URL: https://issues.apache.org/jira/browse/TEXT-182 Project: Commons Text Issue Type: Sub-task Reporter: Jin Xu https://github.com/apache/commons-text/pull/137 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TEXT-181) fix javadocs
Jin Xu created TEXT-181: --- Summary: fix javadocs Key: TEXT-181 URL: https://issues.apache.org/jira/browse/TEXT-181 Project: Commons Text Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-text/pull/135] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEXT-180) Minor improvements
[ https://issues.apache.org/jira/browse/TEXT-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated TEXT-180: Issue Type: Improvement (was: Bug) > Minor improvements > -- > > Key: TEXT-180 > URL: https://issues.apache.org/jira/browse/TEXT-180 > Project: Commons Text > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > > Minor improvements to Commons Text -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TEXT-180) Minor improvements
Jin Xu created TEXT-180: --- Summary: Minor improvements Key: TEXT-180 URL: https://issues.apache.org/jira/browse/TEXT-180 Project: Commons Text Issue Type: Bug Reporter: Jin Xu Minor improvements to Commons Text -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (LANG-1547) Minor improvements
[ https://issues.apache.org/jira/browse/LANG-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed LANG-1547. closed as completed. thanks. > Minor improvements > -- > > Key: LANG-1547 > URL: https://issues.apache.org/jira/browse/LANG-1547 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > original pr : > [https://github.com/apache/commons-lang/pull/533|https://github.com/apache/commons-lang/pull/536] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1588) refine StringUtils.center
Jin Xu created LANG-1588: Summary: refine StringUtils.center Key: LANG-1588 URL: https://issues.apache.org/jira/browse/LANG-1588 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/577] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1587) refine StringUtils.strip
Jin Xu created LANG-1587: Summary: refine StringUtils.strip Key: LANG-1587 URL: https://issues.apache.org/jira/browse/LANG-1587 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu https://github.com/apache/commons-lang/pull/576 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1586) refine StringUtils.wrap
Jin Xu created LANG-1586: Summary: refine StringUtils.wrap Key: LANG-1586 URL: https://issues.apache.org/jira/browse/LANG-1586 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/575] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1572) implement TODO in CharSequenceUtils.indexOf : remake it.
[ https://issues.apache.org/jira/browse/LANG-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1572: - Priority: Major (was: Minor) > implement TODO in CharSequenceUtils.indexOf : remake it. > > > Key: LANG-1572 > URL: https://issues.apache.org/jira/browse/LANG-1572 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/560] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1585) refine performance of StringUtils.normalizeSpace
Jin Xu created LANG-1585: Summary: refine performance of StringUtils.normalizeSpace Key: LANG-1585 URL: https://issues.apache.org/jira/browse/LANG-1585 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/574] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1584) refine StringUtils.isNumericSpace
Jin Xu created LANG-1584: Summary: refine StringUtils.isNumericSpace Key: LANG-1584 URL: https://issues.apache.org/jira/browse/LANG-1584 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu https://github.com/apache/commons-lang/pull/573 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1583) refine StringUtils.isMixedCase
Jin Xu created LANG-1583: Summary: refine StringUtils.isMixedCase Key: LANG-1583 URL: https://issues.apache.org/jira/browse/LANG-1583 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/572] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1582) refine StringUtils.indexOfDifference
Jin Xu created LANG-1582: Summary: refine StringUtils.indexOfDifference Key: LANG-1582 URL: https://issues.apache.org/jira/browse/LANG-1582 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/571] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1581) refine StringUtils.getFuzzyDistance
Jin Xu created LANG-1581: Summary: refine StringUtils.getFuzzyDistance Key: LANG-1581 URL: https://issues.apache.org/jira/browse/LANG-1581 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/570] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1580) refine StringUtils.deleteWhitespace
Jin Xu created LANG-1580: Summary: refine StringUtils.deleteWhitespace Key: LANG-1580 URL: https://issues.apache.org/jira/browse/LANG-1580 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/569] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1579) refine StringUtils.convertRemainingAccentCharacters
Jin Xu created LANG-1579: Summary: refine StringUtils.convertRemainingAccentCharacters Key: LANG-1579 URL: https://issues.apache.org/jira/browse/LANG-1579 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/568] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1575) remake StringUtils.capitalize
[ https://issues.apache.org/jira/browse/LANG-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1575: - Summary: remake StringUtils.capitalize (was: remake capitalize) > remake StringUtils.capitalize > - > > Key: LANG-1575 > URL: https://issues.apache.org/jira/browse/LANG-1575 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/563] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1576: - Summary: refine StringUtils.chomp (was: refine chomp) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1577) refine StringUtils.chop
[ https://issues.apache.org/jira/browse/LANG-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1577: - Summary: refine StringUtils.chop (was: refine chop ) > refine StringUtils.chop > > > Key: LANG-1577 > URL: https://issues.apache.org/jira/browse/LANG-1577 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/566] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1574) refine CharSequenceUtils.toCharArray
[ https://issues.apache.org/jira/browse/LANG-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1574: - Summary: refine CharSequenceUtils.toCharArray (was: refine toCharArray) > refine CharSequenceUtils.toCharArray > > > Key: LANG-1574 > URL: https://issues.apache.org/jira/browse/LANG-1574 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/562] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1578) refine StringUtils.compare
Jin Xu created LANG-1578: Summary: refine StringUtils.compare Key: LANG-1578 URL: https://issues.apache.org/jira/browse/LANG-1578 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu https://github.com/apache/commons-lang/pull/567 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1577) refine chop
Jin Xu created LANG-1577: Summary: refine chop Key: LANG-1577 URL: https://issues.apache.org/jira/browse/LANG-1577 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/566] -- This message was sent by Atlassian Jira (v8.3.4#803005)
