[GitHub] flink pull request #4939: [FLINK-4228][yarn/s3a] fix yarn resource upload s3...

2017-11-03 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4939#discussion_r148756933 --- Diff: flink-filesystems/flink-s3-fs-hadoop/pom.xml --- @@ -182,6 +182,21 @@ under the License. ${project.version}

[jira] [Commented] (FLINK-4228) YARN artifact upload does not work with S3AFileSystem

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237462#comment-16237462 ] ASF GitHub Bot commented on FLINK-4228: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4939: [FLINK-4228][yarn/s3a] fix yarn resource upload s3...

2017-11-03 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4939#discussion_r148756295 --- Diff: flink-filesystems/flink-s3-fs-hadoop/src/test/java/org/apache/flink/fs/s3hadoop/HadoopS3FileSystemITCase.java --- @@ -57,11 +62,52 @@

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237452#comment-16237452 ] ASF GitHub Bot commented on FLINK-7870: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-03 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148754660 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java --- @@ -316,6 +316,13 @@ private void

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237447#comment-16237447 ] ASF GitHub Bot commented on FLINK-7870: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-03 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148754465 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -302,7 +302,12 @@ public boolean

[GitHub] flink issue #4931: [FLINK-7420] Move all Avro code to flink-avro

2017-11-03 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4931 I posted a followup to this pull request in #4942 ---

[jira] [Commented] (FLINK-7420) Move all Avro code to flink-avro

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237440#comment-16237440 ] ASF GitHub Bot commented on FLINK-7420: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-7420) Move all Avro code to flink-avro

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237437#comment-16237437 ] ASF GitHub Bot commented on FLINK-7420: --- GitHub user StephanEwen opened a pull request:

[GitHub] flink pull request #4942: [FLINK-7420] [avro] Move all Avro code to flink-av...

2017-11-03 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/4942 [FLINK-7420] [avro] Move all Avro code to flink-avro (followup) ## What is the purpose of the change This is an extension of #4931 which adds some cleanups and improvements. Most

[jira] [Commented] (FLINK-6434) There may be allocatedSlots leak in SlotPool

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237426#comment-16237426 ] ASF GitHub Bot commented on FLINK-6434: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-03 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148750995 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java --- @@ -262,23 +263,36 @@ public void disconnectResourceManager()

[jira] [Commented] (FLINK-7947) Let ParameterTool return a dedicated GlobalJobParameters object

2017-11-03 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237418#comment-16237418 ] Till Rohrmann commented on FLINK-7947: -- I think so because {{ParameterTool}} has unfortunately been

[jira] [Created] (FLINK-7972) Move SerializationSchema to flink-core

2017-11-03 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-7972: --- Summary: Move SerializationSchema to flink-core Key: FLINK-7972 URL: https://issues.apache.org/jira/browse/FLINK-7972 Project: Flink Issue Type: Improvement

[jira] [Closed] (FLINK-6226) ScalarFunction and TableFunction do not support parameters of byte, short and float

2017-11-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6226. Resolution: Cannot Reproduce Fix Version/s: 1.3.3 1.4.0 Could not

[jira] [Closed] (FLINK-7968) Deduplicate serializer classes between runtime and queryable state

2017-11-03 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-7968. --- > Deduplicate serializer classes between runtime and queryable state >

[jira] [Resolved] (FLINK-7968) Deduplicate serializer classes between runtime and queryable state

2017-11-03 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-7968. - Resolution: Fixed Fixed via 37df826e4e1355a2cba89a85ea94257d40785cb2 > Deduplicate serializer

[GitHub] flink pull request #4935: [Flink-7945][Metrics]Fix per partition-l...

2017-11-03 Thread Aitozi
Github user Aitozi commented on a diff in the pull request: https://github.com/apache/flink/pull/4935#discussion_r148738495 --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --- @@

[GitHub] flink pull request #4935: [Flink-7945][Metrics]Fix per partition-l...

2017-11-03 Thread Aitozi
Github user Aitozi commented on a diff in the pull request: https://github.com/apache/flink/pull/4935#discussion_r148738023 --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --- @@

[jira] [Closed] (FLINK-7421) AvroRow(De)serializationSchema not serializable

2017-11-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7421. Resolution: Fixed Fix Version/s: 1.3.3 1.4.0 Fixed for 1.3.3 with

[jira] [Closed] (FLINK-7338) User Defined aggregation with constants causes error under in lowerbound over window extraction

2017-11-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7338. Resolution: Fixed Fix Version/s: 1.4.0 Fixed for 1.4.0 with

[jira] [Commented] (FLINK-7971) Fix potential NPE with inconsistent state

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237259#comment-16237259 ] ASF GitHub Bot commented on FLINK-7971: --- GitHub user Xpray opened a pull request:

[GitHub] flink pull request #4941: [FLINK-7971][TableAPI & SQL] Fix potential NPE wit...

2017-11-03 Thread Xpray
GitHub user Xpray opened a pull request: https://github.com/apache/flink/pull/4941 [FLINK-7971][TableAPI & SQL] Fix potential NPE with inconsistent state ## What is the purpose of the change fix potential NPE with inconsistent state ## Brief change log

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237221#comment-16237221 ] ASF GitHub Bot commented on FLINK-7959: --- GitHub user KurtYoung opened a pull request:

[GitHub] flink pull request #4940: [FLINK-7959] [table] Split CodeGenerator into Code...

2017-11-03 Thread KurtYoung
GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/4940 [FLINK-7959] [table] Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator. ## What is the purpose of the change Split current `CodeGenerator` into two dedicated

[jira] [Commented] (FLINK-6434) There may be allocatedSlots leak in SlotPool

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237187#comment-16237187 ] ASF GitHub Bot commented on FLINK-6434: --- Github user shuai-xu commented on a diff in the pull

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-03 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148718854 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java --- @@ -262,23 +263,36 @@ public void disconnectResourceManager() {

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-03 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148716173 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -874,6 +894,13 @@ public void handleError(final

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237169#comment-16237169 ] ASF GitHub Bot commented on FLINK-7870: --- Github user shuai-xu commented on a diff in the pull

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237162#comment-16237162 ] ASF GitHub Bot commented on FLINK-7870: --- Github user shuai-xu commented on a diff in the pull

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-03 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148715689 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceActions.java --- @@ -52,4 +52,6 @@ * @param

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-11-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237161#comment-16237161 ] ASF GitHub Bot commented on FLINK-7870: --- Github user shuai-xu commented on a diff in the pull

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-03 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148715651 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -302,7 +302,12 @@ public boolean

[jira] [Updated] (FLINK-7971) Fix potential NPE with inconsistent state

2017-11-03 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruidong Li updated FLINK-7971: -- Description: In {{GroupAggProcessFunction}}, the status of {{state}} and {{cntState}} are not

[jira] [Created] (FLINK-7971) Fix potential NPE with inconsistent state

2017-11-03 Thread Ruidong Li (JIRA)
Ruidong Li created FLINK-7971: - Summary: Fix potential NPE with inconsistent state Key: FLINK-7971 URL: https://issues.apache.org/jira/browse/FLINK-7971 Project: Flink Issue Type: Bug

<    1   2