[jira] [Created] (FLINK-8218) move flink-connector-kinesis examples from /src to /test

2017-12-06 Thread Bowen Li (JIRA)
Bowen Li created FLINK-8218: --- Summary: move flink-connector-kinesis examples from /src to /test Key: FLINK-8218 URL: https://issues.apache.org/jira/browse/FLINK-8218 Project: Flink Issue Type:

[jira] [Commented] (FLINK-8149) Replace usages of deprecated SerializationSchema

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281455#comment-16281455 ] ASF GitHub Bot commented on FLINK-8149: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5069: [FLINK-8149][kinesis] Replace usages of deprecated Serial...

2017-12-06 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5069 @bowenli86 do you mean the `ProduceIntoKinesis` and `ConsumeFromKinesis` classes? I agree that we should move them to `/test`, but we should consider that as a separate issue than this one.

[jira] [Commented] (FLINK-8149) Replace usages of deprecated SerializationSchema

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281449#comment-16281449 ] ASF GitHub Bot commented on FLINK-8149: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5069: [FLINK-8149][kinesis] Replace usages of deprecated Serial...

2017-12-06 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5069 @tzulitai @yew1eb I just saw the code in src tree and traced back to this PR. I feel it's really bad to have runnable examples (with java main method) in a lib jar that Flink distributes.

[jira] [Created] (FLINK-8217) Properly annotate APIs of flink-connector-kinesis

2017-12-06 Thread Bowen Li (JIRA)
Bowen Li created FLINK-8217: --- Summary: Properly annotate APIs of flink-connector-kinesis Key: FLINK-8217 URL: https://issues.apache.org/jira/browse/FLINK-8217 Project: Flink Issue Type: Sub-task

[GitHub] flink pull request #5130: [FLINK-8216] Unify test utils in flink-connector-k...

2017-12-06 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5130 [FLINK-8216] Unify test utils in flink-connector-kinesis ## What is the purpose of the change currently there are a few ways to get a `Properties` object with required fields (aws access

[jira] [Commented] (FLINK-8216) Unify test utils in flink-connector-kinesis

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281434#comment-16281434 ] ASF GitHub Bot commented on FLINK-8216: --- GitHub user bowenli86 opened a pull request:

[jira] [Created] (FLINK-8216) Unify test utils in flink-connector-kinesis

2017-12-06 Thread Bowen Li (JIRA)
Bowen Li created FLINK-8216: --- Summary: Unify test utils in flink-connector-kinesis Key: FLINK-8216 URL: https://issues.apache.org/jira/browse/FLINK-8216 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-7897) Consider using nio.Files for file deletion in TransientBlobCleanupTask

2017-12-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7897: -- Component/s: Local Runtime > Consider using nio.Files for file deletion in TransientBlobCleanupTask >

[jira] [Created] (FLINK-8215) Collections codegen exception when constructing Array or Map via SQL API

2017-12-06 Thread Rong Rong (JIRA)
Rong Rong created FLINK-8215: Summary: Collections codegen exception when constructing Array or Map via SQL API Key: FLINK-8215 URL: https://issues.apache.org/jira/browse/FLINK-8215 Project: Flink

[jira] [Commented] (FLINK-8205) Multi key get

2017-12-06 Thread Martin Eden (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281078#comment-16281078 ] Martin Eden commented on FLINK-8205: Hi [~kkl0u]. Glad it was already on the map. We are using 1.3.2

[GitHub] flink pull request #5129: [Hotfix for State doc in 1.4 and 1.5] update State...

2017-12-06 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5129 [Hotfix for State doc in 1.4 and 1.5] update State's doc and javaDoc to clarify replacement of foldingstate ## What is the purpose of the change Clarify that `aggregatingstate` is the

[jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280664#comment-16280664 ] ASF GitHub Bot commented on FLINK-4812: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5125: [WIP][FLINK-4812][metrics] Expose currentLowWaterm...

2017-12-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5125#discussion_r155327970 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java --- @@ -80,7 +91,10 @@ public void init()

[jira] [Commented] (FLINK-8174) Mesos RM unable to accept offers for unreserved resources

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280547#comment-16280547 ] ASF GitHub Bot commented on FLINK-8174: --- Github user EronWright commented on the issue:

[GitHub] flink issue #5114: [FLINK-8174] [mesos] Mesos RM unable to accept offers for...

2017-12-06 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/5114 @tillrohrmann should we patch the 1.3 release too? Or is 1.3.2 the last release there? ---

[jira] [Commented] (FLINK-8120) Cannot access Web UI from YARN application overview in FLIP-6 mode

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280513#comment-16280513 ] ASF GitHub Bot commented on FLINK-8120: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5128: [FLINK-8120] [flip6] Register Yarn application wit...

2017-12-06 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5128 [FLINK-8120] [flip6] Register Yarn application with correct tracking URL ## What is the purpose of the change The cluster entrypoints start the ResourceManager with the web interface

[jira] [Commented] (FLINK-8087) Decouple Slot from SlotPool

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280506#comment-16280506 ] ASF GitHub Bot commented on FLINK-8087: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5088: [FLINK-8087] Decouple Slot from AllocatedSlot

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5088#discussion_r155296898 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/AllocatedSlot.java --- @@ -144,6 +144,78 @@ public TaskManagerGateway

[jira] [Assigned] (FLINK-8120) Cannot access Web UI from YARN application overview in FLIP-6 mode

2017-12-06 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-8120: Assignee: Till Rohrmann > Cannot access Web UI from YARN application overview in FLIP-6

[jira] [Commented] (FLINK-7746) move ResultPartitionWriter#writeBufferToAllChannels up into ResultPartition

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280454#comment-16280454 ] ASF GitHub Bot commented on FLINK-7746: --- Github user NicoK closed the pull request at:

[jira] [Commented] (FLINK-7746) move ResultPartitionWriter#writeBufferToAllChannels up into ResultPartition

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280453#comment-16280453 ] ASF GitHub Bot commented on FLINK-7746: --- Github user NicoK commented on the issue:

[GitHub] flink pull request #4759: [FLINK-7746][network] move ResultPartitionWriter#w...

2017-12-06 Thread NicoK
Github user NicoK closed the pull request at: https://github.com/apache/flink/pull/4759 ---

[GitHub] flink issue #4759: [FLINK-7746][network] move ResultPartitionWriter#writeBuf...

2017-12-06 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4759 closed in favour of a different approach in #5127 ---

[jira] [Commented] (FLINK-7749) Refactor the ResultPartitionWriter into an interface

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280446#comment-16280446 ] ASF GitHub Bot commented on FLINK-7749: --- Github user NicoK closed the pull request at:

[jira] [Commented] (FLINK-7749) Refactor the ResultPartitionWriter into an interface

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280445#comment-16280445 ] ASF GitHub Bot commented on FLINK-7749: --- Github user NicoK commented on the issue:

[GitHub] flink pull request #4762: [FLINK-7749][network] remove the ResultPartitionWr...

2017-12-06 Thread NicoK
Github user NicoK closed the pull request at: https://github.com/apache/flink/pull/4762 ---

[GitHub] flink issue #4762: [FLINK-7749][network] remove the ResultPartitionWriter wr...

2017-12-06 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4762 closed in favour of #5127 ---

[jira] [Commented] (FLINK-7749) Refactor the ResultPartitionWriter into an interface

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280441#comment-16280441 ] ASF GitHub Bot commented on FLINK-7749: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #5127: [FLINK-7749][network] refactor the ResultPartition...

2017-12-06 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5127 [FLINK-7749][network] refactor the ResultPartitionWriter into an interface ## What is the purpose of the change After moving task event notification into the `TaskEventDispatcher` (#4761),

[jira] [Commented] (FLINK-8087) Decouple Slot from SlotPool

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280378#comment-16280378 ] ASF GitHub Bot commented on FLINK-8087: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5088: [FLINK-8087] Decouple Slot from AllocatedSlot

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5088#discussion_r155279729 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java --- @@ -312,24 +312,36 @@ public void returnAllocatedSlot(Slot slot) {

[jira] [Commented] (FLINK-8087) Decouple Slot from SlotPool

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280352#comment-16280352 ] ASF GitHub Bot commented on FLINK-8087: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5088: [FLINK-8087] Decouple Slot from AllocatedSlot

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5088#discussion_r155276432 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/slots/SlotContext.java --- @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-7974) AbstractServerBase#shutdown does not wait for shutdown completion

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280339#comment-16280339 ] ASF GitHub Bot commented on FLINK-7974: --- Github user kl0u commented on the issue:

[GitHub] flink issue #4993: [FLINK-7974][FLINK-7975][QS] Wait for shutdown in QS clie...

2017-12-06 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4993 It was merged as part of https://github.com/apache/flink/pull/5062 ---

[jira] [Commented] (FLINK-7974) AbstractServerBase#shutdown does not wait for shutdown completion

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280336#comment-16280336 ] ASF GitHub Bot commented on FLINK-7974: --- Github user kl0u closed the pull request at:

[GitHub] flink pull request #4993: [FLINK-7974][FLINK-7975][QS] Wait for shutdown in ...

2017-12-06 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/4993 ---

[jira] [Closed] (FLINK-7974) AbstractServerBase#shutdown does not wait for shutdown completion

2017-12-06 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-7974. - Resolution: Fixed Release Note: Merged on master (74d052bb045031363652116ab8226d8ac00e0cd0)

[jira] [Closed] (FLINK-7975) Queryable state client does not wait for shutdown completion

2017-12-06 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-7975. - Resolution: Fixed Merged on master (5760677b3bb26245ca4816548833da0257ec7c7a) and 1.4. >

[jira] [Closed] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-12-06 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-7880. - Resolution: Fixed Merged on master (a3fd548e9c76c67609bbf159d5fb743d756450b1) and 1.4. >

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280295#comment-16280295 ] ASF GitHub Bot commented on FLINK-7880: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5062 ---

[jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280264#comment-16280264 ] ASF GitHub Bot commented on FLINK-4812: --- Github user aljoscha commented on a diff in the pull

[jira] [Updated] (FLINK-8205) Multi key get

2017-12-06 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-8205: -- Fix Version/s: (was: 1.4.0) 1.5.0 > Multi key get > - > >

[jira] [Commented] (FLINK-8087) Decouple Slot from SlotPool

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280265#comment-16280265 ] ASF GitHub Bot commented on FLINK-8087: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5088: [FLINK-8087] Decouple Slot from AllocatedSlot

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5088#discussion_r155258087 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotsTestImplContext.java --- @@ -31,7 +30,7 @@ import static

[GitHub] flink pull request #5125: [WIP][FLINK-4812][metrics] Expose currentLowWaterm...

2017-12-06 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5125#discussion_r155257760 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java --- @@ -80,7 +91,10 @@ public void init()

[jira] [Created] (FLINK-8214) Do not use mockito for collecting results in StreamMockEnvironment

2017-12-06 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-8214: - Summary: Do not use mockito for collecting results in StreamMockEnvironment Key: FLINK-8214 URL: https://issues.apache.org/jira/browse/FLINK-8214 Project: Flink

[jira] [Created] (FLINK-8213) Prevent potential metric-related ClassCastExceptions

2017-12-06 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-8213: --- Summary: Prevent potential metric-related ClassCastExceptions Key: FLINK-8213 URL: https://issues.apache.org/jira/browse/FLINK-8213 Project: Flink

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280221#comment-16280221 ] ASF GitHub Bot commented on FLINK-8176: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280222#comment-16280222 ] ASF GitHub Bot commented on FLINK-8176: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r155245759 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -507,6 +514,41 @@ public void handleError(final Exception

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r155245771 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -507,6 +514,41 @@ public void handleError(final Exception

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280210#comment-16280210 ] ASF GitHub Bot commented on FLINK-8176: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280212#comment-16280212 ] ASF GitHub Bot commented on FLINK-8176: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r155242826 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java --- @@ -86,122 +125,143 @@ public static void teardown() {

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r155242900 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java --- @@ -86,122 +125,143 @@ public static void teardown() {

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r155242108 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InMemorySubmittedJobGraphStore.java --- @@ -0,0 +1,90 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280199#comment-16280199 ] ASF GitHub Bot commented on FLINK-8176: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r155240139 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InMemorySubmittedJobGraphStore.java --- @@ -0,0 +1,90 @@ +/* + * Licensed to

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-06 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r155237910 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java --- @@ -86,122 +125,143 @@ public static void teardown()

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-06 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r155225461 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -507,6 +514,41 @@ public void handleError(final

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280189#comment-16280189 ] ASF GitHub Bot commented on FLINK-8176: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280188#comment-16280188 ] ASF GitHub Bot commented on FLINK-8176: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280187#comment-16280187 ] ASF GitHub Bot commented on FLINK-8176: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280185#comment-16280185 ] ASF GitHub Bot commented on FLINK-8176: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280186#comment-16280186 ] ASF GitHub Bot commented on FLINK-8176: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-06 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r155225963 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java --- @@ -86,122 +125,143 @@ public static void teardown()

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-06 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r155229002 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InMemorySubmittedJobGraphStore.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-06 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r155225574 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -507,6 +514,41 @@ public void handleError(final

[GitHub] flink issue #5062: [FLINK-7880][QS] Wait for proper resource cleanup after e...

2017-12-06 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5062 Thanks @zentol ! I will let another travis run, and then merge. ---

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280184#comment-16280184 ] ASF GitHub Bot commented on FLINK-7880: --- Github user kl0u commented on the issue:

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280140#comment-16280140 ] ASF GitHub Bot commented on FLINK-7880: --- Github user zentol commented on the issue:

[GitHub] flink issue #5062: [FLINK-7880][QS] Wait for proper resource cleanup after e...

2017-12-06 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5062 👍 ---

[jira] [Commented] (FLINK-8085) Thin out the LogicalSlot interface

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280136#comment-16280136 ] ASF GitHub Bot commented on FLINK-8085: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5087: [FLINK-8085] Thin out LogicalSlot interface

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5087#discussion_r155227397 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SimpleSlot.java --- @@ -208,27 +209,61 @@ public void setLocality(Locality locality) {

[jira] [Commented] (FLINK-8085) Thin out the LogicalSlot interface

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280127#comment-16280127 ] ASF GitHub Bot commented on FLINK-8085: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5087: [FLINK-8085] Thin out LogicalSlot interface

2017-12-06 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5087#discussion_r155225733 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/LogicalSlot.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280124#comment-16280124 ] ASF GitHub Bot commented on FLINK-7880: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280126#comment-16280126 ] ASF GitHub Bot commented on FLINK-7880: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280125#comment-16280125 ] ASF GitHub Bot commented on FLINK-7880: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r155224199 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java --- @@ -224,6 +225,7 @@

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r155224312 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java --- @@ -234,9 +236,14 @@

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r155225199 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java ---

[jira] [Comment Edited] (FLINK-8073) Test instability FlinkKafkaProducer011ITCase.testScaleDownBeforeFirstCheckpoint()

2017-12-06 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278585#comment-16278585 ] Till Rohrmann edited comment on FLINK-8073 at 12/6/17 12:26 PM: Happened

[jira] [Closed] (FLINK-8211) Rename ResultPartitionWriter to OutputGate

2017-12-06 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-8211. - Resolution: Won't Fix > Rename ResultPartitionWriter to OutputGate >

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r155212885 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/NonHAAbstractQueryableStateTestBase.java ---

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280060#comment-16280060 ] ASF GitHub Bot commented on FLINK-7880: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280061#comment-16280061 ] ASF GitHub Bot commented on FLINK-7880: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r155212865 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/HAAbstractQueryableStateTestBase.java ---

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r155212313 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java --- @@

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280057#comment-16280057 ] ASF GitHub Bot commented on FLINK-7880: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-8205) Multi key get

2017-12-06 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280053#comment-16280053 ] Kostas Kloudas commented on FLINK-8205: --- Hi [~MartinEden131] ! That is a nice idea, and something we

[jira] [Commented] (FLINK-7928) Extend the filed in ResourceProfile for precisely calculating the resource of a task manager

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280050#comment-16280050 ] ASF GitHub Bot commented on FLINK-7928: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4991: [FLINK-7928] [runtime] extend the resources in Res...

2017-12-06 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4991#discussion_r155211436 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java --- @@ -61,16 +80,26 @@ * @param

[jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators

2017-12-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280046#comment-16280046 ] ASF GitHub Bot commented on FLINK-4812: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5125: [WIP][FLINK-4812][metrics] Expose currentLowWaterm...

2017-12-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5125#discussion_r155210876 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java --- @@ -80,7 +91,10 @@ public void init()

  1   2   >