[jira] [Commented] (FLINK-8220) Implement set of network throughput benchmarks in Flink

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283159#comment-16283159 ] ASF GitHub Bot commented on FLINK-8220: --- Github user pnowojski commented on the issue:

[GitHub] flink issue #5134: [FLINK-8220] Implement set of network benchmarks

2017-12-07 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/5134 @zentol putting this code in external repository would make those benchmarks very fragile, since they depend on Flink internals. Almost any refactor made in Flink's network stack would brake the

[GitHub] flink issue #5112: [FLINK-8175] remove flink-streaming-contrib and migrate i...

2017-12-07 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5112 Hi @tillrohrmann , per our discussion, I sent out an email to dev@flink, but seems it didn't catch any attention. What do you think about this PR? ---

[jira] [Commented] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283113#comment-16283113 ] ASF GitHub Bot commented on FLINK-8175: --- Github user bowenli86 commented on the issue:

[GitHub] flink pull request #5138: [FLINK-8192] Properly annotate APIs of flink-conne...

2017-12-07 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5138 [FLINK-8192] Properly annotate APIs of flink-connector-kinesis ## What is the purpose of the change Properly annotate classes in flink-connector-kinesis ## Brief change log

[jira] [Commented] (FLINK-8192) Properly annotate APIs of all Flink connectors with @Public / @PublicEvolving / @Internal

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283108#comment-16283108 ] ASF GitHub Bot commented on FLINK-8192: --- GitHub user bowenli86 opened a pull request:

[GitHub] flink pull request #4991: [FLINK-7928] [runtime] extend the resources in Res...

2017-12-07 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4991#discussion_r155708446 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java --- @@ -61,16 +80,26 @@ * @param

[GitHub] flink issue #4911: [FLINK-7878] [api] make resource type extendible in Resou...

2017-12-07 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/4911 @tillrohrmann , I agree with you that adding a build looks better, I changed it according to your comments. Do you think it works now? ---

[jira] [Commented] (FLINK-7878) Extend the resource type user can define in ResourceSpec

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282937#comment-16282937 ] ASF GitHub Bot commented on FLINK-7878: --- Github user shuai-xu commented on the issue:

[GitHub] flink issue #5133: [hotfix] Fix typo in AkkaUtils method

2017-12-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5133 [ERROR] src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceUtils.java:[41,8] (imports) UnusedImports: Unused import: java.net.InetSocketAddress. ---

[GitHub] flink issue #5133: [hotfix] Fix typo in AkkaUtils method

2017-12-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5133 @casidiablo please also describe why or how the removed code came to be unused. I see that `StandaloneHaServices#RESOURCE_MANAGER_RPC_ENDPOINT_NAME` was left unused by `433a345e`. ---

[jira] [Commented] (FLINK-8215) Collections codegen exception when constructing Array or Map via SQL API

2017-12-07 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282799#comment-16282799 ] Rong Rong commented on FLINK-8215: -- Agree. as long as the ValidationException is thrown for TableAPI, we

[GitHub] flink pull request #5134: [FLINK-8220] Implement set of network benchmarks

2017-12-07 Thread casidiablo
Github user casidiablo commented on a diff in the pull request: https://github.com/apache/flink/pull/5134#discussion_r155667757 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/benchmark/SerializingLongReceiver.java --- @@ -0,0 +1,101 @@ +/* + *

[jira] [Commented] (FLINK-8220) Implement set of network throughput benchmarks in Flink

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282687#comment-16282687 ] ASF GitHub Bot commented on FLINK-8220: --- Github user casidiablo commented on a diff in the pull

[GitHub] flink issue #5072: [FLINK-7984][build] Bump snappy-java to 1.1.4

2017-12-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5072 @yew1eb have you looked at FLINK-6965? ---

[jira] [Commented] (FLINK-8223) Update Hadoop versions

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282572#comment-16282572 ] ASF GitHub Bot commented on FLINK-8223: --- GitHub user greghogan opened a pull request:

[GitHub] flink pull request #5137: [FLINK-8223] [build] Update Hadoop versions

2017-12-07 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/5137 [FLINK-8223] [build] Update Hadoop versions ## What is the purpose of the change Update Hadoop minor versions for Flink 1.5 development cycle. ## Brief change log Update

[jira] [Commented] (FLINK-8222) Update Scala version

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282490#comment-16282490 ] ASF GitHub Bot commented on FLINK-8222: --- GitHub user greghogan opened a pull request:

[GitHub] flink pull request #5136: [FLINK-8222] [build] Update Scala version

2017-12-07 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/5136 [FLINK-8222] [build] Update Scala version ## What is the purpose of the change This is an incremental upgrade to the Scala security release 2.11.12. "A privilege escalation

[jira] [Commented] (FLINK-8080) Remove need for "metrics.reporters"

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282444#comment-16282444 ] ASF GitHub Bot commented on FLINK-8080: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #5099: [FLINK-8080][metrics] Remove need for "metrics.rep...

2017-12-07 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5099#discussion_r155625966 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/metrics/MetricRegistryImplTest.java --- @@ -76,8 +76,27 @@ public void testIsShutdown() {

[GitHub] flink pull request #5099: [FLINK-8080][metrics] Remove need for "metrics.rep...

2017-12-07 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5099#discussion_r155620220 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java --- @@ -108,15 +118,36 @@ public static

[jira] [Commented] (FLINK-8080) Remove need for "metrics.reporters"

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282443#comment-16282443 ] ASF GitHub Bot commented on FLINK-8080: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #5135: [hotfix] [doc] Fix typo in TaskManager and Environ...

2017-12-07 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5135#discussion_r155627163 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -585,7 +585,7 @@ class TaskManager(

[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282466#comment-16282466 ] ASF GitHub Bot commented on FLINK-7984: --- Github user greghogan commented on the issue:

[jira] [Commented] (FLINK-8080) Remove need for "metrics.reporters"

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282445#comment-16282445 ] ASF GitHub Bot commented on FLINK-8080: --- Github user greghogan commented on a diff in the pull

[jira] [Commented] (FLINK-8080) Remove need for "metrics.reporters"

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282446#comment-16282446 ] ASF GitHub Bot commented on FLINK-8080: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #5099: [FLINK-8080][metrics] Remove need for "metrics.rep...

2017-12-07 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5099#discussion_r155618187 --- Diff: docs/monitoring/metrics.md --- @@ -329,11 +329,11 @@ or by assigning unique names to jobs and operators. Metrics can be exposed to an

[GitHub] flink pull request #5099: [FLINK-8080][metrics] Remove need for "metrics.rep...

2017-12-07 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5099#discussion_r155623170 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java --- @@ -44,7 +48,13 @@ private static

[GitHub] flink pull request #5135: [hotfix] [doc] Fix typo in TaskManager and Environ...

2017-12-07 Thread casidiablo
GitHub user casidiablo opened a pull request: https://github.com/apache/flink/pull/5135 [hotfix] [doc] Fix typo in TaskManager and EnvironmentInformation doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/casidiablo/flink

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155604499 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java --- @@ -266,104 +279,367 @@ public void

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282293#comment-16282293 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282300#comment-16282300 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155605251 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/LogicalSlot.java --- @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (FLINK-8222) Update Scala version

2017-12-07 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-8222: - Summary: Update Scala version Key: FLINK-8222 URL: https://issues.apache.org/jira/browse/FLINK-8222 Project: Flink Issue Type: Improvement Components:

[jira] [Created] (FLINK-8223) Update Hadoop versions

2017-12-07 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-8223: - Summary: Update Hadoop versions Key: FLINK-8223 URL: https://issues.apache.org/jira/browse/FLINK-8223 Project: Flink Issue Type: Improvement Components:

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155590317 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java --- @@ -266,104 +279,367 @@ public void

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282216#comment-16282216 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8220) Implement set of network throughput benchmarks in Flink

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282181#comment-16282181 ] ASF GitHub Bot commented on FLINK-8220: --- Github user greghogan commented on the issue:

[GitHub] flink issue #5047: Code refine of WordWithCount

2017-12-07 Thread harborl
Github user harborl commented on the issue: https://github.com/apache/flink/pull/5047 Yes, after a few learning, it turns out that, in this project, POJO is a sort of reasonable style of parameters. Sorry for interruption, I think I am exited about learning more further. ---

[jira] [Commented] (FLINK-7129) Dynamically changing patterns

2017-12-07 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282185#comment-16282185 ] Fabian Hueske commented on FLINK-7129: -- It won't go into Flink 1.4.0 because feature freeze was more

[GitHub] flink issue #5134: [FLINK-8220] Implement set of network benchmarks

2017-12-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5134 Or if `flink-benchmarks` does not need to be distributed then that code could be contributed to the main Flink repository. ---

[jira] [Commented] (FLINK-8220) Implement set of network throughput benchmarks in Flink

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282080#comment-16282080 ] ASF GitHub Bot commented on FLINK-8220: --- Github user zentol commented on the issue:

[GitHub] flink issue #5134: [FLINK-8220] Implement set of network benchmarks

2017-12-07 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5134 Why do you want to add these to flink when they are only used by an external repository? Wouldn't it make sense to consolidate all benchmarking code to the flink-benchmark repo? ---

[jira] [Commented] (FLINK-8220) Implement set of network throughput benchmarks in Flink

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281998#comment-16281998 ] ASF GitHub Bot commented on FLINK-8220: --- GitHub user pnowojski opened a pull request:

[GitHub] flink pull request #5134: [FLINK-8220] Implement set of network benchmarks

2017-12-07 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/5134 [FLINK-8220] Implement set of network benchmarks This PR implements sets of network benchmarks that are intended to simulate various workloads for network stack. Benchmarks will be executed by

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281986#comment-16281986 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155549755 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/LogicalSlot.java --- @@ -32,6 +34,20 @@ */ public interface LogicalSlot {

[jira] [Created] (FLINK-8221) Implement set of network latency benchmarks in Flink

2017-12-07 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-8221: - Summary: Implement set of network latency benchmarks in Flink Key: FLINK-8221 URL: https://issues.apache.org/jira/browse/FLINK-8221 Project: Flink Issue

[jira] [Updated] (FLINK-8220) Implement set of network throughput benchmarks in Flink

2017-12-07 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-8220: -- Summary: Implement set of network throughput benchmarks in Flink (was: Define set of network

[jira] [Updated] (FLINK-8220) Define set of network throughput benchmarks in Flink

2017-12-07 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-8220: -- Description: Benchmarks should be defined and implemented in flink project and they will be

[jira] [Created] (FLINK-8220) Define set of network throughput benchmarks in Flink

2017-12-07 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-8220: - Summary: Define set of network throughput benchmarks in Flink Key: FLINK-8220 URL: https://issues.apache.org/jira/browse/FLINK-8220 Project: Flink Issue

[jira] [Commented] (FLINK-8078) Decouple Execution from actual slot implementation

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281918#comment-16281918 ] ASF GitHub Bot commented on FLINK-8078: --- Github user GJL commented on the issue:

[GitHub] flink issue #5086: [FLINK-8078] Introduce LogicalSlot interface

2017-12-07 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5086 LGTM ---

[jira] [Created] (FLINK-8219) Kinesis Connector metrics

2017-12-07 Thread Gary Oslon (JIRA)
Gary Oslon created FLINK-8219: - Summary: Kinesis Connector metrics Key: FLINK-8219 URL: https://issues.apache.org/jira/browse/FLINK-8219 Project: Flink Issue Type: Bug Components:

[GitHub] flink issue #5133: [hotfix] Fix typo in AkkaUtils method

2017-12-07 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5133 LGTM. ---

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281885#comment-16281885 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281883#comment-16281883 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281884#comment-16281884 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155519870 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java --- @@ -0,0 +1,722 @@ +/* + * Licensed to the

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155528224 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java --- @@ -0,0 +1,722 @@ +/* + * Licensed to the

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155520946 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java --- @@ -0,0 +1,722 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-8124) EventTimeTrigger (and other triggers) could have less specific generic types

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281876#comment-16281876 ] ASF GitHub Bot commented on FLINK-8124: --- Github user casidiablo commented on the issue:

[GitHub] flink issue #5073: [FLINK-8124] Make Trigger implementations more generic

2017-12-07 Thread casidiablo
Github user casidiablo commented on the issue: https://github.com/apache/flink/pull/5073 > I thought this was mainly about making the time triggers more relaxed so that they accept a Window in addition to only TimeWindow. That's exactly what this PR is about. ---

[GitHub] flink pull request #5133: [hotfix] Fix typo in AkkaUtils method

2017-12-07 Thread casidiablo
GitHub user casidiablo opened a pull request: https://github.com/apache/flink/pull/5133 [hotfix] Fix typo in AkkaUtils method Also, removed unused code: - `StandaloneHaServices#RESOURCE_MANAGER_RPC_ENDPOINT_NAME` -

[jira] [Commented] (FLINK-8122) Name all table sinks and sources

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281851#comment-16281851 ] ASF GitHub Bot commented on FLINK-8122: --- Github user xccui commented on the issue:

[GitHub] flink issue #5068: [FLINK-8122] [table] Name all built-in table sinks and so...

2017-12-07 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/5068 Thanks for the review @fhueske. * I added the `explainSink()` method to make the `TableSink` consistent with the `TableSource`. Discarding this method and using the

[jira] [Commented] (FLINK-8093) flink job fail because of kafka producer create fail of "javax.management.InstanceAlreadyExistsException"

2017-12-07 Thread dongtingting (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281834#comment-16281834 ] dongtingting commented on FLINK-8093: - [~aljoscha] I think clientid is thread safe and static. But one

[GitHub] flink pull request #5052: [FLINK-8133][REST][docs] Generate REST API documen...

2017-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5052 ---

[jira] [Commented] (FLINK-8133) Generate documentation for new REST API

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281796#comment-16281796 ] ASF GitHub Bot commented on FLINK-8133: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-8133) Generate documentation for new REST API

2017-12-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8133. --- Resolution: Fixed master: 610fde722fc91ff760cff3865564a51a4b945f19 > Generate documentation

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281780#comment-16281780 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155507607 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java --- @@ -0,0 +1,722 @@ +/* + * Licensed to the

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155507294 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java --- @@ -0,0 +1,722 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281778#comment-16281778 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-7684) Avoid multiple data copies in MergingWindowSet

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281775#comment-16281775 ] ASF GitHub Bot commented on FLINK-7684: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4723: [FLINK-7684] Avoid data copies in MergingWindowSet

2017-12-07 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4723 I think this needs a lot more description of what is happening. For example, this introduces a prominent new configuration setting on the `ExecutionConfig` that is nowhere described, making

[jira] [Commented] (FLINK-7812) Log system resources as metrics

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281768#comment-16281768 ] ASF GitHub Bot commented on FLINK-7812: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-7812) Log system resources as metrics

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281767#comment-16281767 ] ASF GitHub Bot commented on FLINK-7812: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-7812) Log system resources as metrics

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281766#comment-16281766 ] ASF GitHub Bot commented on FLINK-7812: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #4801: [FLINK-7812] Log system resources metrics

2017-12-07 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4801#discussion_r155503740 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/util/MetricUtils.java --- @@ -102,37 +103,16 @@ public static void

[GitHub] flink pull request #4801: [FLINK-7812] Log system resources metrics

2017-12-07 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4801#discussion_r155503385 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/utils/SystemResourcesCounter.java --- @@ -0,0 +1,236 @@ +/* + *

[GitHub] flink pull request #4801: [FLINK-7812] Log system resources metrics

2017-12-07 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4801#discussion_r155501129 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunnerITCase.java --- @@ -0,0 +1,132 @@ +/* + * Licensed

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281765#comment-16281765 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155503866 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerTest.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281764#comment-16281764 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155503994 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerTest.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281759#comment-16281759 ] ASF GitHub Bot commented on FLINK-7956: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155502971 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/TestingAllocatedSlotActions.java --- @@ -0,0 +1,53 @@ +/* + *

[jira] [Commented] (FLINK-8133) Generate documentation for new REST API

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281754#comment-16281754 ] ASF GitHub Bot commented on FLINK-8133: --- Github user zentol commented on the issue:

[GitHub] flink issue #5052: [FLINK-8133][REST][docs] Generate REST API documentation

2017-12-07 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5052 merging. ---

[jira] [Commented] (FLINK-8174) Mesos RM unable to accept offers for unreserved resources

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281752#comment-16281752 ] ASF GitHub Bot commented on FLINK-8174: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-8133) Generate documentation for new REST API

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281753#comment-16281753 ] ASF GitHub Bot commented on FLINK-8133: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink issue #5114: [FLINK-8174] [mesos] Mesos RM unable to accept offers for...

2017-12-07 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5114 It depends a little bit on 1.4. We have serious build stability issues in the `release-1.3` branch and it would take a serious effort to stabilize it again. If I could choose, then we wouldn't

[GitHub] flink pull request #5052: [FLINK-8133][REST][docs] Generate REST API documen...

2017-12-07 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5052#discussion_r155501188 --- Diff: flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java --- @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-7561) Add support for pre-aggregation in DataStream API

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281748#comment-16281748 ] ASF GitHub Bot commented on FLINK-7561: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4626: [FLINK-7561][streaming] Implement PreAggregationOperator

2017-12-07 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4626 I think it would be nice to have a utility here in order to make this easier to use: ```java DataStream result = Utils.withPreaggregation(

[jira] [Commented] (FLINK-8089) Fulfil slot requests with unused offered slots

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281732#comment-16281732 ] ASF GitHub Bot commented on FLINK-8089: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5090: [FLINK-8089] Also check for other pending slot req...

2017-12-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5090#discussion_r155496482 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolTest.java --- @@ -383,6 +386,76 @@ public void

[jira] [Commented] (FLINK-8203) Make schema definition of DataStream/DataSet to Table conversion more flexible

2017-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281731#comment-16281731 ] ASF GitHub Bot commented on FLINK-8203: --- GitHub user twalthr opened a pull request:

  1   2   >