[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281851#comment-16281851
]
ASF GitHub Bot commented on FLINK-8122:
---------------------------------------
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5068
Thanks for the review @fhueske.
* I added the `explainSink()` method to make the `TableSink` consistent
with the `TableSource`. Discarding this method and using the
`TableConnectorUtil.genRuntimeName()` in each table sink should also be OK.
* Yes, the test sources and sinks are not exposed. I'll revert them.
* The source name was set via this call
`execEnv.createInput(orcIF).name(explainSource())`. The `createInput()` method
for a **mocked** `execEnv` will return `null` and cause a NPE.
Thanks,
Xingcan
> Name all table sinks and sources
> --------------------------------
>
> Key: FLINK-8122
> URL: https://issues.apache.org/jira/browse/FLINK-8122
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Timo Walther
> Assignee: Xingcan Cui
>
> Not all table sink and sources have proper names. Therefore, they are
> displayed as "Unnamed" in the logs and Web UI (e.g. CsvTableSink). We should
> add names for all built-in connectors. Having information about the table
> sink name (via {{INSERT INTO}}) would be even better.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
