[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310737#comment-16310737 ] ASF GitHub Bot commented on FLINK-7475: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159582753 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/benchmark/RocksDBListStatePerformanceTest.java ---

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310731#comment-16310731 ] ASF GitHub Bot commented on FLINK-7475: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #4963: [FLINK-7475] [core][DataStream API] support update() in L...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4963 @StefanRRichter I added a perf benchmarking unit test, you can find the perf results in both this PR's description and the comment of that test. The perf improvement is pretty magnificent, between

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310729#comment-16310729 ] ASF GitHub Bot commented on FLINK-7475: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159582105 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java --- @@ -497,6 +497,15 @@ public String toString() {

[jira] [Commented] (FLINK-8323) Fix Mod scala function bug

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310680#comment-16310680 ] ASF GitHub Bot commented on FLINK-8323: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #5212: [FLINK-8323][table] fix MOD scalar function bug.

2018-01-03 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/5212 @twalthr Thanks for your comments. I am grateful if you can take a look at this PR again. :) Thanks, Jincheng ---

[jira] [Commented] (FLINK-7860) Support YARN proxy user in Flink (impersonation)

2018-01-03 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310669#comment-16310669 ] Eron Wright commented on FLINK-7860: - I think you're overstating what Hadoop does. The proxy user

[jira] [Commented] (FLINK-7860) Support YARN proxy user in Flink (impersonation)

2018-01-03 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310633#comment-16310633 ] Shuyi Chen commented on FLINK-7860: --- I assume in the doAs block, it will be run as "joe" and should not

[jira] [Commented] (FLINK-7935) Metrics with user supplied scope variables

2018-01-03 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310618#comment-16310618 ] Wei-Che Wei commented on FLINK-7935: Hi [~elevy] What you described is almost correct. The FLINK-7692

[jira] [Commented] (FLINK-7860) Support YARN proxy user in Flink (impersonation)

2018-01-03 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310598#comment-16310598 ] Eron Wright commented on FLINK-7860: - If I understand correctly, your scenario is as follows. You

[jira] [Commented] (FLINK-7860) Support YARN proxy user in Flink (impersonation)

2018-01-03 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310583#comment-16310583 ] Shuyi Chen commented on FLINK-7860: --- Using the HADOOP_PROXY_USER env variable would be good for command

[jira] [Commented] (FLINK-8043) change fullRestarts (for fine grained recovery) from guage to counter

2018-01-03 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310567#comment-16310567 ] Steven Zhen Wu commented on FLINK-8043: --- [~trohrm...@apache.org] any objection/comment on changing

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159565645 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/ListState.java --- @@ -33,4 +35,14 @@ * @param Type of values that this list

[jira] [Commented] (FLINK-7860) Support YARN proxy user in Flink (impersonation)

2018-01-03 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310570#comment-16310570 ] Shuyi Chen commented on FLINK-7860: --- Hi [~eronwright], thanks for the response. The "Flink" keytab will

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310572#comment-16310572 ] ASF GitHub Bot commented on FLINK-7475: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159565552 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java --- @@ -158,4 +158,28 @@

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310571#comment-16310571 ] ASF GitHub Bot commented on FLINK-7475: --- Github user bowenli86 commented on a diff in the pull

[jira] [Updated] (FLINK-8357) enable rolling in default log settings

2018-01-03 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Mingmin updated FLINK-8357: -- Description: The release packages uses {{org.apache.log4j.FileAppender}} for log4j and

[jira] [Created] (FLINK-8358) Hostname used by DataDog metric reporter is not configurable

2018-01-03 Thread Elias Levy (JIRA)
Elias Levy created FLINK-8358: - Summary: Hostname used by DataDog metric reporter is not configurable Key: FLINK-8358 URL: https://issues.apache.org/jira/browse/FLINK-8358 Project: Flink Issue

[jira] [Created] (FLINK-8357) enable rolling in default log settings

2018-01-03 Thread Xu Mingmin (JIRA)
Xu Mingmin created FLINK-8357: - Summary: enable rolling in default log settings Key: FLINK-8357 URL: https://issues.apache.org/jira/browse/FLINK-8357 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310436#comment-16310436 ] ASF GitHub Bot commented on FLINK-7475: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159549233 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/util/MergeUtils.java --- @@ -0,0 +1,63 @@

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159549032 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/ListState.java --- @@ -33,4 +35,14 @@ * @param Type of values that this

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310435#comment-16310435 ] ASF GitHub Bot commented on FLINK-7475: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159548273 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java --- @@ -158,4

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310433#comment-16310433 ] ASF GitHub Bot commented on FLINK-7475: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310422#comment-16310422 ] ASF GitHub Bot commented on FLINK-7475: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159547336 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapListState.java --- @@ -120,4 +121,16 @@ public void add(V value) {

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310415#comment-16310415 ] ASF GitHub Bot commented on FLINK-7475: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159546670 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java --- @@ -158,4 +158,28 @@

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310416#comment-16310416 ] ASF GitHub Bot commented on FLINK-7475: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159546631 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java --- @@ -158,4 +158,28 @@

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310411#comment-16310411 ] ASF GitHub Bot commented on FLINK-7475: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159546186 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/util/MergeUtils.java --- @@ -0,0 +1,63 @@

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310409#comment-16310409 ] ASF GitHub Bot commented on FLINK-7475: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #4963: [FLINK-7475] [core][DataStream API] support update...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4963#discussion_r159545896 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapListState.java --- @@ -120,4 +121,16 @@ public void add(V value) {

[jira] [Updated] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-01-03 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright updated FLINK-8275: Fix Version/s: 1.4.1 > Flink YARN deployment with Kerberos enabled not working >

[jira] [Created] (FLINK-8356) JDBCAppendTableSink does not work for Hbase Phoenix Driver

2018-01-03 Thread Paul Wu (JIRA)
Paul Wu created FLINK-8356: -- Summary: JDBCAppendTableSink does not work for Hbase Phoenix Driver Key: FLINK-8356 URL: https://issues.apache.org/jira/browse/FLINK-8356 Project: Flink Issue Type:

[GitHub] flink pull request #5213: [Minor][docs][metrics] Fix typo of metrics docs

2018-01-03 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5213#discussion_r159523422 --- Diff: docs/monitoring/metrics.md --- @@ -905,7 +903,7 @@ Thus, in order to infer the metric identifier: Job-/TaskManager

[jira] [Updated] (FLINK-8320) Flink cluster does not work on Java 9

2018-01-03 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-8320: -- Issue Type: Wish (was: Bug) > Flink cluster does not work on Java 9 >

[jira] [Commented] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310240#comment-16310240 ] ASF GitHub Bot commented on FLINK-8175: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5112: [FLINK-8175] [DataStream API java/scala] remove flink-str...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5112 @StephanEwen Thanks Stephan. To your comments: 1. in order to have `experiemental/scala` package in `flink-streaming-scala`, I have to make `DataStreamUtils` its own class to avoid

[jira] [Commented] (FLINK-7935) Metrics with user supplied scope variables

2018-01-03 Thread Elias Levy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310189#comment-16310189 ] Elias Levy commented on FLINK-7935: --- It appears the Metric documentation has not been updated in the 1.5

[jira] [Commented] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310141#comment-16310141 ] ASF GitHub Bot commented on FLINK-8175: --- Github user bowenli86 commented on a diff in the pull

[jira] [Commented] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310140#comment-16310140 ] ASF GitHub Bot commented on FLINK-8175: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #5112: [FLINK-8175] [DataStream API java/scala] remove fl...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5112#discussion_r159494408 --- Diff: flink-tests/src/test/java/org/apache/flink/test/streaming/experimental/CollectITCase.java --- @@ -7,7 +7,7 @@ * "License"); you may not

[GitHub] flink pull request #5112: [FLINK-8175] [DataStream API java/scala] remove fl...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5112#discussion_r159494457 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/experimental/package.scala --- @@ -16,23 +16,25 @@ * limitations under

[jira] [Commented] (FLINK-8265) Missing jackson dependency for flink-mesos

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310016#comment-16310016 ] ASF GitHub Bot commented on FLINK-8265: --- Github user EronWright commented on the issue:

[GitHub] flink issue #5208: [FLINK-8265] [Mesos] Missing jackson dependency for flink...

2018-01-03 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/5208 @aljoscha that might work but the independence is also nice. In this case, Fenzo is using Jackson 2.4.5 while Flink itself is using 2.7.9. How strongly do you feel about this? ---

[jira] [Commented] (FLINK-8322) support getting number of existing timers in TimerService

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309977#comment-16309977 ] ASF GitHub Bot commented on FLINK-8322: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5236: [FLINK-8322] support getting number of existing timers in...

2018-01-03 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5236 @GJL Thanks for the feedback, will address them. I thought about this overnight, and realized this is actually not all parts I want to build. What I want is number of timers **per key** in a

[jira] [Commented] (FLINK-8322) support getting number of existing timers in TimerService

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309871#comment-16309871 ] ASF GitHub Bot commented on FLINK-8322: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5236: [FLINK-8322] support getting number of existing ti...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5236#discussion_r159465985 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -442,23 +458,15 @@ public int

[jira] [Commented] (FLINK-8322) support getting number of existing timers in TimerService

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309866#comment-16309866 ] ASF GitHub Bot commented on FLINK-8322: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5236: [FLINK-8322] support getting number of existing ti...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5236#discussion_r159465653 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -442,23 +458,15 @@ public int

[GitHub] flink pull request #5236: [FLINK-8322] support getting number of existing ti...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5236#discussion_r159464428 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -475,4 +483,38 @@ public int

[jira] [Commented] (FLINK-8322) support getting number of existing timers in TimerService

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309857#comment-16309857 ] ASF GitHub Bot commented on FLINK-8322: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8322) support getting number of existing timers in TimerService

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309850#comment-16309850 ] ASF GitHub Bot commented on FLINK-8322: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8322) support getting number of existing timers in TimerService

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309851#comment-16309851 ] ASF GitHub Bot commented on FLINK-8322: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5236: [FLINK-8322] support getting number of existing ti...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5236#discussion_r159462006 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -262,16 +277,17 @@ public void

[GitHub] flink pull request #5236: [FLINK-8322] support getting number of existing ti...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5236#discussion_r159461777 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -442,23 +458,15 @@ public int

[GitHub] flink pull request #5237: [hotfix][doc] fix typo in filesystems.md

2018-01-03 Thread Matrix42
GitHub user Matrix42 opened a pull request: https://github.com/apache/flink/pull/5237 [hotfix][doc] fix typo in filesystems.md ## Brief change log * fix typo in filesystems.md You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159446300 --- Diff: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java --- @@ -99,6 +69,44 @@ public void testStop() throws Exception {

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309789#comment-16309789 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309787#comment-16309787 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159447901 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java --- @@ -1,170 +0,0 @@ -/* - * Licensed to the Apache Software

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159449988 --- Diff: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendCancelTest.java --- @@ -42,70 +39,54 @@ /** * Tests for the CANCEL

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309788#comment-16309788 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309757#comment-16309757 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309758#comment-16309758 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309754#comment-16309754 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309755#comment-16309755 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159432084 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -598,189 +535,154 @@ protected int cancel(String[] args) {

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159439656 --- Diff: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java --- @@ -99,6 +69,44 @@ public void testStop() throws Exception {

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309756#comment-16309756 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159435504 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -292,20 +267,14 @@ protected int run(String[] args) { *

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159422039 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -882,42 +784,28 @@ protected ClusterClient

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309753#comment-16309753 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309759#comment-16309759 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309760#comment-16309760 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159425958 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -274,19 +251,13 @@ protected int run(String[] args) {

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159431758 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -598,189 +535,154 @@ protected int cancel(String[] args) {

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159430427 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -587,9 +526,7 @@ protected int cancel(String[] args) {

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159429333 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -515,33 +464,28 @@ protected int stop(String[] args) {

[jira] [Commented] (FLINK-6756) Provide RichAsyncFunction to Scala API suite

2018-01-03 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309739#comment-16309739 ] Aljoscha Krettek commented on FLINK-6756: - This wrapper probably needs to be implemented similarly

[jira] [Created] (FLINK-8355) DataSet Should not union a NULL row for AGG without GROUP BY clause.

2018-01-03 Thread sunjincheng (JIRA)
sunjincheng created FLINK-8355: -- Summary: DataSet Should not union a NULL row for AGG without GROUP BY clause. Key: FLINK-8355 URL: https://issues.apache.org/jira/browse/FLINK-8355 Project: Flink

[jira] [Updated] (FLINK-8325) Add COUNT support constant parameter, COUNT(*), COUNT(1)

2018-01-03 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-8325: --- Summary: Add COUNT support constant parameter, COUNT(*), COUNT(1) (was: Add support for constant

[jira] [Updated] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-03 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-8325: --- Summary: Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1) (was: Add COUNT support

[jira] [Commented] (FLINK-8325) Add support for constant parameters in GROUP WINDOW aggregate

2018-01-03 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309715#comment-16309715 ] sunjincheng commented on FLINK-8325: After I check the detail I find that only `CountAggFunction `

[jira] [Updated] (FLINK-8354) Flink Kafka connector ignores Kafka message headers

2018-01-03 Thread Mohammad Abareghi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Abareghi updated FLINK-8354: - Summary: Flink Kafka connector ignores Kafka message headers (was: Flink Kafka

[jira] [Updated] (FLINK-8354) Flink Kafka connector ingonre Kafka message headers

2018-01-03 Thread Mohammad Abareghi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Abareghi updated FLINK-8354: - Priority: Minor (was: Major) > Flink Kafka connector ingonre Kafka message headers >

[jira] [Commented] (FLINK-7760) Restore failing from external checkpointing metadata.

2018-01-03 Thread Shashank Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309634#comment-16309634 ] Shashank Agarwal commented on FLINK-7760: - Hi [~kkl0u] , I have checked again and facing the same

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2018-01-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159422003 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -882,42 +784,28 @@ protected ClusterClient

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309632#comment-16309632 ] ASF GitHub Bot commented on FLINK-8333: --- Github user GJL commented on a diff in the pull request:

[jira] [Created] (FLINK-8354) Flink Kafka connector ingonre Kafka message headers

2018-01-03 Thread Mohammad Abareghi (JIRA)
Mohammad Abareghi created FLINK-8354: Summary: Flink Kafka connector ingonre Kafka message headers Key: FLINK-8354 URL: https://issues.apache.org/jira/browse/FLINK-8354 Project: Flink

[jira] [Commented] (FLINK-7756) RocksDB state backend Checkpointing (Async and Incremental) is not working with CEP.

2018-01-03 Thread Shashank Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309626#comment-16309626 ] Shashank Agarwal commented on FLINK-7756: - Hi [~kkl0u] , I have tried this, No this doesn't solve

[jira] [Reopened] (FLINK-8103) Flink 1.4 not writing to standard out log file

2018-01-03 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reopened FLINK-8103: - Reopen to change resolution > Flink 1.4 not writing to standard out log file >

[jira] [Closed] (FLINK-8103) Flink 1.4 not writing to standard out log file

2018-01-03 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-8103. --- Resolution: Not A Problem > Flink 1.4 not writing to standard out log file >

  1   2   >