[jira] [Created] (FLINK-8552) CliFrontend don't exit normal after job has been submitted with 'bin/flink run some_jar_ball'

2018-02-02 Thread Lynch Lee (JIRA)
Lynch Lee created FLINK-8552: Summary: CliFrontend don't exit normal after job has been submitted with 'bin/flink run some_jar_ball' Key: FLINK-8552 URL: https://issues.apache.org/jira/browse/FLINK-8552

[jira] [Updated] (FLINK-8551) Should BIGINT in Flink SQL will be enchanced

2018-02-02 Thread Lynch Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lynch Lee updated FLINK-8551: - Summary: Should BIGINT in Flink SQL will be enchanced (was: Should BIGINT in Flink SQL will be enchance

[jira] [Updated] (FLINK-8551) Should BIGINT in Flink SQL will be enchance to

2018-02-02 Thread Lynch Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lynch Lee updated FLINK-8551: - Description: As we all known , see

[jira] [Closed] (FLINK-8506) fullRestarts Gauge not incremented when jobmanager got killed

2018-02-02 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu closed FLINK-8506. - Resolution: Not A Problem > fullRestarts Gauge not incremented when jobmanager got killed >

[jira] [Updated] (FLINK-8551) Should BIGINT in Flink SQL will be enchance to

2018-02-02 Thread Lynch Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lynch Lee updated FLINK-8551: - Description: As we all known , see

[jira] [Updated] (FLINK-8551) Should BIGINT in Flink SQL will be enchance to

2018-02-02 Thread Lynch Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lynch Lee updated FLINK-8551: - Description: As we all known , see

[jira] [Created] (FLINK-8551) Should BIGINT in Flink SQL will be enchance to

2018-02-02 Thread Lynch Lee (JIRA)
Lynch Lee created FLINK-8551: Summary: Should BIGINT in Flink SQL will be enchance to Key: FLINK-8551 URL: https://issues.apache.org/jira/browse/FLINK-8551 Project: Flink Issue Type:

[jira] [Commented] (FLINK-7525) Add config option to disable Cancel functionality on UI

2018-02-02 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351287#comment-16351287 ] Chesnay Schepler commented on FLINK-7525: - Nah, various FLIP-6 issues aren't assigned as subtasks

[GitHub] flink pull request #5407: [hotfix][build] Fix duplicate maven enforce plugin...

2018-02-02 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/5407 [hotfix][build] Fix duplicate maven enforce plugin declaration ## What is the purpose of the change Hotfix duplicate `maven-enforce-plugin` declaration. ## Brief change log -

[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.

2018-02-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5406#discussion_r165807233 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java --- @@ -90,11 +90,11 @@ CompletableFuture

[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.

2018-02-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5406#discussion_r165807228 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java --- @@ -109,7 +109,7 @@ * slot offers.

[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.

2018-02-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5406#discussion_r165807220 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java --- @@ -90,11 +90,11 @@ CompletableFuture

[jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351279#comment-16351279 ] ASF GitHub Bot commented on FLINK-4812: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5155: [FLINK-4812][metrics] Expose currentLowWatermark f...

2018-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5155 ---

[jira] [Closed] (FLINK-4812) Report Watermark metrics in all operators

2018-02-02 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-4812. --- Resolution: Fixed master: 92ad53e6a7e4c9df7055aac89b49ae95d50c5b4c > Report Watermark

[GitHub] flink pull request #5406: [hotfix][docs] Fix typos

2018-02-02 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/5406 [hotfix][docs] Fix typos Hotfix some typos in comments. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yew1eb/flink fix_typos Alternatively you

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351270#comment-16351270 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tweise commented on the issue:

[GitHub] flink issue #5393: [FLINK-8516] Allow for custom hash function for shard to ...

2018-02-02 Thread tweise
Github user tweise commented on the issue: https://github.com/apache/flink/pull/5393 @tzulitai What is the proposed migration test going to assert? The assigner does not influence how state is saved and restored. Even when the assigner returns invalid index, the modulus will ensure

[jira] [Comment Edited] (FLINK-8545) Implement upsert stream table source

2018-02-02 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350548#comment-16350548 ] Hequn Cheng edited comment on FLINK-8545 at 2/3/18 2:33 AM: Hi, the {{Tuple}} 

[jira] [Updated] (FLINK-8003) Support named ROW in Flink SQL

2018-02-02 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuyi Chen updated FLINK-8003: -- Summary: Support named ROW in Flink SQL (was: Support Calcite's ROW value constructor in Flink SQL) >

[jira] [Commented] (FLINK-7923) SQL parser exception when accessing subfields of a Composite element in an Object Array type column

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351189#comment-16351189 ] ASF GitHub Bot commented on FLINK-7923: --- Github user suez1224 commented on the issue:

[GitHub] flink issue #5367: [FLINK-7923][Table API & SQL] Support field access of com...

2018-02-02 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5367 @hequn8128 @twalthr could you please take another look? I've refactored the code to reuse the generateFieldAccess() code, also added null test. Nested tuple wont work now due to

[jira] [Commented] (FLINK-8477) Add api to support for user to skip the first incomplete window data

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351172#comment-16351172 ] ASF GitHub Bot commented on FLINK-8477: --- Github user Aitozi commented on the issue:

[GitHub] flink issue #5405: [FLINK-8477][Window]Add api to support user to skip serva...

2018-02-02 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/5405 cc @aljoscha please help review this patch. ![image](https://user-images.githubusercontent.com/9486140/35761522-6e00f4b8-08c4-11e8-8063-7ec015802428.png) see the picture above, when user

[jira] [Commented] (FLINK-8477) Add api to support for user to skip the first incomplete window data

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351163#comment-16351163 ] ASF GitHub Bot commented on FLINK-8477: --- GitHub user Aitozi opened a pull request:

[GitHub] flink pull request #5405: [FLINK-8477][Window]Add api to support user to ski...

2018-02-02 Thread Aitozi
GitHub user Aitozi opened a pull request: https://github.com/apache/flink/pull/5405 [FLINK-8477][Window]Add api to support user to skip serval broken window In production, some application like monitor type , it need the accuarcy data,but in this scenario: if we start a job at

[jira] [Commented] (FLINK-7525) Add config option to disable Cancel functionality on UI

2018-02-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351081#comment-16351081 ] Ted Yu commented on FLINK-7525: --- Looks like activity on FLINK-4319 has stalled. > Add config option to

[jira] [Updated] (FLINK-7588) Document RocksDB tuning for spinning disks

2018-02-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7588: -- Labels: performance (was: ) > Document RocksDB tuning for spinning disks >

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350872#comment-16350872 ] ASF GitHub Bot commented on FLINK-8384: --- Github user dyanarose commented on the issue:

[GitHub] flink issue #5295: [FLINK-8384] [streaming] Session Window Assigner with Dyn...

2018-02-02 Thread dyanarose
Github user dyanarose commented on the issue: https://github.com/apache/flink/pull/5295 erf, I see what you mean, as well as the creation of all those Time objects. ---

[jira] [Comment Edited] (FLINK-8545) Implement upsert stream table source

2018-02-02 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350548#comment-16350548 ] Hequn Cheng edited comment on FLINK-8545 at 2/2/18 4:01 PM: Hi, the {{Tuple}} 

[jira] [Comment Edited] (FLINK-8545) Implement upsert stream table source

2018-02-02 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350548#comment-16350548 ] Hequn Cheng edited comment on FLINK-8545 at 2/2/18 4:09 PM: Hi, the {{Tuple}} 

[jira] [Comment Edited] (FLINK-8545) Implement upsert stream table source

2018-02-02 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350548#comment-16350548 ] Hequn Cheng edited comment on FLINK-8545 at 2/2/18 4:08 PM: Hi, the {{Tuple}} 

[jira] [Commented] (FLINK-8545) Implement upsert stream table source

2018-02-02 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350548#comment-16350548 ] Hequn Cheng commented on FLINK-8545: Hi, the {{Tuple}} input format is a good choice. It is consistent

[jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350488#comment-16350488 ] ASF GitHub Bot commented on FLINK-4812: --- Github user zentol commented on the issue:

[GitHub] flink issue #5155: [FLINK-4812][metrics] Expose currentLowWatermark for all ...

2018-02-02 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5155 merging. ---

[jira] [Commented] (FLINK-6109) Add "consumer lag" report metric to FlinkKafkaConsumer

2018-02-02 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350468#comment-16350468 ] aitozi commented on FLINK-6109: --- [~tzulitai] you mentioned that the calculate of the lag is overwhelming,

[jira] [Closed] (FLINK-8489) Data is not emitted by second ElasticSearch connector

2018-02-02 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8489. --- Resolution: Fixed Fix Version/s: 1.4.1 1.5.0 1.4:

[jira] [Commented] (FLINK-7856) Port JobVertexBackPressureHandler to REST endpoint

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350465#comment-16350465 ] ASF GitHub Bot commented on FLINK-7856: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5397: [FLINK-7856][flip6] WIP JobVertexBackPressureHandl...

2018-02-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5397#discussion_r165666773 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TestingTaskExecutorGateway.java --- @@ -75,6 +76,17 @@ public void

[jira] [Updated] (FLINK-8489) Data is not emitted by second ElasticSearch connector

2018-02-02 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8489: Affects Version/s: 1.5.0 > Data is not emitted by second ElasticSearch connector >

[jira] [Commented] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350431#comment-16350431 ] ASF GitHub Bot commented on FLINK-8275: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...

2018-02-02 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5172#discussion_r165636080 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java --- @@ -142,19 +153,10 @@ public static void

[jira] [Commented] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350438#comment-16350438 ] ASF GitHub Bot commented on FLINK-8275: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5172: [FLINK-8275] [Security] fix keytab local path in YarnTask...

2018-02-02 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5172 @suez1224 Thanks a lot for the contribution! I've had a look and the changes LGTM. I did have a comment regarding injecting a dependency for the runner, which I've added a commit for.

[jira] [Commented] (FLINK-6109) Add "consumer lag" report metric to FlinkKafkaConsumer

2018-02-02 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350437#comment-16350437 ] aitozi commented on FLINK-6109: --- OK, i will see the pr later . > Add "consumer lag" report metric to

[jira] [Commented] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350430#comment-16350430 ] ASF GitHub Bot commented on FLINK-8275: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350432#comment-16350432 ] ASF GitHub Bot commented on FLINK-8275: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...

2018-02-02 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5172#discussion_r165635517 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java --- @@ -170,9 +160,10 @@ protected int run(String[] args) {

[GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...

2018-02-02 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5172#discussion_r165663546 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java --- @@ -142,19 +153,10 @@ public static void

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350425#comment-16350425 ] ASF GitHub Bot commented on FLINK-8345: --- Github user kl0u commented on the issue:

[GitHub] flink issue #5230: [FLINK-8345] Add iterator of keyed state on broadcast sid...

2018-02-02 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5230 @aljoscha I addressed your comments. Please have a look. ---

[jira] [Commented] (FLINK-8477) Add api to support for user to skip the first incomplete window data

2018-02-02 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350403#comment-16350403 ] aitozi commented on FLINK-8477: --- [~aljoscha]In production, some application like monitor type , it need the

[jira] [Commented] (FLINK-8364) Add iterator() to ListState which returns empty iterator when it has no value

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350371#comment-16350371 ] ASF GitHub Bot commented on FLINK-8364: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #5356: [FLINK-8364][state backend] Add iterator() to ListState w...

2018-02-02 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5356 I still do not believe that this is a significant improvement, and may even increase confusion: Now you have two slightly different ways to do almost the same thing, in one case you need to

[GitHub] flink issue #5357: [hotfix][JobGraph] Eliminate the conditions of parallelis...

2018-02-02 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5357 In this case, could you please close the PR? (we cannot easily do that) ---

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350363#comment-16350363 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-02-02 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Thanks @StephanEwen review. Yea, You correct. DailyRollingFileAppender doesn't support MaxFileSize, RollingFileAppender does. I will changed the code to a correct version and wait for the CI

[jira] [Commented] (FLINK-8550) Iterate over entryset instead of keys

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350339#comment-16350339 ] ASF GitHub Bot commented on FLINK-8550: --- GitHub user hequn8128 opened a pull request:

[jira] [Commented] (FLINK-8421) HeapInternalTimerService should reconfigure compatible key / namespace serializers on restore

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350342#comment-16350342 ] ASF GitHub Bot commented on FLINK-8421: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5362: [FLINK-8421] [DataStream] Make timer serializers r...

2018-02-02 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5362#discussion_r165646464 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimeServiceManager.java --- @@ -52,7 +52,7 @@

[GitHub] flink pull request #5404: [FLINK-8550][table] Iterate over entryset instead ...

2018-02-02 Thread hequn8128
GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/5404 [FLINK-8550][table] Iterate over entryset instead of keys ## What is the purpose of the change Iterate over entrysets instead of keys when we want to get both key and value. I went

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350278#comment-16350278 ] ASF GitHub Bot commented on FLINK-8384: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #5295: [FLINK-8384] [streaming] Session Window Assigner with Dyn...

2018-02-02 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5295 I get that logic, but the existing `TimestampAssigner` also returns a `long` and if we return `Time` we always have to wrap/unwrap that long. What do you think? ---

[jira] [Commented] (FLINK-8421) HeapInternalTimerService should reconfigure compatible key / namespace serializers on restore

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350259#comment-16350259 ] ASF GitHub Bot commented on FLINK-8421: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #5362: [FLINK-8421] [DataStream] Make timer serializers r...

2018-02-02 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5362#discussion_r165636384 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimeServiceManager.java --- @@ -52,7 +52,7 @@

[GitHub] flink pull request #5403: [WIP] Reschedule failed tasks to previous allocati...

2018-02-02 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/5403 [WIP] Reschedule failed tasks to previous allocation (if possible). This PR is a preview for early feedback on scheduler changes that make allocations sticky under failures for local

[GitHub] flink pull request #5398: [hotfix][cep] Remove migration from 1.5 test

2018-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5398 ---

[jira] [Commented] (FLINK-8308) Update yajl-ruby dependency to 1.3.1 or higher

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350108#comment-16350108 ] ASF GitHub Bot commented on FLINK-8308: --- Github user uce commented on the issue:

[GitHub] flink issue #5395: [FLINK-8308] Remove explicit yajl-ruby dependency, update...

2018-02-02 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5395 https://issues.apache.org/jira/browse/INFRA-15959 `ruby2.3.1` has been installed on the buildbot. I will check whether the build works as expected and report back here (probably only by next

[jira] [Commented] (FLINK-8549) Move TimerServiceOptions to TaskManagerOptions

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350209#comment-16350209 ] ASF GitHub Bot commented on FLINK-8549: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5402: [FLINK-8549] [config] Move TimerServiceOptions into TaskM...

2018-02-02 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5402 Thanks for the heads up - nice to know that the generator also supports different projects now. I am still leaning towards making this change, because all other shutdown options are

[jira] [Commented] (FLINK-8549) Move TimerServiceOptions to TaskManagerOptions

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350207#comment-16350207 ] ASF GitHub Bot commented on FLINK-8549: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #5402: [FLINK-8549] [config] Move TimerServiceOptions int...

2018-02-02 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5402#discussion_r165626728 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java --- @@ -206,6 +206,14 @@

[GitHub] flink issue #5364: [FLINK-8472] [test] Extend all migration tests for Flink ...

2018-02-02 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5364 Thanks for the reviews, I'll address Chesnay's comment and the merge this then (to `master` and `release-1.4`). ---

[jira] [Commented] (FLINK-8472) Extend migration tests for Flink 1.4

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350146#comment-16350146 ] ASF GitHub Bot commented on FLINK-8472: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350138#comment-16350138 ] ASF GitHub Bot commented on FLINK-8384: --- Github user dyanarose commented on the issue:

[GitHub] flink issue #5295: [FLINK-8384] [streaming] Session Window Assigner with Dyn...

2018-02-02 Thread dyanarose
Github user dyanarose commented on the issue: https://github.com/apache/flink/pull/5295 I like long myself, but I think that's only because I'm quite used to working in milliseconds. As the existing static Session Windows take Time as the gap, I think it made sense to have the

[jira] [Commented] (FLINK-8549) Move TimerServiceOptions to TaskManagerOptions

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350191#comment-16350191 ] ASF GitHub Bot commented on FLINK-8549: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5402: [FLINK-8549] [config] Move TimerServiceOptions int...

2018-02-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5402#discussion_r165623427 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java --- @@ -206,6 +206,14 @@

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350119#comment-16350119 ] ASF GitHub Bot commented on FLINK-8384: --- Github user aljoscha commented on the issue:

[jira] [Updated] (FLINK-8543) Output Stream closed at org.apache.hadoop.fs.s3a.S3AOutputStream.checkOpen

2018-02-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-8543: Fix Version/s: 1.5.0 > Output Stream closed at

[jira] [Updated] (FLINK-8543) Output Stream closed at org.apache.hadoop.fs.s3a.S3AOutputStream.checkOpen

2018-02-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-8543: Priority: Blocker (was: Major) > Output Stream closed at

[GitHub] flink issue #5295: [FLINK-8384] [streaming] Session Window Assigner with Dyn...

2018-02-02 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5295 I think the changes are good! Thanks for working on this. 👍 As a final change before merging, I would annotate the new classes/methods as `@PublicEvolving`, would you be ok with that?

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350040#comment-16350040 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350046#comment-16350046 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350048#comment-16350048 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350045#comment-16350045 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350050#comment-16350050 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350043#comment-16350043 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350041#comment-16350041 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350037#comment-16350037 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350044#comment-16350044 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350039#comment-16350039 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350042#comment-16350042 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350047#comment-16350047 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350049#comment-16350049 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350038#comment-16350038 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5393: [FLINK-8516] Allow for custom hash function for sh...

2018-02-02 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5393#discussion_r165590401 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisShardAssigner.java --- @@ -0,0

[GitHub] flink pull request #5393: [FLINK-8516] Allow for custom hash function for sh...

2018-02-02 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5393#discussion_r165590209 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisShardAssigner.java --- @@ -0,0

  1   2   >