[jira] [Commented] (FLINK-8652) Reduce log level of QueryableStateClient.getKvState() to DEBUG

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364179#comment-16364179 ] ASF GitHub Bot commented on FLINK-8652: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5489: [FLINK-8652] [QS] Reduce log level in getKvState t...

2018-02-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5489#discussion_r168197563 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java --- @@ -268

[GitHub] flink issue #5436: [FLINK-8613] [flip6] [yarn] Return excess containers

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5436 Thanks for the review @GJL. I addressed your comments. Merging this PR. ---

[GitHub] flink pull request #5436: [FLINK-8613] [flip6] [yarn] Return excess containe...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5436#discussion_r168197381 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -325,26 +325,43 @@ public void onContainersCompleted(List list

[jira] [Commented] (FLINK-8613) Return excess container in YarnResourceManager

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364177#comment-16364177 ] ASF GitHub Bot commented on FLINK-8613: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8613) Return excess container in YarnResourceManager

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364171#comment-16364171 ] ASF GitHub Bot commented on FLINK-8613: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8652) Reduce log level of QueryableStateClient.getKvState() to DEBUG

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364172#comment-16364172 ] ASF GitHub Bot commented on FLINK-8652: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5489: [FLINK-8652] [QS] Reduce log level in getKvState t...

2018-02-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5489#discussion_r168196728 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java --- @@ -268

[GitHub] flink pull request #5436: [FLINK-8613] [flip6] [yarn] Return excess containe...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5436#discussion_r168196542 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -325,26 +325,43 @@ public void onContainersCompleted(List list

[jira] [Commented] (FLINK-8652) Reduce log level of QueryableStateClient.getKvState() to DEBUG

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364170#comment-16364170 ] ASF GitHub Bot commented on FLINK-8652: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #5489: [FLINK-8652] [QS] Reduce log level in getKvState t...

2018-02-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5489#discussion_r168196028 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java --- @@ -268,7

[jira] [Commented] (FLINK-8652) Reduce log level of QueryableStateClient.getKvState() to DEBUG

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364166#comment-16364166 ] ASF GitHub Bot commented on FLINK-8652: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request #5489: [FLINK-8652] [QS] Reduce log level in getKvState t...

2018-02-14 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/5489 [FLINK-8652] [QS] Reduce log level in getKvState to DEBUG. ## What is the purpose of the change Reduce log level in `QueryableStateClient.getKvState()` from `INFO` to `DEBUG`. ## B

[jira] [Commented] (FLINK-8609) Add support to deploy detached job mode clusters

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364162#comment-16364162 ] ASF GitHub Bot commented on FLINK-8609: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #5432: [FLINK-8609] [flip6] Enable Flip-6 job mode in Cli...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5432#discussion_r168195242 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -210,51 +225,72 @@ protected void run(String[] args) throws Ex

[jira] [Commented] (FLINK-8608) Add MiniDispatcher for job mode

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364159#comment-16364159 ] ASF GitHub Bot commented on FLINK-8608: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #5431: [FLINK-8608] [flip6] Implement MiniDispatcher for job mod...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5431 Thanks a lot for the review @GJL. Merging this PR once Travis gives green light. ---

[jira] [Commented] (FLINK-8608) Add MiniDispatcher for job mode

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364153#comment-16364153 ] ASF GitHub Bot commented on FLINK-8608: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #5431: [FLINK-8608] [flip6] Implement MiniDispatcher for ...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5431#discussion_r168193217 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java --- @@ -163,29 +210,130 @@ protected void runCluster(C

[jira] [Commented] (FLINK-8297) RocksDBListState stores whole list in single byte[]

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364145#comment-16364145 ] ASF GitHub Bot commented on FLINK-8297: --- Github user aljoscha commented on the issue

[GitHub] flink issue #5185: [FLINK-8297] [flink-rocksdb] Optionally store elements of...

2018-02-14 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5185 It doesn't have to be the same while were working on it in RocksDB but when checkpointing it should be written in the same format. This might be trickier than it sounds, btw, but I don't think we ca

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364133#comment-16364133 ] ASF GitHub Bot commented on FLINK-8360: --- Github user sihuazhou commented on a diff i

[jira] [Commented] (FLINK-8604) Move JobTerminationHandler to WebMonitorEndpoint

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364132#comment-16364132 ] ASF GitHub Bot commented on FLINK-8604: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168191066 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -0,0 +1,298 @@ +/* + * Licensed to the Ap

[GitHub] flink issue #5429: [FLINK-8604] [rest] Move JobTerminationHandler into WebMo...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5429 Merging this PR. ---

[jira] [Commented] (FLINK-8529) Let Yarn entry points use YarnConfigOptions#APPLICATION_MASTER_PORT

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364130#comment-16364130 ] ASF GitHub Bot commented on FLINK-8529: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-8603) Split RestClusterClient#submitJob into submitJob and requestJobResult

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364131#comment-16364131 ] ASF GitHub Bot commented on FLINK-8603: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #5428: [FLINK-8603] [flip6] Split submitJob into job submission ...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5428 Thanks for the review @GJL. Merging this PR. ---

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364127#comment-16364127 ] ASF GitHub Bot commented on FLINK-8360: --- Github user sihuazhou commented on a diff i

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364126#comment-16364126 ] ASF GitHub Bot commented on FLINK-8360: --- Github user sihuazhou commented on a diff i

[GitHub] flink issue #5388: [FLINK-8529] [flip6] Let Yarn entry points use APPLICATIO...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5388 Merging this PR. ---

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168189852 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -0,0 +1,298 @@ +/* + * Licensed to the Ap

[jira] [Commented] (FLINK-8335) Upgrade hbase connector dependency to 1.4.0

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364125#comment-16364125 ] ASF GitHub Bot commented on FLINK-8335: --- GitHub user zhangminglei opened a pull requ

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168184247 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java --- @@ -0,0 +1,298 @@ +/* + * Licensed to the Ap

[GitHub] flink pull request #5488: [FLINK-8335] [hbase] Upgrade hbase connector depen...

2018-02-14 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/5488 [FLINK-8335] [hbase] Upgrade hbase connector dependency to 1.4.0 ## What is the purpose of the change Upgrade hbase connector dependency to 1.4.0 ## Brief change log U

[jira] [Commented] (FLINK-7658) Support COLLECT Aggregate function in Flink TABLE API

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364117#comment-16364117 ] ASF GitHub Bot commented on FLINK-7658: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-8605) Enable job cancellation from the web UI

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364116#comment-16364116 ] ASF GitHub Bot commented on FLINK-8605: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8605) Enable job cancellation from the web UI

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364118#comment-16364118 ] ASF GitHub Bot commented on FLINK-8605: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #5472: [FLINK-7658][Table API & SQL] support Collect aggregate f...

2018-02-14 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5472 We also have to add the function to `FunctionCatalog` to be able to parse it in the String-based Java Table API. ---

[GitHub] flink issue #5430: [FLINK-8605] [rest] Enable job cancellation from the web ...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5430 Thanks for the review @GJL. Addressing your comments and then merging this PR. ---

[GitHub] flink pull request #5430: [FLINK-8605] [rest] Enable job cancellation from t...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5430#discussion_r168187766 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobTerminationHeaders.java --- @@ -32,7 +32,7 @@ private sta

[jira] [Commented] (FLINK-8605) Enable job cancellation from the web UI

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364114#comment-16364114 ] ASF GitHub Bot commented on FLINK-8605: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #5430: [FLINK-8605] [rest] Enable job cancellation from t...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5430#discussion_r168187481 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java --- @@ -593,6 +617,8 @@ public void shutdown(Time tim

[jira] [Commented] (FLINK-8605) Enable job cancellation from the web UI

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364102#comment-16364102 ] ASF GitHub Bot commented on FLINK-8605: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #5430: [FLINK-8605] [rest] Enable job cancellation from t...

2018-02-14 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5430#discussion_r168186153 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/YarnCancelJobTerminationHeaders.java --- @@ -0,0 +1,55 @@ +/* + *

[jira] [Commented] (FLINK-8613) Return excess container in YarnResourceManager

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364100#comment-16364100 ] ASF GitHub Bot commented on FLINK-8613: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5436: [FLINK-8613] [flip6] [yarn] Return excess containe...

2018-02-14 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5436#discussion_r168185682 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -325,26 +325,43 @@ public void onContainersCompleted(List list) {

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364098#comment-16364098 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-8613) Return excess container in YarnResourceManager

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364096#comment-16364096 ] ASF GitHub Bot commented on FLINK-8613: --- Github user GJL commented on a diff in the

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364092#comment-16364092 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364093#comment-16364093 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168185050 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java --- @@ -686,4 +714

[GitHub] flink pull request #5436: [FLINK-8613] [flip6] [yarn] Return excess containe...

2018-02-14 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5436#discussion_r168184923 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -325,26 +325,43 @@ public void onContainersCompleted(List list) {

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168184599 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -630,19 +506,210 @@ public int numStateEn

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364090#comment-16364090 ] ASF GitHub Bot commented on FLINK-8656: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168184825 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -363,1

[GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...

2018-02-14 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5487 [FLINK-8656] [flip6] Add modify CLI command to rescale Flink jobs ## What is the purpose of the change Jobs can now be rescaled by calling flink modify -p . Internally, the CliFron

[jira] [Updated] (FLINK-8655) Add a default keyspace to CassandraSink

2018-02-14 Thread Christopher Hughes (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Hughes updated FLINK-8655: -- Description: Currently, to use the CassandraPojoSink, it is necessary for a user to prov

[jira] [Commented] (FLINK-7658) Support COLLECT Aggregate function in Flink TABLE API

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364086#comment-16364086 ] ASF GitHub Bot commented on FLINK-7658: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5472: [FLINK-7658][Table API & SQL] support Collect aggr...

2018-02-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5472#discussion_r168183721 --- Diff: docs/dev/table/tableApi.md --- @@ -2885,6 +2885,17 @@ FIELD.varSamp + + +{% highlight java

[jira] [Created] (FLINK-8656) Add CLI command for rescaling

2018-02-14 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8656: Summary: Add CLI command for rescaling Key: FLINK-8656 URL: https://issues.apache.org/jira/browse/FLINK-8656 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-8297) RocksDBListState stores whole list in single byte[]

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364082#comment-16364082 ] ASF GitHub Bot commented on FLINK-8297: --- Github user je-ik commented on the issue:

[GitHub] flink issue #5185: [FLINK-8297] [flink-rocksdb] Optionally store elements of...

2018-02-14 Thread je-ik
Github user je-ik commented on the issue: https://github.com/apache/flink/pull/5185 @aljoscha I updated the title. I'm a little concerned about the serialization in savepoint. If the serialization is *exactly* the same, doesn't that actually mean that again, the whole List will be sto

[jira] [Created] (FLINK-8655) Add a default keyspace to CassandraSink

2018-02-14 Thread Christopher Hughes (JIRA)
Christopher Hughes created FLINK-8655: - Summary: Add a default keyspace to CassandraSink Key: FLINK-8655 URL: https://issues.apache.org/jira/browse/FLINK-8655 Project: Flink Issue Type: I

[GitHub] flink issue #5185: [FLINK-8297] [flink-rocksdb] optionally use RocksDBMapSta...

2018-02-14 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5185 Thanks for the update. Regarding migration, I think the format that we write to the savepoint must be the same between the two `ListState` implementations. @StefanRRichter could you please

[jira] [Commented] (FLINK-8297) RocksDBListState stores whole list in single byte[]

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364078#comment-16364078 ] ASF GitHub Bot commented on FLINK-8297: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-8212) Pull EnvironmentInformation out of TaskManagerServices

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364076#comment-16364076 ] ASF GitHub Bot commented on FLINK-8212: --- Github user zhangminglei commented on a dif

[jira] [Commented] (FLINK-8212) Pull EnvironmentInformation out of TaskManagerServices

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364074#comment-16364074 ] ASF GitHub Bot commented on FLINK-8212: --- Github user zhangminglei commented on a dif

[GitHub] flink pull request #5458: [FLINK-8212] [network] Pull EnvironmentInformation...

2018-02-14 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5458#discussion_r168180788 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java --- @@ -530,10 +538,12 @@ public static long calcu

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364073#comment-16364073 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5458: [FLINK-8212] [network] Pull EnvironmentInformation...

2018-02-14 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5458#discussion_r168180756 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java --- @@ -270,10 +273,14 @@ public static TaskManage

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168180636 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/SnapshotStrategy.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to the Apach

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364067#comment-16364067 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168180080 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/LocalStateForwardingTest.java --- @@ -156,30 +157,38 @@ public

[jira] [Commented] (FLINK-8520) CassandraConnectorITCase.testCassandraTableSink unstable on Travis

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364066#comment-16364066 ] ASF GitHub Bot commented on FLINK-8520: --- Github user zentol commented on the issue:

[GitHub] flink issue #5474: [FLINK-8520][cassandra] Fix race condition

2018-02-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5474 yes it should be 8520 (good catch!), will fix while merging. ---

[jira] [Commented] (FLINK-8600) BucketingSink errors out when used with Presto filesystem

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364062#comment-16364062 ] ASF GitHub Bot commented on FLINK-8600: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-8600) BucketingSink errors out when used with Presto filesystem

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364061#comment-16364061 ] ASF GitHub Bot commented on FLINK-8600: --- GitHub user aljoscha opened a pull request:

[jira] [Commented] (FLINK-8641) Move BootstrapTools#getTaskManagerShellCommand to flink-yarn

2018-02-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364063#comment-16364063 ] Chesnay Schepler commented on FLINK-8641: - Yes, that would work as well. However w

[GitHub] flink issue #5486: [FLINK-8600] Don't use flaky truncate() test in Bucketing...

2018-02-14 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5486 (I realised this doesn't add any tests or anything but `BucketingSink` is currently problematic with S3 anyways.) ---

[jira] [Assigned] (FLINK-8212) Pull EnvironmentInformation out of TaskManagerServices

2018-02-14 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang reassigned FLINK-8212: --- Assignee: mingleizhang > Pull EnvironmentInformation out of TaskManagerServices > ---

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364060#comment-16364060 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5486: [FLINK-8600] Don't use flaky truncate() test in Bu...

2018-02-14 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/5486 [FLINK-8600] Don't use flaky truncate() test in BucketingSink R: @kl0u You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink jira-860

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364059#comment-16364059 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168179062 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskStateManagerImplTest.java --- @@ -97,6 +104,39 @@ public void testStateRepor

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168179034 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskStateManagerImplTest.java --- @@ -97,6 +104,39 @@ public void testStateRepor

[GitHub] flink pull request #5272: [Flink-8397][Connectors]Support Row type for Cassa...

2018-02-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5272#discussion_r168176395 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraRowOutputFormat.java --- @@ -0,0 +1,

[GitHub] flink pull request #5272: [Flink-8397][Connectors]Support Row type for Cassa...

2018-02-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5272#discussion_r168169778 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraTupleOutputFormat.java --- @@ -0,0 +

[GitHub] flink pull request #5272: [Flink-8397][Connectors]Support Row type for Cassa...

2018-02-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5272#discussion_r168177375 --- Diff: flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java --- @@ -482

[GitHub] flink pull request #5272: [Flink-8397][Connectors]Support Row type for Cassa...

2018-02-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5272#discussion_r168177338 --- Diff: flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java --- @@ -457

[GitHub] flink pull request #5272: [Flink-8397][Connectors]Support Row type for Cassa...

2018-02-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5272#discussion_r168169354 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -37,11 +36,

[GitHub] flink pull request #5272: [Flink-8397][Connectors]Support Row type for Cassa...

2018-02-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5272#discussion_r168175822 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -95,15 +94,

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364056#comment-16364056 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364057#comment-16364057 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168177861 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskStateManagerImplTest.java --- @@ -25,17 +25,24 @@ import org.apache.fli

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168177813 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskExecutorLocalStateStoresManagerTest.java --- @@ -0,0 +1,122 @@ +/* +

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364049#comment-16364049 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364047#comment-16364047 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168176949 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java --- @@ -197,7 +201,13 @@ public static TaskManag

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168176995 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskExecutorLocalStateStoresManagerTest.java --- @@ -0,0 +1,122 @@ +/* +

<    1   2   3   4   5   >