[GitHub] [flink] LadyForest commented on a change in pull request #18394: [FLINK-25520][Table SQL/API] Implement "ALTER TABLE ... COMPACT" SQL

2022-01-19 Thread GitBox
LadyForest commented on a change in pull request #18394: URL: https://github.com/apache/flink/pull/18394#discussion_r787562855 ## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/connector/source/TestManagedTableSink.java ## @@ -0,0 +1,468 @@ +/*

[jira] [Commented] (FLINK-14304) Avoid task starvation with mailbox

2022-01-19 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478503#comment-17478503 ] Bo Cui commented on FLINK-14304: hi [~arvid]  why add the condition? https://github.com

[jira] [Updated] (FLINK-25485) JDBC connector implicitly append url options when use mysql

2022-01-19 Thread Ada Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ada Wong updated FLINK-25485: - Description: When we directly use buffer-flush options of the mysql sink (sink.buffer-flush.max-rows an

[GitHub] [flink] flinkbot edited a comment on pull request #18303: [FLINK-25085][runtime] Add a scheduled thread pool for periodic tasks in RpcEndpoint

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18303: URL: https://github.com/apache/flink/pull/18303#issuecomment-1008005239 ## CI report: * 6024e28f7d315a7d1157f9af33da9b815f81a27a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] LadyForest commented on a change in pull request #18394: [FLINK-25520][Table SQL/API] Implement "ALTER TABLE ... COMPACT" SQL

2022-01-19 Thread GitBox
LadyForest commented on a change in pull request #18394: URL: https://github.com/apache/flink/pull/18394#discussion_r787401902 ## File path: flink-formats/flink-orc/pom.xml ## @@ -145,6 +145,19 @@ under the License. test test-jar

[jira] [Updated] (FLINK-25485) JDBC connector implicitly append url options when use mysql

2022-01-19 Thread Ada Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ada Wong updated FLINK-25485: - Description: When we directly use buffer-flush options of the mysql sink (sink.buffer-flush.max-rows an

[GitHub] [flink] rkhachatryan merged pull request #18393: Revert "[FLINK-25399][tests] Disable changelog backend in tests"

2022-01-19 Thread GitBox
rkhachatryan merged pull request #18393: URL: https://github.com/apache/flink/pull/18393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Commented] (FLINK-25699) Use HashMap for MAP value constructors

2022-01-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478500#comment-17478500 ] Sergey Nuyanzin commented on FLINK-25699: - Hi [~twalthr] Am I correct that this

[jira] [Comment Edited] (FLINK-25700) flinksql Cascading Window TVF Aggregation exception

2022-01-19 Thread simenliuxing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478494#comment-17478494 ] simenliuxing edited comment on FLINK-25700 at 1/19/22, 9:52 AM: --

[jira] [Commented] (FLINK-25485) JDBC connector implicitly append url options when use mysql

2022-01-19 Thread Ada Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478499#comment-17478499 ] Ada Wong commented on FLINK-25485: -- cc [~jark] [~fpaul] [~roman]  So many users reflec

[jira] [Updated] (FLINK-25485) JDBC connector implicitly append url options when use mysql

2022-01-19 Thread Ada Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ada Wong updated FLINK-25485: - Description: When we directly use buffer-flush options of the mysql sink, buffer-flush options(sink.buf

[GitHub] [flink] snuyanzin commented on a change in pull request #18287: [FLINK-17321][table] Add support casting of map to map and multiset to multiset

2022-01-19 Thread GitBox
snuyanzin commented on a change in pull request #18287: URL: https://github.com/apache/flink/pull/18287#discussion_r787556416 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala ## @@ -722,9 +722,9 @@ clas

[jira] [Commented] (FLINK-25700) flinksql Cascading Window TVF Aggregation exception

2022-01-19 Thread simenliuxing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478494#comment-17478494 ] simenliuxing commented on FLINK-25700: -- [~jark] hi,can you take a look? > flinksql

[jira] [Updated] (FLINK-25700) flinksql Cascading Window TVF Aggregation exception

2022-01-19 Thread simenliuxing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] simenliuxing updated FLINK-25700: - Attachment: (was: image-2022-01-19-17-45-57-124.png) > flinksql Cascading Window TVF Aggrega

[jira] [Updated] (FLINK-25700) flinksql Cascading Window TVF Aggregation exception

2022-01-19 Thread simenliuxing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] simenliuxing updated FLINK-25700: - Attachment: image-2022-01-19-17-45-57-124.png > flinksql Cascading Window TVF Aggregation excep

[jira] [Created] (FLINK-25700) flinksql Cascading Window TVF Aggregation exception

2022-01-19 Thread simenliuxing (Jira)
simenliuxing created FLINK-25700: Summary: flinksql Cascading Window TVF Aggregation exception Key: FLINK-25700 URL: https://issues.apache.org/jira/browse/FLINK-25700 Project: Flink Issue Ty

[GitHub] [flink] JingsongLi commented on pull request #18359: [FLINK-25484][connectors/filesystem] Support inactivityInterval config in table api

2022-01-19 Thread GitBox
JingsongLi commented on pull request #18359: URL: https://github.com/apache/flink/pull/18359#issuecomment-1016258587 Thanks @lichang-bd , can you add test to verify? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (FLINK-25699) Use HashMap for MAP value constructors

2022-01-19 Thread Timo Walther (Jira)
Timo Walther created FLINK-25699: Summary: Use HashMap for MAP value constructors Key: FLINK-25699 URL: https://issues.apache.org/jira/browse/FLINK-25699 Project: Flink Issue Type: Sub-task

[GitHub] [flink] flinkbot edited a comment on pull request #18394: [FLINK-25520][Table SQL/API] Implement "ALTER TABLE ... COMPACT" SQL

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18394: URL: https://github.com/apache/flink/pull/18394#issuecomment-1015323011 ## CI report: * cc5eaf1dd5be0414a77c59f619e407c01d083e0c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[jira] [Commented] (FLINK-25695) TemporalJoin cause state leak in some cases

2022-01-19 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478486#comment-17478486 ] Lyn Zhang commented on FLINK-25695: --- The sql like below and set table.exec.state.ttl =

[jira] [Comment Edited] (FLINK-24163) PartiallyFinishedSourcesITCase fails due to timeout

2022-01-19 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478483#comment-17478483 ] Roman Khachatryan edited comment on FLINK-24163 at 1/19/22, 9:38 AM: -

[jira] [Updated] (FLINK-25695) TemporalJoin cause state leak in some cases

2022-01-19 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-25695: -- Attachment: test.sql > TemporalJoin cause state leak in some cases > -

[jira] [Commented] (FLINK-24163) PartiallyFinishedSourcesITCase fails due to timeout

2022-01-19 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478483#comment-17478483 ] Roman Khachatryan commented on FLINK-24163: --- Hi Yun, sure, I'll take a look.

[GitHub] [flink] flinkbot edited a comment on pull request #18368: [FLINK-18356][Azure] Enforce memory limits for docker containers

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18368: URL: https://github.com/apache/flink/pull/18368#issuecomment-1013194055 ## CI report: * 13a059ef4d8b011d5cc1cac10861e0bafa98c6d2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[jira] [Commented] (FLINK-25698) Elasticsearch7DynamicSinkITCase.testWritingDocuments fails on AZP

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478481#comment-17478481 ] Martijn Visser commented on FLINK-25698: CC [~alexanderpreuss] [~fpaul]  > Elas

[GitHub] [flink-table-store] tsreaper commented on a change in pull request #10: [FLINK-25680] Introduce Table Store Flink Sink

2022-01-19 Thread GitBox
tsreaper commented on a change in pull request #10: URL: https://github.com/apache/flink-table-store/pull/10#discussion_r787537977 ## File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/StoreSinkWriter.java ## @@ -0,0 +1,163 @@ +/*

[jira] [Commented] (FLINK-24163) PartiallyFinishedSourcesITCase fails due to timeout

2022-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478479#comment-17478479 ] Till Rohrmann commented on FLINK-24163: --- https://dev.azure.com/apache-flink/apache

[GitHub] [flink] wenlong88 commented on pull request #18017: [FLINK-25171] Validation of duplicate fields in ddl sql

2022-01-19 Thread GitBox
wenlong88 commented on pull request #18017: URL: https://github.com/apache/flink/pull/18017#issuecomment-1016246672 @jelly-1203 thanks for the following up, I would ping @godfreyhe offline to follow the pr. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (FLINK-24163) PartiallyFinishedSourcesITCase fails due to timeout

2022-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478475#comment-17478475 ] Till Rohrmann commented on FLINK-24163: --- Another instance: https://dev.azure.com/

[GitHub] [flink] flinkbot edited a comment on pull request #18102: [FLINK-25033][runtime] Let some scheduler components updatable

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18102: URL: https://github.com/apache/flink/pull/18102#issuecomment-993332110 ## CI report: * 2182c3801f333d4b4827b177bb05ec04c648ea87 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17601: [FLINK-24697][flink-connectors-kafka] add auto.offset.reset configuration for group-offsets startup mode

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #17601: URL: https://github.com/apache/flink/pull/17601#issuecomment-954546978 ## CI report: * 124c7893234b31fc1a3ce5b3b29aff32e3b7847d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[jira] [Updated] (FLINK-21834) org.apache.flink.core.fs.AbstractRecoverableWriterTest.testResumeWithWrongOffset fail

2022-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-21834: -- Labels: test-stability (was: auto-deprioritized-major test-stability) > org.apache.flink.core

[jira] [Updated] (FLINK-21834) org.apache.flink.core.fs.AbstractRecoverableWriterTest.testResumeWithWrongOffset fail

2022-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-21834: -- Affects Version/s: 1.15.0 > org.apache.flink.core.fs.AbstractRecoverableWriterTest.testResumeW

[jira] [Commented] (FLINK-21834) org.apache.flink.core.fs.AbstractRecoverableWriterTest.testResumeWithWrongOffset fail

2022-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478472#comment-17478472 ] Till Rohrmann commented on FLINK-21834: --- Another instance: https://dev.azure.com/

[jira] [Updated] (FLINK-21834) org.apache.flink.core.fs.AbstractRecoverableWriterTest.testResumeWithWrongOffset fail

2022-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-21834: -- Priority: Critical (was: Minor) > org.apache.flink.core.fs.AbstractRecoverableWriterTest.test

[jira] [Commented] (FLINK-25695) TemporalJoin cause state leak in some cases

2022-01-19 Thread Wenlong Lyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478471#comment-17478471 ] Wenlong Lyu commented on FLINK-25695: - According to the description in FLINK-21833,

[jira] [Created] (FLINK-25698) Elasticsearch7DynamicSinkITCase.testWritingDocuments fails on AZP

2022-01-19 Thread Till Rohrmann (Jira)
Till Rohrmann created FLINK-25698: - Summary: Elasticsearch7DynamicSinkITCase.testWritingDocuments fails on AZP Key: FLINK-25698 URL: https://issues.apache.org/jira/browse/FLINK-25698 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #18349: [FLINK-25609][table] Anonymous/inline tables don't require ObjectIdentifier anymore

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18349: URL: https://github.com/apache/flink/pull/18349#issuecomment-1011991081 ## CI report: * e4399cdc5964a3f49354cb114f5c043f5b2702dc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18349: [FLINK-25609][table] Anonymous/inline tables don't require ObjectIdentifier anymore

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18349: URL: https://github.com/apache/flink/pull/18349#issuecomment-1011991081 ## CI report: * e4399cdc5964a3f49354cb114f5c043f5b2702dc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #10: [FLINK-25680] Introduce Table Store Flink Sink

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #10: URL: https://github.com/apache/flink-table-store/pull/10#discussion_r787519403 ## File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/StoreSinkWriter.java ## @@ -0,0 +1,163 @@ +/

[jira] [Commented] (FLINK-25695) TemporalJoin cause state leak in some cases

2022-01-19 Thread Wenlong Lyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478465#comment-17478465 ] Wenlong Lyu commented on FLINK-25695: - [~zicat] could you share your sql too? it wo

[jira] [Assigned] (FLINK-25681) CodeSplitITCase produces large stacktraces and potentially out of memory errors

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-25681: -- Assignee: Caizhi Weng > CodeSplitITCase produces large stacktraces and potentially ou

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #10: [FLINK-25680] Introduce Table Store Flink Sink

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #10: URL: https://github.com/apache/flink-table-store/pull/10#discussion_r787518576 ## File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/StoreSinkWriter.java ## @@ -0,0 +1,163 @@ +/

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #10: [FLINK-25680] Introduce Table Store Flink Sink

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #10: URL: https://github.com/apache/flink-table-store/pull/10#discussion_r787516809 ## File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/SinkRecord.java ## @@ -0,0 +1,71 @@ +/* + *

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #10: [FLINK-25680] Introduce Table Store Flink Sink

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #10: URL: https://github.com/apache/flink-table-store/pull/10#discussion_r787516809 ## File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/SinkRecord.java ## @@ -0,0 +1,71 @@ +/* + *

[jira] [Commented] (FLINK-18356) Exit code 137 returned from process

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478464#comment-17478464 ] Martijn Visser commented on FLINK-18356: [~dwysakowicz] I've talked to [~TsReape

[GitHub] [flink] rkhachatryan commented on pull request #18393: Revert "[FLINK-25399][tests] Disable changelog backend in tests"

2022-01-19 Thread GitBox
rkhachatryan commented on pull request #18393: URL: https://github.com/apache/flink/pull/18393#issuecomment-1016229700 Thanks for the review. I think the remaining bugs don't affect correctness so I'm going to merge this PR. -- This is an automated message from the Apache Git Service.

[GitHub] [flink] flinkbot edited a comment on pull request #17720: [FLINK-24210][serializer] Return the correct serialized length for wi…

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #17720: URL: https://github.com/apache/flink/pull/17720#issuecomment-963141306 ## CI report: * cec9ccbee64a29f43eb24f42dfd8db48e0d9e08a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-25649) Scheduling jobs fails with org.apache.flink.runtime.jobmanager.scheduler.NoResourceAvailableException

2022-01-19 Thread Gil De Grove (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478449#comment-17478449 ] Gil De Grove commented on FLINK-25649: -- [~zhuzh] [~trohrmann],   The logs are qu

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18349: [FLINK-25609][table] Anonymous/inline tables don't require ObjectIdentifier anymore

2022-01-19 Thread GitBox
slinkydeveloper commented on a change in pull request #18349: URL: https://github.com/apache/flink/pull/18349#discussion_r787503439 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/CreateTableASOperation.java ## @@ -26,25 +26,3

[jira] [Commented] (FLINK-25681) CodeSplitITCase produces large stacktraces and potentially out of memory errors

2022-01-19 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478438#comment-17478438 ] Caizhi Weng commented on FLINK-25681: - Hi [~MartijnVisser]! Thanks for looking into

[jira] [Comment Edited] (FLINK-25681) CodeSplitITCase produces large stacktraces and potentially out of memory errors

2022-01-19 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478438#comment-17478438 ] Caizhi Weng edited comment on FLINK-25681 at 1/19/22, 8:56 AM: ---

[jira] [Commented] (FLINK-25649) Scheduling jobs fails with org.apache.flink.runtime.jobmanager.scheduler.NoResourceAvailableException

2022-01-19 Thread Gil De Grove (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478436#comment-17478436 ] Gil De Grove commented on FLINK-25649: -- [~zhuzh] [~trohrmann] , I was able to repr

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN * b220c66e7dd126f894235bc66b8fe5ba8b56

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN * b220c66e7dd126f894235bc66b8fe5ba8b56

[GitHub] [flink] flinkbot edited a comment on pull request #18398: [FLINK-25695][flink-table] Fix state leak in temporalRowTimeJoinOper…

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18398: URL: https://github.com/apache/flink/pull/18398#issuecomment-1016025272 ## CI report: * 0fb5e7a2b2f583a36775e1d7347080e834e0d806 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18368: [FLINK-18356][Azure] Enforce memory limits for docker containers

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18368: URL: https://github.com/apache/flink/pull/18368#issuecomment-1013194055 ## CI report: * 13a059ef4d8b011d5cc1cac10861e0bafa98c6d2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r787408231 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreOptions.java ## @@ -0,0 +1,53 @@ +/* + * Licensed

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN * b220c66e7dd126f894235bc66b8fe5ba8b56

[GitHub] [flink] flinkbot edited a comment on pull request #18368: [FLINK-18356][Azure] Enforce memory limits for docker containers

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18368: URL: https://github.com/apache/flink/pull/18368#issuecomment-1013194055 ## CI report: * 13a059ef4d8b011d5cc1cac10861e0bafa98c6d2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN * b220c66e7dd126f894235bc66b8fe5ba8b56

[GitHub] [flink] XComp commented on a change in pull request #18189: [FLINK-25430] Replace RunningJobRegistry by JobResultStore

2022-01-19 Thread GitBox
XComp commented on a change in pull request #18189: URL: https://github.com/apache/flink/pull/18189#discussion_r787472097 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/runner/SessionDispatcherLeaderProcessTest.java ## @@ -130,28 +146,56 @@ publi

[GitHub] [flink] XComp commented on a change in pull request #18189: [FLINK-25430] Replace RunningJobRegistry by JobResultStore

2022-01-19 Thread GitBox
XComp commented on a change in pull request #18189: URL: https://github.com/apache/flink/pull/18189#discussion_r787470497 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultEntry.java ## @@ -22,41 +22,18 @@ import org.apache.flink.uti

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN * b220c66e7dd126f894235bc66b8fe5ba8b56

[GitHub] [flink] dawidwys commented on pull request #18368: [FLINK-18356][Azure] Enforce memory limits for docker containers

2022-01-19 Thread GitBox
dawidwys commented on pull request #18368: URL: https://github.com/apache/flink/pull/18368#issuecomment-1016200608 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink] XComp commented on a change in pull request #18189: [FLINK-25430] Replace RunningJobRegistry by JobResultStore

2022-01-19 Thread GitBox
XComp commented on a change in pull request #18189: URL: https://github.com/apache/flink/pull/18189#discussion_r787467634 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java ## @@ -943,15 +945,26 @@ protected CleanupJobState jobReache

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN * b220c66e7dd126f894235bc66b8fe5ba8b56

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18349: [FLINK-25609][table] Anonymous/inline tables don't require ObjectIdentifier anymore

2022-01-19 Thread GitBox
slinkydeveloper commented on a change in pull request #18349: URL: https://github.com/apache/flink/pull/18349#discussion_r787463301 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/StatementSet.java ## @@ -62,10 +62,10 @@ * written

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN * b220c66e7dd126f894235bc66b8fe5ba8b56

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18349: [FLINK-25609][table] Anonymous/inline tables don't require ObjectIdentifier anymore

2022-01-19 Thread GitBox
slinkydeveloper commented on a change in pull request #18349: URL: https://github.com/apache/flink/pull/18349#discussion_r787459410 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/ContextResolvedTable.java ## @@ -0,0 +1,190 @@ +/* +

[GitHub] [flink] zhuzhengjun01 edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2022-01-19 Thread GitBox
zhuzhengjun01 edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-1016191275 > like this , ` syntax = proto3; package org.apache.flink.formats.protobuf.proto; option java_multiple_files = false; message KafkaSinkTestTT

[GitHub] [flink] zhuzhengjun01 edited a comment on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2022-01-19 Thread GitBox
zhuzhengjun01 edited a comment on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-1016191275 > like this , `syntax = 'proto3'; package org.apache.flink.formats.protobuf.proto; option java_multiple_files = false; message KafkaSinkTestTT {

[GitHub] [flink] zhuzhengjun01 commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2022-01-19 Thread GitBox
zhuzhengjun01 commented on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-1016191275 > like this , `syntax = "proto3"; package org.apache.flink.formats.protobuf.proto; option java_multiple_files = false; message KafkaSinkTestTT {

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN * b220c66e7dd126f894235bc66b8fe5ba8b56

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18349: [FLINK-25609][table] Anonymous/inline tables don't require ObjectIdentifier anymore

2022-01-19 Thread GitBox
slinkydeveloper commented on a change in pull request #18349: URL: https://github.com/apache/flink/pull/18349#discussion_r787453251 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java ## @@ -157,7 +157,7 @@ public static

[jira] [Commented] (FLINK-25683) wrong result if table transfrom to DataStream then window process in batch mode

2022-01-19 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478400#comment-17478400 ] Timo Walther commented on FLINK-25683: -- Thanks for investigating [~paul8263]. I wil

[GitHub] [flink] flinkbot edited a comment on pull request #18394: [FLINK-25520][Table SQL/API] Implement "ALTER TABLE ... COMPACT" SQL

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18394: URL: https://github.com/apache/flink/pull/18394#issuecomment-1015323011 ## CI report: * 455dfd8ad2146f35d31a602715a9b27a07aa2aba Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resu

[GitHub] [flink] flinkbot edited a comment on pull request #18388: [FLINK-25530][python][connector/pulsar] Support Pulsar source connector in Python DataStream API.

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18388: URL: https://github.com/apache/flink/pull/18388#issuecomment-1015205179 ## CI report: * 76134252d18e14772c18739278af72c9b519e353 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN * b220c66e7dd126f894235bc66b8fe5ba8b56

[GitHub] [flink] flinkbot edited a comment on pull request #18119: [FLINK-24947] Support hostNetwork for native K8s integration on session mode

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18119: URL: https://github.com/apache/flink/pull/18119#issuecomment-994734000 ## CI report: * 99653eb7e622b96ba0bb47836fe3eefe7b71d942 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] maosuhan commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2022-01-19 Thread GitBox
maosuhan commented on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-1016185722 > @maosuhan hi, flink-protobuf works very well in my job, but i found some corner case that it was not supported `oneof` in proto3. so this will be dealt in future or not ?

[GitHub] [flink] twalthr commented on a change in pull request #18349: [FLINK-25609][table] Anonymous/inline tables don't require ObjectIdentifier anymore

2022-01-19 Thread GitBox
twalthr commented on a change in pull request #18349: URL: https://github.com/apache/flink/pull/18349#discussion_r786804756 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/ContextResolvedTable.java ## @@ -0,0 +1,190 @@ +/* + * Licens

[jira] [Updated] (FLINK-25694) GSON/Alluxio Vulnerability

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-25694: --- Component/s: Connectors / FileSystem > GSON/Alluxio Vulnerability >

[jira] [Commented] (FLINK-25694) GSON/Alluxio Vulnerability

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478398#comment-17478398 ] Martijn Visser commented on FLINK-25694: [~davidnperkins] Was there a CVE number

[jira] [Updated] (FLINK-25694) GSON/Alluxio Vulnerability

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-25694: --- Description: GSON has a bug, which was fixed in 2.8.9, see [https://github.com/google/gson/

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN * b220c66e7dd126f894235bc66b8fe5ba8b56

[jira] [Comment Edited] (FLINK-25684) Support enhanced show databases syntax

2022-01-19 Thread Moses (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477583#comment-17477583 ] Moses edited comment on FLINK-25684 at 1/19/22, 8:09 AM: - [~jark

[jira] [Commented] (FLINK-25562) hive sql connector dependency conflicts

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478387#comment-17478387 ] Martijn Visser commented on FLINK-25562: [~luoyuxia] Thank you!  > hive sql con

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478386#comment-17478386 ] Martijn Visser commented on FLINK-25614: [~lmagics] Given that the Flink 1.15 re

[jira] [Updated] (FLINK-25694) GSON/Alluxio Vulnerability

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-25694: --- Issue Type: Technical Debt (was: Bug) > GSON/Alluxio Vulnerability > --

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-19 Thread GitBox
slinkydeveloper commented on a change in pull request #18290: URL: https://github.com/apache/flink/pull/18290#discussion_r787442155 ## File path: flink-connectors/flink-connector-hbase-2.2/src/main/java/org/apache/flink/connector/hbase2/HBase2DynamicTableFactory.java ## @@ -13

[jira] [Commented] (FLINK-25683) wrong result if table transfrom to DataStream then window process in batch mode

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478384#comment-17478384 ] Martijn Visser commented on FLINK-25683: [~paul8263] I've assigned it to you. 

[jira] [Assigned] (FLINK-25683) wrong result if table transfrom to DataStream then window process in batch mode

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-25683: -- Assignee: Yao Zhang > wrong result if table transfrom to DataStream then window proce

[GitHub] [flink] flinkbot edited a comment on pull request #18399: [FLINK-25118][streaming] Add vertex topology index prefix in vertex name

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18399: URL: https://github.com/apache/flink/pull/18399#issuecomment-1016036536 ## CI report: * 1b59e0775a0fc8288e915036f8ba7a658069881d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

<    1   2   3   4   5   6