Re: [PR] Add release announcement for Flink CDC 3.1.0 [flink-web]

2024-05-07 Thread via GitHub
JingsongLi commented on code in PR #739: URL: https://github.com/apache/flink-web/pull/739#discussion_r1593424071 ## docs/content/posts/2024-MM-DD-release-cdc-3.1.0.md: ## @@ -0,0 +1,67 @@ +--- +title: "Apache Flink CDC 3.1.0 Release Announcement" +date:

Re: [PR] Add release announcement for Flink CDC 3.1.0 [flink-web]

2024-05-07 Thread via GitHub
JingsongLi commented on code in PR #739: URL: https://github.com/apache/flink-web/pull/739#discussion_r1593423213 ## docs/content/posts/2024-MM-DD-release-cdc-3.1.0.md: ## @@ -0,0 +1,67 @@ +--- +title: "Apache Flink CDC 3.1.0 Release Announcement" +date:

Re: [PR] Add release announcement for Flink CDC 3.1.0 [flink-web]

2024-05-07 Thread via GitHub
JingsongLi commented on code in PR #739: URL: https://github.com/apache/flink-web/pull/739#discussion_r1593422867 ## docs/content/posts/2024-MM-DD-release-cdc-3.1.0.md: ## @@ -0,0 +1,67 @@ +--- +title: "Apache Flink CDC 3.1.0 Release Announcement" +date:

Re: [PR] Add release announcement for Flink CDC 3.1.0 [flink-web]

2024-05-07 Thread via GitHub
JingsongLi commented on code in PR #739: URL: https://github.com/apache/flink-web/pull/739#discussion_r159343 ## docs/content/posts/2024-MM-DD-release-cdc-3.1.0.md: ## @@ -0,0 +1,67 @@ +--- +title: "Apache Flink CDC 3.1.0 Release Announcement" +date:

Re: [PR] [fix-issue-2676] repair a snapshot-split bug: [flink-cdc]

2024-05-07 Thread via GitHub
yuxiqian commented on code in PR #2968: URL: https://github.com/apache/flink-cdc/pull/2968#discussion_r1593412252 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/ObjectUtils.java: ## @@

[jira] [Commented] (FLINK-35306) Flink cannot compile with jdk17

2024-05-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844530#comment-17844530 ] Rui Fan commented on FLINK-35306: - Sounds make sense to me, let's follow FLINK-35307. > Flink cannot

[jira] [Updated] (FLINK-35306) Flink cannot compile with jdk17

2024-05-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35306: Component/s: Build System / CI Tests > Flink cannot compile with jdk17 >

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-07 Thread via GitHub
RocMarshal commented on code in PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593374629 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java: ## @@ -144,7 +146,8 @@ void

Re: [PR] [FLINK-32087][checkpoint] Introduce space amplification statistics of file merging [flink]

2024-05-07 Thread via GitHub
flinkbot commented on PR #24762: URL: https://github.com/apache/flink/pull/24762#issuecomment-2099726058 ## CI report: * 1a7982481df72336b004d2581772a96e3205b0d7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-07 Thread via GitHub
RocMarshal commented on code in PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593372606 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -179,13 +205,34 @@ public

[jira] [Assigned] (FLINK-32087) Space amplification statistics of file merging

2024-05-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-32087: --- Assignee: Yanfei Lei (was: Rui Xia) > Space amplification statistics of file merging >

Re: [PR] [FLINK-31228] Update kafka and zookeeper docker image [flink-playgrounds]

2024-05-07 Thread via GitHub
somelovelanguage commented on PR #41: URL: https://github.com/apache/flink-playgrounds/pull/41#issuecomment-2099721932 It works! Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-32087) Space amplification statistics of file merging

2024-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32087: --- Labels: pull-request-available (was: ) > Space amplification statistics of file merging >

[PR] [FLINK-32087][checkpoint] Introduce space amplification statistics of file merging [flink]

2024-05-07 Thread via GitHub
fredia opened a new pull request, #24762: URL: https://github.com/apache/flink/pull/24762 ## What is the purpose of the change This PR introduces space amplification statistics of file merging. ## Brief change log - Add `SpaceStat` class in

[jira] [Created] (FLINK-35307) Add Compile CI check on jdk17

2024-05-07 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-35307: --- Summary: Add Compile CI check on jdk17 Key: FLINK-35307 URL: https://issues.apache.org/jira/browse/FLINK-35307 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-35306) Flink cannot compile with jdk17

2024-05-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844519#comment-17844519 ] Zakelly Lan commented on FLINK-35306: - How about also adding compilation CI check on java11/17 >

[jira] [Comment Edited] (FLINK-35306) Flink cannot compile with jdk17

2024-05-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844519#comment-17844519 ] Zakelly Lan edited comment on FLINK-35306 at 5/8/24 4:25 AM: - How about also

[jira] [Updated] (FLINK-35306) Flink cannot compile with jdk17

2024-05-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35306: Description: [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=59380=results]

[jira] [Updated] (FLINK-35192) Kubernetes operator oom

2024-05-07 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenyuzhi updated FLINK-35192: -- Attachment: screenshot-4.png > Kubernetes operator oom > --- > >

[PR] [FLINK-35192] support jemalloc in image [flink-kubernetes-operator]

2024-05-07 Thread via GitHub
chenyuzhi459 opened a new pull request, #825: URL: https://github.com/apache/flink-kubernetes-operator/pull/825 ## What is the purpose of the change According to [FLINK-35192](https://issues.apache.org/jira/browse/FLINK-35192), the current operator image uses glibc as the

Re: [PR] [FLINK-35306][test] Update some methods in flink-tests-java17 to solve jdk17 compile fails [flink]

2024-05-07 Thread via GitHub
flinkbot commented on PR #24761: URL: https://github.com/apache/flink/pull/24761#issuecomment-2099697858 ## CI report: * 94df53390b48dc820d8147a0eb17f84743f7850d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35306) Flink cannot compile with jdk17

2024-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35306: --- Labels: pull-request-available (was: ) > Flink cannot compile with jdk17 >

[PR] [FLINK-35306][test] Update some methods in flink-tests-java17 to solve jdk17 compile fails [flink]

2024-05-07 Thread via GitHub
1996fanrui opened a new pull request, #24761: URL: https://github.com/apache/flink/pull/24761 ## What is the purpose of the change Flink cannot compile with jdk17 Reason: TypeSerializerUpgradeTestBase.UpgradeVerifier updates the schemaCompatibilityMatcher method name to

[jira] [Updated] (FLINK-35306) Flink cannot compile with jdk17

2024-05-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35306: Description: Reason: TypeSerializerUpgradeTestBase.UpgradeVerifier update the schemaCompatibilityMatcher

[jira] [Created] (FLINK-35306) Flink cannot compile with jdk17

2024-05-07 Thread Rui Fan (Jira)
Rui Fan created FLINK-35306: --- Summary: Flink cannot compile with jdk17 Key: FLINK-35306 URL: https://issues.apache.org/jira/browse/FLINK-35306 Project: Flink Issue Type: Bug Affects Versions:

[jira] [Commented] (FLINK-34954) Kryo input implementation NoFetchingInput fails to handle zero length bytes

2024-05-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844507#comment-17844507 ] Rui Fan commented on FLINK-34954: - Hi [~q.xu] , I wanna check with you did you meet this issue in your

[jira] [Assigned] (FLINK-35215) The performance of serializerKryo and serializerKryoWithoutRegistration are regressed

2024-05-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-35215: --- Assignee: Rui Fan > The performance of serializerKryo and serializerKryoWithoutRegistration are >

Re: [PR] [FLINK-35030][runtime] Introduce Epoch Manager under async execution [flink]

2024-05-07 Thread via GitHub
Zakelly commented on code in PR #24748: URL: https://github.com/apache/flink/pull/24748#discussion_r1593310127 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/ParallelEpochManager.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[jira] [Closed] (FLINK-34666) Keep assigned splits in order to fix wrong meta group calculation

2024-05-07 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren closed FLINK-34666. - Resolution: Fixed > Keep assigned splits in order to fix wrong meta group calculation >

Re: [PR] [fix] repair a snapshot-split bug: [flink-cdc]

2024-05-07 Thread via GitHub
AidenPerce commented on PR #2968: URL: https://github.com/apache/flink-cdc/pull/2968#issuecomment-2099656171 @yuxiqian may help to merge it please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-05-07 Thread via GitHub
Jiabao-Sun commented on code in PR #24670: URL: https://github.com/apache/flink/pull/24670#discussion_r1593325219 ## flink-core/src/test/java/org/apache/flink/util/SerializedValueTest.java: ## @@ -20,62 +20,57 @@ import org.apache.flink.core.testutils.CommonTestUtils;

[jira] [Commented] (FLINK-35215) The performance of serializerKryo and serializerKryoWithoutRegistration are regressed

2024-05-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844504#comment-17844504 ] Rui Fan commented on FLINK-35215: - Thanks [~kkrugler] for the feedback! {quote} * I was surprised that

Re: [PR] [FLINK-35215][core] Fix the bug when Kryo serialize length is 0 [flink]

2024-05-07 Thread via GitHub
1996fanrui commented on code in PR #24717: URL: https://github.com/apache/flink/pull/24717#discussion_r1593318508 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java: ## @@ -114,18 +117,26 @@ public void readBytes(byte[] bytes, int

Re: [PR] [FLINK-35215][core] Fix the bug when Kryo serialize length is 0 [flink]

2024-05-07 Thread via GitHub
1996fanrui commented on code in PR #24717: URL: https://github.com/apache/flink/pull/24717#discussion_r1593316335 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java: ## @@ -114,18 +117,26 @@ public void readBytes(byte[] bytes, int

Re: [PR] [FLINK-35215][core] Fix the bug when Kryo serialize length is 0 [flink]

2024-05-07 Thread via GitHub
1996fanrui commented on code in PR #24717: URL: https://github.com/apache/flink/pull/24717#discussion_r1579104254 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java: ## @@ -65,6 +65,10 @@ public boolean canReadLong() throws

[jira] [Updated] (FLINK-35143) Expose newly added tables capture in mysql pipeline connector

2024-05-07 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35143: -- Fix Version/s: cdc-3.2.0 Affects Version/s: cdc-3.1.0 > Expose newly added tables

[jira] [Updated] (FLINK-35129) Postgres source commits the offset after every multiple checkpoint cycles.

2024-05-07 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35129: -- Fix Version/s: cdc-3.2.0 Affects Version/s: cdc-3.1.0 > Postgres source commits the

[jira] [Updated] (FLINK-35067) Support metadata 'op_type' virtual column for Postgres CDC Connector.

2024-05-07 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35067: -- Fix Version/s: cdc-3.2.0 > Support metadata 'op_type' virtual column for Postgres CDC

[jira] [Updated] (FLINK-34688) CDC framework split snapshot chunks asynchronously

2024-05-07 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-34688: -- Fix Version/s: cdc-3.2.0 (was: cdc-3.1.0) Affects

[jira] [Updated] (FLINK-35093) Postgres source connector support SPECIFIC_OFFSETS start up mode from an existed replication slot.

2024-05-07 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35093: -- Affects Version/s: cdc-3.1.0 > Postgres source connector support SPECIFIC_OFFSETS start up

[jira] [Updated] (FLINK-35067) Support metadata 'op_type' virtual column for Postgres CDC Connector.

2024-05-07 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35067: -- Affects Version/s: cdc-3.1.0 > Support metadata 'op_type' virtual column for Postgres CDC

[jira] [Updated] (FLINK-35121) CDC pipeline connector should verify requiredOptions and optionalOptions

2024-05-07 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35121: -- Fix Version/s: cdc-3.2.0 > CDC pipeline connector should verify requiredOptions and

[jira] [Updated] (FLINK-35121) CDC pipeline connector should verify requiredOptions and optionalOptions

2024-05-07 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35121: -- Affects Version/s: cdc-3.1.0 > CDC pipeline connector should verify requiredOptions and

[jira] [Updated] (FLINK-35093) Postgres source connector support SPECIFIC_OFFSETS start up mode from an existed replication slot.

2024-05-07 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35093: -- Fix Version/s: cdc-3.2.0 > Postgres source connector support SPECIFIC_OFFSETS start up mode

[jira] [Commented] (FLINK-34666) Keep assigned splits in order to fix wrong meta group calculation

2024-05-07 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844495#comment-17844495 ] Hongshun Wang commented on FLINK-34666: --- Have done it in FLINK-34634, please close it. [~renqs] 

[jira] [Updated] (FLINK-35281) FlinkEnvironmentUtils#addJar add each jar only once

2024-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35281: --- Labels: pull-request-available (was: ) > FlinkEnvironmentUtils#addJar add each jar only

Re: [PR] [FLINK-35281][hotfix][cdc-common] FlinkEnvironmentUtils#addJar add each jar only once [flink-cdc]

2024-05-07 Thread via GitHub
loserwang1024 commented on PR #3301: URL: https://github.com/apache/flink-cdc/pull/3301#issuecomment-2099626220 @yuxiqian , @PatrickRen , CC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [FLINK-35281][hotfix][cdc-common] FlinkEnvironmentUtils#addJar add each jar only once [flink-cdc]

2024-05-07 Thread via GitHub
loserwang1024 opened a new pull request, #3301: URL: https://github.com/apache/flink-cdc/pull/3301 Current org.apache.flink.cdc.composer.flink.FlinkEnvironmentUtils#addJar will be invoked for each source and sink. ```java public static void addJar(StreamExecutionEnvironment env,

Re: [PR] [FLINK-35234][hotfix][cdc-common] Fix NullPointerException of org.apache.flink.cdc.common.configuration.ConfigurationUtils#convertToString [flink-cdc]

2024-05-07 Thread via GitHub
loserwang1024 commented on code in PR #3255: URL: https://github.com/apache/flink-cdc/pull/3255#discussion_r1593302893 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/configuration/ConfigurationUtils.java: ## @@ -130,7 +130,9 @@ static Duration

Re: [PR] [FLINK-35112][python] Fix membership for Row class PyFlink [flink]

2024-05-07 Thread via GitHub
dianfu commented on code in PR #24756: URL: https://github.com/apache/flink/pull/24756#discussion_r1593302200 ## flink-python/pyflink/common/types.py: ## @@ -177,7 +177,10 @@ def of_kind(row_kind: RowKind, *args, **kwargs): return row def __contains__(self,

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-05-07 Thread via GitHub
fredia commented on PR #24698: URL: https://github.com/apache/flink/pull/24698#issuecomment-2099597032 Thanks for the detailed review, rebased to master. Will merge after CI green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-05-07 Thread via GitHub
Jiabao-Sun commented on code in PR #24670: URL: https://github.com/apache/flink/pull/24670#discussion_r1593260020 ## flink-core/src/test/java/org/apache/flink/util/LinkedOptionalMapTest.java: ## @@ -124,42 +118,50 @@ public void mergingToEmpty() {

[PR] Lab 1 with filtering and enrichment [flink-training]

2024-05-07 Thread via GitHub
manoellins opened a new pull request, #79: URL: https://github.com/apache/flink-training/pull/79 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (FLINK-35305) FLIP-438: Amazon SQS Sink Connector

2024-05-07 Thread Priya Dhingra (Jira)
Priya Dhingra created FLINK-35305: - Summary: FLIP-438: Amazon SQS Sink Connector Key: FLINK-35305 URL: https://issues.apache.org/jira/browse/FLINK-35305 Project: Flink Issue Type: New

Re: [PR] Lab 1 - Filter New York only rides [flink-training]

2024-05-07 Thread via GitHub
manoellins closed pull request #78: Lab 1 - Filter New York only rides URL: https://github.com/apache/flink-training/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Lab 1 - Filter New York only rides [flink-training]

2024-05-07 Thread via GitHub
manoellins opened a new pull request, #78: URL: https://github.com/apache/flink-training/pull/78 Logic to filter and return New York only rides -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [DRAFT][FLINK-34440][formats][protobuf-confluent] add support for protobuf-confluent [flink]

2024-05-07 Thread via GitHub
klam-shop commented on PR #24482: URL: https://github.com/apache/flink/pull/24482#issuecomment-2099270127  Thanks for working on this Anupam. Any updates on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-33699) Verify the snapshot migration on Java21

2024-05-07 Thread Alexander Filipchik (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844372#comment-17844372 ] Alexander Filipchik commented on FLINK-33699: - hey folks, is anyone actively working on this

Re: [PR] [FLINK-35299] Respect initial position for new streams [flink-connector-aws]

2024-05-07 Thread via GitHub
antssilva96 commented on code in PR #140: URL: https://github.com/apache/flink-connector-aws/pull/140#discussion_r1592721925 ## flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java: ## @@

Re: [PR] Flink module 1 [flink-training]

2024-05-07 Thread via GitHub
Grub3rMS closed pull request #77: Flink module 1 URL: https://github.com/apache/flink-training/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core [flink]

2024-05-07 Thread via GitHub
GOODBOY008 closed pull request #24523: [FLINK-25537] [JUnit5 Migration] Module: flink-core URL: https://github.com/apache/flink/pull/24523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-35193][table] Support the execution of refresh materialized table [flink]

2024-05-07 Thread via GitHub
flinkbot commented on PR #24760: URL: https://github.com/apache/flink/pull/24760#issuecomment-2098577523 ## CI report: * 7e2b5f7bc2a6137445c6fbca41fe705d96599932 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34916][table] Support `ALTER CATALOG SET` syntax [flink]

2024-05-07 Thread via GitHub
liyubin117 commented on PR #24735: URL: https://github.com/apache/flink/pull/24735#issuecomment-2098565516 @LadyForest Hi, Thanks for your review, I have updated as you said :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (FLINK-35193) Support drop materialized table syntax and execution in continuous refresh mode

2024-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35193: --- Labels: pull-request-available (was: ) > Support drop materialized table syntax and

[PR] [FLINK-35193][table] Support the execution of refresh materialized table [flink]

2024-05-07 Thread via GitHub
xuyangzhong opened a new pull request, #24760: URL: https://github.com/apache/flink/pull/24760 ## What is the purpose of the change Support the execution of refresh materialized table. ## Brief change log - *Add execution in sql gateway* - *Add operation in

[PR] Flink module 1 [flink-training]

2024-05-07 Thread via GitHub
Grub3rMS opened a new pull request, #77: URL: https://github.com/apache/flink-training/pull/77 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Resolved] (FLINK-35195) Support the execution of create materialized table in continuous refresh mode

2024-05-07 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu resolved FLINK-35195. --- Resolution: Fixed > Support the execution of create materialized table in continuous refresh mode >

[jira] [Commented] (FLINK-35195) Support the execution of create materialized table in continuous refresh mode

2024-05-07 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844266#comment-17844266 ] dalongliu commented on FLINK-35195: --- Merged in master: 29736b8c01924b7da03d4bcbfd9c812a8e5a08b4 >

Re: [PR] [FLINK-35195][table] Support the execution of create materialized table in continuous refresh mode [flink]

2024-05-07 Thread via GitHub
lsyldliu merged PR #24750: URL: https://github.com/apache/flink/pull/24750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-35299) FlinkKinesisConsumer does not respect StreamInitialPosition for new Kinesis Stream when restoring from snapshot

2024-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35299: --- Labels: pull-request-available (was: ) > FlinkKinesisConsumer does not respect

Re: [PR] [FLINK-35232] Add retry settings for GCS connector [flink]

2024-05-07 Thread via GitHub
xintongsong commented on code in PR #24753: URL: https://github.com/apache/flink/pull/24753#discussion_r1592308269 ## flink-filesystems/flink-gs-fs-hadoop/src/main/java/org/apache/flink/fs/gs/GSFileSystemOptions.java: ## @@ -80,6 +84,74 @@ public class GSFileSystemOptions {

Re: [PR] FLINK-35299: Add logic to respect initial position for new streams [flink-connector-aws]

2024-05-07 Thread via GitHub
boring-cyborg[bot] commented on PR #140: URL: https://github.com/apache/flink-connector-aws/pull/140#issuecomment-2098181150 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[PR] FLINK-35299: Add logic to respect initial position for new streams [flink-connector-aws]

2024-05-07 Thread via GitHub
antssilva96 opened a new pull request, #140: URL: https://github.com/apache/flink-connector-aws/pull/140 ## Purpose of the change According to the javadoc, the `STREAM_INITIAL_POSITION` property defines where to start reading Kinesis streams from. However, in the current

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-07 Thread via GitHub
eskabetxe commented on code in PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1592285942 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java: ## @@ -144,7 +146,8 @@ void

Re: [PR] [FLINK-34916][table] Support `ALTER CATALOG SET` syntax [flink]

2024-05-07 Thread via GitHub
liyubin117 commented on code in PR #24735: URL: https://github.com/apache/flink/pull/24735#discussion_r1592243049 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -321,6 +322,42 @@ public void createCatalog(String

Re: [PR] [FLINK-34916][table] Support `ALTER CATALOG SET` syntax [flink]

2024-05-07 Thread via GitHub
liyubin117 commented on code in PR #24735: URL: https://github.com/apache/flink/pull/24735#discussion_r1592242102 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -102,6 +103,23 @@ /** Test

Re: [PR] [FLINK-34916][table] Support `ALTER CATALOG SET` syntax [flink]

2024-05-07 Thread via GitHub
liyubin117 commented on code in PR #24735: URL: https://github.com/apache/flink/pull/24735#discussion_r1592237072 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -147,6 +147,28 @@ SqlDrop SqlDropCatalog(Span s, boolean replace) : } }

[jira] [Commented] (FLINK-33462) Sort out the document page about the new Jdbc source.

2024-05-07 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844238#comment-17844238 ] RocMarshal commented on FLINK-33462: Hi, [~martijnvisser]  There's a minor item to confirm, should

Re: [PR] [FLINK-34916][table] Support `ALTER CATALOG SET` syntax [flink]

2024-05-07 Thread via GitHub
liyubin117 commented on code in PR #24735: URL: https://github.com/apache/flink/pull/24735#discussion_r1592191396 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -321,6 +322,42 @@ public void createCatalog(String

[jira] [Resolved] (FLINK-35161) Implement StateExecutor for ForStStateBackend

2024-05-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-35161. - Resolution: Fixed > Implement StateExecutor for ForStStateBackend >

[jira] [Commented] (FLINK-35161) Implement StateExecutor for ForStStateBackend

2024-05-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844232#comment-17844232 ] Zakelly Lan commented on FLINK-35161: - Merged via ea4112aefa72e9d15525a72157ced3e3da3650ff >

Re: [PR] [FLINK-35161][state] Implement StateExecutor for ForStStateBackend [flink]

2024-05-07 Thread via GitHub
Zakelly closed pull request #24739: [FLINK-35161][state] Implement StateExecutor for ForStStateBackend URL: https://github.com/apache/flink/pull/24739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: util [flink]

2024-05-07 Thread via GitHub
Jiabao-Sun commented on code in PR #24670: URL: https://github.com/apache/flink/pull/24670#discussion_r1592131889 ## flink-core/src/test/java/org/apache/flink/util/CloseableIteratorTest.java: ## @@ -17,48 +17,48 @@ package org.apache.flink.util; -import org.junit.Test;

Re: [PR] [FLINK-34916][table] Support `ALTER CATALOG SET` syntax [flink]

2024-05-07 Thread via GitHub
LadyForest commented on code in PR #24735: URL: https://github.com/apache/flink/pull/24735#discussion_r1591751966 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -102,6 +103,23 @@ /** Test

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-05-07 Thread via GitHub
yunfengzhou-hub commented on code in PR #24698: URL: https://github.com/apache/flink/pull/24698#discussion_r1592131320 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncStateException.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35172]DDL statement is added to the Schema Change Event [flink-cdc]

2024-05-07 Thread via GitHub
melin commented on PR #3245: URL: https://github.com/apache/flink-cdc/pull/3245#issuecomment-2097893968 / -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [FLINK-35172]DDL statement is added to the Schema Change Event [flink-cdc]

2024-05-07 Thread via GitHub
melin closed pull request #3245: [FLINK-35172]DDL statement is added to the Schema Change Event URL: https://github.com/apache/flink-cdc/pull/3245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-32706][table] Add built-in SPLIT_STRING function [flink]

2024-05-07 Thread via GitHub
dawidwys commented on PR #24365: URL: https://github.com/apache/flink/pull/24365#issuecomment-2097889690 > Now we use splitByWholeSeparatorPreserveAllTokens, when delimiter is empty, it will return entire string. Actually it splits by whitespaces:

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-05-07 Thread via GitHub
fredia commented on code in PR #24698: URL: https://github.com/apache/flink/pull/24698#discussion_r1592128250 ## flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java: ## @@ -203,12 +251,29 @@ public void callbackFinished() { } @Override -

Re: [PR] [FLINK-35161][state] Implement StateExecutor for ForStStateBackend [flink]

2024-05-07 Thread via GitHub
masteryhx commented on code in PR #24739: URL: https://github.com/apache/flink/pull/24739#discussion_r1592121657 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStGeneralMultiGetOperation.java: ## @@ -31,75 +30,50 @@ /** * The

[jira] [Commented] (FLINK-25537) [JUnit5 Migration] Module: flink-core

2024-05-07 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844226#comment-17844226 ] Jiabao Sun commented on FLINK-25537: master: ffa3869c48a68c1dd3126fa949adc6953979711f > [JUnit5

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: api [flink]

2024-05-07 Thread via GitHub
Jiabao-Sun merged PR #24603: URL: https://github.com/apache/flink/pull/24603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35262] Bridge between AsyncKeyedStateBackend and AsyncExecutionController [flink]

2024-05-07 Thread via GitHub
masteryhx commented on code in PR #24740: URL: https://github.com/apache/flink/pull/24740#discussion_r1592119008 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContext.java: ## @@ -114,6 +116,10 @@ public void

[jira] [Commented] (FLINK-35303) Support logical deletion of data

2024-05-07 Thread LvYanquan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844224#comment-17844224 ] LvYanquan commented on FLINK-35303: --- Currently, we can add a metadata column from row_kind

[jira] [Resolved] (FLINK-32080) Restoration of FileMergingSnapshotManager

2024-05-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-32080. - Resolution: Fixed > Restoration of FileMergingSnapshotManager >

[jira] [Commented] (FLINK-32080) Restoration of FileMergingSnapshotManager

2024-05-07 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844223#comment-17844223 ] Zakelly Lan commented on FLINK-32080: - Merged via afe4c79efa15902369d41ef5a6e73d79a2e7d525 >

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-05-07 Thread via GitHub
Zakelly closed pull request #24640: [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager URL: https://github.com/apache/flink/pull/24640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (FLINK-35304) Mongo ITCase fails due to duplicate records after resuming

2024-05-07 Thread yux (Jira)
yux created FLINK-35304: --- Summary: Mongo ITCase fails due to duplicate records after resuming Key: FLINK-35304 URL: https://issues.apache.org/jira/browse/FLINK-35304 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-35112][python] Fix membership for Row class PyFlink [flink]

2024-05-07 Thread via GitHub
wzorgdrager commented on code in PR #24756: URL: https://github.com/apache/flink/pull/24756#discussion_r1592097458 ## flink-python/pyflink/common/types.py: ## @@ -177,7 +177,10 @@ def of_kind(row_kind: RowKind, *args, **kwargs): return row def __contains__(self,

[jira] [Commented] (FLINK-35041) IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegistration failed

2024-05-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844215#comment-17844215 ] Rui Fan commented on FLINK-35041: - I have asked [~Feifan Wang] offline, he will check it this week with

  1   2   >