Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5950#discussion_r185775633
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5950#discussion_r185772501
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/testutils/ArtificialCNFErrorThrowingClassLoader.java
---
@@ -0,0 +1,42
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5950#discussion_r185771830
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSerializationUtil.java
---
@@ -69,7 +69,7
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5908#discussion_r185749819
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -222,29 +228,53 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5908#discussion_r185749320
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -222,29 +228,53 @@ public
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5908
Maybe let me add some more. First, about introducing a separate new state
handle. Our long term plan is actually to integrate timers more closely with
the backends, so that we can also have
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5908#discussion_r185729732
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java
---
@@ -39,11 +40,18 @@
private
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5908#discussion_r185730033
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java
---
@@ -97,6 +105,32 @@ public String
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5908#discussion_r185734334
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
---
@@ -395,36 +402,102 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5908#discussion_r185729269
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -49,13 +50,13
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5921#discussion_r185711958
--- Diff:
flink-end-to-end-tests/test-scripts/test_high_parallelism_iterations.sh ---
@@ -0,0 +1,70 @@
+#!/usr/bin/env bash
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5947#discussion_r185537704
--- Diff:
flink-end-to-end-tests/flink-stream-stateful-job-upgrade-test/src/main/java/org/apache/flink/streaming/tests
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5947#discussion_r185537151
--- Diff:
flink-end-to-end-tests/flink-stream-stateful-job-upgrade-test/src/main/java/org/apache/flink/streaming/tests
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5947#discussion_r185541401
--- Diff:
flink-end-to-end-tests/flink-stream-stateful-job-upgrade-test/src/main/java/org/apache/flink/streaming/tests
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5185
Just a thought, how about having all this implemented on top of a map
state, and also include the current size as a special entry in the map (with
the size field having a key that makes
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5934
Thanks! Will merge once my travis run is green.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5934#discussion_r185508430
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -3594,6 +3599,58 @@ public String fold(String
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5934
Thanks for your work! Besides my comments, this looks good ð
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5934#discussion_r185470576
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -622,20 +622,23 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5934#discussion_r185465407
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5934#discussion_r185465142
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5934#discussion_r185464970
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -3594,6 +3599,58 @@ public String fold(String
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3359
@shixiaogang Thank you very much, appreciate your efforts on this feature!
There is no need to rush this if you are busy right now, the cycle for the 1.6
release is just beginning.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5934
Yes, there is a theoretical problem if the serialization would not be
threadsafe. I think currently the silent assumption that holds is that
serializers are immutable w.r.t. serialization
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5934
I am also a bit torn. Sometimes I am thinking we might just have a pool
with as many serializer copies as se can have concurrent checkpoints +
savepoints. But then again, it is borderline
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5934
Hi, can you give some more detail about the actual problem you are trying
to fix here? To me it looks like duplicating the serializer only for the meta
data should not be required, because
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5937
@bowenli86 I already wanted to do this for some time but unfortunately we
currently cannot upgrade RocksDB to any higher version than what is used in
master. It seems like there is again
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5930
Thanks, will merge this. There are still the `<>` missing on the new call,
but I will just fix it for you when merging if you don't mind?
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5930
If we remove the use of raw types this fix is good to merge, thanks! ð
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5930#discussion_r184708667
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastBackendStateMetaInfo.java
---
@@ -52,6 +52,23 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5930#discussion_r184708513
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastBackendStateMetaInfo.java
---
@@ -52,6 +52,23 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184696134
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5925
LGTM ð Will merge this.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184691691
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5885
Had two more suggestions, otherwise this is ð for merging.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184690567
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184675164
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5925#discussion_r184647536
--- Diff:
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/DataStreamAllroundTestProgram.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3359
@shixiaogang are you still interested in contributing or collaborating on
this feature? I think we should try to get this into Flink 1.6. What do you
think?
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5910
LGTM ð
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5910#discussion_r184304664
--- Diff:
flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java ---
@@ -221,6 +226,52 @@ protected ObjectStreamClass
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5910#discussion_r184304800
--- Diff:
flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java ---
@@ -221,6 +226,52 @@ protected ObjectStreamClass
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5910#discussion_r184304555
--- Diff:
flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java ---
@@ -221,6 +226,52 @@ protected ObjectStreamClass
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5910#discussion_r184304412
--- Diff:
flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java ---
@@ -221,6 +226,52 @@ protected ObjectStreamClass
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184104126
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -185,36 +188,44 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184101616
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184098081
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -185,36 +188,44 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184093390
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapFoldingState.java
---
@@ -103,17 +104,17 @@ public void add(T value
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184087656
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapFoldingState.java
---
@@ -49,17 +49,18
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184087107
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/AbstractHeapState.java
---
@@ -42,33 +42,35 @@
/** Map containing
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184087357
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapFoldingState.java
---
@@ -49,17 +49,18
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184086555
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapAggregatingState.java
---
@@ -47,21 +47,23
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184085595
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r184084995
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/AbstractHeapState.java
---
@@ -42,33 +42,35 @@
/** Map containing
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r183997653
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -169,13 +169,16 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5885#discussion_r183996477
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5890
Hi @zhangminglei . I think there might unfortunately be a small
misunderstanding: this issue was a subtask for the task of creating a single
general purpose test job, i.e. a single job
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5880
Thanks for the comments, will fix the names and then merge.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5880
@sihuazhou I think it can and should also go into 1.4.
@aljoscha is that a +1 once I have fixed the method names?
---
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/5880
[FLINK-8836] Fix duplicate method in KryoSerializer to perform deep câ¦
â¦opy of default/registered serializer instances.
This method did create deep copies of registered
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5842
LGTM ð Will merge.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5676
I updated the PR to address the review comments.
@aljoscha maybe you can take a look because Till is not available for some
time.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5712
LGTM ð Will merge this.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r182126796
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r182116943
--- Diff: flink-end-to-end-tests/test-scripts/common.sh ---
@@ -176,10 +176,40 @@ function s3_delete {
https://${bucket}.s3.amazonaws.com
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r182117045
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r182116588
--- Diff: flink-end-to-end-tests/test-scripts/common.sh ---
@@ -176,10 +176,40 @@ function s3_delete {
https://${bucket}.s3.amazonaws.com
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r182048477
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/TaskInfo.java ---
@@ -107,4 +131,12 @@ public int getAttemptNumber() {
public
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5705
Thanks for the fixes. LGTM ð Will merge this. Sorry that this took so
long.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178836145
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/TaskInfo.java ---
@@ -107,4 +131,12 @@ public int getAttemptNumber() {
public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178819991
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/TaskInfo.java ---
@@ -107,4 +131,12 @@ public int getAttemptNumber() {
public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178790739
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178790036
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178790018
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178790003
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178789878
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178789937
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/NopTaskLocalStateStoreImpl.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178789236
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178788782
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/NopTaskLocalStateStoreImpl.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178788150
--- Diff:
flink-end-to-end-tests/test-scripts/test_local_recovery_and_scheduling.sh ---
@@ -0,0 +1,111 @@
+#!/usr/bin/env bash
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178771947
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178771812
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178771774
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178771748
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178770202
--- Diff: flink-end-to-end-tests/test-scripts/common.sh ---
@@ -176,10 +176,40 @@ function s3_delete {
https://${bucket}.s3.amazonaws.com
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r178770011
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/TaskInfo.java ---
@@ -107,4 +131,12 @@ public int getAttemptNumber() {
public
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5705
You can cover it here and I will review it again ð
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5705
LGTM ð
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5667
LGTM ð
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5668
LGTM ð
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5666
LGTM ð
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174473498
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/internal/InternalKvState.java
---
@@ -70,10 +88,18 @@
* If no value
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r174446646
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/BackendRestorerProcedure.java
---
@@ -105,6 +105,8 @@ public T
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r174446219
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,450
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r174446255
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,450
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5672#discussion_r174161228
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/Flip6DefaultCLI.java ---
@@ -40,6 +40,7 @@ public Flip6DefaultCLI(Configuration
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5671#discussion_r174142014
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendCancelTest.java
---
@@ -39,13 +47,27 @@
/**
* Tests
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5671#discussion_r174139638
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -567,7 +567,7 @@ public
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5676
CC @tillrohrmann
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5682
LGTM, nice catch ð
---
301 - 400 of 1452 matches
Mail list logo
