Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4360
Yes, that is correct, I kindly asked them to also update their license in
the releases on their issue tracker
https://github.com/facebook/rocksdb/issues/2605.
I will update the PR
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4360
Just noticed that the license is not updated in the 5.5.1 branch, but only
in master. So I guess this means we have to wait for a release that has the
updated Apache compatible license
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4360
CC @aljoscha - suggesting to add this change also to the 1.3.2 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4360
[FLINK-7220] [checkpoints] Update RocksDB dependency to 5.5.1
This PR updates the RocksDB dependency to 5.5.1. Further changes:
- the more performant merge operator is used via
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4353
CC @StephanEwen @zentol
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4353
[FLINK-7213] Introduce state management by OperatorID in TaskManager
Flink-5892 introduced the job manager / checkpoint coordinator part of
managing state on the operator level instead
Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/4192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4192#discussion_r127453343
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/IncrementalKeyedStateHandleTest.java
---
@@ -187,7 +188,7 @@ public void
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4192
Thanks @aljoscha and @StephanEwen for the thorough review :-) I will merge
this once Travis is green.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4192#discussion_r127431267
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/IncrementalKeyedStateHandleTest.java
---
@@ -187,7 +188,7 @@ public void
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4192
@aljoscha @StephanEwen I have added an IT case for this problem. It is
testing a sequence externalized checkpoint recoveries, using full and
incremental checkpoints on standalone
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4192#discussion_r126725696
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV2Serializer.java
---
@@ -391,7 +392,7 @@ private
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4192#discussion_r126725439
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStoreTest.java
---
@@ -160,9 +162,12 @@ public
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4246
Thanks for the review @NicoK !
Merged in 74adb84742.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/4246
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4130
Merged in 5171513a3c.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/4130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4130
Thanks for the review @tillrohrmann! I will address your comments and
proceed with merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4213
I observed similar problems as @pnowojski and the fix helped for me, so +1
from my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4246
CC @NicoK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4246
[FLINK-7063] [checkpoint] Call super.cancel(...) before closing streaâ¦
Minor fix that has only consequences in exception reporting. With this
change, the future is first set to canceled
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4192
[FLINK-6964] [checkpoint] Fix externalized incremental checkpoints foâ¦
This PR fixes a problem that came up with incremental checkpoints and the
`StandaloneCompletedCheckpointStore`. After
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4130
CC @tillrohrmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4130
[FLINK-6773] [checkpoint] Introduce compression (snappy) for keyed stâ¦
This PR introduce optional snappy compression for the keyed state in full
checkpoints and savepoints. This feature
Github user StefanRRichter commented on the pull request:
https://github.com/apache/flink/commit/9141379f6d2654886d48154b453170cc23b89a87#commitcomment-22558757
In
flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStream.java:
In
flink-runtime/src/main
Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/4019
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4019
Merged in 9141379f6d.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4019
Updated with comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4019#discussion_r121632647
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStream.java
---
@@ -89,4 +99,14 @@ public long skip(long n
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4108
@tillrohrmann thanks for the review and the merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4019#discussion_r121630151
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStream.java
---
@@ -31,11 +31,15 @@
*/
public final
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4073
Very good work. I think the properly addresses the mentioned issues. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4107
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4108
[FLINK-6685] Adjust scopes of SafetyNetCloseableRegistry usage
This PR addresses remaining issues with the `SafetyNetCloseableregistry`:
- reset the registry to `null` after usage
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4090
Overall, I think this is ok as a best effort until we have some eager
registration that helps with the remaining problems in the heap backend.
---
If your project is set up for it, you can
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4058
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4058#discussion_r120291185
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -824,11 +824,14 @@ public
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4011
Thanks for the input @alpinegizmo ! I updated the text accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4026#discussion_r119364516
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
@@ -110,4 +123,20 @@ public
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4026
Overall, very nice work! I just had few minor comments. After they are
addressed, this is good to merge. +1
---
If your project is set up for it, you can reply to this email and have your
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4026
Overall, very nice work! I just had few minor comments. After they are
addressed, this is good to merge. +1
---
If your project is set up for it, you can reply to this email and have your
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4026#discussion_r119359879
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
@@ -110,4 +123,20 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4026#discussion_r119358003
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java
---
@@ -795,13 +782,15 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4026#discussion_r119357811
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java
---
@@ -795,13 +782,15 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4026#discussion_r119348235
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerTest.java
---
@@ -606,6 +665,45 @@ public void
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4026#discussion_r119348073
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerTest.java
---
@@ -606,6 +665,45 @@ public void
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4019
[FLINK-6776] [runtime] Use skip instead of seek for small forward repâ¦
â¦ositioning in DFS streams
Reading checkpoint meta data and finding key-groups in restores sometimes
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4011
CC @rmetzger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4011
[FLINK-6766] Update documentation about async backends and incrementaâ¦
â¦l checkpoints
This PR introduces some documentation about async heap backends and
incremental snapshots
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3937
Overall, LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3937#discussion_r117710523
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
@@ -19,47 +19,65
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3937#discussion_r117710279
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
@@ -19,47 +19,65
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3937#discussion_r117697041
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
@@ -73,13 +91,11 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3937#discussion_r117696993
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
@@ -73,13 +91,11 @@ public
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3939
Thanks for your work @tillrohrmann ! I merged this manually. Please close
this PR and the jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3939
LGMT +1. Tested that this is running with incremental checkpoints, however
the test did not (yet) cover a "split brain" scenario with to JobManagers
running in parallel.
---
If yo
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3925
Thanks for adding this so quickly @tzulitai ! The changes look good to me
+1.
@tillrohrmann maybe you can already include this for your testing.
---
If your project is set up
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3925#discussion_r116977867
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -385,6 +386,19 @@ private void
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3925#discussion_r116977261
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3925#discussion_r116977075
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3912
Yes, there is a tradeoff, and probably the nicest way would be to restore
the internal array size as it was when we serialized the original. However, I
guess that is too much effort
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3912
No concern, just curious if there is any reason for the 1 additional. The
problem also still exists now for a second element. So is it, in general,
unlikely that new elements are added
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3888#discussion_r116446914
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
@@ -235,8 +235,54 @@ else if (contentAddressable
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3884
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/3870
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3870
Thanks @rmetzger ! Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3882
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3886
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3883#discussion_r116249086
--- Diff:
flink-core/src/main/java/org/apache/flink/core/io/VersionedIOReadableWritable.java
---
@@ -18,55 +18,66 @@
package
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3870
Updated and enhanced.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3870#discussion_r116179467
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistry.java
---
@@ -18,91 +18,137 @@
package
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3870#discussion_r116175297
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalKeyedStateHandle.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3870#discussion_r116174101
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalKeyedStateHandle.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3870
@gyfora Yes, this is still a limitation, because the incremental
checkpoints are currently not (yet) externalizable. The missing piece is,
exactly as you said, familiarizing
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3870
CC @shixiaogang @StephanEwen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/3870
[Flink 6537] Fixes and improvements for incremental checkpoints in RocksDB
This PR bundles several fixes and improvements for incremental checkpoints
in RocksDB.
In particular
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3859#discussion_r115721158
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3859#discussion_r115719033
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3859#discussion_r115714053
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3853
LGMT +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3837
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/3837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3839
Merged manually in 38003c2829. Please close this PR and the jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3839
LGTM +1, will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/3837
[FLINK-6471] [checkpoint] Fix RocksDBStateBackendTest
`RocksDBStateBackendTest::testCancelRunningSnapshot` sometimes failes. This
is cause by a problem that I fixed
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3834
I was already familiar with the high level design of this PR from my
discussions with @tzulitai. As the feature freeze is already tomorrow, I had to
focus my review on the functionality
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3522
I agree that we can change the Strings to some proper types later. Besides
what I mentioned before, I just thought that even if a string is the underlying
data type for the moment, having
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3834#discussion_r115139530
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializer.java
---
@@ -161,7 +162,93 @@
public abstract
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3834#discussion_r115139440
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializer.java
---
@@ -161,7 +162,93 @@
public abstract
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3834#discussion_r115139379
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/MigrationStrategy.java
---
@@ -0,0 +1,87 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3834#discussion_r115139339
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3834#discussion_r115139044
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3801
I merged your changes. Please close this PR and the JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3801
I am sorry, but before merging I noticed that some tests (e.g.
`RocksDBStateBackendTest.testCancelRunningSnapshot`) fail sporadically (only on
Travis). I tracked the problem and I think
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3801
@shixiaogang This looks good for me, I will go ahead and merge this. Thanks
for your work!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114580123
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -769,9 +769,10 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114579898
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateHandle.java
---
@@ -0,0
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3813
No objections from my side. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114504710
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114380645
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
901 - 1000 of 1452 matches
Mail list logo
