Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5706
updated PR
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5706#discussion_r175230116
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalWindowAggregate.scala
---
@@ -103,6 +106,19
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5706#discussion_r175181100
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalWindowAggregate.scala
---
@@ -103,6 +106,19
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5706
Updated the PR with the Calcite issue.
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5706#discussion_r175056688
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalWindowAggregate.scala
---
@@ -103,6 +106,19
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5706#discussion_r175055646
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/calcite/rel/rules/AggregateReduceFunctionsRule.java
---
@@ -0,0 +1,590
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/5706
[FLINK-8903] [table] Fix VAR_SAMP, VAR_POP, STDEV_SAMP, STDEV_POP functions
on GROUP BY windows.
## What is the purpose of the change
* Fixes the computation of `VAR_SAMP`, `VAR_POP
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5327
Thanks @hequn8128! We're pretty busy with the Flink 1.5 release right now.
This will be one of the first features to add once 1.5 is out!
Best, Fabian
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5673
Looks good to me.
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5683#discussion_r174426760
--- Diff: flink-libraries/flink-sql-client/conf/sql-client-defaults.yaml ---
@@ -41,12 +41,20 @@ sources: [] # empty list
# Execution properties allow
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5683#discussion_r174427161
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Execution.java
---
@@ -54,6 +56,22 @@ public boolean
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5683#discussion_r174427215
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/PropertyStrings.java
---
@@ -35,6 +35,14 @@ private
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5680
Oh, I see.
Thanks for the explanation @liurenjie1024. In the future, it would be good
to add such pointers to the description of the PR.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5680
Taking a step back. What's the purpose of this change? It adds a class to
the `flink-table` module that is not used anywhere and not part of the public
API of the Table API or SQL.
Why do we
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5639
Thanks for the PR @neoremind.
At the moment, the community is busy working on the 1.5 release which means
that PRs for 1.5 fixes have priority right now. Also a large contribution
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5680
The purpose of unit tests is not only to validate that the new feature
works as expected but also to ensure that the functionality is not broken by
future changes.
So even if the code is copied
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/
Yes, thanks for the update @walterddr! I'm travelling this week, but will
try to have a look next week as well.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5564
Thanks for the update.
I think this is good to merge.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/
Hi @walterddr and @hequn8128, thanks for the PR, review, and discussions.
The current implementation with the `DistinctAggDelegateFunction` and
accumulators takes the path of user-defined
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170291034
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/RowtimeTest.scala
---
@@ -18,48 +18,67 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170230962
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -178,46 +244,128 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170224845
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSource.java
---
@@ -83,10
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170230041
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -178,46 +244,128 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170257053
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170257084
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170273135
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactory.scala
---
@@ -41,10 +41,10 @@ trait
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170290993
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/RowtimeTest.scala
---
@@ -18,48 +18,67 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170256851
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170229569
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -128,6 +165,13 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170230912
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -178,46 +244,128 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170271213
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/Schema.scala
---
@@ -32,11 +32,36 @@ import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170296912
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/table/descriptors/JsonValidator.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170256878
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170230028
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -155,6 +199,28 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170273904
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/CsvTest.scala
---
@@ -47,53 +79,18 @@ class CsvTest extends
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170274382
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170298004
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170232160
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -246,13 +394,93 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170256073
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170272030
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -67,14 +92,188 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170297941
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170229924
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -89,37 +105,58 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170256006
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170256141
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/
Hi @walterddr, thanks for working on this and opening the PR!
I'm quite busy right now, but will try to have a look at the changes next
week.
Thank you, Fabian
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/1990
Hi @gna-phetsarath, I rebased and merged your commit as part of PR #5415.
Could you please close this PR?
Thank you, Fabian
---
Github user fhueske closed the pull request at:
https://github.com/apache/flink/pull/5415
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5415
Will merge this.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5272
Hi @suez1224, thanks for the update.
The PR looks good. Will merge it.
Btw. please do not squash commits when you update a PR. This makes tracking
the changes much harder. It would also
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5274
Looks good to me.
Will merge this.
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5272#discussion_r168343968
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java
---
@@ -95,15
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5489#discussion_r168197563
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5489#discussion_r168196728
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/5489
[FLINK-8652] [QS] Reduce log level in getKvState to DEBUG.
## What is the purpose of the change
Reduce log level in `QueryableStateClient.getKvState()` from `INFO` to
`DEBUG
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5472
We also have to add the function to `FunctionCatalog` to be able to parse
it in the String-based Java Table API.
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5472#discussion_r168183721
--- Diff: docs/dev/table/tableApi.md ---
@@ -2885,6 +2885,17 @@ FIELD.varSamp
+
+
+{% highlight
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5272#discussion_r168176395
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraRowOutputFormat.java
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5272#discussion_r168169778
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraTupleOutputFormat.java
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5272#discussion_r168177375
--- Diff:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5272#discussion_r168177338
--- Diff:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5272#discussion_r168169354
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java
---
@@ -37,11
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5272#discussion_r168175822
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java
---
@@ -95,15
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5415
Thanks for the review @zentol.
I've addressed your feedback, improved the backwards compatibility as
discussed offline, and added multi-path support to additional input formats.
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167903512
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/TypedResult.java
---
@@ -0,0 +1,69
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167889717
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliChangelogResultView.java
---
@@ -0,0 +1,284
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167917093
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/LocalExecutor.java
---
@@ -0,0 +1,445
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167916900
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/LocalExecutor.java
---
@@ -0,0 +1,445
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r16794
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/LocalExecutor.java
---
@@ -0,0 +1,445
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167951055
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/DynamicResult.java
---
@@ -0,0 +1,253
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167953460
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/DynamicResult.java
---
@@ -0,0 +1,253
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167871796
--- Diff: flink-libraries/flink-sql-client/pom.xml ---
@@ -0,0 +1,149 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167939768
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/LocalExecutor.java
---
@@ -0,0 +1,445
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167914210
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
---
@@ -0,0 +1,121
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167922399
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ResultStore.java
---
@@ -0,0 +1,124
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167896355
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/CollectTableSink.java
---
@@ -0,0 +1,116
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167949288
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/DynamicResult.java
---
@@ -0,0 +1,253
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167944240
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ResultStore.java
---
@@ -0,0 +1,124
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167921047
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/PropertyStrings.java
---
@@ -0,0 +1,63
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167871058
--- Diff: flink-libraries/flink-sql-client/pom.xml ---
@@ -0,0 +1,149 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167953650
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/DynamicResult.java
---
@@ -0,0 +1,253
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167921296
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/PropertyStrings.java
---
@@ -0,0 +1,63
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167912319
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/LocalExecutor.java
---
@@ -0,0 +1,445
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167912662
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/LocalExecutor.java
---
@@ -0,0 +1,445
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167952297
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/DynamicResult.java
---
@@ -0,0 +1,253
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167898913
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/LocalExecutor.java
---
@@ -0,0 +1,445
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167936060
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
---
@@ -0,0 +1,121
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167881723
--- Diff: flink-libraries/flink-sql-client/pom.xml ---
@@ -0,0 +1,149 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167921412
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/PropertyStrings.java
---
@@ -0,0 +1,63
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167947410
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/DynamicResult.java
---
@@ -0,0 +1,253
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167938697
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/LocalExecutor.java
---
@@ -0,0 +1,445
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167902843
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/TypedResult.java
---
@@ -0,0 +1,69
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167880842
--- Diff: flink-libraries/flink-sql-client/pom.xml ---
@@ -0,0 +1,149 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167880856
--- Diff: flink-libraries/flink-sql-client/pom.xml ---
@@ -0,0 +1,149 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167869733
--- Diff: flink-libraries/flink-sql-client/bin/sql-client.sh ---
@@ -0,0 +1,83 @@
+#!/usr/bin/env bash
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167892881
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/CollectTableSink.java
---
@@ -0,0 +1,116
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167882975
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlClient.java
---
@@ -0,0 +1,181 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167909635
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/LocalExecutor.java
---
@@ -0,0 +1,445
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167872946
--- Diff: flink-libraries/flink-sql-client/pom.xml ---
@@ -0,0 +1,149 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167870419
--- Diff: flink-libraries/flink-sql-client/conf/sql-client-defaults.yaml ---
@@ -0,0 +1,47
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r167871291
--- Diff: flink-libraries/flink-sql-client/pom.xml ---
@@ -0,0 +1,149 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
201 - 300 of 6115 matches
Mail list logo
