Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699060
--- Diff: flink-streaming-connectors/flink-connector-redis/pom.xml ---
@@ -0,0 +1,86 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51700184
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699767
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699856
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699225
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699774
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51717701
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,143
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51717544
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,143
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-179221148
Please *rebase* on current master instead of merging the current master
into your branch. See "Preparing and submitting your contribution" in
https://flink.
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r51699764
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,107
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-179257332
Please add documentation for the web page. For details, see here:
https://github.com/apache/flink/tree/master/docs
---
If your project is set up for it, you can reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-178836268
> I had some more comments concerning the failure case handling of stop
calls. The first problem is still the handling of exceptions when calling stop
on the Invoka
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1483#issuecomment-177069344
I would like to keep this open, until
[FLINK-2721](https://issues.apache.org/jira/browse/FLINK-2721) is merged. To
make sure, we do not need this -- for this case, we can
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-172792701
That is my plan. Is there already a planed date to release 1.0 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1519#issuecomment-172859784
Ok. Will increase sleep time and merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1519
[FLINK-2831] [Storm Compatibility Tests] Fixed instable test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink flink-2831
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1483#issuecomment-171928147
We do not have any message wrappers on the wire. Data is transfered as
plain Flink `TupleX` types and are translated into Storm format before handing
them over
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1510#issuecomment-171906082
Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1510
[hotfix] moved files to correct folder to match package statements
Eclipse shows error about wrong package statement.
Changing the package statement according to existing folder/package
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1495#issuecomment-171785609
Will fix both and merge. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1483#issuecomment-171790057
Ok. I will try to rework this to the custom operator approach...
About your last statement: We could decide to omit this information in the
Storm compatibility
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1502#issuecomment-171778290
Thanks. Will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1502
[FLINK-2586] Unstable Storm Compatibility Tests
- added BLOCKING flag to FlinkLocalCluster
- added NullTerminatingSpout and SpoutOutputCollectorObserver plus tests
- reworked test
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1498
[Docs] Fixed code example in streaming docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink docFix
Alternatively you can review
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1498#issuecomment-170899461
I just pushed this but got an error:
```
git push origin docFix:master
Password for 'https://mj...@git-wip-us.apache.org':
Counting objects: 5, done
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1493#issuecomment-170362531
Done. Failing Travis is unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1495
[Storm-Compatibility] Forward Storm Kryo registrations to Flink
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink storm-kryo
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1483#issuecomment-170244363
I understand your skeptic, but I don't see it as dangerous as you. If
somebody access this information and does not use it properly, it's his/her own
fault... (same
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1483#issuecomment-170073172
If you implement a Bolt you can retrieve this information from Storm. Thus,
the compatibility layer should provide this information, too.
---
If your project is set up
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1493#issuecomment-170035218
Sure. Will do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1493
[FLINK-3189] Error while parsing job arguments passed by CLI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink flink-3189-cli-info
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-169267260
Just updated this. I did not add an additional YARN test, because I test
`GET` and `DELETE` in the REST test. About your last comment regarding
`Execution`: behavior
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-169344534
Travis failed with weird compilation error. I guess this is an caching
issue. It builds locally and on my personal Travis:
https://travis-ci.org/mjsax/flink/builds
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-168746132
Addressing your comments is WIP... Hope to get it done this week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1483#issuecomment-168748526
Needed for Storm compatibility. This information is made available in Storm
to the user. Not sure why adding it to `RuntimeContext` breaks abstraction
layer (it's only
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1483
[FLINK-1870] Reintroduce indexed reader functionality to streaming
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink flink-1870
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1483#issuecomment-168464116
Travis failed due to know instable test...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1457
Set current class loader to user-class loader and disable class
initialization.
This PR fixes class loading issues with regard to Clojure. It is required
to execute a Clojure example via `bin/flink
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1457#issuecomment-164794316
Personal Travis is green: https://travis-ci.org/mjsax/flink/builds/96973608
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-161982097
Thanks. I will take care of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1398#issuecomment-161412796
Thanks for you patience. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46465735
--- Diff: flink-runtime-web/web-dashboard/package.json ---
@@ -7,27 +7,27 @@
"devDependencies": {
"browserify": "^9.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-161460588
Updated this PR. The test that should be extended is the last open question
if I did not miss anything else.
---
If your project is set up for it, you can reply
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46414197
--- Diff: flink-runtime-web/web-dashboard/package.json ---
@@ -7,27 +7,27 @@
"devDependencies": {
"browserify": "^9.
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46414370
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java
---
@@ -227,4 +235,121 @@ public void testRequestPartitionState
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46307098
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java
---
@@ -227,4 +235,121 @@ public void testRequestPartitionState
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46308707
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -732,6 +758,18 @@ else if (current
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-161045939
Actually all changes after running `gulp` in
`flink-runtime-web/web-dashboard` are committed. There should be no need. I had
similar problems as the WebUI caches stuff
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46290465
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java
---
@@ -227,4 +235,121 @@ public void testRequestPartitionState
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46291411
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java
---
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46292645
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -112,19 +114,24 @@
/** The log object
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46293301
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java
---
@@ -227,6 +229,10 @@ public ExecutionState
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46295358
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertexTest.java
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46294804
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java
---
@@ -0,0 +1,221 @@
+/*
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46284474
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,16 +47,32 @@
/** The schema (ie, ordered
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46284171
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -108,16 +114,13 @@ public BoltWrapper(final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46286009
--- Diff: flink-runtime-web/web-dashboard/package.json ---
@@ -7,27 +7,27 @@
"devDependencies": {
"browserify": "^9.
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46286695
--- Diff: docs/apis/cli.md ---
@@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs.
-s,--scheduled
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46284023
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -89,13 +99,9 @@ public BoltWrapper(final IRichBolt
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1398#issuecomment-160985940
If Travis is green please merge. You can fix the last tiny comments
directly before merging. No need to update this PR.
---
If your project is set up for it, you can
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46287141
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -569,6 +571,69 @@ public int compare(JobStatusMessage o1
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46283446
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46281582
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java
---
@@ -265,12 +264,12 @@ public void testOpen() throws
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46283023
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46300384
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java
---
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46300626
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java
---
@@ -227,4 +235,121 @@ public void testRequestPartitionState
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46205018
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -569,6 +571,69 @@ public int compare(JobStatusMessage o1
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46204977
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -569,6 +571,69 @@ public int compare(JobStatusMessage o1
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-160779157
Same failing test as before. We forgot to address this: "I just
investigated the failing test. The test is new and passed up to know. @uce
changed ExecutionGraph.c
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46205386
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendStopTest.java ---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-160774595
Updated this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46205848
--- Diff: flink-runtime-web/web-dashboard/package.json ---
@@ -7,27 +7,27 @@
"devDependencies": {
"browserify": "^9.
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46205569
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendStopTest.java ---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r46206488
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -402,21 +405,53 @@ public void onComplete(Throwable failure
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46033582
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/exclamation/ExclamationWithBolt.java
---
@@ -72,7 +71,7 @@ public static
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46033705
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/SpoutSplitExample.java
---
@@ -70,7 +70,7 @@ public static void main
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46033750
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/BoltTokenizerWordCount.java
---
@@ -64,7 +63,7 @@ public static
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46033770
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/BoltTokenizerWordCountPojo.java
---
@@ -71,7 +70,7 @@ public
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46033787
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/BoltTokenizerWordCountWithNames.java
---
@@ -75,7 +74,7 @@ public
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46034951
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -193,24 +189,22 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46035118
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java
---
@@ -265,12 +264,12 @@ public void testOpen() throws
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r46035298
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -224,7 +224,7 @@ static synchronized
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45965316
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/print/PrintSampleStream.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45965523
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45970389
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45892009
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkTopologyTest.java
---
@@ -14,50 +14,70 @@
* See the License
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893951
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/SpoutWrapperTest.java
---
@@ -21,7 +21,6 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885626
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/VerifyAndEnrichBolt.java
---
@@ -17,8 +17,6
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885529
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/print/PrintSampleStream.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885615
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/RandomSpout.java
---
@@ -17,9 +17,6 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45889473
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltCollector.java
---
@@ -19,7 +19,6 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890399
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -108,20 +112,19 @@ public BoltWrapper(final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890935
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapperTwoInput.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890996
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891069
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/SpoutCollector.java
---
@@ -18,7 +18,6 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891019
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/SetupOutputFieldsDeclarer.java
---
@@ -17,12 +17,12 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45894573
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -613,29 +611,29 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886387
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/WordCountLocal.java
---
@@ -57,16 +57,13 @@ public static void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45887969
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkOutputFieldsDeclarer.java
---
@@ -20,11 +20,9 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r4594
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License
201 - 300 of 694 matches
Mail list logo
