Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194663296
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RoutedRequest.java
---
@@ -97,11 +98,17 @@ public ReferenceCounted
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194652733
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/ChunkedByteBuf.java
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194660815
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/ReadOnlySlicedNetworkBuffer.java
---
@@ -75,12 +75,12 @@ private
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194652495
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/ChunkedByteBuf.java
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6096#discussion_r193043954
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/ProcessOperator.java
---
@@ -114,12 +114,22 @@ public long
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5798
Thanks for the fix @yanghua and the review @dawidwys.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5786#discussion_r193040157
--- Diff: docs/ops/cli.md ---
@@ -287,6 +287,16 @@ Action "run" compiles and runs a program.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6096#discussion_r193039294
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/ProcessOperator.java
---
@@ -114,12 +114,22 @@ public long
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6096#discussion_r192976292
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/ProcessOperator.java
---
@@ -114,12 +114,22 @@ public long
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5786
I've updated the PR @zorro786 and @zentol.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5786
The section `flip6` is effectively the standalone mode @zorro786. I'll
update the documentation accordingly. The reason why the job manager option is
now shown under the diff
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6101
Could you please close this PR @yanghua. It is now subsumed by #6119.
---
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6119
[FLINK-9458] Ignore SharedSlot in CoLocationConstraint when not using
legacy mode
## What is the purpose of the change
The SharedSlot in CoLocationConstraint is only set when using
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6083
Thanks for opening the PR @medcv. I will try to take a look next week.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6103#discussion_r192558687
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java
---
@@ -103,9 +103,7 @@ public String
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6093#discussion_r191794378
--- Diff: flink-connectors/flink-connector-filesystem/pom.xml ---
@@ -67,13 +67,6 @@ under the License
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6093
I've updated the PR @zentol and removed the version and scope tags from all
`flink-test-utils-junit` dependencies in all modules. The scope and version is
now defined in the depen
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191772629
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java
---
@@ -0,0 +1,511
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5593
Thanks for the reminder @yanghua. I forgot about it and will merge it now.
Thanks again for your contributions. Flink wouldn't be what it is without you!
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6087
Thanks for opening the PR @zhangminglei. I agree with @sihuazhou that it's
not as easy as replacing `x` with `xAsync`. As @sihuazhou pointed out, we have
to react to asynchronous Yarn mes
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6103#discussion_r191753857
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java
---
@@ -103,9 +103,7 @@ public String
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6093
I agree that the scope and version should be set via dependency management.
If we no longer use the category annotations, then we should indeed be able to
remove the general `flink-test-utils
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191414669
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java
---
@@ -0,0 +1,511
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191446484
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java
---
@@ -0,0 +1,470
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191425505
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java
---
@@ -0,0 +1,511
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191426419
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java
---
@@ -0,0 +1,511
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191436243
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java
---
@@ -0,0 +1,246
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191419645
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java
---
@@ -0,0 +1,511
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191445752
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimersSnapshotReaderWriters.java
---
@@ -96,7 +96,7
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191440142
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java
---
@@ -0,0 +1,246
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191422654
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java
---
@@ -0,0 +1,511
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191450664
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java
---
@@ -0,0 +1,470
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191413234
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -301,114 +259,39 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191447784
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java
---
@@ -0,0 +1,470
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191432905
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java
---
@@ -0,0 +1,511
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191435370
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java
---
@@ -0,0 +1,511
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191423366
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java
---
@@ -0,0 +1,511
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191440434
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java
---
@@ -0,0 +1,246
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191446801
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java
---
@@ -0,0 +1,470
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191427611
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java
---
@@ -0,0 +1,511
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191409829
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -96,14 +91,12
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191446041
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java
---
@@ -0,0 +1,470
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191412983
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -199,17 +186,9 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191441546
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java
---
@@ -0,0 +1,246
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191447618
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/InternalTimerHeapTest.java
---
@@ -0,0 +1,470
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191440239
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerHeapInternalTimer.java
---
@@ -0,0 +1,246
Github user tillrohrmann closed the pull request at:
https://github.com/apache/flink/pull/2742
---
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6093
[FLINK-9464] Various pom.xml file clean ups
## What is the purpose of the change
Various `pom.xml` file clean ups where we remove redundant or unnecessary
specifications because they
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4543
Ping @StefanRRichter. Can we get this documentation merged? The community
would definitely appreciate it.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190611660
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
---
@@ -1483,6 +1485,216 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190611581
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerTest.java
---
@@ -1139,6 +1147,61 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190611399
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
---
@@ -1483,6 +1485,216 @@ public void
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6069
Thanks for the review @GJL. I will address your comments and then merge
this PR.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6069#discussion_r190609681
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -274,11 +275,17 @@ public JobSubmissionResult
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6069#discussion_r190609755
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -314,7 +319,8 @@ public JobSubmissionResult
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6061
Thanks for the review @tzulitai. Merging this PR.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6068
Thanks for the review @GJL. I'll address your comments and then merge the
PR.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6068#discussion_r190571258
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
---
@@ -271,6 +279,80 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6068#discussion_r190571226
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
---
@@ -271,6 +279,80 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6068#discussion_r190571191
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
---
@@ -271,6 +279,80 @@ public void
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6069
[FLINK-9416] Make all RestClusterClient calls retriable
## What is the purpose of the change
This commit changes the RestClusterClient calls such that they are all
retriable wrt
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6068
[FLINK-9421] Remove job from RunningJobsRegistry when it reaches a
terminal state
## What is the purpose of the change
This commit lets the Dispatcher remove the RunningJobsRegistry
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6067
[FLINK-9427] Fix registration and request slot race condition in
TaskExecutor
## What is the purpose of the change
This commit fixes a race condition between the TaskExecutor and the
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6061
[FLINK-9425] Make release scripts compliant with ASF release policy
## What is the purpose of the change
Remove the generation of MD5 checksum files and create sha checksum
files
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6057
[FLINK-9406] Use equals in JobMaster#requestPartitionState
## What is the purpose of the change
Use equals instead of referential equality in
JobMaster#requestPartitionState
when
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6056
[FLINK-9408] Let JM try to reconnect to RM
## What is the purpose of the change
This commit changes the behaviour of the JM to always try to reconnect to
the latest known RM address
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189019837
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -947,6 +964,36 @@ private void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189019783
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -1605,9 +1609,16 @@ public void notifyHeartbeatTimeout
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189017088
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -947,6 +964,36 @@ private void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189016636
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java
---
@@ -50,8 +50,11 @@
private final
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189016685
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -1605,9 +1609,16 @@ public void notifyHeartbeatTimeout
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189016603
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -232,8 +239,10 @@ public TaskExecutor
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6035
[FLINK-6160] Add reconnection attempts in case of heartbeat timeouts to
JobMaster and TaskExecutor
## What is the purpose of the change
If a timeout with the RM occurs on on the
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6030
[FLINK-9381] Release blobs after job termination
## What is the purpose of the change
Properly remove job blobs from BlobServer after the job terminates. If the
job reaches a globally
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6017
[FLINK-9365] [rpc] Add handshake procedure to AkkaRpcService when connecting
## What is the purpose of the change
The handshake procedure sends the source version and the target rpc
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5962#discussion_r188004528
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SystemProcessingTimeService.java
---
@@ -197,6 +204,23 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5962#discussion_r188004638
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SystemProcessingTimeServiceTest.java
---
@@ -504,7 +475,101
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6006#discussion_r188000256
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
---
@@ -128,8 +128,8 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6006#discussion_r188000337
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
---
@@ -78,13 +78,13
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6011
[FLINK-9358] Avoid NPE when closing an unestablished ResourceManager
connection
## What is the purpose of the change
A NPE occurred when trying to disconnect an unestablished
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5879
@sihuazhou I'm actually no longer sure whether sending exceptions as causes
along with the RPC messages was the best decision. Exceptions signal an
exceptional situation and should not occ
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5879
Thanks for the contribution @sihuazhou. You're right that the log output of
the `SlotPool` component is a bit too noisy and should not log the full stack
trace in the happy case. What abou
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5986
[FLINK-9331] [mesos] Let MesosResourceManager request new tasks for failed
ones
## What is the purpose of the change
In order to avoid the problem of not fulfilling allocation
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5980
Thanks for the review @StephanEwen. I've addressed your comments and added
some more tests. Once Travis passes, I'll merge it.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5980#discussion_r187307945
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SingleLogicalSlot.java
---
@@ -159,10 +159,51 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5980#discussion_r187306715
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SingleLogicalSlot.java
---
@@ -159,10 +159,51 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5980#discussion_r187305983
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SingleLogicalSlot.java
---
@@ -159,10 +159,51 @@ public
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5931
I looked into the problem @GJL reported and I think it is not caused by
killed TMs which don't have the chance to tell the JMs about the slot
allocations (even though this can theoreti
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5931#discussion_r187106742
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -293,21 +293,16 @@ public void startNewWorker(ResourceProfile
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5931#discussion_r187102871
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -293,21 +293,16 @@ public void startNewWorker(ResourceProfile
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5980
[FLINK-9324] Wait for slot release before completing release future in
SingleLogicalSlot
## What is the purpose of the change
This commit properly waits for the completion of the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181467478
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
---
@@ -196,21 +188,23 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181465966
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -225,6 +247,11 @@ private
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181467950
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -117,6 +138,7 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181466728
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -117,6 +138,7 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181468061
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -49,15 +54,17
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5780
The `ClassLoaderITCase` fails on Travis. There are also checkstyle
violations:
```
10:04:01.988 [ERROR]
src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java:[62,15
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5828
[FLINK-9147] [metrics] Include shaded Prometheus dependencies in jar
## What is the purpose of the change
The Prometheus metrics reporter does not include the shaded Prometheus
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5786#discussion_r179766125
--- Diff: docs/ops/cli.md ---
@@ -300,70 +306,134 @@ Action "info" shows the optimized execution plan of
the pro
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5812
Travis passed. Merging.
---
401 - 500 of 6586 matches
Mail list logo
