Re: [PR] [FLINK-34511] Remove legacy State&Checkpointing&Recovery options [flink]

2024-09-17 Thread via GitHub
flinkbot commented on PR #25346: URL: https://github.com/apache/flink/pull/25346#issuecomment-2357462017 ## CI report: * 20936762eed6bea3c11a90780ca2f0fd0350fa20 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix] Use `Duration` instead of `Time` [flink-benchmarks]

2024-09-17 Thread via GitHub
Zakelly commented on PR #95: URL: https://github.com/apache/flink-benchmarks/pull/95#issuecomment-2357458487 @XComp would you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] [FLINK-34511] Remove legacy State&Checkpointing&Recovery options [flink]

2024-09-17 Thread via GitHub
Zakelly opened a new pull request, #25346: URL: https://github.com/apache/flink/pull/25346 ## What is the purpose of the change Removes the deprecated State&Checkpointing&Recovery related options ## Brief change log Still in progress, several commits: - Remove for

Re: [PR] [FLINK-36112][Connector/Filesystem].Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes [flink]

2024-09-17 Thread via GitHub
xintongsong commented on code in PR #25226: URL: https://github.com/apache/flink/pull/25226#discussion_r1764328992 ## flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableWriter.java: ## @@ -46,13 +46,22 @@ public class HadoopRecovera

Re: [PR] [FLINK-36112][Connector/Filesystem].Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes [flink]

2024-09-17 Thread via GitHub
xintongsong commented on code in PR #25226: URL: https://github.com/apache/flink/pull/25226#discussion_r1764322519 ## flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java: ## @@ -665,6 +666,16 @@ public RecoverableWriter createRecoverableWriter() throws IOException

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-09-17 Thread via GitHub
zoltar9264 commented on PR #24879: URL: https://github.com/apache/flink/pull/24879#issuecomment-2357426433 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-36112][Connector/Filesystem].Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes [flink]

2024-09-17 Thread via GitHub
xintongsong commented on code in PR #25226: URL: https://github.com/apache/flink/pull/25226#discussion_r1764322519 ## flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java: ## @@ -665,6 +666,16 @@ public RecoverableWriter createRecoverableWriter() throws IOException

Re: [PR] [FLINK-36192][autocaler] Autocaler supports adjusting the parallelism of source vertex based on the number of partitions in Kafka or pulsars [flink-kubernetes-operator]

2024-09-17 Thread via GitHub
huyuanfeng2018 commented on PR #879: URL: https://github.com/apache/flink-kubernetes-operator/pull/879#issuecomment-2357419920 > Great discussion @huyuanfeng2018 @1996fanrui! I think this is a good opportunity to unify the logic further and to address a gap with the current key alignment l

Re: [PR] [FLINK-36283][table-planner] Fix an issue where a UDAF incorrectly accessed the implementation of a built-in function with the same name [flink]

2024-09-17 Thread via GitHub
lincoln-lil merged PR #25335: URL: https://github.com/apache/flink/pull/25335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-36249][streaming-java] Remove RestartStrategy-related configuration getters/setters that return/set complex Java objects. [flink]

2024-09-17 Thread via GitHub
zhuzhurk closed pull request #25256: [FLINK-36249][streaming-java] Remove RestartStrategy-related configuration getters/setters that return/set complex Java objects. URL: https://github.com/apache/flink/pull/25256 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-36117] Internal adaptor from State v1 interfaces to v2 [flink]

2024-09-17 Thread via GitHub
Zakelly commented on PR #25345: URL: https://github.com/apache/flink/pull/25345#issuecomment-2357359574 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36117] Internal adaptor from State v1 interfaces to v2 [flink]

2024-09-17 Thread via GitHub
Zakelly commented on PR #25345: URL: https://github.com/apache/flink/pull/25345#issuecomment-2357359791 The CI failure related to https://issues.apache.org/jira/browse/FLINK-36166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [FLINK-33750][config] Remove unused deprecated option [flink]

2024-09-17 Thread via GitHub
Sxnan merged PR #25314: URL: https://github.com/apache/flink/pull/25314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-35822] Introduce DESCRIBE FUNCTION [flink]

2024-09-17 Thread via GitHub
nateab commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1764243768 ## flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java: ## @@ -448,6 +448,15 @@ void testDescribeModel() { sql("d

Re: [PR] [FLINK-35822] Introduce DESCRIBE FUNCTION [flink]

2024-09-17 Thread via GitHub
nateab commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1764243005 ## docs/content/docs/dev/table/sql/describe.md: ## @@ -26,7 +26,7 @@ under the License. # DESCRIBE Statements -DESCRIBE statements are used to describe the schema o

Re: [PR] [FLINK-35822] Introduce DESCRIBE FUNCTION [flink]

2024-09-17 Thread via GitHub
nateab commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1764239002 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlRichDescribeModel.java: ## @@ -41,7 +41,7 @@ public class SqlRichDescribeModel extends S

Re: [PR] [FLINK-35822] Introduce DESCRIBE FUNCTION [flink]

2024-09-17 Thread via GitHub
nateab commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1764237227 ## flink-table/flink-sql-client/src/test/resources/sql/function.q: ## @@ -1,4 +1,4 @@ -# function.q - CREATE/DROP/ALTER FUNCTION +# function.q - CREATE/DROP/ALTER/SHOW/D

Re: [PR] [FLINK-35822] Introduce DESCRIBE FUNCTION [flink]

2024-09-17 Thread via GitHub
nateab commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1764237227 ## flink-table/flink-sql-client/src/test/resources/sql/function.q: ## @@ -1,4 +1,4 @@ -# function.q - CREATE/DROP/ALTER FUNCTION +# function.q - CREATE/DROP/ALTER/SHOW/D

Re: [PR] fix PostgreSQL minimum timestamp precision [flink-connector-jdbc]

2024-09-17 Thread via GitHub
boring-cyborg[bot] commented on PR #142: URL: https://github.com/apache/flink-connector-jdbc/pull/142#issuecomment-2357222740 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

Re: [PR] [FLINK-36240][runtime/metrics] Fix incorrect Ports display in the PrometheusReporter constructor in case of the httpServer creation failure [flink]

2024-09-17 Thread via GitHub
ferenc-csaky commented on PR #25339: URL: https://github.com/apache/flink/pull/25339#issuecomment-2356959667 cc @mateczagany -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-25920] Ignore duplicate EOI in SinkWriter [flink]

2024-09-17 Thread via GitHub
AHeise merged PR #25292: URL: https://github.com/apache/flink/pull/25292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-35822] Introduce DESCRIBE FUNCTION [flink]

2024-09-17 Thread via GitHub
jnh5y commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1764002232 ## flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java: ## @@ -448,6 +448,15 @@ void testDescribeModel() { sql("de

Re: [PR] [FLINK-35822] Introduce DESCRIBE FUNCTION [flink]

2024-09-17 Thread via GitHub
jnh5y commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1764001398 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlRichDescribeTable.java: ## @@ -39,7 +39,7 @@ public class SqlRichDescribeTable extends Sq

Re: [PR] [FLINK-35822] Introduce DESCRIBE FUNCTION [flink]

2024-09-17 Thread via GitHub
jnh5y commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1764000979 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlRichDescribeModel.java: ## @@ -41,7 +41,7 @@ public class SqlRichDescribeModel extends Sq

Re: [PR] [FLINK-35822] Introduce DESCRIBE FUNCTION [flink]

2024-09-17 Thread via GitHub
jnh5y commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1763999075 ## flink-table/flink-sql-client/src/test/resources/sql/function.q: ## @@ -1,4 +1,4 @@ -# function.q - CREATE/DROP/ALTER FUNCTION +# function.q - CREATE/DROP/ALTER/SHOW/DE

Re: [PR] [FLINK-35822] Introduce DESCRIBE FUNCTION [flink]

2024-09-17 Thread via GitHub
jnh5y commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1763997897 ## docs/content/docs/dev/table/sql/describe.md: ## @@ -26,7 +26,7 @@ under the License. # DESCRIBE Statements -DESCRIBE statements are used to describe the schema of

Re: [PR] [FLINK-25920] Ignore duplicate EOI in SinkWriter [flink]

2024-09-17 Thread via GitHub
AHeise commented on PR #25292: URL: https://github.com/apache/flink/pull/25292#issuecomment-2356464478 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-36208][core] use ThreadLocalRandom in AbstractID [flink]

2024-09-17 Thread via GitHub
ferenc-csaky merged PR #25286: URL: https://github.com/apache/flink/pull/25286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-36117] Internal adaptor from State v1 interfaces to v2 [flink]

2024-09-17 Thread via GitHub
flinkbot commented on PR #25345: URL: https://github.com/apache/flink/pull/25345#issuecomment-2356294825 ## CI report: * 6ad92fb2dd01579e35993a8bf9ce70091703c6d1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36117] Internal adaptor from State v1 interfaces to v2 [flink]

2024-09-17 Thread via GitHub
Zakelly opened a new pull request, #25345: URL: https://github.com/apache/flink/pull/25345 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

Re: [PR] [FLINK-36283][table-planner] Fix an issue where a UDAF incorrectly accessed the implementation of a built-in function with the same name [flink]

2024-09-17 Thread via GitHub
dylanhz commented on PR #25335: URL: https://github.com/apache/flink/pull/25335#issuecomment-2356124774 @lincoln-lil I've made some updates about descriptions. Could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [FLINK-36284][format-avro] Support extracting Avro type with new DataType stack [flink]

2024-09-17 Thread via GitHub
davidradl commented on code in PR #25336: URL: https://github.com/apache/flink/pull/25336#discussion_r1762908443 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java: ## @@ -1971,7 +1967,7 @@ private TypeInformation privateGetForClass( }

Re: [PR] [FLINK-36209] Remove redundant operations in the initialization of KafkaSourceEnumState [flink-connector-kafka]

2024-09-17 Thread via GitHub
xiaochen-zhou commented on PR #116: URL: https://github.com/apache/flink-connector-kafka/pull/116#issuecomment-2355956742 Friendly ping, passed ci. If you have time, pls help to review it again. thanks a lot. @AHeise -- This is an automated message from the Apache Git Service. To respo

Re: [PR] [docs] Update Java 17 compatibility docs [flink]

2024-09-17 Thread via GitHub
mbalassi commented on PR #25342: URL: https://github.com/apache/flink/pull/25342#issuecomment-2355827442 > Thanks. Overall, I think the tone is a bit too much like a blog post, and a not enough like a documentation that you use as a reference. Thanks, updated accordingly. -- This i

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-17 Thread via GitHub
boring-cyborg[bot] commented on PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#issuecomment-2355822850 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-17 Thread via GitHub
AHeise merged PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] [docs] Update Java 17 compatibility docs [flink]

2024-09-17 Thread via GitHub
mbalassi commented on code in PR #25342: URL: https://github.com/apache/flink/pull/25342#discussion_r1763256681 ## docs/content/docs/deployment/java_compatibility.md: ## @@ -50,7 +50,8 @@ The following Flink features have not been tested with Java 11: ## Java 17 -Experimen

Re: [PR] [FLINK-25920] Ignore duplicate EOI in SinkWriter [flink]

2024-09-17 Thread via GitHub
AHeise commented on code in PR #25292: URL: https://github.com/apache/flink/pull/25292#discussion_r1763233550 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/stream/AbstractStreamingWriter.java: ## @@ -149,15 +190,20 @@ public void p

Re: [PR] [FLINK-25920] Ignore duplicate EOI in SinkWriter [flink]

2024-09-17 Thread via GitHub
AHeise commented on code in PR #25292: URL: https://github.com/apache/flink/pull/25292#discussion_r1763232011 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/stream/AbstractStreamingWriter.java: ## @@ -123,6 +142,27 @@ public void bu

Re: [PR] [hotfix][docs] Fix typo in Hive connector overview Python example [flink]

2024-09-17 Thread via GitHub
TomiFG commented on code in PR #25343: URL: https://github.com/apache/flink/pull/25343#discussion_r1763163971 ## docs/content/docs/connectors/table/hive/overview.md: ## @@ -237,7 +237,7 @@ hive_catalog = HiveCatalog(catalog_name, default_database, hive_conf_dir) t_env.register

Re: [PR] [FLINK-25920] Ignore duplicate EOI in SinkWriter [flink]

2024-09-17 Thread via GitHub
fapaul commented on code in PR #25292: URL: https://github.com/apache/flink/pull/25292#discussion_r1763062367 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/stream/AbstractStreamingWriter.java: ## @@ -123,6 +142,27 @@ public void bu

Re: [PR] add array aggregate function [flink]

2024-09-17 Thread via GitHub
davidradl commented on code in PR #25275: URL: https://github.com/apache/flink/pull/25275#discussion_r1762912702 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/ArrayAggr.java: ## @@ -0,0 +1,81 @@ +package org.apache.flink.table.utils; + +import org.

Re: [PR] [FLINK-36284][format-avro] Support extracting Avro type with new DataType stack [flink]

2024-09-17 Thread via GitHub
davidradl commented on code in PR #25336: URL: https://github.com/apache/flink/pull/25336#discussion_r1762908443 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java: ## @@ -1971,7 +1967,7 @@ private TypeInformation privateGetForClass( }

Re: [PR] [hotfix][docs] Fix typo in Hive connector overview Python example [flink]

2024-09-17 Thread via GitHub
davidradl commented on code in PR #25343: URL: https://github.com/apache/flink/pull/25343#discussion_r1762819715 ## docs/content/docs/connectors/table/hive/overview.md: ## @@ -237,7 +237,7 @@ hive_catalog = HiveCatalog(catalog_name, default_database, hive_conf_dir) t_env.regis

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-17 Thread via GitHub
AHeise commented on PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#issuecomment-2355026088 Changes all LGTM. I'm running CI and merge when it's green. Thank you very much for this much needed fix! -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-17 Thread via GitHub
AHeise commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1762809895 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java: ## @@ -369,6 +370,38 @@ public void testConsumingTopi

Re: [PR] [FLINK-35401][Connectors/Sqs] Add Sqs Table API connector [flink-connector-aws]

2024-09-17 Thread via GitHub
vahmed-hamdy commented on PR #155: URL: https://github.com/apache/flink-connector-aws/pull/155#issuecomment-2354877068 @hlteoh37 Thanks for the review, Addressed now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [hotfix][doc] Fix the wrong link of materialized table [flink]

2024-09-17 Thread via GitHub
1996fanrui commented on PR #25344: URL: https://github.com/apache/flink/pull/25344#issuecomment-2354875613 Thanks @hackergin for pointing it out. Let me close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [hotfix][doc] Fix the wrong link of materialized table [flink]

2024-09-17 Thread via GitHub
1996fanrui closed pull request #25344: [hotfix][doc] Fix the wrong link of materialized table URL: https://github.com/apache/flink/pull/25344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [hotfix][doc] Fix the wrong link of materialized table [flink]

2024-09-17 Thread via GitHub
hackergin commented on PR #25344: URL: https://github.com/apache/flink/pull/25344#issuecomment-2354868964 @1996fanrui There is similar pr https://github.com/apache/flink/pull/25315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [FLINK-36296][Connectors/DynamoDB] Add support for incremental shard discovery [flink-connector-aws]

2024-09-17 Thread via GitHub
gguptp commented on code in PR #166: URL: https://github.com/apache/flink-connector-aws/pull/166#discussion_r1762623393 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/tracker/SplitTracker.java: ## @@ -250,6 +2

Re: [PR] [FLINK-35401][Connectors/Sqs] Add Sqs Table API connector [flink-connector-aws]

2024-09-17 Thread via GitHub
vahmed-hamdy commented on code in PR #155: URL: https://github.com/apache/flink-connector-aws/pull/155#discussion_r1762620710 ## flink-connector-aws/flink-connector-sqs/src/main/java/org/apache/flink/connector/sqs/table/SqsConnectorOptions.java: ## @@ -0,0 +1,52 @@ +/* + * Lice

Re: [PR] [FLINK-36296][Connectors/DynamoDB] Add support for incremental shard discovery [flink-connector-aws]

2024-09-17 Thread via GitHub
gguptp commented on code in PR #166: URL: https://github.com/apache/flink-connector-aws/pull/166#discussion_r1762621737 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/tracker/SplitTracker.java: ## @@ -250,6 +2

Re: [PR] [FLINK-36296][Connectors/DynamoDB] Add support for incremental shard discovery [flink-connector-aws]

2024-09-17 Thread via GitHub
hlteoh37 commented on code in PR #166: URL: https://github.com/apache/flink-connector-aws/pull/166#discussion_r1762617573 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/tracker/SplitTracker.java: ## @@ -250,6

Re: [PR] [FLINK-36296][Connectors/DynamoDB] Add support for incremental shard discovery [flink-connector-aws]

2024-09-17 Thread via GitHub
hlteoh37 commented on code in PR #166: URL: https://github.com/apache/flink-connector-aws/pull/166#discussion_r1762616322 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/tracker/SplitTracker.java: ## @@ -250,6

Re: [PR] [FLINK-35401][Connectors/Sqs] Add Sqs Table API connector [flink-connector-aws]

2024-09-17 Thread via GitHub
vahmed-hamdy commented on code in PR #155: URL: https://github.com/apache/flink-connector-aws/pull/155#discussion_r1762615947 ## flink-connector-aws/flink-connector-sqs/src/main/java/org/apache/flink/connector/sqs/table/SqsDynamicSink.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed

Re: [PR] [FLINK-36296][Connectors/DynamoDB] Add support for incremental shard discovery [flink-connector-aws]

2024-09-17 Thread via GitHub
gguptp commented on code in PR #166: URL: https://github.com/apache/flink-connector-aws/pull/166#discussion_r1762610714 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/tracker/SplitTracker.java: ## @@ -185,7 +1

Re: [PR] [FLINK-36296][Connectors/DynamoDB] Add support for incremental shard discovery [flink-connector-aws]

2024-09-17 Thread via GitHub
hlteoh37 commented on code in PR #166: URL: https://github.com/apache/flink-connector-aws/pull/166#discussion_r1762608231 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/tracker/SplitTracker.java: ## @@ -185,7

Re: [PR] [FLINK-36296][Connectors/DynamoDB] Add support for incremental shard discovery [flink-connector-aws]

2024-09-17 Thread via GitHub
gguptp commented on code in PR #166: URL: https://github.com/apache/flink-connector-aws/pull/166#discussion_r1762602286 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/DynamoDbStreamsSourceEnumerator.java: ## @

Re: [PR] [FLINK-36296][Connectors/DynamoDB] Add support for incremental shard discovery [flink-connector-aws]

2024-09-17 Thread via GitHub
hlteoh37 commented on code in PR #166: URL: https://github.com/apache/flink-connector-aws/pull/166#discussion_r1762594562 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/DynamoDbStreamsSourceEnumerator.java: ##

Re: [PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff strategies [flink-connector-aws]

2024-09-17 Thread via GitHub
hlteoh37 commented on code in PR #165: URL: https://github.com/apache/flink-connector-aws/pull/165#discussion_r1762592327 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/config/KinesisSourceConfigOptions.java: #

Re: [PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff strategies [flink-connector-aws]

2024-09-17 Thread via GitHub
hlteoh37 commented on code in PR #165: URL: https://github.com/apache/flink-connector-aws/pull/165#discussion_r1762587971 ## flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/config/AWSConfigOptions.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache S

Re: [PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff strategies [flink-connector-aws]

2024-09-17 Thread via GitHub
hlteoh37 commented on code in PR #165: URL: https://github.com/apache/flink-connector-aws/pull/165#discussion_r1762587467 ## flink-connector-aws-base/pom.xml: ## @@ -87,6 +87,12 @@ under the License. test + +software.amazon.awssdk +

Re: [PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff [flink-connector-aws]

2024-09-17 Thread via GitHub
hlteoh37 commented on PR #150: URL: https://github.com/apache/flink-connector-aws/pull/150#issuecomment-2354810490 Closed as replaced by this PR https://github.com/apache/flink-connector-aws/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff [flink-connector-aws]

2024-09-17 Thread via GitHub
hlteoh37 closed pull request #150: [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff URL: https://github.com/apache/flink-connector-aws/pull/150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[PR] [FLINK-36296][Connectors/DynamoDB] Add support for incremental shard discovery [flink-connector-aws]

2024-09-17 Thread via GitHub
gguptp opened a new pull request, #166: URL: https://github.com/apache/flink-connector-aws/pull/166 ## Purpose of the change Adds incremental shard discovery for DDB Streams source. Since full describestream discovery can take a longer time, having incremental shard d

Re: [PR] [hotfix][doc] Fix the wrong link of materialized table [flink]

2024-09-17 Thread via GitHub
flinkbot commented on PR #25344: URL: https://github.com/apache/flink/pull/25344#issuecomment-2354728877 ## CI report: * 8239f405e28f45a0143c4ae3df5b22ec84b5bb50 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][doc] Fix the wrong link of materialized table [flink]

2024-09-17 Thread via GitHub
1996fanrui opened a new pull request, #25344: URL: https://github.com/apache/flink/pull/25344 ## What is the purpose of the change The link has 2 `https://` prefixes. ## Brief change log [hotfix][doc] Fix the wrong link of materialized table -- This is an autom

Re: [PR] [FLINK-36281][runtime] resourceSpec replace SlotSharingGroupUtils.extractResourceSpec(slotSharingGroup) [flink]

2024-09-16 Thread via GitHub
1996fanrui merged PR #25333: URL: https://github.com/apache/flink/pull/25333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#issuecomment-2354460790 @AHeise Thanks for the feedback. I've left some comments and made updates. Please have a look. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#issuecomment-2354458757 > Seems like the deleted arch unit rule was still needed. What was your intent when you deleted it? It was automatically deleted after running `mvn clean verify` lo

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1762233642 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java: ## @@ -369,6 +370,38 @@ public void testConsumin

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1762233642 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java: ## @@ -369,6 +370,38 @@ public void testConsumin

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1762220365 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableITCase.java: ## @@ -188,6 +190,66 @@ public void tes

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1762219777 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java: ## @@ -369,6 +370,38 @@ public void testConsumin

Re: [PR] Use Schema#newBuilder instead of TableSchema#fromResolvedSchema [flink-cdc]

2024-09-16 Thread via GitHub
github-actions[bot] commented on PR #2061: URL: https://github.com/apache/flink-cdc/pull/2061#issuecomment-2354238716 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [FLINK-35600] Add timestamp for low and high watermark [flink-cdc]

2024-09-16 Thread via GitHub
github-actions[bot] commented on PR #3415: URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2354238674 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [hotfix][docs] Fix typo in Hive connector overview Python example [flink]

2024-09-16 Thread via GitHub
flinkbot commented on PR #25343: URL: https://github.com/apache/flink/pull/25343#issuecomment-2353927053 ## CI report: * d723c7beb1d7734f8353c467109e8a4a8251438d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [docs] Update Java 17 compatibility docs [flink]

2024-09-16 Thread via GitHub
rmetzger commented on PR #25342: URL: https://github.com/apache/flink/pull/25342#issuecomment-2353900424 Thanks. Overall, I think the tone is a bit too much like a blog post, and a not enough like a documentation that you use as a reference. -- This is an automated message from the Apache

Re: [PR] [docs] Update Java 17 compatibility docs [flink]

2024-09-16 Thread via GitHub
rmetzger commented on code in PR #25342: URL: https://github.com/apache/flink/pull/25342#discussion_r1761871634 ## docs/content/docs/deployment/java_compatibility.md: ## @@ -50,7 +50,8 @@ The following Flink features have not been tested with Java 11: ## Java 17 -Experimen

Re: [PR] [docs] Update Java 17 compatibility docs [flink]

2024-09-16 Thread via GitHub
rmetzger commented on code in PR #25342: URL: https://github.com/apache/flink/pull/25342#discussion_r1761865441 ## docs/content/docs/deployment/java_compatibility.md: ## @@ -50,7 +50,8 @@ The following Flink features have not been tested with Java 11: ## Java 17 -Experimen

[PR] [hotfix][docs] Fix typo in Hive connector overview Python example [flink]

2024-09-16 Thread via GitHub
TomiFG opened a new pull request, #25343: URL: https://github.com/apache/flink/pull/25343 Fix python example variable `t_env` being mistakenly referenced as `tableEnv`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-14068][core] Removes deprecated org.apache.flink.api.common.time.Time [flink]

2024-09-16 Thread via GitHub
XComp merged PR #25250: URL: https://github.com/apache/flink/pull/25250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-14068][core] Removes deprecated org.apache.flink.api.common.time.Time [flink]

2024-09-16 Thread via GitHub
XComp commented on PR #25250: URL: https://github.com/apache/flink/pull/25250#issuecomment-2353308496 force-pushed a rebase to master after FLINK-36279 was merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FLINK-36279][runtime] Making desired resources being calculated based on all available slots for the job [flink]

2024-09-16 Thread via GitHub
XComp merged PR #25341: URL: https://github.com/apache/flink/pull/25341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761393374 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java: ## @@ -476,11 +578,12 @@ public CatalogFunction getFunction(

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761390457 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -1341,6 +1352,293 @@ private void dropTableInternal(

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761332241 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -1341,6 +1352,293 @@ private void dropTableInternal(

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761329016 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -1341,6 +1352,293 @@ private void dropTableInternal(

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761326715 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -888,7 +899,7 @@ public Set listSchemas() { * NOTE:It is

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761325334 ## flink-python/pyflink/table/catalog.py: ## @@ -15,9 +15,8 @@ # See the License for the specific language governing permissions and # limitations under the License.

[PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff strategoes [flink-connector-aws]

2024-09-16 Thread via GitHub
karubian opened a new pull request, #165: URL: https://github.com/apache/flink-connector-aws/pull/165 ## Purpose of the change Port over Kinesis Client configurations for retry and backoff ## Verifying this change - *Added unit tests* ## Significant changes *(Pl

Re: [PR] [FLINK-36278] Reduce log size by avoiding container logs by default [flink-connector-kafka]

2024-09-16 Thread via GitHub
fapaul commented on PR #119: URL: https://github.com/apache/flink-connector-kafka/pull/119#issuecomment-2353092492 Looking at the current test failures of this PR the log size (https://github.com/apache/flink-connector-kafka/actions/runs/10881066111/job/30189211552?pr=119) is still 50MB+.

Re: [PR] [FLINK-31980] Implement support for EFO in Kinesis consumer [flink-connector-aws]

2024-09-16 Thread via GitHub
dzikosc commented on code in PR #76: URL: https://github.com/apache/flink-connector-aws/pull/76#discussion_r1761179807 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/fanout/StreamConsumerRegistrar.java:

Re: [PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff [flink-connector-aws]

2024-09-16 Thread via GitHub
karubian commented on code in PR #150: URL: https://github.com/apache/flink-connector-aws/pull/150#discussion_r1758962947 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSource.java: ## @@ -226,4 +

Re: [PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff [flink-connector-aws]

2024-09-16 Thread via GitHub
karubian commented on code in PR #150: URL: https://github.com/apache/flink-connector-aws/pull/150#discussion_r1761182118 ## flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/config/AWSConfigOptions.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache S

Re: [PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff [flink-connector-aws]

2024-09-16 Thread via GitHub
karubian commented on code in PR #150: URL: https://github.com/apache/flink-connector-aws/pull/150#discussion_r1761179260 ## flink-connector-aws-base/pom.xml: ## @@ -87,6 +87,12 @@ under the License. test + +software.amazon.awssdk +

Re: [PR] [FLINK-31980] Implement support for EFO in Kinesis consumer [flink-connector-aws]

2024-09-16 Thread via GitHub
dzikosc commented on code in PR #76: URL: https://github.com/apache/flink-connector-aws/pull/76#discussion_r1760919190 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSource.java: ## @@ -178,6 +185

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-09-16 Thread via GitHub
zoltar9264 commented on PR #24879: URL: https://github.com/apache/flink/pull/24879#issuecomment-2352836545 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [docs] Update Java 17 compatibility docs [flink]

2024-09-16 Thread via GitHub
flinkbot commented on PR #25342: URL: https://github.com/apache/flink/pull/25342#issuecomment-2352764203 ## CI report: * ba05a7d2ae38b1c1e4219978cbaae3ae6737b252 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

<    2   3   4   5   6   7   8   9   10   11   >