Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5007
merging.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5010
[FLINK-8056][dist] Use 'web.port' instead of 'jobmanager.web.port'
## What is the purpose of the change
This PR modfiies the default `flink-conf.yaml` to no longer
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4939
yes there could be a sleeper failure in hadoop, but there's nothing we can
do to fix that besides relocation jackson in either hadoop or aws, which is
probably not possible.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5007#discussion_r150755017
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -52,8 +52,10 @@
/**
* A simple and
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4939
So we pin the version, update aws at some point (and forget to check the
dependency), and now we got a sleeper failure because there may be a single
code-path that fails due to a version mismatch
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5006
[hotfix][docs][QS] MInor cleanup of QS documentation
## What is the purpose of the change
This PR fixes a few smaller issues in the Queryable State
documentation/javadocs.
You can merge
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4999
+1
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5000
+1
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5002
+1
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4939
At the same time, pinning a dependency version can cause problems if a
dependency is upgraded and requires another jackson version.
There isn't a perfect solution. The current approach
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4605
I had to modify the PR more than i initially expected.
I removed the option to disable the new behavior again; after thinking
about it more i came to the conclusion that silently losing data
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4945
@greghogan That's a great point.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4981
i don't think we need that. We do that for akka to reduce the impact of
shading akka-remote on the dependency footprint of flink-runtime incurred by
creating the dependency reduce pom.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4981#discussion_r149702871
--- Diff: flink-formats/flink-avro/pom.xml ---
@@ -185,17 +185,6 @@ under the License
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/4970
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4777#discussion_r149655646
--- Diff: pom.xml ---
@@ -289,6 +289,48 @@ under the License.
1.8.2
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4981
7419
## What is the purpose of the change
This PR relocates avros jackson dependency in flink-dist.
## Brief change log
* remove ineffective jackson shading configuration
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4605
I've rebased this locally (along with some cleanup) and will merge it later
today.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4961#discussion_r149635214
--- Diff: flink-filesystems/flink-s3-fs-presto/README.md ---
@@ -0,0 +1,28 @@
+This project is a wrapper around the S3 file system from the Presto
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4961#discussion_r149635319
--- Diff: flink-filesystems/flink-s3-fs-hadoop/README.md ---
@@ -0,0 +1,27 @@
+This project is a wrapper around Hadoop's s3a file system. By pull
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4972
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4945
Ultimately it shouldn't make a difference, but comparing against 1.0.X
would require less maintenance as we no longer have to update it with every
release.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4975
missing a few classes from flink-kafka-base
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4971
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4965
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4971
scratch that, i have it in this one, here:
```
org.apache.flink
flink-shaded-guava
- 18.0-1.0
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4971
@greghogan I also had this in another PR but not this one.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4975
[FLINK-7991][examples][kafka] Cleanup kafka10 example jar
## What is the purpose of the change
This PR cleans up the kafka example shading configuration, removing plenty
of unnecessary
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4972
@aljoscha fixed
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4973
[FLINK-8011][dist] Set flink-python to provided
## What is the purpose of the change
Minor clean-up in the flink-dist pom. flink-python is now set to provided,
similar to other libraries
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4972
[FLINK-8009][build][runtime] Remove transitive dependency promotion
## What is the purpose of the change
This PR replaces the dependency promotion from flink-runtime. The promotion
appears
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4777#discussion_r149409270
--- Diff: pom.xml ---
@@ -289,6 +289,48 @@ under the License.
1.8.2
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4958
you can also remove the comment in the DispatcherRestEndpoint that says to
register the stat file handler last.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4971
[FLINK-8010][build] Bump remaining flink-shaded versions
## What is the purpose of the change
This PR bumps the remaining flink-shaded dependencies to 2.0.
## Brief change log
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4958#discussion_r149382049
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java
---
@@ -268,4 +287,69 @@ private static void registerHandler
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4970
[FLINK-8007][metrics] Move TestMeter into test scope
This PR moves the TestMeter class into the test scope where it belongs.
You can merge this pull request into a Git repository by running
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4961#discussion_r149344188
--- Diff: flink-filesystems/flink-s3-fs-presto/pom.xml ---
@@ -284,6 +322,7 @@ under the License
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4961#discussion_r149344386
--- Diff: flink-filesystems/flink-s3-fs-hadoop/pom.xml ---
@@ -33,6 +33,7 @@ under the License.
jar
+
--- End diff
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4961#discussion_r149344106
--- Diff: flink-filesystems/flink-s3-fs-hadoop/pom.xml ---
@@ -277,6 +336,7 @@ under the License
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4965
[FLINK-8004][metrics][docs] Fix usage examples
## What is the purpose of the change
This PR fixes several issues in the metric usage examples in the
documentation.
## Brief change
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4957
+1
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4958#discussion_r149325305
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java
---
@@ -268,4 +287,69 @@ private static void registerHandler
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4953
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4954
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4951
Looks good, I think we can merge it once #4939 has been merged.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4953
yes
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4921#discussion_r149071909
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -210,15 +212,44 @@ public static ParameterTool
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4952#discussion_r149070673
--- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
@@ -63,9 +63,9 @@ This change added tests and can be verified as follows:
- The serializers: (yes / no
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4952
I've merged the PR as is, please open a follow-up for the suggestions.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4944
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4947
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4951#discussion_r149069349
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -186,6 +186,8 @@ public void addShipFiles(List shipFiles
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4954
[FLINK-7994][mesos] Remove effectively unused curator dependency
## What is the purpose of the change
This PR removes the effectively unused flink-shaded-curator dependency from
flink-mesos
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4953
[FLINK-7993][kafka] Sync curator shading patterns
## What is the purpose of the change
This PR syncs the curator shading patterns in flink-runtime and
flink-connector-kafka-0.8
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4952
+1
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4524
@zjureel The PR has been merged, could you close the PR?
---
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/4835
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4927
@StephanEwen Implemented both suggestions.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4932
true, we can use default methods for this, I was concerned about backwards
compatibilty but forgot about that option.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4927
@StephanEwen I've added another commit that modifies flink-shaded-hadoop to
include its own zookeeper dependency. So far we were re-using the runtime zk
dependency.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4921#discussion_r148286896
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameters.java
---
@@ -83,82 +82,100 @@ public void add(Option option) throws
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4927
I've added the `ZookeeperAccess` class as suggested.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4932
[FLINK-7958][metrics] Allow reporters to define default delimiter
## What is the purpose of the change
This PR allows reporters to define their default delimiter. Previously we
always
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4927
@StephanEwen
Regarding1) Curator 2.12 does not shade all of guava. This is the curation
relocation definition for guava:
```
com.google
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4930
Please rebase the PR and update all jackson imports to
`org.apache.flink.shaded.jackson2.org.fasterxml.jackson...`
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4921#discussion_r148240608
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -560,9 +591,13 @@ protected Object clone() throws
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4921#discussion_r148241001
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -454,124 +469,196 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4921#discussion_r148240611
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -210,15 +212,44 @@ public static ParameterTool
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4921
Travis failure:
```
Tests run: 17, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 0.029 sec
<<< FAILURE! - in org.apache.flink.api.java.utils.RequiredParam
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4835
@aljoscha do you want to include this in your avro PR?
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4927
[FLINK-7778] [build] Shade ZooKeeper dependency
## What is the purpose of the change
This PR shades and relocates curator&zookeeper into flink-runtime to avoid
dependency confl
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4923
It's more of an assumption tbh, i haven't tried it out. I've looked through
the fenzo source code to search for APIs that expose jackson but couldn't find
any. They annotate a
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4923
[FLINK-7418][build] Integrate flink-shaded-jackson2
## What is the purpose of the change
This PR replaces all usages of com.fasterxml.jackson with
flink-shaded-jackson.
One change
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4922
[hotfix][metrics] Cleanup ScopeFormats
## What is the purpose of the change
This PR cleans up a few things related to `ScopeFormats`.
## Brief change log
* remove unused
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4712
@yew1eb yes i think so. Let's get back to this once we forked of the 1.4
branch.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4901
@kl0u I've addressed your comments.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4901#discussion_r147670970
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/SubtaskMetricsHandler.java
---
@@ -0,0 +1,70
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4901#discussion_r147670055
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/DoubleAccumulator.java
---
@@ -0,0 +1,260
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4901#discussion_r147669836
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractMetricsHandler.java
---
@@ -39,12 +39,15 @@
* If
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4901#discussion_r147669457
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java
---
@@ -0,0 +1,223
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4901#discussion_r147668677
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java
---
@@ -0,0 +1,223
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4872#discussion_r147657172
--- Diff:
flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingCluster.scala
---
@@ -42,7 +42,8 @@ import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4872#discussion_r147654224
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/UnregisteredTaskMetricsGroup.java
---
@@ -28,15 +28,15 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4872#discussion_r147656394
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -163,12 +156,14 @@ public JobLeaderService
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4872#discussion_r147657678
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java
---
@@ -80,7 +80,6 @@
import akka.actor.ActorRef
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4872#discussion_r147666537
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java
---
@@ -166,4 +169,12 @@ void notifySlotAvailable
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4872#discussion_r147665524
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/runtime/clusterframework/MesosJobManager.scala
---
@@ -31,7 +31,8 @@ import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4872#discussion_r147655034
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherTest.java
---
@@ -76,25 +74,22 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4908#discussion_r147639583
--- Diff:
flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTaskScopeTest.java
---
@@ -72,10 +72,30
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4777
How does this interact with the shade plugin, i.e. what happens if a
relocated transitive dependency has a different version than another direct
dependency?
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4918#discussion_r147594462
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
---
@@ -446,19 +449,67 @@ public void onComplete(Throwable
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4918#discussion_r147594496
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
---
@@ -446,19 +449,67 @@ public void onComplete(Throwable
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4918#discussion_r147594412
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
---
@@ -446,19 +449,67 @@ public void onComplete(Throwable
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4908#discussion_r147379229
--- Diff:
flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTaskScopeTest.java
---
@@ -72,10 +72,30
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4908#discussion_r147379207
--- Diff:
flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTaskScopeTest.java
---
@@ -72,10 +72,30
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4908
[FLINK-7933][metrics] Improve PrometheusReporter tests
## What is the purpose of the change
This PR resolves the test instabilities of the prometheus reporter.
## Brief change log
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4872#discussion_r147151661
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/entrypoint/MesosSessionClusterEntrypoint.java
---
@@ -113,7 +113,7 @@ protected void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4872#discussion_r147149524
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
---
@@ -239,7 +239,15 @@ public void shutdown
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4872
Does this PR actually depend on the MetricFetcher changes?
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4827
+1
---
1701 - 1800 of 5315 matches
Mail list logo
