1996fanrui merged PR #22985:
URL: https://github.com/apache/flink/pull/22985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
echauchot commented on PR #22985:
URL: https://github.com/apache/flink/pull/22985#issuecomment-1776774654
> Thanks @echauchot for the hard work!
>
> LGTM, I will merge it if no any comments within 2 days.
Thanks for your review !
--
This is an automated message from the
1996fanrui commented on PR #22985:
URL: https://github.com/apache/flink/pull/22985#issuecomment-1776391285
Would you mind updating the commit message to `[FLINK-21883][scheduler]
Implement cooldown period for adaptive scheduler`?
The current commit message missed the `module name`
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1368585344
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##
@@ -1162,16 +1167,24 @@ private ExecutionGraph
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1368585344
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##
@@ -1162,16 +1167,24 @@ private ExecutionGraph
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1368585344
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##
@@ -1162,16 +1167,24 @@ private ExecutionGraph
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1368578637
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -67,13 +77,33 @@ class Executing extends StateWithExecutionGraph
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1367736920
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##
@@ -1162,16 +1167,24 @@ private ExecutionGraph
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1367736920
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##
@@ -1162,16 +1167,24 @@ private ExecutionGraph
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1366420311
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -67,13 +77,33 @@ class Executing extends StateWithExecutionGraph
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1366403842
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -252,28 +259,94 @@ public void
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1366402713
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##
@@ -1162,16 +1167,24 @@ private ExecutionGraph
echauchot commented on PR #22985:
URL: https://github.com/apache/flink/pull/22985#issuecomment-1766631855
> Thanks @echauchot for the update!
>
> The CI failure isn't caused by this PR, please rebase the master branch.
>
> Also, would you mind squash all commits to one? They
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1362211935
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##
@@ -1162,16 +1167,24 @@ private ExecutionGraph
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1362263357
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -252,28 +259,94 @@ public void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1362283946
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -252,28 +259,94 @@ public void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1362263357
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -252,28 +259,94 @@ public void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1362263357
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -252,28 +259,94 @@ public void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1362257848
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -252,28 +259,94 @@ public void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1362230288
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -252,28 +259,94 @@ public void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1362218036
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -252,28 +259,94 @@ public void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1362211935
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##
@@ -1162,16 +1167,24 @@ private ExecutionGraph
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1362127991
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##
@@ -1162,16 +1167,24 @@ private ExecutionGraph
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1362127991
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##
@@ -1162,16 +1167,24 @@ private ExecutionGraph
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1361760710
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##
@@ -1162,16 +1167,24 @@ private ExecutionGraph
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1361748211
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -124,23 +158,70 @@ private void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360731620
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/scalingpolicy/EnforceParallelismChangeRescalingControllerTest.java:
##
@@ -0,0 +1,64 @@
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360730445
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/scalingpolicy/EnforceParallelismChangeRescalingControllerTest.java:
##
@@ -0,0 +1,64 @@
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360728058
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -594,8 +683,12 @@ public FailureResult
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360721374
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -594,8 +683,12 @@ public FailureResult
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360479261
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -124,23 +158,70 @@ private void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360474345
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -124,23 +158,70 @@ private void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360409626
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/scalingpolicy/EnforceParallelismChangeRescalingController.java:
##
@@ -0,0 +1,41 @@
+/*
+
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360405854
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -67,13 +77,36 @@ class Executing extends StateWithExecutionGraph
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360383883
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -67,13 +77,36 @@ class Executing extends StateWithExecutionGraph
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360359084
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/scalingpolicy/EnforceParallelismChangeRescalingController.java:
##
@@ -0,0 +1,41 @@
+/*
+
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360353250
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360310094
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -67,13 +77,33 @@ class Executing extends StateWithExecutionGraph
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360222871
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/scalingpolicy/EnforceParallelismChangeRescalingControllerTest.java:
##
@@ -0,0 +1,64 @@
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360218985
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/scalingpolicy/EnforceParallelismChangeRescalingController.java:
##
@@ -0,0 +1,41 @@
+/*
+
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360215766
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360214322
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -67,13 +77,33 @@ class Executing extends StateWithExecutionGraph
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360214322
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -67,13 +77,33 @@ class Executing extends StateWithExecutionGraph
echauchot commented on PR #22985:
URL: https://github.com/apache/flink/pull/22985#issuecomment-1761625553
@1996fanrui thanks for your review, I'm done addressing all your comments. I
hope it's the last round of review.
--
This is an automated message from the Apache Git Service.
To
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1358346133
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -252,28 +257,96 @@ public void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1358336728
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -570,8 +659,9 @@ public void setHowToHandleFailure(Function
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1358281363
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -124,23 +157,74 @@ private void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1358306727
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -124,23 +157,74 @@ private void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1358317366
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -67,13 +77,36 @@ class Executing extends StateWithExecutionGraph
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1358300145
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -124,23 +157,74 @@ private void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1354914923
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/scalingpolicy/EnforceParallelismChangeRescalingController.java:
##
@@ -0,0 +1,41 @@
+/*
+
1996fanrui commented on PR #22985:
URL: https://github.com/apache/flink/pull/22985#issuecomment-1761053544
> @1996fanrui thanks for your comments, please ping me when you're done with
all the comments so that I address them all at once and push the code.
It's done for now, I will
echauchot commented on PR #22985:
URL: https://github.com/apache/flink/pull/22985#issuecomment-1761013944
@1996fanrui thanks for your comments, please ping me when you're done with
all the comments so that I address them all at once and push the code.
--
This is an automated message from
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1357685699
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##
@@ -570,8 +659,9 @@ public void setHowToHandleFailure(Function
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1356736651
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/scalingpolicy/EnforceParallelismChangeRescalingController.java:
##
@@ -0,0 +1,41 @@
+/*
+
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1356642732
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1356590600
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1321300535
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1356383787
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -124,23 +157,74 @@ private void
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1354914923
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/scalingpolicy/EnforceParallelismChangeRescalingController.java:
##
@@ -0,0 +1,41 @@
+/*
+
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1354521971
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -67,13 +77,36 @@ class Executing extends StateWithExecutionGraph
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1354440991
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1354440991
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1354439095
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1354399571
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1354397865
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1349638795
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1349637114
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -488,6 +488,23 @@ public enum SchedulerType {
1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1349504826
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##
@@ -67,13 +77,33 @@ class Executing extends StateWithExecutionGraph
echauchot commented on PR #22985:
URL: https://github.com/apache/flink/pull/22985#issuecomment-1743082203
> > > > ## CI report:
> > > >
> > > > *
[6fa4048](https://github.com/apache/flink/commit/6fa40484d3725b7b4e4b095171a20f57b72ce7d5)
Azure:
70 matches
Mail list logo