[jira] [Comment Edited] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`

2016-10-18 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587764#comment-15587764 ] Gabor Gevay edited comment on FLINK-3999 at 10/19/16 5:47 AM: -- Won't Fix; See

[jira] [Resolved] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`

2016-10-18 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay resolved FLINK-3999. Resolution: Won't Fix See comment here:

[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...

2016-10-18 Thread ggevay
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/2642 OK, I see your point now @StephanEwen. @nssalian, I'm sorry for opening the jira; I didn't think it through from this perspective at the time. --- If your project is set up for it, you can reply

[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587758#comment-15587758 ] ASF GitHub Bot commented on FLINK-3999: --- Github user ggevay commented on the issue:

[jira] [Commented] (FLINK-4844) Partitionable Raw Keyed/Operator State

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585088#comment-15585088 ] ASF GitHub Bot commented on FLINK-4844: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #2648: [FLINK-4844] Partitionable Raw Keyed/Operator Stat...

2016-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2648#discussion_r83822468 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/OneInputStreamOperatorTestHarness.java --- @@ -199,30 +228,56 @@ public

[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585220#comment-15585220 ] ASF GitHub Bot commented on FLINK-3999: --- Github user ggevay commented on the issue:

[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...

2016-10-18 Thread ggevay
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/2642 Could you please explain why are the first and last commit (65b3ff78f100ed1b13ec2fcc727f4869823b5918 and ba4f429043f3985db5ab37a3902a6fee15a7440e) necessary? Are they related to FLINK-3999? --- If

[jira] [Commented] (FLINK-4844) Partitionable Raw Keyed/Operator State

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584899#comment-15584899 ] ASF GitHub Bot commented on FLINK-4844: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-4283) ExecutionGraphRestartTest fails

2016-10-18 Thread Alexander Shoshin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585134#comment-15585134 ] Alexander Shoshin commented on FLINK-4283: -- It will look like this:

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584853#comment-15584853 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584852#comment-15584852 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584855#comment-15584855 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584851#comment-15584851 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83801277 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,50 @@ public void

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584854#comment-15584854 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83803660 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,50 @@ public void

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83800396 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1183,47 +1220,48 @@ public String toString() { */

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83800757 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[jira] [Commented] (FLINK-4844) Partitionable Raw Keyed/Operator State

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584893#comment-15584893 ] ASF GitHub Bot commented on FLINK-4844: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #2648: [FLINK-4844] Partitionable Raw Keyed/Operator Stat...

2016-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2648#discussion_r83807199 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java --- @@ -804,199 +792,15 @@ public boolean

[jira] [Commented] (FLINK-1807) Stochastic gradient descent optimizer for ML library

2016-10-18 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585097#comment-15585097 ] Gábor Hermann commented on FLINK-1807: -- Hi all, I have a workaround in mind for a "real" SGD. The

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585118#comment-15585118 ] ASF GitHub Bot commented on FLINK-4715: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585117#comment-15585117 ] ASF GitHub Bot commented on FLINK-4715: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585120#comment-15585120 ] ASF GitHub Bot commented on FLINK-4715: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83824750 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83824704 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585115#comment-15585115 ] ASF GitHub Bot commented on FLINK-4715: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83824787 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83824898 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,50 @@ public void testOnPartitionStateUpdate()

[jira] [Updated] (FLINK-4850) FlinkML - SVM predict Operation for Vector and not LaveledVector

2016-10-18 Thread Thomas FOURNIER (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas FOURNIER updated FLINK-4850: --- Description: It seems that SVM has predict operation for Vector and not LabeledVector. It

[jira] [Created] (FLINK-4850) FlinkML - SVM predict Operation for Vector and not LaveledVector

2016-10-18 Thread Thomas FOURNIER (JIRA)
Thomas FOURNIER created FLINK-4850: -- Summary: FlinkML - SVM predict Operation for Vector and not LaveledVector Key: FLINK-4850 URL: https://issues.apache.org/jira/browse/FLINK-4850 Project: Flink

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83800845 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83800506 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83800264 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -289,6 +294,10 @@ public Task(

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584856#comment-15584856 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584857#comment-15584857 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #2648: [FLINK-4844] Partitionable Raw Keyed/Operator Stat...

2016-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2648#discussion_r83807634 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorStateHandle.java --- @@ -38,8 +38,8 @@ private final

[jira] [Commented] (FLINK-4723) Unify behaviour of committed offsets to Kafka / ZK for Kafka 0.8 and 0.9 consumer

2016-10-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585045#comment-15585045 ] Robert Metzger commented on FLINK-4723: --- I would not merge it because of the offset issues you've

[GitHub] flink pull request #2648: [FLINK-4844] Partitionable Raw Keyed/Operator Stat...

2016-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2648#discussion_r83819873 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorStateHandles.java --- @@ -0,0 +1,105 @@ +/* + *

[jira] [Commented] (FLINK-4844) Partitionable Raw Keyed/Operator State

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585058#comment-15585058 ] ASF GitHub Bot commented on FLINK-4844: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-4825) Implement a RexExecutor that uses Flink's code generation

2016-10-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584809#comment-15584809 ] Jark Wu commented on FLINK-4825: Hi [~twalthr] , I also found the result of {{CAST(TRUE AS VARCHAR)}} will

[jira] [Closed] (FLINK-4792) Update documentation - FlinkML/QuickStart Guide

2016-10-18 Thread Thomas FOURNIER (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas FOURNIER closed FLINK-4792. -- Resolution: Fixed > Update documentation - FlinkML/QuickStart Guide >

[GitHub] flink issue #2652: [FLINK-4715] Fail TaskManager with fatal error if task ca...

2016-10-18 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2652 Renamed the `TaskOptions` class to `TaskManagerOptions` so that we can easily migrate the task manager options as a follow up. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585344#comment-15585344 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-1807) Stochastic gradient descent optimizer for ML library

2016-10-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585342#comment-15585342 ] Till Rohrmann commented on FLINK-1807: -- This could work as a workaround but I think it's not the

[GitHub] flink issue #2652: [FLINK-4715] Fail TaskManager with fatal error if task ca...

2016-10-18 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2652 We have the `TaskManagerProcessReapingTest` which tests that the TaskManager process properly exits when the TaskManager actor dies. In addition, there is `TaskManagerTest#testTerminationOnFatalError`,

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585380#comment-15585380 ] ASF GitHub Bot commented on FLINK-4715: --- Github user uce commented on the issue:

[GitHub] flink issue #2510: FLINK-3322 Allow drivers and iterators to reuse the memor...

2016-10-18 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2510 @ggevay Do you have some time to check the last commit in this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Created] (FLINK-4851) Add FatalErrorHandler and MetricRegistry to ResourceManager

2016-10-18 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4851: Summary: Add FatalErrorHandler and MetricRegistry to ResourceManager Key: FLINK-4851 URL: https://issues.apache.org/jira/browse/FLINK-4851 Project: Flink

[GitHub] flink issue #2652: [FLINK-4715] Fail TaskManager with fatal error if task ca...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2652 Should we have one class `TaskManagerOptions`? To not spread the config over too many classes. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #2649: [FLINK-4829] snapshot accumulators on a best-effor...

2016-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2649 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2652: [FLINK-4715] Fail TaskManager with fatal error if task ca...

2016-10-18 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2652 Thanks for the valuable feedback. Some of the errors were a little sloppy on my side. Sorry for that. I addressed all your comments. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585275#comment-15585275 ] ASF GitHub Bot commented on FLINK-4715: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585309#comment-15585309 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83839720 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1299,124 @@ public void run() {

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585332#comment-15585332 ] ASF GitHub Bot commented on FLINK-4715: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585352#comment-15585352 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2652: [FLINK-4715] Fail TaskManager with fatal error if task ca...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2652 What do you think about a followup test, where we ensure that a fatal error notification on the TaskManager actually results in a process kill? --- If your project is set up for it, you can

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83842005 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,128 @@ public void

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585320#comment-15585320 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83840545 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,128 @@ public void

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83841451 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1299,124 @@ public void run() {

[jira] [Assigned] (FLINK-2118) Table API fails on composite filter conditions

2016-10-18 Thread Alexander Shoshin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shoshin reassigned FLINK-2118: Assignee: Alexander Shoshin > Table API fails on composite filter conditions >

[jira] [Commented] (FLINK-4829) Accumulators are not thread safe

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585520#comment-15585520 ] ASF GitHub Bot commented on FLINK-4829: --- Github user asfgit closed the pull request at:

[jira] [Updated] (FLINK-4850) FlinkML - SVM predict Operation for Vector and not LaveledVector

2016-10-18 Thread Thomas FOURNIER (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas FOURNIER updated FLINK-4850: --- Description: It seems that SVM has predict operation for Vector and not LabeledVector. It

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585283#comment-15585283 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83840872 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,128 @@ public void testOnPartitionStateUpdate()

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585325#comment-15585325 ] ASF GitHub Bot commented on FLINK-4715: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585346#comment-15585346 ] ASF GitHub Bot commented on FLINK-4715: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585403#comment-15585403 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2652: [FLINK-4715] Fail TaskManager with fatal error if task ca...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2652 Yeah, this sort of covers it. Just afraid of such a situation here: https://twitter.com/thepracticaldev/status/687672086152753152 --- If your project is set up for it, you can reply to this

[GitHub] flink issue #2652: [FLINK-4715] Fail TaskManager with fatal error if task ca...

2016-10-18 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2652 Haha, that picture convinced me to actually add the test :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585425#comment-15585425 ] ASF GitHub Bot commented on FLINK-4715: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-4829) Accumulators are not thread safe

2016-10-18 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585534#comment-15585534 ] Maximilian Michels commented on FLINK-4829: --- To mitigate the problem, we have best-effort

[jira] [Commented] (FLINK-4851) Add FatalErrorHandler and MetricRegistry to ResourceManager

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585538#comment-15585538 ] ASF GitHub Bot commented on FLINK-4851: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink issue #2652: [FLINK-4715] Fail TaskManager with fatal error if task ca...

2016-10-18 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2652 Travis gives the green light except for a Kafka failure. @StephanEwen @rmetzger Do you know whether this is a known issue? Or might it be a regression from this change?

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585948#comment-15585948 ] ASF GitHub Bot commented on FLINK-4715: --- Github user uce commented on the issue:

[GitHub] flink pull request #2654: [hotfix] [kafka] Fix RackAwareMode instantiation i...

2016-10-18 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/2654 [hotfix] [kafka] Fix RackAwareMode instantiation in Kafka 0.10 test The IDE is complaining that `new kafka.admin.RackAwareMode.Enforced$()` has private access. Looking at Kafka's own tests

[jira] [Commented] (FLINK-4833) Unstable test OperatorStatsAccumulatorTest.testAccumulatorHeavyHitterCountMinSketch

2016-10-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585028#comment-15585028 ] Robert Metzger commented on FLINK-4833: --- But why is the error now happening to frequently? Did we

[jira] [Commented] (FLINK-4852) ClassCastException when assigning Watermarks with TimeCharacteristic.ProcessingTime

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585929#comment-15585929 ] ASF GitHub Bot commented on FLINK-4852: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request #2656: [FLINK-4852] Remove Non-Multiplexing StreamRecordS...

2016-10-18 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2656 [FLINK-4852] Remove Non-Multiplexing StreamRecordSerializer This is getting rid of a source `ClassCastExceptions` that cropped up several times now. We simply always to the multiplexing now which

[jira] [Commented] (FLINK-3322) MemoryManager creates too much GC pressure with iterative jobs

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585571#comment-15585571 ] ASF GitHub Bot commented on FLINK-3322: --- Github user ggevay commented on the issue:

[jira] [Created] (FLINK-4853) Clean up JobManager registration at the ResourceManager

2016-10-18 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4853: Summary: Clean up JobManager registration at the ResourceManager Key: FLINK-4853 URL: https://issues.apache.org/jira/browse/FLINK-4853 Project: Flink Issue

[jira] [Commented] (FLINK-4499) Introduce findbugs maven plugin

2016-10-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585619#comment-15585619 ] Ted Yu commented on FLINK-4499: --- +1 on starting with a very small set of rules > Introduce findbugs maven

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585558#comment-15585558 ] ASF GitHub Bot commented on FLINK-3674: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r83856028 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/TimelyFlatMapTest.java --- @@ -0,0 +1,442 @@ +/* + *

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r83859446 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -0,0 +1,325 @@ +/*

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585563#comment-15585563 ] ASF GitHub Bot commented on FLINK-3674: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1558#comment-1558 ] ASF GitHub Bot commented on FLINK-3674: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585560#comment-15585560 ] ASF GitHub Bot commented on FLINK-3674: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r83858268 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java --- @@ -0,0 +1,90 @@ +/* + *

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585557#comment-15585557 ] ASF GitHub Bot commented on FLINK-3674: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r83857663 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimelyFlatMapFunction.java --- @@ -0,0 +1,78 @@ +/* + *

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585562#comment-15585562 ] ASF GitHub Bot commented on FLINK-3674: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585559#comment-15585559 ] ASF GitHub Bot commented on FLINK-3674: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585556#comment-15585556 ] ASF GitHub Bot commented on FLINK-3674: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r83860194 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -0,0 +1,325 @@ +/*

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585554#comment-15585554 ] ASF GitHub Bot commented on FLINK-3674: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r83861268 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java --- @@ -390,4 +425,141 @@ public

  1   2   >