[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887597#comment-15887597 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r103404131 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0

[GitHub] flink pull request #3390: [FLINK-5864] CEP: fix duplicate output patterns pr...

2017-02-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3390#discussion_r103405219 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -254,7 +255,18 @@ public int hashCode() {

[jira] [Commented] (FLINK-5864) CEP: fix duplicate output patterns problem.

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887624#comment-15887624 ] ASF GitHub Bot commented on FLINK-5864: --- Github user kl0u commented on a diff in the pull request:

[jira] [Created] (FLINK-5932) Order of legacy vs new state initialization in the AbstractStreamOperator.

2017-02-28 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-5932: - Summary: Order of legacy vs new state initialization in the AbstractStreamOperator. Key: FLINK-5932 URL: https://issues.apache.org/jira/browse/FLINK-5932 Project:

[GitHub] flink issue #3151: [FLINK-4364][runtime] Implement TaskManager side of heart...

2017-02-28 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/3151 @tillrohrmann , I have submitted the modifications that covered all your suggestions. Only one issue I am not confirmed is in order to reuse the **ScheduledExecutor** in **RpcService**,

[jira] [Commented] (FLINK-5921) Adapt time mode indicator functions return custom data types

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887551#comment-15887551 ] ASF GitHub Bot commented on FLINK-5921: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3425: [FLINK-5921] [table] Add custom data types for row...

2017-02-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3425#discussion_r10335 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala --- @@ -327,6 +329,15 @@ object

[jira] [Commented] (FLINK-5932) Order of legacy vs new state initialization in the AbstractStreamOperator.

2017-02-28 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887699#comment-15887699 ] Aljoscha Krettek commented on FLINK-5932: - +1 I think this makes a lot of sense [~srichter] what

[jira] [Commented] (FLINK-5929) Allow Access to Per-Window State in ProcessWindowFunction

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887731#comment-15887731 ] ASF GitHub Bot commented on FLINK-5929: --- GitHub user uce opened a pull request:

[GitHub] flink pull request #3427: [FLINK-5929] [tests] Fix SavepointITCase instabili...

2017-02-28 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3427 [FLINK-5929] [tests] Fix SavepointITCase instability When shutting down the testing cluster it could happen that checkpoint files lingered around (for checkpoints independent of the savepoint).

[jira] [Updated] (FLINK-5668) passing taskmanager configuration through taskManagerEnv instead of file

2017-02-28 Thread Bill Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Liu updated FLINK-5668: Summary: passing taskmanager configuration through taskManagerEnv instead of file (was: Reduce dependency

[jira] [Created] (FLINK-5933) Allow Evictor for merging windows

2017-02-28 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5933: --- Summary: Allow Evictor for merging windows Key: FLINK-5933 URL: https://issues.apache.org/jira/browse/FLINK-5933 Project: Flink Issue Type: Bug

[GitHub] flink issue #3425: [FLINK-5921] [table] Add custom data types for rowtime an...

2017-02-28 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3425 @fhueske Thanks for updating, the PR looks very good to me. I look forward to merge. Best, SunJincheng --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-5921) Adapt time mode indicator functions return custom data types

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887721#comment-15887721 ] ASF GitHub Bot commented on FLINK-5921: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink pull request #3381: [FLINK-5871] [cep] Enforce uniqueness of pattern n...

2017-02-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3381 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5501) Determine whether the job starts from last JobManager failure

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887547#comment-15887547 ] ASF GitHub Bot commented on FLINK-5501: --- Github user shuai-xu commented on the issue:

[GitHub] flink issue #3385: [FLINK-5501] JM use running job registry to determine whe...

2017-02-28 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/3385 @StephanEwen , Thank you very much, sorry for the test break, next time I will be more careful. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-5414) Bump up Calcite version to 1.11

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887638#comment-15887638 ] ASF GitHub Bot commented on FLINK-5414: --- Github user twalthr commented on the issue:

[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11

2017-02-28 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3426 Thanks @wuchong and @haohui. I will look at it today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3314: [FLINK-3679] DeserializationSchema should handle zero or ...

2017-02-28 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3314 @StephanEwen and I just had an offline discussion about the change, and we came up with the following thoughts: Using an `ArrayList` for buffering elements is an "anti-pattern" in Flink,

[jira] [Commented] (FLINK-3679) DeserializationSchema should handle zero or more outputs for every input

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887668#comment-15887668 ] ASF GitHub Bot commented on FLINK-3679: --- Github user rmetzger commented on the issue:

[jira] [Commented] (FLINK-5776) Improve XXMapRunner support create instance by carrying constructor parameters

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887683#comment-15887683 ] ASF GitHub Bot commented on FLINK-5776: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3418: [FLINK-5776][Table API & SQL]Improve XXMapRunner support ...

2017-02-28 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3418 Hmm, I see. I'm usually not in favor of adding code without a clear need. On the other hand, these changes are not very extensive and I can see how it might help to code-gen the aggregation

[GitHub] flink issue #3303: [FLINK-5133][core] Support to set resource for operator i...

2017-02-28 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/3303 @StephanEwen , sorry for my carelessness of **checkNotNull**, it is a low mistake. And I passed the "clean verify" in my local machine, thank you for merging! --- If your project is set up for

[jira] [Commented] (FLINK-5133) Support to set resource for operator in DataStream and DataSet

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887614#comment-15887614 ] ASF GitHub Bot commented on FLINK-5133: --- Github user zhijiangW commented on the issue:

[jira] [Commented] (FLINK-5864) CEP: fix duplicate output patterns problem.

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887700#comment-15887700 ] ASF GitHub Bot commented on FLINK-5864: --- Github user kl0u commented on the issue:

[GitHub] flink issue #3390: [FLINK-5864] CEP: fix duplicate output patterns problem.

2017-02-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3390 I agree that the solution is temporary but the new version (with the richer pattern support) could take some time. As for the sorting, we could have a "pre-traversal" of the transitions, as you had in

[jira] [Commented] (FLINK-3679) DeserializationSchema should handle zero or more outputs for every input

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887647#comment-15887647 ] ASF GitHub Bot commented on FLINK-3679: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #3314: [FLINK-3679] DeserializationSchema should handle z...

2017-02-28 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/3314#discussion_r103405663 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/RichKeyedDeserializationSchema.java ---

[jira] [Commented] (FLINK-5668) passing taskmanager configuration through taskManagerEnv instead of file

2017-02-28 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887703#comment-15887703 ] Robert Metzger commented on FLINK-5668: --- [~wheat9] I still did not understand how you can "inject" a

[jira] [Commented] (FLINK-4364) Implement TaskManager side of heartbeat from JobManager

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887712#comment-15887712 ] ASF GitHub Bot commented on FLINK-4364: --- Github user zhijiangW commented on the issue:

[jira] [Commented] (FLINK-5871) Enforce uniqueness of pattern names in CEP.

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887747#comment-15887747 ] ASF GitHub Bot commented on FLINK-5871: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-5871) Enforce uniqueness of pattern names in CEP.

2017-02-28 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887748#comment-15887748 ] Kostas Kloudas commented on FLINK-5871: --- Merged at commit a92d78746318e9bbe949d9d030fc21b5348b56e2

[jira] [Closed] (FLINK-5871) Enforce uniqueness of pattern names in CEP.

2017-02-28 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-5871. - Resolution: Fixed > Enforce uniqueness of pattern names in CEP. >

[jira] [Commented] (FLINK-5864) CEP: fix duplicate output patterns problem.

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887630#comment-15887630 ] ASF GitHub Bot commented on FLINK-5864: --- Github user dawidwys commented on a diff in the pull

[GitHub] flink pull request #3390: [FLINK-5864] CEP: fix duplicate output patterns pr...

2017-02-28 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/3390#discussion_r103407276 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -254,7 +255,18 @@ public int hashCode() {

[GitHub] flink issue #3390: [FLINK-5864] CEP: fix duplicate output patterns problem.

2017-02-28 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/3390 Just had a second thought, this solution is temporary anyway, so that the current Pattern graph is processed correctly. Before changing anything in `NFACompiler` we will need to change the

[jira] [Commented] (FLINK-5864) CEP: fix duplicate output patterns problem.

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887653#comment-15887653 ] ASF GitHub Bot commented on FLINK-5864: --- Github user dawidwys commented on the issue:

[jira] [Commented] (FLINK-5921) Adapt time mode indicator functions return custom data types

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887684#comment-15887684 ] ASF GitHub Bot commented on FLINK-5921: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3425: [FLINK-5921] [table] Add custom data types for rowtime an...

2017-02-28 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3425 Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request #3393: [FLINK-3903][docs] adding alternative installation...

2017-02-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3393 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3903) Homebrew Installation

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887749#comment-15887749 ] ASF GitHub Bot commented on FLINK-3903: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-3903) Homebrew Installation

2017-02-28 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-3903. -- Resolution: Fixed Fix Version/s: 1.2.1 1.3.0 Fixed in 90173b7 (release-1.2),

[jira] [Commented] (FLINK-3679) DeserializationSchema should handle zero or more outputs for every input

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887548#comment-15887548 ] ASF GitHub Bot commented on FLINK-3679: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3314: [FLINK-3679] DeserializationSchema should handle z...

2017-02-28 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3314#discussion_r103399810 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/RichKeyedDeserializationSchema.java ---

[jira] [Updated] (FLINK-5932) Order of legacy vs new state initialization in the AbstractStreamOperator.

2017-02-28 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-5932: -- Description: Currently in the {{AbstractStreamOperator::initializeState(OperatorStateHandles

[GitHub] flink issue #3393: [FLINK-3903][docs] adding alternative installation for OS...

2017-02-28 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3393 Looks good, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (FLINK-5668) passing taskmanager configuration through taskManagerEnv instead of file

2017-02-28 Thread Bill Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887736#comment-15887736 ] Bill Liu commented on FLINK-5668: - [~rmetzger] We are trying to implement a server which could be used

[jira] [Commented] (FLINK-3903) Homebrew Installation

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887739#comment-15887739 ] ASF GitHub Bot commented on FLINK-3903: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888069#comment-15888069 ] ASF GitHub Bot commented on FLINK-5870: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3376: [FLINK-5870] Handlers define REST URLs

2017-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3376#discussion_r103459049 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagersHandler.java --- @@ -53,6 +59,11 @@ public

[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888070#comment-15888070 ] ASF GitHub Bot commented on FLINK-5870: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3365: [FLINK-5852] Move handler JSON generation code int...

2017-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3365#discussion_r103464724 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/utils/JsonUtils.java --- @@ -0,0 +1,228 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-5852) Move JSON generation code into static methods

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888116#comment-15888116 ] ASF GitHub Bot commented on FLINK-5852: --- Github user zentol commented on the issue:

[GitHub] flink issue #3427: [FLINK-5923] [tests] Fix SavepointITCase instability

2017-02-28 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3427 Three of my local Travis runs passed: https://travis-ci.org/uce/flink/builds/206125226 https://travis-ci.org/uce/flink/builds/206125321 https://travis-ci.org/uce/flink/builds/206125360

[GitHub] flink pull request #3412: [FLINK-5420] [cep] Make the CEP operators rescalab...

2017-02-28 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3412#discussion_r103471738 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/OnWatermarkCallback.java --- @@ -0,0 +1,39 @@ +/* + *

[jira] [Commented] (FLINK-5923) Test instability in SavepointITCase testTriggerSavepointAndResume

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888164#comment-15888164 ] ASF GitHub Bot commented on FLINK-5923: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-4816) Executions failed from "DEPLOYING" should retain restored checkpoint information

2017-02-28 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887850#comment-15887850 ] ramkrishna.s.vasudevan commented on FLINK-4816: --- Going through the code, will it better that

[GitHub] flink issue #3427: [FLINK-5929] [tests] Fix SavepointITCase instability

2017-02-28 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3427 Wrong Jira Issue ID. 😅 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-5852) Move JSON generation code into static methods

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888030#comment-15888030 ] ASF GitHub Bot commented on FLINK-5852: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3376: [FLINK-5870] Handlers define REST URLs

2017-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3376#discussion_r103458807 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java --- @@ -256,117 +256,106 @@ public WebRuntimeMonitor(

[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888066#comment-15888066 ] ASF GitHub Bot commented on FLINK-5870: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3376: [FLINK-5870] Handlers define REST URLs

2017-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3376#discussion_r103458922 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java --- @@ -141,6 +144,15 @@ public

[jira] [Commented] (FLINK-5852) Move JSON generation code into static methods

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888091#comment-15888091 ] ASF GitHub Bot commented on FLINK-5852: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3365: [FLINK-5852] Move handler JSON generation code int...

2017-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3365#discussion_r103463182 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ArchivedExecutionConfig.java --- @@ -54,6 +54,19 @@ public

[jira] [Commented] (FLINK-5852) Move JSON generation code into static methods

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888114#comment-15888114 ] ASF GitHub Bot commented on FLINK-5852: --- Github user zentol commented on a diff in the pull request:

[jira] [Updated] (FLINK-5720) Deprecate "Folding" in all of DataStream API

2017-02-28 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-5720: Priority: Blocker (was: Major) > Deprecate "Folding" in all of DataStream API >

[jira] [Updated] (FLINK-5720) Deprecate "Folding" in all of DataStream API

2017-02-28 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-5720: Fix Version/s: 1.3.0 > Deprecate "Folding" in all of DataStream API >

[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888158#comment-15888158 ] ASF GitHub Bot commented on FLINK-5870: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #3376: [FLINK-5870] Handlers define REST URLs

2017-02-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3376#discussion_r103471161 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java --- @@ -256,117 +256,106 @@ public WebRuntimeMonitor(

[GitHub] flink pull request #3376: [FLINK-5870] Handlers define REST URLs

2017-02-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3376#discussion_r103452837 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java --- @@ -256,117 +256,106 @@ public WebRuntimeMonitor(

[GitHub] flink pull request #3376: [FLINK-5870] Handlers define REST URLs

2017-02-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3376#discussion_r103452124 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandlerBase.java --- @@ -67,6 +67,8 @@ public

[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888047#comment-15888047 ] ASF GitHub Bot commented on FLINK-5870: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888050#comment-15888050 ] ASF GitHub Bot commented on FLINK-5870: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888048#comment-15888048 ] ASF GitHub Bot commented on FLINK-5870: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #3365: [FLINK-5852] Move handler JSON generation code int...

2017-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3365#discussion_r103456991 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/utils/JsonUtils.java --- @@ -0,0 +1,228 @@ +/* + * Licensed to the

[GitHub] flink pull request #3376: [FLINK-5870] Handlers define REST URLs

2017-02-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3376#discussion_r103455030 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java --- @@ -141,6 +144,15 @@ public

[GitHub] flink pull request #3376: [FLINK-5870] Handlers define REST URLs

2017-02-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3376#discussion_r103455491 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/checkpoints/CheckpointStatsDetailsSubtasksHandler.java --- @@ -52,6

[GitHub] flink pull request #3376: [FLINK-5870] Handlers define REST URLs

2017-02-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3376#discussion_r103455441 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagersHandler.java --- @@ -53,6 +59,11 @@ public

[GitHub] flink pull request #3376: [FLINK-5870] Handlers define REST URLs

2017-02-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3376#discussion_r103453211 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java --- @@ -435,6 +424,36 @@ protected void

[GitHub] flink pull request #3376: [FLINK-5870] Handlers define REST URLs

2017-02-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3376#discussion_r103456488 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/utils/RestUtils.java --- @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3365: [FLINK-5852] Move handler JSON generation code int...

2017-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3365#discussion_r103461677 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ArchivedExecutionConfig.java --- @@ -54,6 +54,19 @@ public

[GitHub] flink issue #3365: [FLINK-5852] Move handler JSON generation code into stati...

2017-02-28 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3365 @uce Thank your for the review. I've addressed all issues that you raised, either with further comments or changes. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request #3412: [FLINK-5420] [cep] Make the CEP operators rescalab...

2017-02-28 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3412#discussion_r103471629 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalWatermarkCallbackService.java --- @@ -0,0 +1,237 @@ +/*

[jira] [Commented] (FLINK-5420) Make CEP operators rescalable

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888166#comment-15888166 ] ASF GitHub Bot commented on FLINK-5420: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-5420) Make CEP operators rescalable

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888165#comment-15888165 ] ASF GitHub Bot commented on FLINK-5420: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-5929) Allow Access to Per-Window State in ProcessWindowFunction

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887811#comment-15887811 ] ASF GitHub Bot commented on FLINK-5929: --- Github user aljoscha commented on the issue:

[jira] [Created] (FLINK-5935) confusing/misleading error message when failing to restore savepoint

2017-02-28 Thread David Anderson (JIRA)
David Anderson created FLINK-5935: - Summary: confusing/misleading error message when failing to restore savepoint Key: FLINK-5935 URL: https://issues.apache.org/jira/browse/FLINK-5935 Project: Flink

[GitHub] flink pull request #3365: [FLINK-5852] Move handler JSON generation code int...

2017-02-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3365#discussion_r103434202 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/utils/JsonTestUtils.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the

[GitHub] flink pull request #3365: [FLINK-5852] Move handler JSON generation code int...

2017-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3365#discussion_r103453996 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobExceptionsHandler.java --- @@ -41,19 +43,23 @@ public

[jira] [Commented] (FLINK-5852) Move JSON generation code into static methods

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888025#comment-15888025 ] ASF GitHub Bot commented on FLINK-5852: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888051#comment-15888051 ] ASF GitHub Bot commented on FLINK-5870: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888052#comment-15888052 ] ASF GitHub Bot commented on FLINK-5870: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-5852) Move JSON generation code into static methods

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888045#comment-15888045 ] ASF GitHub Bot commented on FLINK-5852: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888049#comment-15888049 ] ASF GitHub Bot commented on FLINK-5870: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-5870) Make handlers aware of their REST URLs

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888046#comment-15888046 ] ASF GitHub Bot commented on FLINK-5870: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-5852) Move JSON generation code into static methods

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888098#comment-15888098 ] ASF GitHub Bot commented on FLINK-5852: --- Github user zentol commented on a diff in the pull request:

[jira] [Updated] (FLINK-4965) AllPairsShortestPaths

2017-02-28 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-4965: -- Labels: Algorithm (was: ) > AllPairsShortestPaths > - > > Key:

[jira] [Commented] (FLINK-5852) Move JSON generation code into static methods

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888190#comment-15888190 ] ASF GitHub Bot commented on FLINK-5852: --- Github user uce commented on a diff in the pull request:

  1   2   3   4   5   >