Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106921358
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/StreamTableEnvironment.scala
---
@@ -180,4 +180,31 @@ class StreamTable
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106921688
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -511,15 +511,15 @@ case class Join(
}
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106921052
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -178,4 +178,32 @@ class BatchTableEn
[
https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932773#comment-15932773
]
zhijiang commented on FLINK-4545:
-
[~StephanEwen], Yeah, there are two cases, first is for
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106920718
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/exceptions.scala
---
@@ -165,3 +165,31 @@ case class AmbiguousTableSourceCon
[
https://issues.apache.org/jira/browse/FLINK-6095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhijiang updated FLINK-6095:
Description:
Currently all the parameters in {{SlotPool}} are hard coded including
{{DEFAULT_SLOT_REQUEST_T
Ted Yu created FLINK-6130:
-
Summary: Consider calling resourceManager#getTerminationFuture()
with lock held
Key: FLINK-6130
URL: https://issues.apache.org/jira/browse/FLINK-6130
Project: Flink
Issue
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3539
@shuai-xu Had a look at the changes. In general, I like the decoupling of
failover handling from the execution graph.
Some suggestions:
- How about we rename the `FailoverCoordinato
GitHub user huawei-flink opened a pull request:
https://github.com/apache/flink/pull/3574
Eager aggregation over row bounded window
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your change
Github user huawei-flink closed the pull request at:
https://github.com/apache/flink/pull/3547
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
[
https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932841#comment-15932841
]
ASF GitHub Bot commented on FLINK-5653:
---
Github user huawei-flink closed the pull re
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3574
@fhueske let's see if the third attempt works. I have included all the
comments of @sunjincheng121 (apart from the window function) and having done a
merge on a fresh checkout also the imports s
[
https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932850#comment-15932850
]
ASF GitHub Bot commented on FLINK-5653:
---
Github user huawei-flink commented on the i
[
https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek reassigned FLINK-4940:
---
Assignee: (was: Stefan Richter)
> Add Support for Broadcast/Global State
> --
Aljoscha Krettek created FLINK-6131:
---
Summary: Add side inputs for DataStream API
Key: FLINK-6131
URL: https://issues.apache.org/jira/browse/FLINK-6131
Project: Flink
Issue Type: Improvemen
[
https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-4940:
Parent Issue: FLINK-6131 (was: FLINK-3659)
> Add Support for Broadcast/Global State
> -
[
https://issues.apache.org/jira/browse/FLINK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek closed FLINK-3659.
---
Resolution: Won't Do
This is superseded by the more general FLINK-6131.
> Add ConnectWithBroa
GitHub user zhengcanbin opened a pull request:
https://github.com/apache/flink/pull/3575
[FLINK-6117]makes setting of 'zookeeper.sasl.disable' work correctly
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into conside
[
https://issues.apache.org/jira/browse/FLINK-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-6018:
Priority: Blocker (was: Major)
> Properly initialise StateDescriptor in
> AbstractStateBac
[
https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932882#comment-15932882
]
ASF GitHub Bot commented on FLINK-6117:
---
GitHub user zhengcanbin opened a pull reque
[
https://issues.apache.org/jira/browse/FLINK-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek reopened FLINK-6018:
-
Assignee: Aljoscha Krettek (was: sunjincheng)
This needs a fix to {{KryoSerializer}} to
[
https://issues.apache.org/jira/browse/FLINK-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932892#comment-15932892
]
ASF GitHub Bot commented on FLINK-6027:
---
Github user asfgit closed the pull request
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3565#discussion_r106935333
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/batch/TableEnvironmentTest.java
---
@@ -209,28 +206,20 @@ public void te
[
https://issues.apache.org/jira/browse/FLINK-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932903#comment-15932903
]
ASF GitHub Bot commented on FLINK-5413:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932904#comment-15932904
]
ASF GitHub Bot commented on FLINK-5413:
---
Github user twalthr commented on a diff in
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3565#discussion_r106939552
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/batch/TableEnvironmentTest.java
---
@@ -47,10 +48,16 @@
import org.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3565#discussion_r106939048
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/batch/TableEnvironmentTest.java
---
@@ -47,10 +48,16 @@
import org.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3565#discussion_r106939897
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TableTestBase.scala
---
@@ -151,21 +152,31 @@ case class BatchTableTestUti
[
https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932908#comment-15932908
]
ASF GitHub Bot commented on FLINK-6117:
---
Github user zhengcanbin commented on a diff
Github user zhengcanbin commented on a diff in the pull request:
https://github.com/apache/flink/pull/3566#discussion_r106940624
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java
---
@@ -89,6 +90,7 @@ public static CuratorFramework
startCurat
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3521
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932889#comment-15932889
]
Aljoscha Krettek commented on FLINK-6018:
-
Changed to blocker because we either ne
Github user gaqzcb closed the pull request at:
https://github.com/apache/flink/pull/3566
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932916#comment-15932916
]
ASF GitHub Bot commented on FLINK-6117:
---
Github user gaqzcb closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932902#comment-15932902
]
ASF GitHub Bot commented on FLINK-5413:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932919#comment-15932919
]
ASF GitHub Bot commented on FLINK-6127:
---
Github user uce commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932922#comment-15932922
]
ASF GitHub Bot commented on FLINK-6127:
---
Github user uce commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932933#comment-15932933
]
ASF GitHub Bot commented on FLINK-4565:
---
Github user twalthr commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932905#comment-15932905
]
ASF GitHub Bot commented on FLINK-5413:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-4940:
Summary: Add Support for Broadcast State (was: Add Support for
Broadcast/Global State)
> A
canbinzheng created FLINK-6132:
--
Summary: Remove redundant code in CliFrontend.java
Key: FLINK-6132
URL: https://issues.apache.org/jira/browse/FLINK-6132
Project: Flink
Issue Type: Improvement
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3502
Hi @DmytroShkvyra,
as I mentioned earlier, the first thing we should fix in this PR is using
more of Calcite capabilities. Calcite provides a `SubQueryRemoveRule` and
according to the Javado
[
https://issues.apache.org/jira/browse/FLINK-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932953#comment-15932953
]
Till Rohrmann commented on FLINK-5650:
--
[~Zentol], I think the encouraged way is to o
GitHub user gaqzcb opened a pull request:
https://github.com/apache/flink/pull/3576
[FLINK-6132]Remove redundant code in CliFrontend.java
Look at the switch case block in method parseParameters of CliFrontend.java.
```
// do action
switch (action) {
cas
[
https://issues.apache.org/jira/browse/FLINK-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932959#comment-15932959
]
ASF GitHub Bot commented on FLINK-6132:
---
GitHub user gaqzcb opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932962#comment-15932962
]
Till Rohrmann commented on FLINK-6063:
--
Hi Razvan, yes it is necessary to configure a
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3460#discussion_r106948356
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
---
@@ -0,0 +1,242 @@
+/*
+ * Lic
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3460#discussion_r106948899
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/history/FsJobArchivist.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/FLINK-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932976#comment-15932976
]
ASF GitHub Bot commented on FLINK-1579:
---
Github user uce commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932979#comment-15932979
]
ASF GitHub Bot commented on FLINK-1579:
---
Github user uce commented on a diff in the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3572#discussion_r106942215
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/calcite/rules/FlinkAggregateExpandDistinctAggregatesRule.java
---
@@ -114,15 +114,21
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3460#discussion_r106949177
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
---
@@ -0,0 +1,242 @@
+/*
+ * Lic
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3572
Thanks for catching the unfortunate typo. I've fixed all of those. I left
the confusing deprecation comment as is in the table API.
I think this is good to merge then.
---
If your project is se
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106949663
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0 +1,181
[
https://issues.apache.org/jira/browse/FLINK-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932970#comment-15932970
]
ASF GitHub Bot commented on FLINK-1579:
---
Github user uce commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932990#comment-15932990
]
ASF GitHub Bot commented on FLINK-5658:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106950142
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0 +1,181
[
https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932994#comment-15932994
]
ASF GitHub Bot commented on FLINK-5658:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933000#comment-15933000
]
ASF GitHub Bot commented on FLINK-5658:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106950646
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0 +1,181
[
https://issues.apache.org/jira/browse/FLINK-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933003#comment-15933003
]
Till Rohrmann commented on FLINK-6129:
--
[~Zentol] they are, but who says that the und
[
https://issues.apache.org/jira/browse/FLINK-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bowen Li reassigned FLINK-6121:
---
Assignee: Bowen Li
> Include TravisCI build status to README.md
> ---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3537
Thanks for the review @StephanEwen. I will check whether we have such a
test case and if not, I'll add it.
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933015#comment-15933015
]
ASF GitHub Bot commented on FLINK-6050:
---
Github user tillrohrmann commented on the i
[
https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-4940:
Description:
As mentioned in
https://cwiki.apache.org/confluence/display/FLINK/FLIP-17+Side
Bowen Li created FLINK-6133:
---
Summary: fix build status in README.md
Key: FLINK-6133
URL: https://issues.apache.org/jira/browse/FLINK-6133
Project: Flink
Issue Type: Bug
Components: Build
[
https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-4940:
Description:
As mentioned in
https://cwiki.apache.org/confluence/display/FLINK/FLIP-17+Side
[
https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-4940:
Description:
As mentioned in
https://cwiki.apache.org/confluence/display/FLINK/FLIP-17+Side
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/3577
[FLINK-6133] fix build status in README.md
So sorry, I think I made a mistake when committing code for
https://issues.apache.org/jira/browse/FLINK-6122.
I tried to copy what's in the home
[
https://issues.apache.org/jira/browse/FLINK-6133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933057#comment-15933057
]
ASF GitHub Bot commented on FLINK-6133:
---
GitHub user bowenli86 opened a pull request
[
https://issues.apache.org/jira/browse/FLINK-6133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933081#comment-15933081
]
ASF GitHub Bot commented on FLINK-6133:
---
Github user uce commented on the issue:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3573#discussion_r106959941
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -198,6 +204,14 @@ public boolean isShutdown() {
*
[
https://issues.apache.org/jira/browse/FLINK-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933091#comment-15933091
]
ASF GitHub Bot commented on FLINK-6129:
---
Github user zentol commented on a diff in t
Till Rohrmann created FLINK-6134:
Summary: Set UUID(0L, 0L) as default leader session id
Key: FLINK-6134
URL: https://issues.apache.org/jira/browse/FLINK-6134
Project: Flink
Issue Type: Impro
[
https://issues.apache.org/jira/browse/FLINK-6134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933116#comment-15933116
]
ASF GitHub Bot commented on FLINK-6134:
---
GitHub user tillrohrmann opened a pull requ
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/3578
[FLINK-6134] Set UUID(0L, 0L) as default leader session id
Before the default leader session id was null in the standalone case.
However, in the ZooKeeper
case null indicated that there was
[
https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-4940:
Summary: Add support for broadcast state (was: Add Support for Broadcast
State)
> Add supp
Aljoscha Krettek created FLINK-6135:
---
Summary: Allowing adding inputs to StreamOperator
Key: FLINK-6135
URL: https://issues.apache.org/jira/browse/FLINK-6135
Project: Flink
Issue Type: Sub-
[
https://issues.apache.org/jira/browse/FLINK-6135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-6135:
Summary: Allowing adding additional inputs to StreamOperator (was:
Allowing adding inputs t
Till Rohrmann created FLINK-6136:
Summary: Separate EmbeddedNonHaServices and NonHaServices
Key: FLINK-6136
URL: https://issues.apache.org/jira/browse/FLINK-6136
Project: Flink
Issue Type: Su
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3577
There is a discussion on the dev mailing list whether we want to have this
or not. I would wait until that is resolved before continuing here.
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/FLINK-5999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933146#comment-15933146
]
ASF GitHub Bot commented on FLINK-5999:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3526
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-5999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-5999.
--
Resolution: Fixed
Fixed via 124872319889206b8ceaa7222c25318047102f6e
> MiniClusterITCase.runJob
[
https://issues.apache.org/jira/browse/FLINK-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933151#comment-15933151
]
ASF GitHub Bot commented on FLINK-6127:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3572#discussion_r106967721
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/calcite/rules/FlinkAggregateExpandDistinctAggregatesRule.java
---
@@ -114,15 +114
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3502
I have opened an architecture design about how these can be implemented
FLINK-6077 - https://issues.apache.org/jira/browse/FLINK-6077?filter=-2
You can take a look at this as well.
[
https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933157#comment-15933157
]
ASF GitHub Bot commented on FLINK-4565:
---
Github user rtudoran commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933182#comment-15933182
]
ASF GitHub Bot commented on FLINK-6107:
---
Github user aljoscha commented on the issue
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3567
In the ML discussion "Google code style" was repeatedly brought up
(initially by me):
https://lists.apache.org/thread.html/94c8c5186b315c58c3f8aaf536501b99e8b92ee97b0034dee295ff6a@%3Cdev.flink.apach
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3477
Hi @dawidwys , I have 2 comments for this PR:
1) in the `findFinalStateAfterProceed()` in the `NFA` you should also check
the filter condition as you traverse the `PROCEED` edges towards the end.
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3550
@fhueske @twalthr - I am not sure if you saw the updates last Friday with
all the things that are going on :)
If you have a chance to look over it would be great - I would like to merge
and clo
[
https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933282#comment-15933282
]
ASF GitHub Bot commented on FLINK-5654:
---
Github user rtudoran commented on the issue
Dawid Wysakowicz created FLINK-6137:
---
Summary: Add custom checkstyle for flink-cep
Key: FLINK-6137
URL: https://issues.apache.org/jira/browse/FLINK-6137
Project: Flink
Issue Type: Improveme
[
https://issues.apache.org/jira/browse/FLINK-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933361#comment-15933361
]
ASF GitHub Bot commented on FLINK-6107:
---
Github user greghogan commented on the issu
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3567
@aljoscha do you think we can use a single checkstyle or will this need to
be customized per module? Is this enforced by IntelliJ?
---
If your project is set up for it, you can reply to this email
Github user sjwiesman commented on the issue:
https://github.com/apache/flink/pull/3479
sorry for the delay, things got crazy at work. let me know if there are any
issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
[
https://issues.apache.org/jira/browse/FLINK-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933371#comment-15933371
]
ASF GitHub Bot commented on FLINK-5929:
---
Github user sjwiesman commented on the issu
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3479
Don't worry. ð Is it ready for another review pass now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
[
https://issues.apache.org/jira/browse/FLINK-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933393#comment-15933393
]
ASF GitHub Bot commented on FLINK-5929:
---
Github user aljoscha commented on the issue
201 - 300 of 433 matches
Mail list logo
